dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Brian Wilkerson 2dbd6dc83b Clean up the tests for extension overrides 
Change-Id: I1e74b51220b08a48788a387b8c1c60ec60cc28fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109122
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-07-16 15:03:40 +00:00
Brian Wilkerson e80f779914 Add context messages for equal map keys and set elements 
Change-Id: If1a2af91f35f869f7a9df89d0729949d5098c3b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109181
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-16 13:14:02 +00:00
Johnni Winther 4cd16d3954 [analyzer+cfe] Use more shared code for annotated code testing. 
Change-Id: Id1d234beed0059c84375bbeefb4755fac23d72c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108817
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-16 05:41:11 +00:00
pq f4b4147381 extension method resolution 
Change-Id: Id9e5fa618bc5ad284ab0415ccc0e515a475d095a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109144
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-15 23:42:30 +00:00
Brian Wilkerson 700195642a Initial implementation of extension override resolution 
Change-Id: I3cb1de3f82a3995c015e8f3045cab4b3ac83a079
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109141
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-15 21:27:26 +00:00
Paul Berry 87ab724f10 Streamline a few flow analysis tests 
In response to comments on
https://dart-review.googlesource.com/c/sdk/+/108263

Change-Id: I96ab6c20b8ef70b060e76d1ed3d763099ed682cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108816
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-14 20:14:54 +00:00
Paul Berry ebbfb48e15 Followups to https://dart-review.googlesource.com/c/sdk/+/108265 
Change-Id: I38cdf22aff3bb89f2f05001f878da334793c18f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108270
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-13 07:17:33 +00:00
Brian Wilkerson 2048e0a064 Rewrite extension overrides, improve resolution, remove unused method 
Change-Id: I2b11e0213250ffa01d7a186c7265af45d6a30301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108945
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-12 21:42:11 +00:00
pq 8e094cd94f extension element factory helper 
Change-Id: I98f92dfe72537fa03db9bb5ce5c80b79e032836a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108940
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-12 17:03:43 +00:00
pq 5d7bdc3cae extension method tests (and fix for duplicate entries) 
Change-Id: Ib8b5f80106cf05bf72c705266146e0705cacd771
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108881
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-12 14:04:53 +00:00
Brian Wilkerson 3ee54f8305 Move more diagnostic tests 
Change-Id: Ic5de1d807926c5aeeb8c5ee882ee3cbe8f9f2cf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108904
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-12 12:39:54 +00:00
Brian Wilkerson 1e4b799a58 It is an error for an extension to declare an abstract method 
Change-Id: I66f708dbe1f42b905b626b105a87c30325eb5c77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-11 22:15:54 +00:00
Brian Wilkerson 28962e1e80 Support static fields in extensions 
Change-Id: Id7897485e23f39e45918f6029b43a75e5327e0a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108764
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-11 21:47:25 +00:00
Mike Fairhurst 3c3dc09d47 Test that ! on void is a compile time error 
Change-Id: Ia2a43dca23df6d332bd5baa63af7cb68c94ac612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108762
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-11 18:48:53 +00:00
Mike Fairhurst e95b1f7bf0 Make UNNECESSARY_NULL_AWARE_CALL a warning 
Change-Id: I0cbe9522dcddb4c664ae5679e521191d0c91d777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106385
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-11 17:59:58 +00:00
Brian Wilkerson 97587b554f Update the element model to support extension methods 
Change-Id: Ia3bd6a19514368b3e046fead2eed0a4d0bfb133d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108504
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-11 13:28:37 +00:00
Brian Wilkerson a8331cd109 Remove the STRONG_MODE_ prefix from error codes 
Change-Id: Id8bacbd52f13030dc614952576e8576368e44b28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108688
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-11 13:27:57 +00:00
Konstantin Shcheglov 4a56e6169e Update test expectation for enabled constant-update-2018 
R=brianwilkerson@google.com

Change-Id: I059e7aa29a58c78fde9b8c62e6bd295ed841e297
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-10 21:56:01 +00:00
pq 016061d159 libray imported extensions 
Change-Id: Ibe2f772886b42cf0ccc577a55106dc33cf690b7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-10 19:17:58 +00:00
Danny Tuppeny 2c2364c3b4 Use a Map to avoid duplicate items in OverlayFileSystem.getChildren 
This fixes two issues:

- Dupes when a folder exists both on the real file system and has a child overlay
- Dupes when a folder has multiple descendant overlay files

Both are covered by new tests.

Fixes https://github.com/dart-lang/sdk/issues/37211.

Change-Id: Ia36eb1083dae55608009016a68589355a1eecabe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108600
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-10 18:13:28 +00:00
Brian Wilkerson 7820e807a6 Add missed type annotations and sort 
Change-Id: I07f0b96d2595a676ee8456bbcb353852adb37f64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-10 16:47:52 +00:00
Brian Wilkerson de2ff7eebb Split out the remaining HintCode tests 
Change-Id: Ief95dda424d458d9ad1739df99c5533738559508
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108620
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-10 14:58:14 +00:00
pq 8f90265176 de-lint collection size checks 
Change-Id: Id8e7ce2ec59ad7cd2b0b9c961594a37d4fef621a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-10 13:46:43 +00:00
Brian Wilkerson 3a8d755989 Change the delimiters used to mark highlight ranges in diagnostic documentation 
Change-Id: I4eb2c44ea4eb2a054eccbb4a6ab64a01d2866042
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108506
Reviewed-by: Kathy Walrath <kathyw@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-09 22:12:07 +00:00
Mike Fairhurst 449b799c21 Test that null cannot be used because its potentially nullable 
Change-Id: I344157c31225f92f1a8a931b9ffe23feebcb15de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102500
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-07-09 22:05:15 +00:00
Brian Wilkerson c3a1670c00 Attempt to fix the windows bot again 
Change-Id: Iefce582101c3efc736ef640d42c03b3e35b9e9ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108505
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-09 21:50:45 +00:00
Mike Fairhurst b472d7a9be Unnecessary null aware spread hint 
Change-Id: I33645c0bf948c5a3c3b06a5c81a7b77b82fe191c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105734
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-09 20:14:38 +00:00
pq f939ad3964 library scope extensions 
Change-Id: I060ddd02145d949b0becf7d2fb20f2ca01401766
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108461
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-09 19:27:43 +00:00
Vyacheslav Egorov a86db84e0a [fasta] Preserve information about const constructors in outline. 
- for classes with const constructors parse field initializers;
- for const constructions parse initializer lists and default parameter
values;

Fixes issue https://github.com/dart-lang/sdk/issues/37357
Fixes issue https://github.com/dart-lang/sdk/issues/36635

Change-Id: Iff0e47f8bd2925cee9f42a2b309de4de84e99cad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108279
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-09 14:02:01 +00:00
Brian Wilkerson a945888627 Discard constructors and fields temporarily to get valid code compiling 
Change-Id: If3e15a1f3164ee23a5e54e3a04b777de8e0189c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-08 21:49:11 +00:00
Brian Wilkerson a6afc5a9b0 Disable tests under windows to fix the bot 
Change-Id: I93f003f55ca522f6690fd9a8a3a7075666113218
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108361
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-08 17:02:02 +00:00
Brian Wilkerson d914839ce6 Add tests for diagnostic docs 
This tests that the docs have been generated and that the code samples
in the docs generate the expected errors at the expected locations.

Change-Id: Iff254537c15c58d6c5dde2bb2bb739e52f156b50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-08 13:36:14 +00:00
Brian Wilkerson 588ab11ecc Unify two error codes that are essentially identical 
The original reason for the difference is that one was used for run-time
exceptions that become static errors in constant evaluation, but that
distinction does not seem to be necessary any more.

Change-Id: Ie16ad623e292f9755cbe316755210097870a1515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-06 15:19:18 +00:00
Paul Berry c0932a8af6 Move annotated_code_helper.dart into front_end. 
This avoids the need for the analyzer to depend on the unpublished
package sourcemap_testing.

Change-Id: I7632df2028d4f3557d2c5c4a3a75510cda968efd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108268
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-05 11:40:25 +00:00
Paul Berry cea3d85ade Rename statment -> stmt in testing annotations. 
We are probably going to want to use this often enough that giving it
a short name will save a lot of typing.

Change-Id: Id95297183afa9d8e87002b93900d5c279401c74d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108267
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-05 10:24:10 +00:00
Paul Berry ee696f2c35 In flow analysis tests, annotate doesNotComplete on functions rather than bodies. 
Change-Id: I40476db016fd153ea4a013bcaa452775bcd960d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108266
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-05 09:08:40 +00:00
Paul Berry c1ca599353 Adapt flow and promotion tests to make use of CFE testing framework. 
This CL reworks the tests flow_analysis_test.dart and
type_promotion_test.dart to make use of the framework recently
introduced into pkg/front_end/lib/src/testing/id.dart.  The long term
goal is to move these tests into a common location so that they can
exercise both the front end and the analyzer.

Change-Id: Iad95065e995b0fe3c6e4990d2ea015215895743a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108265
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-05 09:08:40 +00:00
Paul Berry 13251657c6 Fix compile errors in flow analysis and type promotion test cases. 
Change-Id: I4c16ddfeec8598bb07b8c1e44e914424da7199aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108263
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-05 09:00:30 +00:00
Johnni Winther b8a8cfdcda [cfe] Use InvalidExpression for await on non-async context. 
CFE failed to replace an invalid AwaitExpression in a non-async context
with an InvalidExpression. The lead to untransformed (and thus unexpected)
await expressions crashing the hot reload.

Closes #37108

Change-Id: I4457925b20749d231cbf9dac80203ee9b381a312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107501
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-04 08:30:45 +00:00
Konstantin Shcheglov 2ea7e5513b Perform type promotion when NNBD, using flow analysis. 
Mostly just implementing existing interface LocalVariableTypeProvider,
and moving type promotion tests into a separate file.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If864cb2c300f01a152f40c51cffa7f17028ad200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-03 20:33:08 +00:00
Brian Wilkerson 480337106e Implementation of extension override AST node 
Change-Id: Ia4249512c3bc14a995179328603fb847c2fe768e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107925
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-03 14:01:07 +00:00
Vyacheslav Egorov 9f32f9b87e [cfe] Store the initializer tokens in constructor builders 
For const constructors, we need to compile the initializer expressions
and write them into the outline so that we can perform modular
constant evaluation.  As a first step, preserve the tokens for the
initializer expressions in const constructor builders when building
the outline.

Currently they are discarded later during outline building at the
point when we should compile them instead.

Change-Id: Ief8d94ceb752b2315982d720836496b7d597e55c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107509
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-03 10:52:35 +00:00
Paul Berry a2e1434603 Breaking changes for analyzer version 0.37 
Change-Id: I65a16ab2d2ca05de701c27f08300de85a6316b41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99880
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-02 03:59:49 +00:00
Lorenz Nickel 79e478e50e Fixed some links 
**I fixed some links and some other minor flaws.**

I also found the following outdated links, which I didn't fix:

- [This link](https://github.com/dart-lang/pool/tree/zone.strong) in [this file](https://github.com/dart-lang/sdk/blob/master/docs/newsletter/20170728.md) (didn't fix because don't know new location and this is some sort of archive so the link should probably stay the original)
- [This link](https://www.dartlang.org/tools/analyzer) in [this file](https://github.com/dart-lang/sdk/blob/master/pkg/analyzer_cli/lib/src/options.dart) (didn't fix since the link is still working, it just gets redirected and the link is part of the programm, I don't want to break anything by changing it, all other links are in comments)
- [This link](https://github.com/domokit/mojo/issues/728) in [this file](https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn) (didn't fix since probably has no new location and is part of TODO, which I don't want to change)

While doing all this I also noticed that [these tests](https://github.com/dart-lang/sdk/tree/master/tests/compiler/dart2js_extra) contain a lot of other inconsistencies in their comments and the location of the import-statements (I only fixed one which was not link-related), could be target of another PR.

Closes #36927
https://github.com/dart-lang/sdk/pull/36927

GitOrigin-RevId: 71d05d0b52d8ec5b92d077a070e066d1fdd4bbfa
Change-Id: Ide4b2424fccad8ae2e06c788efd4443dc0de997b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102222
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-07-01 16:21:41 +00:00
Konstantin Shcheglov cbf9cff19f Infer types of field formals before all fields. 
It will not happen strictly before, it happens together, because we
set _FunctionElementForLink_Initializer for fields, which will perform
field type inference when requested.

Found this while running over google3.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I360dff7e815ba997680c4a719a3e82827368db42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107780
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-01 15:53:15 +00:00
Konstantin Shcheglov 0baf81e7d6 Tests for Never and potential nullable / non-nullable. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iad0f455f67a9593ebca20b97a91369fc59023c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-01 00:10:58 +00:00
Konstantin Shcheglov 26d308aad3 Use flow analysis for reporting use sites of not assigned locals during resolution. 
Correspondingly, I moved tests for definite assigned from unit-like
tests to the corresponding error reporting tests suite.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6d286a8b5335e88fe9f7376ed3c829a1e5c39019
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-01 00:06:48 +00:00
Konstantin Shcheglov 499bb051f0 Fix LocalVariableElement.isLate 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I120d720919d6145d0d43fcd2d2ec8f30476a0324
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107562
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-06-28 19:13:09 +00:00
Konstantin Shcheglov 9640ae8319 Perform flow analysis during resolution in ResolverVisitor. 
We need to do this because type promotion should be done in parallel
with resolution. Keeping it as a separate stage worked for definite
assigned, and reachability, but for using flow analysis fully we need
this change.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0608e472c6ca4fa3967bd570b58eb57ff11c33d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107448
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-06-27 02:12:01 +00:00
Konstantin Shcheglov 1f992408c8 Report NOT_INITIALIZED_NON_NULLABLE_STATIC_FIELD. 
Change-Id: I0e2b46df212d2534498a181b36066cd05f635700
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107260
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-25 17:41:22 +00:00