dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Brian Wilkerson 8fb6f68f43 Support resolution of this 
Change-Id: I491703d7dd7c6eed6eebf3597ba33d10cfdb2958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110402
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-25 17:23:38 +00:00
Konstantin Shcheglov a66a42baff Test for default value referencing extension static method. 
Plus implementation for summary2.
And couple other fixes around extensions.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ibb90a6f2fc32ac4ef71023db1f51cdf8d3265022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-25 02:59:24 +00:00
Brian Wilkerson 3e3d6473bc Perform more resolution of method invocations involving extension methods 
Change-Id: Ia8060a8a595003341657422bdb68a7b53153f272
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110346
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 21:09:59 +00:00
Paul Berry bf4bde6ea2 Move test cases from flow_analysis_test.dart into front end. 
We still verify that the analyzer passes these tests, but we now do
the verification using the "ID test" mechanism that's shared with the
CFE.  This will allow the front end to run these tests as soon as its
integration with flow analysis is complete.

Still to do: migrate tests of type promotion and definite assignment
so that they can be shared by the front end.

Change-Id: I3c2ac6ff8b66e3a27110dcdb1f1d2dece447c18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-24 20:20:09 +00:00
Brian Wilkerson 088fbb8d42 Replace newly added uses of assertErrorCodesInCode and deprecate it 
Change-Id: I9937cf88ec57452a97d9b4110bd6d6da36bac159
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 16:09:18 +00:00
Brian Wilkerson 3d5238a0ec Resolve static members of an extension within the members of the extension 
Change-Id: I60687da4353ad056ff6312b07e9818b9dcfb9813
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110202
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-24 16:01:13 +00:00
pq 187c5b5bc9 re-add test dep 
Change-Id: Ie1240eb63b62c4fcd24a9dfda709eb54deb08129
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 15:46:53 +00:00
pq 0677649e8a extension property access 
Change-Id: Icf51679607166e0a449fe0ebeb5f432f17afb34b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 13:37:13 +00:00
Konstantin Shcheglov 58453dc4c7 Use findMethod() and assertElement() in ExtensionMethodTest. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I25d8a7021e78d045bd57b7462fe24c14d8cab518
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110138
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-24 03:20:04 +00:00
Konstantin Shcheglov 48662bdb94 Report not initialized potentially non-nullable instance fields. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id762e0cf651b2f2d7199f3447b5bf305b1a584c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107567
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-23 23:17:32 +00:00
Konstantin Shcheglov ecaa530faf Collect informative data for extensions. 
R=brianwilkerson@google.com

Change-Id: I77866f1bb5e92c074ce700d041a392639f829efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110130
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-23 22:17:12 +00:00
Paul Berry 6c43390cd8 Begin running the shared "ID tests" for constants on the analyzer. 
This exposed an analyzer bug--see #37608.

Change-Id: I96af785ce81ebb7b142b4f71cb43942b2b15f879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-23 22:08:12 +00:00
Konstantin Shcheglov ce7232cd0f Store type Never in summaries. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I2b0e7cc86844caf2613a8c3e5ea00ce4576e6e8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-23 19:30:20 +00:00
Brian Wilkerson 5e2a950685 Support accessing the documentation comment of an ExtensionElement 
Change-Id: If433a7e795369a195a917653f303c71df84a4a0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-07-23 18:09:03 +00:00
Dan Rubel 9c148623c5 prepend missing hex digits error token 
This prepends (rather than append) another error token to the token stream
similar to https://dart-review.googlesource.com/c/sdk/+/110100

In addition, this addresses a comment in
https://dart-review.googlesource.com/c/sdk/+/110140

Change-Id: I27c739b0ee3213cdbce92c3ff18c31fde862251c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-23 18:08:37 +00:00
Dan Rubel 76128480ae fix bug in invalid constructor initializer recovery 
Fix https://github.com/dart-lang/sdk/issues/37600
Fix https://github.com/dart-lang/sdk/issues/37029
Fix https://github.com/dart-lang/sdk/issues/37049
Fix https://github.com/dart-lang/sdk/issues/37110
Fix https://github.com/dart-lang/sdk/issues/37147

Change-Id: I9bc94991e71550410c02332bfd80faef50c229a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-23 16:42:54 +00:00
Konstantin Shcheglov ccdddd2eee Parallel build-mode and DDC changes for summary2. 
It does not enable summary2 yet, but makes it possible to flip
one flag AnalysisDriver.useSummary2 to switch between summary1
and summary2.

I run presubmit scripts, and it seems that it works for both.
https://test.corp.google.com/ui#id=OCL:255717824:BASE:259228828:1563746330268:5481d33a
https://test.corp.google.com/ui#id=OCL:255717824:BASE:258892260:1563515248201:2d5ce329

One thing that is not implemented yet is tracking used dependencies
for summary2. So, //dart/bazel_codegen_tests:dependencies_test_run fails.


Change-Id: Iec9f3852e9b91236ce98e87041031daa0cc71a88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107689
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-23 15:07:11 +00:00
Brian Wilkerson ae5d4973ab Improve a diagnostic message by adding specific type information 
Also, re-enable some tests that were unintentionally commented out.

Change-Id: I88ee5cf690c6c7132d80becae6952add229eba47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109983
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-23 13:55:11 +00:00
Paul Berry baaeafa2bb Flow analysis: move into front_end. 
This will allow it to be used by both the front end and the analyzer.

Change-Id: I3af67aaf3ad7ff2cca0cb245518570892ad473e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109986
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-23 12:55:11 +00:00
Paul Berry 24c0507d73 Flow analysis: remove the State.exit method. 
It was redundant with State.setReachable(false), and it did not have
the necessary logic to avoid creating State objects when unnecessary.

Change-Id: If9e0b8b586dab0e681f4ee0bc7b792d49e1e5f4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109897
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-23 12:55:11 +00:00
Brian Wilkerson 0864980e8c Resolve the call method when used with an extension override 
Change-Id: I2bf310abb3b8c3f4fc5eb9179bd60df4539d241f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109888
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-22 21:18:30 +00:00
Paul Berry ee5a90cb1b Flow analysis: test that all variables are registered with add(). 
This uncovered two more instances where we weren't properly
registering variables:
- Local function parameters
- Variables introduced by "catch" syntax.
- Variables introduced by "for (...; ...; ...)" syntax.

Change-Id: Id5e8aa1b598962cca1bb19df6d4ede99a672f108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109885
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-22 20:27:08 +00:00
Dan Rubel d7cb52b863 capture more info to debug 37528 
This updates the exception message to capture more information
about where the exception is occurring. Hopefully that information
can be used to fix https://github.com/dart-lang/sdk/issues/37528

Change-Id: Iaf10395091f8bd8b540dddc59001f23b6dc6a073
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-22 20:18:17 +00:00
Johnni Winther b3b6533c3d [cfe] Create ClassBuilder for extension declarations 
Change-Id: Ic372b89588ed9ec3afc43f7db7e3d38a81846ad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109264
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Paul Berry b912aebf5c Flow analysis: change tryPromoteToNonNull to promoteToNonNull. 
The flow analysis engine is now responsible for figuring out whether a
promotion actually occurred; this is less error prone.

Change-Id: Idce8af01fae982a9cc240ec4675812f8d7fd68a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109883
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-22 15:58:48 +00:00
Paul Berry 7adca0ec5f Flow analysis: Remove "emptySet" argument from markNonNullable 
Change-Id: Ia2fd7878badedba95ffee5f7a6948402376a2300
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109882
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-22 15:36:48 +00:00
Paul Berry 7719298616 Flow analysis: fix incorrectly written unit test. 
Change-Id: Iba5fcbb6ecd6f707ef2b20b0ec653fda7c577924
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109881
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-22 15:36:48 +00:00
Paul Berry 977a78b7a0 Flow analysis: expose State and unit test. Also fix restrict method. 
Change-Id: Id96a3266aea6ab8dd97e72bbf72a55b4156ebc0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109841
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-21 21:22:45 +00:00
Paul Berry f23418d9b7 Flow analysis: Refactor some common unit testing code 
Change-Id: I227bc09ed8e0c2161b5de9a06e70089b5f623b65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-21 20:33:55 +00:00
Paul Berry c8587ce199 Flow analysis: don't use == to compare types. 
Includes an integration test illustrating where this would have caused
incorrect behavior (due to the fact that the analyzer's `DartType.==`
doesn't yet distinguish nullabilities - see #37587), as well as unit
tests that will ensure we don't regress even after #37587 is fixed.

Change-Id: Ief92cf5a052bc2b96e4e74f69f2268b0565d920f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-21 20:33:55 +00:00
Paul Berry 7b6c667863 Flow analysis: rework tracking of nullability. 
We now track nullability via type promotion, e.g. by promoting from
`int?` to `int` to represent a non-nullable value.

I've added a few more unit tests of flow analysis that were helpful
while preparing this CL.  I plan to add more tests in follow-up CLs.

A few behaviors are lost by this change:

- We no longer track whether a variable's value is exactly null
  (previously the tests annotated such variables as "nullable", which
  was a bit misleading).  I'm not sure whether we really want this
  feature or not; I've filed
  https://github.com/dart-lang/language/issues/461 for discussion.

- Assignment of a non-null value to a nullable-typed variable no
  longer promotes it to non-nullable.  I think we want to get this
  behavior back, but we'll need to add a little bit more machinery to
  get it back (we need to allow assignments in general to promote.
  I'll address in follow-up CLs.  See
  https://github.com/dart-lang/language/issues/440 for discussion.

- A promotion to non-nullable that happens during a "try" block is
  lost if there is a "finally" block.  I think we want to get this
  behavior back, but we'll need to add a little bit more machinery to
  do so, to allow promotions in general to be preserved by
  try/finally.  I'll address in follow-up CLs.

Change-Id: Ibc45d70043725697fbee063a8dcefb1179506e9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109780
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-21 04:09:14 +00:00
Paul Berry c2e78e83c6 Flow analysis: fix and unit test joinPromoted. 
I will add further unit tests of flow analysis in follow-up CLs.

Note that flow_analysis_unit_test.dart does not make use of the
test_reflective_loader package because the intent is to move these
tests into the front end, and front end tests are written using
vanilla package:test conventions.

Change-Id: I10ba27212a1986f0c1fd960d33105f281712b506
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-21 03:24:34 +00:00
Paul Berry 7976bea0df Add ? suffixes to flow analysis tests. 
The new flow analysis will only function for libraries that are opted
into NNBD, therefore if we want to test that a variable is properly
promoted from a nullable type to a non-nullable one, we need its
declared type to be explicitly marked as nullable.

Change-Id: Ia649167f8069c37b3907ba63cabf4f50224dbade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109745
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-20 05:01:43 +00:00
Paul Berry 0faa3b7153 Flow analysis: Remove hack preventing variables showing as both nullable and non-nullable. 
It's better to annotate the test to match the way the code is truly
behaving, and include TODO comments indicating what needs to be
changed, because then when we make the fix we'll be able to see the
behavioral difference in the diff.

Change-Id: I28faad5787f8c70d3b5f5d8fc3510b0e3fb294f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109741
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-20 05:01:43 +00:00
pq 75f6822c70 fix for unnamed extensions 
Change-Id: I93947d66e41314e64c5f14b398fd73bf5344dccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-19 18:27:54 +00:00
pq 2faee21edb diagnostic for static extension member access 
Change-Id: I5380fa6240434ff398cdbd7efeae32b11336cf69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109681
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-19 16:57:23 +00:00
pq 634aa461a0 remove extension field checks 
follow-up from: https://dart-review.googlesource.com/c/sdk/+/109322/3/pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart#241

and some test renames

Change-Id: Ia22768ed60cf85a0b3d6244ff044ff31af17aad6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-19 14:30:06 +00:00
pq 5ce47abf86 extension type bounds instantiation (and failing param type test) 
Change-Id: Ieb94e5838581b4f38ff1624e0c1778ef395003a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-18 18:59:29 +00:00
pq 6dfd5766de error code for ambiguous extension method accesses 
Change-Id: I97b0bc8ba32d1cb0ee3b361525f4c161845f1d01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109463
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-18 03:50:27 +00:00
Konstantin Shcheglov 8dc4148516 Add await to all assertErrors/assertNoErrorsInCode tests. 
R=brianwilkerson@google.com

Change-Id: I5bf1b77ba5224ae5b250a3aa849c1e6da057ac3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-17 20:59:14 +00:00
Konstantin Shcheglov 7de08740f2 Infer types of fields and field formal parameters together. 
They might depend on each other, we cannot infer one or another first.

R=brianwilkerson@google.com

Change-Id: I9639a53561ec12d556fa1b45c44cf8aeb497f618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-17 20:30:44 +00:00
Brian Wilkerson 1865a3c911 Produce diagnostic when extension override argument is not assignable to the extended type 
Change-Id: I05f1f6fb62e01e1e8b4655a8d36e030b411090f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109423
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-17 19:59:05 +00:00
Brian Wilkerson 227ff83571 Add a diagnostic when an extension override is used to access a static member. 
Also added missing awaits to several previously committed tests.

Change-Id: Ide2d714b02e36f097f7c958b609dd780ff333253
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109420
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-17 17:56:14 +00:00
pq 895cb7720d “most specific extension” resolution first steps 
Incomplete but enough there for some initial feedback.


Change-Id: I186b376826d7ffdd8ed2be8e263231abb78cc187
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-17 14:56:26 +00:00
Brian Wilkerson 6073489539 Add diagnostic for undefined getters and setters invoked on an extension override 
Change-Id: Ib66f203836e3900e2e151dd3a8b6be1360e12d50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109319
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-17 12:36:16 +00:00
Brian Wilkerson 9d98dfcb49 Resolve operators whose left operand is an extension override 
Change-Id: I2731e5c95cd9c3c3e127124ad22d08a8695b1235
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109311
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-16 22:04:28 +00:00
Brian Wilkerson d624848b5c Fix resolution when there are multiple extensions in one unit 
Change-Id: I8ef55ad7e74fc6a87d5d927aeea5a8a5566a7668
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109312
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-16 21:11:52 +00:00
Brian Wilkerson ae9c8d00fe Add a diagnostic when extension overrides do not have exactly one argument 
Change-Id: Id48e8bc04c37cd45d018d3f9ec656c4b2d7426a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109310
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-07-16 20:50:39 +00:00
Brian Wilkerson 11e3897b23 Resolve extension overrides referencing a geter or setter 
Change-Id: I694110e7420b5f7d6450639f0af61948b3511711
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109305
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-16 18:56:48 +00:00
Brian Wilkerson b93a98284e Add an error if an undefined extension method is invoked 
Change-Id: Ie21f2ab2ba12d8401cd82191020979b7c6dce244
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109301
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-07-16 17:07:00 +00:00