df97434c28
extract ForwardingListener from ForwardingTestListener
...
Change-Id: I6e073e97130cc78eb33d663b79f3b8e472c7d408
Reviewed-on: https://dart-review.googlesource.com/10220
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-03 12:54:38 +00:00
0549b3160e
Run hint tests with Kernel.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Iea76082755b09015717c19c18a38ffe61072df02
Reviewed-on: https://dart-review.googlesource.com/10201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-02 22:31:38 +00:00
8d0c0bae0b
Triage tests failing because of import/export and duplicate declarations.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I771c33de3f719483d65b8415f4ce61e4335cd84e
Reviewed-on: https://dart-review.googlesource.com/10162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-02 20:56:02 +00:00
e8fe137e94
Remove ExecutableElement.functions and don't resynthesize local functions.
...
As for all other local elements - variables and labels, we now
created them when we analyze the unit, but we don't export them
through the element model.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I71eb567f58d6d710fc8a58d1653a66d95ef1ddcd
Reviewed-on: https://dart-review.googlesource.com/9861
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-01 21:08:04 +00:00
7d8e730b11
Fix for invalid function type in GenericTypeAliasElement.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ide4ca771ae3765f63f5000c9a8d4adca99d960a5
Reviewed-on: https://dart-review.googlesource.com/9785
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-30 01:45:14 +00:00
5a67a64957
Refactor parseClass
...
Refactored the parseClass method in preparation for
adding recovery, updating error messages, and analyzer integration.
* Added several new parser events
- handleClassExtends
- handleClassImplements
- handleClassHeader
* Revised the endClassDeclaration event
Change-Id: Ib58893097650eefb45051b462e9df7260b7776b2
Reviewed-on: https://dart-review.googlesource.com/9580
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-29 19:34:15 +00:00
b5fc2de3bf
Keep sources for libraries of the current cycle.
...
This should fix the issue 30917 flakiness.
The reason why the tests were failing is that the code in the tests
was not quite correct Dart code, so Fasta generated a synthetic
`#errors` top-level variable with fileUri == null. We should skip
this field because it is not a part of any unit, because its fileUri
is not the fileUri of any unit.
But we lose fileUri for a Node if Program.uriToSource does not
include this URI. So, if we clear uriToSource in KernelDriver, we
lose all the file URIs. So, now we keep sources for the cycle files.
The reason for flakiness is because of the same race condition
between analyzing AnalysisDriver.addFile() and getResult(). If
we process getResult() before, we don't have to read the library
kernel file, we just create in first time, and fileUri(s) are
valid.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug: https://github.com/dart-lang/sdk/issues/30917
Change-Id: Ie559cf2a8a778ebf4a9e297f5cb13d30a98b5a3c
Reviewed-on: https://dart-review.googlesource.com/9744
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-29 18:38:52 +00:00
170231c264
Fix a copy/paste error in a test
...
Change-Id: Ia35d0867811ccabbffddd25bd280599003e7a447
Reviewed-on: https://dart-review.googlesource.com/9720
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-29 18:28:52 +00:00
dbb6c5a442
Associate more Fasta errors with analyzer errors
...
Change-Id: I235f748a267819abea739da3885ff9613034ebfe
Reviewed-on: https://dart-review.googlesource.com/9160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2017-09-29 15:14:23 +00:00
9527f37146
refactor parse import
...
* `as` clause and `deferred as` clause processing pushed
into a new processImportPrefixOpt method.
* New handleImportPrefix event for communicating
`as` clause and `deferred as` clause to the listeners.
* Several new more detailed error messages for out of order
clauses and keywords in the import directive.
Change-Id: I133842c7225403fa000ca1cf0e49af9f8a011386
Reviewed-on: https://dart-review.googlesource.com/8580
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-29 14:39:01 +00:00
132d707f6a
Implement context for messages and use it for argument mismatches.
...
Change-Id: Iebf1a1fa0450ab900a9d220bf82bdf0f940c0399
Reviewed-on: https://dart-review.googlesource.com/7714
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2017-09-29 11:30:24 +00:00
d4dec4e1a4
Create GenericTypeAliasElement for both FunctionTypeAlias and GenericTypeAlias nodes.
...
Some pain points are:
1. It is a breaking change. I think I will break it even more by removing
FunctionTypeAliasElement altogether.
2. We lose ability to keep track that this FunctionType is instantiation
of a typedef. Just like in Kernel.
3. We sometimes have to look up to see if the GenericFunctionTypeElement
is a function in a named GenericTypeAliasElement.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ib250cc446a0ed5b8969f16f7cc6293ef4acf01a8
Reviewed-on: https://dart-review.googlesource.com/9421
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-29 00:39:05 +00:00
a65bcaf73f
Report an error for generic function type alias self-references.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I96417a033a2fb2ea63eb2b712fd10783517a2e4f
Reviewed-on: https://dart-review.googlesource.com/9371
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-28 21:30:10 +00:00
fb02cf80ee
Constructors should not have type parameters when resynthesize from Kernel.
...
Factory constructors are represented as static Procedure(s) with
type parameters. This does not match to the language specification and
Analyzer element model. We need to pretend that these type parameters
are absent, so that we pick up the same named type parameters from the
enclosing class.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Id26cf0e9c08699ac46978e14640e01089a1efcbc
Reviewed-on: https://dart-review.googlesource.com/9080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-27 23:55:42 +00:00
f7c4667a54
Triage other NonErrorResolverTest_Kernel tests.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I43070a8afa740dcbb7fd49fb834563fe7c5030cd
Reviewed-on: https://dart-review.googlesource.com/9100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-27 23:47:58 +00:00
f0caee1b24
Improve import directive recovery and report analyzer errors
...
- New handleRecoverImport event
for clauses in import directive that are out of order
- New error codes for
Duplicate prefix
Prefix after combinator
Change-Id: I0fea7ad4b4014a0b8578d3982e0515fe85044854
Reviewed-on: https://dart-review.googlesource.com/7980
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-27 12:56:46 +00:00
fff9215519
Mark a test @assertFailingTest.
...
TBR
R=brianwilkerson@google.com
Bug:
Change-Id: Id135af0d25cd93791f59462b6f24563522c8ad21
Reviewed-on: https://dart-review.googlesource.com/8728
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-26 21:51:12 +00:00
f7dfecf118
Replace generic comments in analyzer's MockSdk with the real generic syntax.
...
Actual SDK already uses generic syntax.
This also fixes some failures in Kernel tests :-)
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ie9bd5a058150522210671feb7009c233f5240add
Reviewed-on: https://dart-review.googlesource.com/8706
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-26 21:39:57 +00:00
73447d0f24
Use NoneTarget with native enabled.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug: https://github.com/dart-lang/sdk/issues/30839
Change-Id: I7ad415f42022eab784de1c53d4bb9afe67b78b2f
Reviewed-on: https://dart-review.googlesource.com/8404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-09-26 20:27:44 +00:00
4c893290e4
Reapply "Check whether type-arguments and type-parameters length match from the body builder."
...
This reverts commit 1ca12788c6https://dart-review.googlesource.com/6360
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-09-26 04:09:37 +00:00
08a3c80553
Triage failing tests and open issues for failing because of Fasta.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ic16133d8b0bdb11d5195efe2b34a93d2f526a8b0
Reviewed-on: https://dart-review.googlesource.com/7482
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-09-26 01:31:34 +00:00
556920dec3
Fix for resynthesizing libraries with unresovled URIs.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I23da60fede6539f1b154a8ed3b73506926126889
Reviewed-on: https://dart-review.googlesource.com/7484
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 22:22:19 +00:00
24ad103514
Run NonErrorResolverTest in strong mode. Extract not strong tests.
...
Plus a tiny fix for not considering a class with a static method
named "call" a Function.
R=brianwilkerson@google.com
Bug:
Change-Id: I2286488b6564be9cecbe318e0331524485e5baf0
Reviewed-on: https://dart-review.googlesource.com/8165
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 21:34:29 +00:00
eb4da3cbc5
Remove fail() for tests that now pass.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I23c388e11f4a7fe7121afb3250aa776c0a39a533
Reviewed-on: https://dart-review.googlesource.com/8166
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 20:31:16 +00:00
c6ba28a5a8
Create (empty) initializers for parameters resynthesized from Kernel.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I1fc4d7db27951fb0e094dc685eb3e0bde4663e68
Reviewed-on: https://dart-review.googlesource.com/8162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 17:13:18 +00:00
e32b446640
Rework getElement() in resynthesizer.
...
So that it is not recursive anymore.
This also fixes a bug with private classes.
There is no library URI qualifier for classes, even if they are private.
R=brianwilkerson@google.com
Bug:
Change-Id: I3c5c3d56e7f895940192fcee692043aaef25d2dc
Reviewed-on: https://dart-review.googlesource.com/8163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 17:08:03 +00:00
a3f287a0a3
Move TypeProvider creation into KernelResynthesizer and create loadLibrary functions.
...
R=brianwilkerson@google.com
Bug:
Change-Id: If2a873ea70133ae7f2c21d356adccc1a9653377d
Reviewed-on: https://dart-review.googlesource.com/8161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-25 17:05:33 +00:00
daa7ba1205
Return SimpleIdentifier or PrefixedIdentifier from _buildIdentifier().
...
R=brianwilkerson@google.com
Bug:
Change-Id: I0de65eb662b5ae3c69ab8c216d013a473b1f9299
Reviewed-on: https://dart-review.googlesource.com/8160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-25 16:55:44 +00:00
bc5531fd1c
remove native clause processing from parser listeners
...
* Finish updating the fasta parser to handle native clauses
* Remove outdated native clause processing from listeners
Change-Id: I2797145d6aff07da2ee4e008d5e1f233f30813a2
Reviewed-on: https://dart-review.googlesource.com/7900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-09-25 15:48:49 +00:00
9831231682
Mark several tests with @assertFailingTest instead of @failingTest.
...
TBR
R=brianwilkerson@google.com
Bug:
Change-Id: Ic486a8506658ffbc42b1a7cd9bd7695013dc429e
Reviewed-on: https://dart-review.googlesource.com/8000
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-24 19:25:07 +00:00
f575c099b0
Run all *_driver tests also with Kernel. (attempt #2 )
...
With previous changes that fix finding dart:core on Windows and
flakyness of reporting import errors, I'd like to reland this CL.
Attempt #1 : https://dart-review.googlesource.com/c/sdk/+/7624
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: If5ab2c5ebe2204df6643ee42cbee5b49fb2d8c31
Reviewed-on: https://dart-review.googlesource.com/7961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-24 18:27:27 +00:00
8e94406288
Remove DirectoryBasedSourceContainer and its test.
...
This is the only test from pkg/analyzer/test/test_all.dart suite
that fails on my Windows machine. Given that the class has not been
used for ages, it is easier to remove it.
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/21772
Change-Id: I110825f44915dde354af22e73e2d376231c08b0d
Reviewed-on: https://dart-review.googlesource.com/7943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-23 16:41:24 +00:00
3b632329f7
Fix source_factory_test to pass on Windows. (attempt #2 )
...
Attempt #1 was: https://dart-review.googlesource.com/c/sdk/+/7843
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: Id5cb82883d25e5b51b8304cd152497535d7db48a
Reviewed-on: https://dart-review.googlesource.com/7940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-23 00:19:09 +00:00
cc787d4803
Recover from getters that have parameter lists
...
Change-Id: I07665f297f067537a45e304d1f1138b6532e8c21
Reviewed-on: https://dart-review.googlesource.com/7559
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2017-09-23 00:13:58 +00:00
e929620072
Revert "Fix source_factory_test to pass on Windows."
...
This reverts commit 11d2dfb915https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/builds/7264/steps/analyzer%20unit%20tests/logs/stdio
Original change's description:
> Fix source_factory_test to pass on Windows.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Bug: https://github.com/dart-lang/sdk/issues/26828
> Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
> Reviewed-on: https://dart-review.googlesource.com/7843
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
Change-Id: I4f4e2f9a0c34fed26726a1d48ab1068ca8b6e16b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/26828
Reviewed-on: https://dart-review.googlesource.com/7920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-22 22:25:18 +00:00
11d2dfb915
Fix source_factory_test to pass on Windows.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
Reviewed-on: https://dart-review.googlesource.com/7843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-22 20:56:58 +00:00
29dd1d6ab3
Recover from finding a colon in a for-in loop
...
Change-Id: Idc10149af816d50046289ac29b3d6480a4caa51d
Reviewed-on: https://dart-review.googlesource.com/7761
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-22 19:36:28 +00:00
603158e917
report more analyzer error messages
...
Change-Id: I8b196ff7fca0e9fb1a5f0dfe6a3477887efa0f76
Reviewed-on: https://dart-review.googlesource.com/7640
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-22 17:01:37 +00:00
2140b878a7
cleanup parser event param
...
This removes the rightParen from parser events
and uses leftParen?.endGroup when needed
Change-Id: Ibc919edff4fffddc35d100453ac652eb5c5ac6e5
Reviewed-on: https://dart-review.googlesource.com/7560
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-09-22 15:50:37 +00:00
8fedf42184
fix out of order directive error codes
...
Change-Id: I903d3e5e59b9d836c7dbe23c5610286437731cb2
Reviewed-on: https://dart-review.googlesource.com/7500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-09-22 13:06:15 +00:00
2274739c3c
Revert addition of kernel tests to analyzer unit tests
...
These tests have flaky failures on the buildbots and commit queue.
Revert "Run all *_driver tests also with Kernel."
This reverts commit d2f887e37b055654e96d824c3f56cchttps://dart-review.googlesource.com/7708
Reviewed-by: William Hesse <whesse@google.com >
2017-09-22 11:37:21 +00:00
d2f887e37b
Run all *_driver tests also with Kernel.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I92a0f5f2192c20276b166a9211ab1064bc6f2b82
Reviewed-on: https://dart-review.googlesource.com/7624
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-21 22:44:39 +00:00
76ad63dadb
fix error dangling annotation
...
Change-Id: Iad0870c7d4a4864654af22f8fc7d69b0be961d4e
Reviewed-on: https://dart-review.googlesource.com/7420
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-21 17:28:07 +00:00
9baee97ea2
Revert "Add NamedNode.nameOffset, fill it for constructors, and use in Analyzer."
...
This reverts commit 9a8621b60ae4fa080f698df6c79b9d9bdda4b1d3c59eaf17886d0515f9cahttps://dart-review.googlesource.com/7550
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-09-21 12:19:47 +00:00
6d0515f9ca
Return SimpleIdentifier or PrefixedIdentifier from _buildIdentifier().
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ifaecb13e6869166deb10c6211cf075761c185100
Reviewed-on: https://dart-review.googlesource.com/7449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-20 21:31:20 +00:00
c59eaf1788
Move TypeProvider creation into KernelResynthesizer and create loadLibrary functions.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Idabf9baa72de55d9a501a9b91317aad004dcf5dc
Reviewed-on: https://dart-review.googlesource.com/7447
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-20 20:48:50 +00:00
9bdda4b1d3
Run NonErrorResolverTest in strong mode. Extract not strong tests.
...
Plus a tiny fix for not considering a class with a static method
named "call" a Function.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I46c470c9d5dfb9f3cda9d5c5ac432962975f6773
Reviewed-on: https://dart-review.googlesource.com/7444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-20 20:46:11 +00:00
7e25f2a336
tests for annotation at EOF
...
Change-Id: I43aafd04dba8511cb603c6ca31a8135d868f52ef
Reviewed-on: https://dart-review.googlesource.com/7300
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-20 18:24:24 +00:00
8df6c79b9d
Create (empty) initializers for parameters resynthesized from Kernel.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ifeddbd315b5c8d541c0db9a577d4cbddcfbdeba0
Reviewed-on: https://dart-review.googlesource.com/7380
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-20 18:04:00 +00:00
e4fa080f69
Rework getElement() in resynthesizer.
...
So that it is not recursive anymore.
This also fixes a bug with private classes.
There is no library URI qualifier for classes, even if they are private.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ibeb8bd18fed9b116a40b2f2ff357f97283bc7b0d
Reviewed-on: https://dart-review.googlesource.com/7382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-20 17:59:57 +00:00
danrubel