bd49ff15bf
Record constructor name offset in metadata.
...
This fixes 70 Analyzer tests.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug:
Change-Id: If7e3fa948aa67712eab5533b083757a75a981e14
Reviewed-on: https://dart-review.googlesource.com/13926
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-16 18:29:37 +00:00
462542b734
Report UNUSED_ELEMENT for top-level variables.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/25323
Change-Id: I751ee82742ff622a9b28b3cb05886b5ee775f9ed
Reviewed-on: https://dart-review.googlesource.com/13929
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-16 17:44:06 +00:00
25dc42f5d8
Revert "Error on setter having not exactly one parameter"
...
This reverts commit 4bb83e9311f1b07b2789https://dart-review.googlesource.com/14061
Reviewed-by: Martin Kustermann <kustermann@google.com >
2017-10-16 16:32:13 +00:00
5da015187e
Improve top level method modifier recovery
...
This updates the fasta parser to report additional analyzer errors
and improves recovery when parsing top level method modifiers.
Change-Id: If863011f6d9a33b366d621bc708c0cc25922ddb9
Reviewed-on: https://dart-review.googlesource.com/14000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-10-16 16:06:55 +00:00
f1b07b2789
Error on setter having not exactly one parameter
...
Rewrite setter with invalid parameters into one with one parameter
and a body throwing a compile-time error.
Some analyzer tests fail until we sort out the expected form of the
generated kernel code in situations like this. This is tracked in
https://github.com/dart-lang/sdk/issues/31096
Closes https://github.com/dart-lang/sdk/issues/31069
Change-Id: I65033709813671ecb933e6a4dc00d1ff3b504661
Reviewed-on: https://dart-review.googlesource.com/13080
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2017-10-16 15:07:49 +00:00
d20bfc5095
Map error codes for uninitialized const and final variables
...
Change-Id: I55e284cce214ffc9d08d5132e7b142f0d07572e3
Reviewed-on: https://dart-review.googlesource.com/13965
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-15 20:35:07 +00:00
66e5dc35de
Associate more fasta and analyzer errors
...
Change-Id: I9e5151fb51cd4d0e488d0dfcc614f286f5f6cadc
Reviewed-on: https://dart-review.googlesource.com/13934
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-14 19:50:57 +00:00
df459aa19d
Malbounded types should have all 'dynamic' type arguments.
...
See "19.8 Parameterized Types" in the specification.
"In short, any arity mismatch results in all type arguments being dropped, and
replaced with the correct number of type arguments, all set to dynamic. Of course,
a static warning will be issued."
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug: https://github.com/dart-lang/sdk/issues/31062
Change-Id: Ia04b6c4da538582736617931eb7b7c20dc0a4259
Reviewed-on: https://dart-review.googlesource.com/13340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-10-13 18:44:34 +00:00
940b9e5fdf
Connect a Fasta error to an Analyzer error
...
Change-Id: I9b47e6712b65c2e97693bfef4c022109431660f1
Reviewed-on: https://dart-review.googlesource.com/13860
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-13 18:05:44 +00:00
2aa005b11b
Improved handling of semicolons
...
Change-Id: I85c42387bad18149bd2fb7718f6d40b82a95562f
Reviewed-on: https://dart-review.googlesource.com/13626
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-13 16:16:43 +00:00
1582021556
Allow built-in keywords as top level function identifiers
...
Change-Id: I4287e8279d2ebe6f4460ce48409b7bd9ead16b96
Reviewed-on: https://dart-review.googlesource.com/13627
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-12 23:48:05 +00:00
a22c8dc958
Recover when enum constants have metadata
...
Change-Id: I1432c3b2d4ce63c5520087c79dd33e48c57cee5b
Reviewed-on: https://dart-review.googlesource.com/13102
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-12 20:50:31 +00:00
c2f11254c8
Recover from a class declaration with no body
...
Change-Id: Ib92d79087841d89ef4dd660345aa22e4006f59c1
Reviewed-on: https://dart-review.googlesource.com/13580
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-12 16:08:33 +00:00
9370149f69
fix keyword as identifer edgecase
...
This addresses the situation where a top level built-in keyword
such as "import" or "export" is used as an identifier
in a top level declaration.
Change-Id: I663ed00502eadd2c639f79e68d26345783911faa
Reviewed-on: https://dart-review.googlesource.com/13361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-12 03:38:48 +00:00
1c7c72c679
Refactor and update modifier warnings
...
* Extract parse modifiers
into ModifierContext and ModifierRecoveryContext
* Recover gracefully given out-of-order modifiers
* Generate analyzer error codes
* Address comment in prior CL
https://dart-review.googlesource.com/c/sdk/+/10760/1/pkg/front_end/lib/src/fasta/parser/parser.dart#436
There are several more modifier error codes that need to be added.
I will tackle those in a subsequent CL.
Change-Id: I61e9182e14fa9d45b35029013a645329e6cc54ab
Reviewed-on: https://dart-review.googlesource.com/11800
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 23:32:10 +00:00
0920da5d52
One more pass to triage the rest of the tests.
...
I hope that's it for now.
At this point we need to fix Fasta problems to fix there tests.
R=brianwilkerson@google.com
Bug:
Change-Id: I68c4ea12a9f1ea524a3d15865f71675a91e18d66
Reviewed-on: https://dart-review.googlesource.com/13303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 21:31:34 +00:00
0a0c5f54cd
Fix accidential failures for StrictModeTest_Kernel and TypePropagationTest_Kernel.
...
I reported issues for reasons why they were failing with Kernel
and fixed mistakes in tests and mocks.
R=brianwilkerson@google.com
Bug:
Change-Id: Ide98582047ebc0b862a2a94a1e1543f0f84d6bfc
Reviewed-on: https://dart-review.googlesource.com/13260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 20:36:45 +00:00
815737113d
Triage StrongModeLocalInferenceTest_Kernel and StrongModeStaticTypeAnalyzer2Test_Kernel.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I5589eedbbbf53b9e09c10284ebdec20c4e76eccd
Reviewed-on: https://dart-review.googlesource.com/13104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 19:41:09 +00:00
afaf47e29b
Triage the rest of StaticWarningCodeTest_Kernel as Fasta problems.
...
Unfortunately there are nothing we can fix at the Analyzer side yet.
R=brianwilkerson@google.com
Bug:
Change-Id: I859f8608833fcdf254bf811906475ffec871665c
Reviewed-on: https://dart-review.googlesource.com/13241
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 18:32:50 +00:00
1e48c3f4d1
Recover from having an index operator with no expression
...
Change-Id: Ic4a6abcc95f61da047053398804bfe947565de88
Reviewed-on: https://dart-review.googlesource.com/11680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-11 18:00:30 +00:00
4c6322ac16
Triage StaticWarningCodeTest_Kernel and fix one problem.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I26d1f30fca0928d1ec00bfba932975734a1c1b7a
Reviewed-on: https://dart-review.googlesource.com/13181
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 18:00:25 +00:00
e942115fcd
Fix an infinite loop in the parser
...
Change-Id: I0946867082afecde10afb00abedc94bb0f18f6d3
Reviewed-on: https://dart-review.googlesource.com/12040
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-11 15:40:30 +00:00
1bdfe2a52c
Triage StaticTypeWarningCodeTest_Kernel.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I7c7004393a68e9a340f5d71e88b829e3493f0dc6
Reviewed-on: https://dart-review.googlesource.com/12880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-11 15:33:00 +00:00
7d9188aea1
Add FallThroughError that is used by Fasta.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Iff5a981f7ce9e9693996bc18493c13b2d88e5f6d
Reviewed-on: https://dart-review.googlesource.com/12782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-11 02:02:40 +00:00
feccb794a2
Don't attempt to query the setter type of a non-setter.
...
Fixes #31031 .
Change-Id: I1a82f7a3da31ad89d0303232977a64ddd546898c
Reviewed-on: https://dart-review.googlesource.com/12781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2017-10-10 21:39:14 +00:00
5e5d4e0e51
Frontend does support generic function typed formal parameters.
...
So, we don't need the workaround in DeclarationResolver, and we
don't need to mark corresponding tests as failing for *_Kernel tests,
so we stop inheriting *_Driver for these tests and provide
enableNewAnalysisDriver explicitly.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ib09f7bc5be5f4a80ba7874791b5b3f28a4d0a23c
Reviewed-on: https://dart-review.googlesource.com/12742
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-10 20:31:28 +00:00
cd55beabd9
Fix failing tests (TBR)
...
Change-Id: I08a73dbdee624c925cf0ee13943a3711787bc5a3
Reviewed-on: https://dart-review.googlesource.com/12303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-07 17:11:45 +00:00
5d4f788352
Avoid exception resulting from invalid user code
...
Change-Id: I23af799bc2ee5c3158cf08ba24a5630f8be8d44c
Reviewed-on: https://dart-review.googlesource.com/12201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-07 15:15:48 +00:00
96265d7ae2
Run CompileTimeErrorCodeTest in strong mode.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I6c0d452935da69c3323c34be4f2ead06d063e2d4
Reviewed-on: https://dart-review.googlesource.com/12127
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-07 01:04:36 +00:00
9cdfb2ffc4
Set ConstructorElement.isCycleFree to 'false' when we detect this.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I0a20d3990260df9aa96325d5e665ff9c1df67f9c
Reviewed-on: https://dart-review.googlesource.com/12061
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-06 22:21:56 +00:00
cf6fff1880
Rework the way AstBuilder finds documentation comments
...
Change-Id: Id3bdb6c68fdbf5c878da77feeb99907ada76ff0d
Reviewed-on: https://dart-review.googlesource.com/11261
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2017-10-06 00:05:23 +00:00
2220f21e40
Preserve comments when rewriting the token stream
...
Change-Id: I76dc76dfcace7b4d0802f961879e26d6a6133170
Reviewed-on: https://dart-review.googlesource.com/11300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-05 17:29:50 +00:00
8bdac8155b
Fix resynthesizing libraries for not existing URIs.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I9706fa3a23d91531f7710aa11b78ba7b3bc9f282
Reviewed-on: https://dart-review.googlesource.com/11245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-05 04:10:10 +00:00
efeaa0eab3
Class header recovery
...
This updates the fasta parser to handle out of order clauses
in the class header similar to analyzer.
Also:
* Fix parseTopLevelDeclaration in parser test proxy
* Fix parseStuff to correctly update token stream
* Extract skipUnexpectedTokenOpt
Change-Id: Ic20c0ab1355e866aa241c591ceeada390890c46a
Reviewed-on: https://dart-review.googlesource.com/9880
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 21:33:09 +00:00
18d37f3ca9
Triage more issues that require Fasta changes.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I908d20bdd6c890acfd9e07b2815f4a3242bf1555
Reviewed-on: https://dart-review.googlesource.com/11244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 21:22:53 +00:00
6b6130e80c
Triage invalid constructor names as Fasta problems.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I5fbe0d7c35124ad4b2113bfd7a4867ce912a0933
Reviewed-on: https://dart-review.googlesource.com/11160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-04 21:06:10 +00:00
10807744b8
Rework tests to parse at a higher level
...
Change-Id: I8d1a13e91a3cce49dafab79a97de4df4807fbbfe
Reviewed-on: https://dart-review.googlesource.com/11100
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 19:52:09 +00:00
a4189d36fd
Handle another variant of _ConstantExpressionError.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I20d16ef0cffd91b32d6ed48a0f981f6542b0dc47
Reviewed-on: https://dart-review.googlesource.com/11120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-04 19:06:09 +00:00
082bbdb6a7
Remove flag and enable asserts in initializers by default
...
Change-Id: Ia81f5ec936981dc08ff4c740f3511c6b7c9e6eb6
Reviewed-on: https://dart-review.googlesource.com/10740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-04 18:45:09 +00:00
69a5202cda
Triage missing import element as a Fasta problem.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/30997
Change-Id: I1db4734b8ced5684d6f8f9706105cef6ecaa37fa
Reviewed-on: https://dart-review.googlesource.com/11024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 17:36:28 +00:00
a212f20a9a
Generate a parser error when an enum declaration is empty
...
Change-Id: I459a329f2e1a3cb7ad52f4a1e79d717d2afeb49f
Reviewed-on: https://dart-review.googlesource.com/10661
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-04 17:33:39 +00:00
2e203d0473
Create initializer element even for parameters that cannot have them.
...
Fasta returns `null` initializer.
But Analyzer needs an initializer element.
So, we now create one always.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/30996
Change-Id: I311f7d188f1e1b5ecf81d6cae7828999f4b4cfce
Reviewed-on: https://dart-review.googlesource.com/11023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 17:33:23 +00:00
9bc267e66c
Fix for exception during resynthesizing 'this' in default value.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I4b866370383d9d4020c5a1b400da8a8b9cab8666
Reviewed-on: https://dart-review.googlesource.com/10841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 16:29:32 +00:00
b7d00a8712
Add _DuplicatedFieldInitializerError that is used by Fasta to report compilation errors in Kernel.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I27ef95ecb53a37fa1543fd65e3a6ea09974f3b56
Reviewed-on: https://dart-review.googlesource.com/10840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 16:24:52 +00:00
c60b193ebb
Use the correct order of 'const factory' modifiers.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Ifdeaa68cbbc74371765ce00ff02197b618c23207
Reviewed-on: https://dart-review.googlesource.com/10824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 16:21:52 +00:00
687ba3c7bc
Fix for unresolved field initializer.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Ib67167973b0cba708e83ee7852e010315d15409b
Reviewed-on: https://dart-review.googlesource.com/10823
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-04 15:51:53 +00:00
e9a849a7d6
Add synthetic semi-colon when missing after expression statement
...
Change-Id: Id14fb60c56790c83358b4c026770e0c691841908
Reviewed-on: https://dart-review.googlesource.com/10721
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 15:19:33 +00:00
0ba2ad032c
Triage CompileTimeErrorCodeTest_Kernel.
...
Mark tests that obviously fail because of bahaviour of Fasta with
corresponding @FastaProblem, and the tests that fail because of
something we do incorrectly in Analyzer with @potentialAnalyzerProblem.
R=brianwilkerson@google.com
Bug:
Change-Id: Ia383a05c0899b2681ebf2383059cf41f909c85f8
Reviewed-on: https://dart-review.googlesource.com/10780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-04 00:39:39 +00:00
4b76d48935
Replace Kernel's InvalidType with Analyzer's UndefinedTypeImpl.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I84bf02c6287aa01f1b4ef831e87719507d2f0ec1
Reviewed-on: https://dart-review.googlesource.com/10202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-03 16:39:10 +00:00
b4d179e58a
Recover from missing identifiers
...
Change-Id: I3c7a908449861eeed0915c4d74b10f4d1e46fde4
Reviewed-on: https://dart-review.googlesource.com/7558
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2017-10-03 13:41:02 +00:00
Konstantin Shcheglov