Commit Graph

8489 Commits

Author SHA1 Message Date
Konstantin Shcheglov 8c767c32f2 Remove JavaSystemIO.
Change-Id: I5f3243534cc6b5e71bb0c76753adff2c636f812d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128370
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-13 20:31:21 +00:00
Brian Wilkerson 43066c9911 Add newly reviewed diagnostic docs
Change-Id: I1a090ebd0129040a5fcbf2fca3919c6e22cf1daa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-12-13 17:55:29 +00:00
Konstantin Shcheglov 8a29e6b830 Remove DevCompilerResynthesizerBuilder from analyzer.
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I330c575531dfeddbb82b4512950677f323adec20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-13 15:31:28 +00:00
Konstantin Shcheglov f14301b0df Stop supporting _sdkext, look for _embedder.yaml only in sky_engine package.
Change-Id: I20d30ef0e07ec617d5d8b9fb2e5fb97a7fc9930f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-13 02:15:28 +00:00
Konstantin Shcheglov b3c2eb9f69 Stop setting AST properties for DDC.
Change-Id: Ia3fd639497b65844d386e06131dd729aa76c6a94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128111
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-12 23:54:41 +00:00
Konstantin Shcheglov e51702a7a1 Issue 39752. Fix for promoting TypeParameterType twice.
Bug: https://github.com/dart-lang/sdk/issues/39752
Change-Id: Idbb1a3b11d8eb6bdb05a2916d224a4d3e08a5b05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128240
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-12 21:35:29 +00:00
Konstantin Shcheglov 3172748cb0 Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider.
It does not look that these are used anymore.

Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-12 19:54:51 +00:00
Konstantin Shcheglov b32922ab9c Fix TODO in lint/analysis.dart
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I3621f5a47c821b8cec22bfb6de298d3a748d6b37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128222
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-12 18:23:01 +00:00
Konstantin Shcheglov 3389b3bd32 Remove Packages from SourceFactory.
We have PackageMapUriResolver, this should be the way to resolve
all `package:xyz` URIs. We should not repeat it in SourceFactory.

Change-Id: I52d33dbf7e2d44f2c53521f6a51b0aea70507d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-12 17:10:00 +00:00
Konstantin Shcheglov dfc268671f Packages configuration abstraction on top of .packages or package_config.json files.
I plan replacing all references to package:package_config with this
new abstraction in future CLs.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ifbe2c6a16f12cbf32f895505b16857a790610f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128102
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-11 20:52:38 +00:00
Konstantin Shcheglov 191df1ff71 Implement NORM.
https://github.com/dart-lang/language/blob/master/resources/type-system/normalization.md

Change-Id: I51d74045a7c50e546427767fcfbc7a28c1986ecc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-12-11 17:47:17 +00:00
Konstantin Shcheglov b305a5cef1 Implement parsing for package_config.json files in analyzer.
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Idb1ae19327df2bb2388fb585aecc7269edfdf66e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-11 17:01:27 +00:00
Sam Rawlins c01b52cb0f Remove duplicate 'DEFAULT_VALUE_IN_FUNCTION_TYPE_ALIAS' already reported by fasta
Fixes #39524

Change-Id: Iaf1c095a9f80809cb8b7e0edd966ab1b22c89abc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-11 16:22:48 +00:00
Paul Berry 06c60481da Create null-aware companion methods for ElementTypeProvider.
These methods are extension methods, so this requires bumping the
analyzer SDK requirement to >=2.6.0.

Change-Id: I2e24027f6cf54520a875dfba60bf85a3644b9fac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-12-11 14:47:29 +00:00
Sam Rawlins bd008dd1e4 Allow empty URI strings in library directives
Fixes #38859

Change-Id: I1698b09bfee367634782f6f7c61f1dbda22edc0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127600
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-12-11 02:20:16 +00:00
Konstantin Shcheglov 74cc764c06 Issue 39598. Make UNNECESSARY_NULL_AWARE_CALL and other warnings.
UNNECESSARY_NON_NULL_ASSERTION
UNNECESSARY_NULL_AWARE_SPREAD
UNNECESSARY_NULL_AWARE_CALL

Bug: https://github.com/dart-lang/sdk/issues/39598
Change-Id: I74c22ad2c63caf7bf6f3d2f8d02a40ef568b242b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127742
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-10 23:06:36 +00:00
Konstantin Shcheglov e22ddd1372 Update TypeSystemTest to reuse more ElementsTypesMixin.
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1ceb8a7fe429f194e7ff418105517b96917ce6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-10 19:10:45 +00:00
Konstantin Shcheglov 1cc5d6927a Deprecate ErrorReporter.reportTypeErrorForNode()
We always want to convert DartType(s) to their String presentations
using getDisplayString(), never using toString(). Also it is OK  to do
some processing during error reporting, it should be rare operation.

R=brianwilkerson@google.com

Change-Id: I57b80cdd7e91de2eb0d06aa84e15ffc0f577090b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-10 18:41:35 +00:00
Konstantin Shcheglov 620dd7dab5 Use just DartType.getDisplayString() in ErrorReporter.
R=brianwilkerson@google.com

Change-Id: Iaddf2e8cb9fb69dab3542766e8bc6bb82e9d726f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-10 17:02:35 +00:00
Konstantin Shcheglov 9456316b51 ErrorReporter should know isNonNullableByDefault.
So, when we call DartType.getDisplayString() we know if the type
presentation should include nullability suffixes.

This fixes many, but not all places where we need to present types.
There are places where we don't go through ErrorReporter, but call
ErrorListener directly. I plan to replace all these with ErrorReporter.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/39651
Change-Id: Ic77a556e7834d8f757c8b13eed37ed1d34f47348
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-10 01:31:22 +00:00
Konstantin Shcheglov b296d55c55 Issue 39709. Disable implicit 'call' tear-off for nullable objects.
Bug: https://github.com/dart-lang/sdk/issues/39709
Change-Id: I5dcb139f99d3d1e7ef43c6e463e01b665e655b77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-09 22:22:44 +00:00
Konstantin Shcheglov ded753a397 Use 'isNonNullableByDefault' as the flag name everywhere.
We used different names at different places, I propose using this
single name everywhere. Hopefully I updated them all.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0fea2799b9a40526c4f0194a8a81812bdf788c90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127722
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-09 22:19:47 +00:00
Konstantin Shcheglov 86723cd5b1 Remove unused private methods and explicit 'new'.
R=brianwilkerson@google.com

Change-Id: I8850fbaa67aad479f8327b7806c5e98aa70e7e03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-09 22:19:27 +00:00
Paul Berry de0e432ef1 Create an abstract layer to customize querying element types.
This will be needed for the NNBD migration engine.

Currently only used in checker.dart.  Later CLs will convert the
resolver to use this abstraction layer as well.

The runtime overhead of this abstraction should be negligible, since
under normal analyzer operation, there will only be a single const
instance of this class, and no instances of any subclasses.  So the VM
should be able to trivially inline all uses of the abstraction layer.

Change-Id: I0132b76238606e6e6b789169a62806d09f10f71d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127490
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-09 19:17:49 +00:00
Brian Wilkerson 5f7177db84 Handle two non-operators as if they were operators to prevent a failure when assertions are enabled
Change-Id: Ia2011d240866ac9f569aa9aacc374e33c89d74d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-12-09 19:07:39 +00:00
Konstantin Shcheglov bafd4e8dc6 Issue 39668. Use 'read type' to check dead '??='.
Bug: https://github.com/dart-lang/sdk/issues/39668
Change-Id: I20bd3ae7806b409d6c4b9b72b4968651db207ea4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-09 18:19:29 +00:00
Paul Berry ffd757640d Duplicate kernel package's graph.dart in analyzer, and prepare to publish 0.39.2+1.
Analyzer has dropped its dependency on kernel, so we can no longer
share this code.

This will allow us to re-publish analyzer and address issue #39702.

Bug: https://github.com/dart-lang/sdk/issues/39702
Change-Id: I20c3505c450dddb1e833fa6e56291ab39c32fe0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-12-08 23:49:27 +00:00
Konstantin Shcheglov 52dc7690ef Issue 39667. Use flow analysis in IfElement.
Bug: https://github.com/dart-lang/sdk/issues/39667
Change-Id: I4528869a8d39d1b27c0cdf21ab20173bdb0efbc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127482
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-12-07 03:32:14 +00:00
Konstantin Shcheglov c17aff87e1 Restore skipping all dynamic type arguments in DartType.displayName
There is one internal client that currently depends on such presentation.
This will unblock rolling analyzer, then we will fix the client, and
remove this skipping code in analyzer.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0d6387892d12326d658800069dd8a60faa589405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127488
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-07 02:24:34 +00:00
Konstantin Shcheglov f024d9dcce NullabilityEliminator - Never to Null*, remove required from formal parameters.
Change-Id: I3ad2cf15c2ed1e8eb347ac84c9dc401e807e2e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127203
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 23:28:09 +00:00
Konstantin Shcheglov b92cd2cb95 Deprecate DartType.displayName, use getDisplayString() instead.
We call it with `withNullability: false` almost everywhere.
My attempt to update all places turned out to be a long chain of
changes. So, instead I will make decisions and updates in separate
CLs, starting with ErrorReporter.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I9d72475577ba2934bed1c06a4808ab620e92a20e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127441
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 22:43:59 +00:00
Sam Rawlins 0939101320 When reporting unused elements, do not count a CommentReference as usage
Fixes #37116

Change-Id: I9ac563036a367a5e5da4fbba8ab521f174062570
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127223
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-06 22:36:54 +00:00
Brian Wilkerson 652926bbaf Deprecate Element.getAncestor, replacing it with methods matching those in AstNode
Change-Id: Iebb046791c1fce57a228f997e9c5936809fbc872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-12-06 18:29:02 +00:00
Konstantin Shcheglov 4b21941d33 Fix prefer_iterable_wheretype in analyzer.
R=brianwilkerson@google.com

Change-Id: Id683ec62a7bdfddb5b2662afbcf57d884767a736
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127454
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-06 15:54:10 +00:00
Konstantin Shcheglov 54e1c16c1c Fix empty_catches in analyzer.
R=brianwilkerson@google.com

Change-Id: I6abc5acbd93aa12df8ff6226c49f9b72c0313c92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127426
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 15:03:30 +00:00
Konstantin Shcheglov 54b7543c55 Fix unnecessary_const in analyzer.
The only non-mechanical change is update for tool/diagnostics/generate.dart
to handle MethodInvocation, because without resolution and without
explicit `new` and `const` we get MethodInvocation(s).

R=brianwilkerson@google.com

Change-Id: Ib89ce9c37066e9b27ad03aed96b349ef36f11d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127453
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 15:03:00 +00:00
Konstantin Shcheglov 0bca6aaf10 Fix avoid_return_types_on_setters in analyzer.
R=brianwilkerson@google.com

Change-Id: If7132980451d76c777d3734abbb89ece5ad3e3d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127425
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-06 01:48:48 +00:00
Konstantin Shcheglov 364dd8936b Fix unnecessary_new in analyzer.
R=brianwilkerson@google.com

Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 01:11:30 +00:00
Konstantin Shcheglov eee20b4e60 Fix prefer_equal_for_default_values in analyzer.
Change-Id: Ia72a2ac31d6cf6329c78baad6954ac9595a6c45a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 00:00:30 +00:00
Konstantin Shcheglov f772b572c8 Fix curly_braces_in_flow_control_structures lint.
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I63cb372bf04f80182f873e2143971cb3cf1392fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-05 23:46:13 +00:00
Konstantin Shcheglov 845fccc337 Issue 35818. Use getDisplayString() in _ElementWriter.
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35818
Change-Id: I9a86729ba48cf599c45afee2c7ba83f32ba3c30b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-05 22:21:55 +00:00
Konstantin Shcheglov eba38af5d1 Add DartType.getDisplayString()
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3849ccb4d2359fddf470b42280e3ea21e38f3664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-05 21:29:20 +00:00
Konstantin Shcheglov 47383da053 Update LUB for Null vs star.
As specified in https://github.com/dart-lang/language/pull/700

Change-Id: I324841799a485600bf1ebfd54cd852465efac715
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126981
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-05 03:55:48 +00:00
Konstantin Shcheglov 9c220059a1 Implement DOWN for FunctionType(s) with NNBD rules.
Change-Id: Icd21f17522a54f6d6545aa13406bbbac6cfb0233
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127060
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-03 20:41:38 +00:00
Sam Rawlins 1ebf5cfb39 Fix false positive UNUSED_FIELD on extensions
Also add tests for extensions, and for mixins.

Fixes #39618

Change-Id: I9f6ab723c72d5297c91e360f3531da374a53f0ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2019-12-03 18:45:38 +00:00
Sam Rawlins 9719f75ef3 Add InvalidLanguageVersionOverride Hint; fixes #37504
Change-Id: Iea0687266b748a94218191f0ebdf7032715bf96a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125522
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-03 13:19:15 +00:00
Konstantin Shcheglov 2de9b45c8f Update isFunctionSubtypeOf() to NNBD spec.
There is no functional changes, just rewriting this to the rules
as they are in the NNBD spec, and iterating over parameters in parallel
without building additional lists and maps.

Change-Id: I5d30cc3b7e1debf45486166aa5a8d1ccc20d5adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-03 03:14:20 +00:00
Konstantin Shcheglov 980b7ace7d Implement DOWN with NNBD rules.
https://github.com/dart-lang/language/blob/master/resources/type-system/upper-lower-bounds.md#lower-bounds

Presubmit is green.
https://test.corp.google.com/ui#id=OCL:283239993:BASE:283239999:1575237950656:febb4697

Change-Id: I50ed1fc8ec589a545f41c2360f7d841a1b11f6fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-12-03 03:04:10 +00:00
Konstantin Shcheglov 4fe27fd444 Report an error when 'await' is used in the initializer of a late local variable.
Change-Id: I4c610dd37e4c7ca653d250d4e0522536a70a6ca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-12-02 18:00:48 +00:00
Konstantin Shcheglov 6305276184 Remove deprecated 'byteStore' and 'fileContentOverlay' parameters.
I don't need them anymore, and would like to stop seeing these
deprecation hints :-)

R=brianwilkerson@google.com

Change-Id: I85fac405211afd4fcd0388c5ca131374e868f9c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-02 16:56:37 +00:00