39f14a000e
Rewrite most getDisplayString() to ElementDisplayStringBuilder.
...
R=brianwilkerson@google.com
Change-Id: I500d0045873a12d550d9ffe302e066a63ba56660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-06 16:43:40 +00:00
877d6f745d
Improve the range selected for const_constructor_with_non_final_field
...
Change-Id: I168e92c32b581dffcad25804161b56f4d99c1dd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-05 23:50:22 +00:00
b975366803
Directly instantiate none/star collection.
...
R=brianwilkerson@google.com
Change-Id: I748230e097e703724cd94e9fa8a17832a8b63c0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-05 23:50:12 +00:00
d89e8b7fad
Remove unused fields from TypeNameResolver.
...
R=brianwilkerson@google.com
Change-Id: I92fa8f47334d3cd24804225f20b2806585cb0c77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-05 23:42:19 +00:00
36fb383a6c
Remove unused TypeSystem.instantiateTypeFormalsToBounds2()
...
R=brianwilkerson@google.com
Change-Id: I7dde98d43f47695565c89c593303fa124a07c5df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130223
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-05 23:42:09 +00:00
5323d60b97
Unify two error codes from the perspective of documentation
...
Change-Id: I53586ba07d3980045a9d869ce33100fcf7c4c604
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-05 20:59:27 +00:00
08bd1d6be7
Merge instantiating ClassElement(s) in TypeNameResolver into _instantiateElement().
...
Change-Id: I3d97c9f03a8ccbc85b025191a85042528e80a8c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-04 19:43:06 +00:00
76e3faa982
Resolve MethodInvocation(s) with Never and Never? receivers.
...
Change-Id: I7314efe7ccc352da7a407c3a657a30cc0956580b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-04 01:41:05 +00:00
6e7a900283
[nnbd_migration] Fix ConditionalModification on IfElement
...
Change-Id: I1e8ec4bead2aaa9147850d27cd5ac4d9c2a700be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130137
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-01-03 23:47:50 +00:00
be4acb4cd5
Remove duplication in checking elements in TypeNameResolver.
...
R=brianwilkerson@google.com
Change-Id: I36b81e80057cab05e5c12818cc19edd53f5071c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130135
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-03 23:39:55 +00:00
4f2a9e083d
Resolve MethodInvocation fully in MethodInvocationResolver.
...
So, it is not separated into ElementResolver and StatisTypeAnalyzer.
Change-Id: I413a71b703ab93304760e1f912c3d55585411397
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130132
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-03 21:40:19 +00:00
c913b01ec0
Report error during constant evaluation for ForElement.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Ic87094ed1dcfb4e630e3e62b9ed7e7ec8feab2c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130133
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-03 21:18:59 +00:00
b94bad1fca
Check for MigrationResolutionHooks directly in StaticTypeAnalyzer and ResolverVisitor.
...
I want to extract invocation inference into a separate helper, and
perform MethodInvocation resolution as a single step inside
MethodInvocationResolver. So, I want to set `Expression.staticType`
in several places. Using special subclass of StaticTypeAnalyzer does
not fit this intention.
I think `is` check is JIT optimizable well, and during analysis
we will have just one type of ElementTypeProvider.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ie718db35ac9426b35b538b92a2e2177828ae7ad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-03 17:40:19 +00:00
2678ee01ac
Don't include end of comment markers in TODO range
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/2181 .
Bug: https://github.com/Dart-Code/Dart-Code/issues/2181
Change-Id: I670f8f46ef60d09ec3f1fd743084734048f3cfc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-03 15:48:09 +00:00
a23a3db99c
Remove unnecessary climbing up when reporting non-type element.
...
R=brianwilkerson@google.com
Change-Id: Icfbd1feec08fb0ff2e988e70a4aa5112cf3f6ae5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-03 15:30:39 +00:00
91341dd0b7
Remove _checkElementOfType().
...
I think we don't need it anymore.
Change-Id: I50b9cc4c0bd3693a7172a2e71cd24096708fd0db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-03 15:29:49 +00:00
d35e94c8ae
Validate incompatible lint rules
...
Change-Id: Ic57cdf7c7264c7d4da266f73a63b0b47e4a1d65a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130007
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-02 22:07:56 +00:00
df98317c42
Report unchecked nullable for explicit / implicit 'this' in extensions.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39875
Change-Id: Ia0e5b9ea736428cd40d8898e48e0db605deebacd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-02 20:17:07 +00:00
dbaeb9a6d9
Use NullableDereferenceVerifier in ErrorVerifier.
...
R=brianwilkerson@google.com
Change-Id: I0adc88b5e6874d2834f904da175757bdbd78772c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130009
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-02 19:45:24 +00:00
2a208b2f7b
Use ErrorReporter in TypeNameResolver.
...
R=brianwilkerson@google.com
Change-Id: I7985fbad36101480b292ebd0e06c0019b9856fbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-02 07:14:36 +00:00
46fbc94985
Simplify 'void' resolution in TypeNameResolver.
...
Also, 'void' is a reserved word, and the grammar does not allow
type arguments after 'void':
<typeNotFunction> ::= void | <typeNotVoidNotFunction>
<typeNotVoidNotFunction> ::= <typeName> <typeArguments>? ... etc
R=brianwilkerson@google.com
Change-Id: Ia54916a8d30ac507bac2133dc3ffabd2c654b09b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-02 06:01:18 +00:00
c7f3020fc6
Extract error reporting from TypeNameResolver.
...
The extracted code mostly chooses which ErrorCode to report, and
does not do resolution logic itself. So, I think it will make the
resolver itself cleaner to keep it separately.
R=brianwilkerson@google.com
Change-Id: Idc6b652028ddb11913d5cd5c8273299ed94e7079
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129987
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-01 22:29:05 +00:00
99a39abe98
Stop using Identifier in several Scope.lookup() methods.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I400f7c5b14f44fb1e2a8b3d5e52016dcc4924961
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129832
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-01 19:55:55 +00:00
850ca2d410
Add Element.getDisplayString(withNullability), use it in analyzer.
...
R=brianwilkerson@google.com
Change-Id: Ic4924e19612f2a7713f9a3f2059a880ebff9d2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-01 19:01:14 +00:00
4a6cd94f61
Deprecate 'ErrorReporter.source' setter.
...
R=brianwilkerson@google.com
Change-Id: I6a0878f0abc206311299281919d41c8ef3b5fd3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-01 18:52:14 +00:00
7b7d8789ca
Use WRONG_NUMBER_OF_TYPE_ARGUMENTS instead of two other equivalent error codes.
...
R=brianwilkerson@google.com
Change-Id: Ibb5ea7d65df75655eaf2d43fba1110740be39912
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129833
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-31 20:27:03 +00:00
c941ad0cba
Tweaks for DuplicateDefinitionVerifier.
...
Change-Id: I2e2ee36dd6061ae368da3c60a20866f40ab4ecec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129834
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-31 19:41:43 +00:00
13a05ee763
Simplify getNullability(hasQuestion).
...
R=brianwilkerson@google.com
Change-Id: I7c1f3eade62d10ff7eb854e27f10680d6a6af8da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129903
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-31 19:28:33 +00:00
85bdbb37bd
Update TypedLiteralResolver.computeElementType()
...
Slightly refactor, move Expression branches up, as first alphabetically.
R=brianwilkerson@google.com
Change-Id: I17afe6544c548a882396d83689233bfdd682935d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129835
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-31 19:10:23 +00:00
7cbc264231
TypeNameResolver refactoring - extract Element instantiation.
...
R=brianwilkerson@google.com
Change-Id: Icaaf2e988108b874fdc16dd837bf3d15eb82740e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-31 18:55:43 +00:00
b169f35743
Remove unnecessary methods to record errors or tokens and nodes.
...
We used them for Proxy support, but it was removed since then.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I417e5f0a473fa4ce418f2e5be524c600e976b2e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-31 18:28:33 +00:00
4e38c9012a
Remove 'isNonNullableByDefault' from TypeSystem.inferGenericFunctionOrType
...
R=brianwilkerson@google.com
Change-Id: Ibdca2d8c762d723ad5847ad99605618db19ad5f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-31 18:28:13 +00:00
566f173f0c
analyzer: Fix duplicate error-reporting with duplicate field formals
...
Change-Id: I80e158b33e7ea6ae4769b37f1a3448ebf6e061a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129824
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-30 04:29:18 +00:00
0c7048be74
Remove reporting duplicate CompileTimeErrorCode.CONST_NOT_INITIALIZED from ConstructorFieldsVerifier.
...
R=brianwilkerson@google.com
Change-Id: I1566c0d4f955846671823fd3736f71f08281d5c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129705
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-30 01:24:38 +00:00
c0819e7b81
Simplify SyntheticIdentifier to partial SimpleIdentifier.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I554df4fcf887497173b4fd29a26f28f47d7f0ab9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129828
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-30 00:53:18 +00:00
90c5eb0603
Remove 'referencingLibrary' from several Scope.lookupX() methods.
...
We don't use them, instead corresponding import namespaces don't
include private declarations.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I727ed92a643412a90f691c6966efb90121b079d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129827
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-30 00:48:18 +00:00
45b780e04c
Add canReferenceElementWithoutThisPrefix() to LinterContext.
...
With this approach, UnnecessaryThis is a bit more complicated than
the one outlined in the previous message:
@override
void visitThisExpression(ThisExpression node) {
final parent = node.parent;
Element element;
if (parent is PropertyAccess) {
element = parent.propertyName.staticElement;
} else if (parent is MethodInvocation) {
element = parent.methodName.staticElement;
} else {
return;
}
if (_canReferenceElementWithoutThisPrefix(element, node)) {
rule.reportLint(parent);
}
}
bool _canReferenceElementWithoutThisPrefix(Element element, AstNode node) {
if (element == null) {
return false;
}
var id = element.displayName;
var isSetter = element is PropertyAccessorElement && element.isSetter;
var result = context.resolveNameInScope(id, isSetter, node);
// No result, definitely no shadowing.
// The requested element is inherited, or from an extension.
if (result.isNone) {
return true;
}
// The result has the matching name, might be shadowing.
// Check that the element is the same.
if (result.isRequestedName) {
return result.element == element;
}
// The result has the same basename, but not the same name.
// Must be an instance member, so that:
// - not shadowed by a local declaration;
// - prevents us from going up to the library scope;
// - the requested element must be inherited, or from an extension.
if (result.isDifferentName) {
var enclosing = result.element.enclosingElement;
return enclosing is ClassElement;
}
// Should not happen.
return false;
}
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I83e2a3a67f3db43caeb8157116e823268c9bfec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129819
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-29 22:31:37 +00:00
11b66df561
[analyzer] fix an issue with the missing_required_param warning ending in two periods
...
Change-Id: Ie4ac2893c763c7b61e698ee6b95b39ad6cd4243a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129826
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-12-29 20:42:07 +00:00
e8f47a6cf3
incompatibleRules
...
Change-Id: I39b53a859176b8b20174b00b402327a7056c01ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129806
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-27 19:24:25 +00:00
2484b50fbb
Extract ConstructorFieldsVerifier.
...
R=brianwilkerson@google.com
Change-Id: Iac41c965ea079740dd0d4e9c6e552fc27b0333a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-27 18:39:15 +00:00
9e25072f2a
update dart.dev links
...
Change-Id: I000b77cd02c38e3147831c3ba605d83b8023b1ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-12-27 18:02:35 +00:00
f979338aab
Extract TypedLiteralResolver.
...
Almost purely moving classes and methods, without desirable additional
refactorings yet.
Change-Id: I7927a432b208747addf4a561d54078da553b339b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-27 07:56:04 +00:00
d0457488df
Extract TypeNameResolver.
...
Change-Id: I3733b1429e490772d6ce1b83987235aa63dd8bfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129640
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-26 22:23:49 +00:00
e2795c41ee
Move ResolverErrorCode codes into CompileTimeErrorCode.
...
Change-Id: Ie8a1422c86da5c4f04fbd4422a758289bf9e078c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-26 22:12:44 +00:00
2fb3f09948
Extract TypeProvider class into lib/dart/element/type_provider.dart file
...
Change-Id: I96cdfccc33e35a9625c14a89a08826758eac0f2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-26 21:31:04 +00:00
24d3174760
Remove unused InstanceFieldResolverVisitor.
...
Change-Id: I2eb4560288cfa7c976cfd0f52bbcc9ee4b279f7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-26 21:24:44 +00:00
94a4f6415e
Remove PartialResolverVisitor.
...
Internal presubmit is green.
https://test.corp.google.com/ui#id=OCL:287066079:BASE:287067930:1577252888356:d48f6795
Change-Id: I099092020f62d64de2f8c3fa4300928832df8085
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-26 18:03:04 +00:00
12136de92f
Copy flatbuffer lists in available declarations.
...
R=brianwilkerson@google.com
Change-Id: I3666f1e6ab9a2bd6a4bcf727b91a0b9ed2f7face
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-26 17:40:24 +00:00
48e42598df
Remove special support for dart:_foreign_helper
...
Change-Id: I5678d208a98dd2a6dce51305ea07df76ca935e53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-23 18:40:00 +00:00
8a0d30d4e2
Fix annotate-overrides in analyzer.
...
R=brianwilkerson@google.com
Change-Id: I7a587daf9715ded6450b28ecf3892ce4181aeb37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-23 00:02:37 +00:00
Konstantin Shcheglov