030594b353
Disable type propagation for class/top-level fields.
...
It was added initially in https://codereview.chromium.org/300033008/
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//837063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42647 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 22:13:55 +00:00
07ff6d4a45
Move incremental resolution validator into the analysis engine.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//842433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42642 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 19:05:27 +00:00
603ca51eec
Add a flag/options for enabling incremental resolution validation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//839553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42640 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 18:17:17 +00:00
b2835b572b
Tweak for escaping in instrumentation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//837753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42637 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 17:16:07 +00:00
fa896352ca
Escape field separator
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//835213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42634 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 15:37:20 +00:00
248d764ba5
Fix for issue 21982. Note the new instrumentation data tag.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//818733006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42608 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:56:45 +00:00
e83d560f8d
Issue 21842. Fix for incremental resolution of function expressions in top-level variables.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21842
Review URL: https://codereview.chromium.org//836763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42600 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 17:32:01 +00:00
0b97eb8807
Incrementally resolve only update to dartdocs, fail if add/remove.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//824783003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42581 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-31 23:39:23 +00:00
55de3493c2
Perform incremental resolution only if the existing unit is not null.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//827343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42580 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-31 23:37:54 +00:00
6d7155de63
Introduce CompletionTarget to take the place of the Node being completed.
...
Instead of locating the node containing the cursor offset using a
NodeLocator, identify the edge in the parse tree which will be
displaced or modified by the completion proposal. This reduces the
number of cases that need to be handled in the _OpTypeAstVisitor, and
avoids the need for the _OpTypeAstVisitor to consider character
offsets in nearly all cases.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//820773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42543 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 15:47:25 +00:00
d139fbfaa2
Add InstrumentationService.logPriorityException() and use logException() in refactorings.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//816103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42530 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 23:00:19 +00:00
232504e215
Incrementally resolve users of a changed method.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//814533005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42515 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 17:42:12 +00:00
a49d0f02c9
Instrument top-level exceptions
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//797503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42513 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 17:11:02 +00:00
8c99b69287
Log more information to debug 'null' location for constructor.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21842
Review URL: https://codereview.chromium.org//809203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42463 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-18 18:52:34 +00:00
7c877ab009
Ensure shutdown is always called
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//814453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42442 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 18:16:11 +00:00
2546490ed5
Ensure that AnalysisContext futures are completed when context disposed.
...
It's possible for the analysis server to create or destroy contexts in
the background while the user is working (as a result of changes on
the filesystem). This ensures that if any code completions are
waiting for analysis when that happens, they are aborted.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//807993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42416 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 23:41:56 +00:00
979dbab4d2
Add examples to illustrate the functionality of CancelableCompleter.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//807283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42414 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 22:34:59 +00:00
3448724d3a
Improve nomenclature of new AnalysisContext async method.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//809793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42404 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 18:05:02 +00:00
bc3d00456b
Issue 21886. Make enums available outside of the defining library.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21886
Review URL: https://codereview.chromium.org//809763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42403 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 17:33:13 +00:00
cbe501644b
Fix for issue 21771
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//810843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42402 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 17:27:09 +00:00
d2f11b6c44
Make futures returned by AnalysisContext cancelable.
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//806733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42400 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 17:01:22 +00:00
116ad81562
Fix error introduced by added import
...
Review URL: https://codereview.chromium.org//803663003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42353 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 23:33:46 +00:00
161285a754
Make instrumentation available in engine
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//798123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42349 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 22:23:18 +00:00
9b70cf5cae
Avoid NPE in package resolver if there's a problem running 'pub list'
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//799063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42347 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 21:52:29 +00:00
0b9ed18603
Allow completions to wait for analysis without requiring a busy wait loop.
...
Two new methods are added to the AnalysisContext which return
Futures--the futures complete with the result of analysis once it's
available, avoiding the need for a busy wait loop in the completion engine.
The futures are guaranteed to complete eventually (provided that
analysis reaches quiescence). If it is determined that the requested
analysis will never become available (e.g. because analysis was
requested for a file or file/library combination that is not subject
to analysis), the future will be completed with an
AnalysisNotScheduledError, so that the client isn't stalled forever
waiting for analysis results.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//800723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42339 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:22:34 +00:00
b9dc81cb2b
Add support for a client id
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//803523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42327 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 17:33:26 +00:00
085afe65ee
Issue 21850. Fix for incremental resolving field formal parameters.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21850
Review URL: https://codereview.chromium.org//799993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42325 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 16:42:43 +00:00
44b69647a3
Rework instrumentation API
...
R=danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//801543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42321 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 16:00:23 +00:00
958a1338e1
Issue 21842. Fix incremental resolving of parameters of function typed parameters.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21842
Review URL: https://codereview.chromium.org//794863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42277 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-11 05:21:05 +00:00
f58bf4dbc9
Remove old instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//784623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42267 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 21:53:08 +00:00
ec5cdd5c26
Fix sort order in engine.dart.
...
TBR=scheglov@google.com
Review URL: https://codereview.chromium.org//792093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42256 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 18:22:42 +00:00
c82b826af1
New getter: FieldElement.isEnumConstant (Dart version of source)
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//790103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42249 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 16:20:49 +00:00
8bfeac0ca5
Instrumentation support
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//751063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42179 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:30:19 +00:00
3f91cbb15e
null check for pub result in PubPackageMapProvider
...
BUG=dartbug.com/21814
R=paulberry@google.com
Review URL: https://codereview.chromium.org//750113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42173 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:58:31 +00:00
afe175a4b5
Rename method
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//786653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42156 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-07 16:25:55 +00:00
59f66641c8
Partial fix for issue 1934
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//765923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42155 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-06 01:04:23 +00:00
e15eff9ed2
Fix for issue 3001
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//780403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42154 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-06 01:00:11 +00:00
71bb5315f7
First step to resolving simple API changes.
...
Limitations:
1. Errors are not updated.
2. Classes are not resolved when it might be required.
3. Just method invocations, and just static elements.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//770333003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42153 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 23:48:32 +00:00
7e19f48c13
Fix for issue 4070
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//781133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42143 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 20:09:58 +00:00
a7d32f9212
Consider adding/editing a method as a resolvable mismatch.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//778153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42142 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 19:46:11 +00:00
625b422a82
Fix for issue 4482
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//785573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42136 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 18:12:19 +00:00
a6123dccea
Always build elements, then match and restore if matches.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//779333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42135 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 18:12:07 +00:00
5858d6558e
When the same contents is set for a source, we still need to reset its modification time.
...
Otherwise quick add/remove a character causes non-incremental resolution.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//750953005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42120 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 22:31:02 +00:00
d0ec660798
Add an option for incremental resolution of API breaking changes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//781783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42113 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 17:10:29 +00:00
5278fa209a
Replace hints. Resolve TODO.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//781683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42110 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 16:21:57 +00:00
6b378d5007
Fix for issue 18244
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//772423004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42097 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 00:48:11 +00:00
784058d8a2
Don't throw an exception when model is changed.
...
I don't add much information, just 'return false;' is enough.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//770613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42094 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 23:21:25 +00:00
05e842e503
Rework the whitespace/comment change detection.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//774153006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42093 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 22:48:27 +00:00
3696e4601d
Fix for issue 18598
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//749283007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42091 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 20:07:29 +00:00
c4818d34c4
More work on logging - new classes and timers.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//780643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42090 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 19:47:06 +00:00
scheglov@google.com