890c99238c
Make source be a target
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//882813007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43355 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 17:08:28 +00:00
651ea223ca
Fix to add lints to error report summary.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874253004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43354 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 16:02:06 +00:00
21850bf962
Fix to ensure lint analysis option gets properly set.
...
R=brianwilkerson@google.com , danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//881403005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43298 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:58:13 +00:00
cb6c16922f
Fix for issue 22052
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//881403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
f16e7b8d2e
Add simple Dart tasks
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//887433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43261 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 21:56:42 +00:00
fe471e8f02
Make test context more accurate
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43246 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 17:11:38 +00:00
ea333d8459
Fix mixin resolution order when multiple mixins present.
...
BUG=dartbug.com/22069
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
413de8f419
Support for 'async' in the old formatter.
...
We still use it, and now we have asynchronous code to format :-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//884513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43205 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:00:37 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
7bf029506d
Fix "reanalyze sources" when there are unsaved files.
...
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).
Two other bugs are fixed in the process:
- If a file is analyzed in multiple contexts, then editing it will
cause all affected contexts to be notified of the change. (Note
that this could potentially account for some other strange behaviors
we've seen recently, such as incorrect semantic highlighting and
lingering errors/warnings.)
- If the client supplies a ChangeContentOverlay for a file which
currently has no overlay, the proper error is generated.
I plan to submit tests for these two bugs in a follow-up CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//880643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
2b8c66ea79
Rename ChangeNotice resolved Dart/Html unit fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
0d6228609d
Improvements to task model
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//867563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43146 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:47:12 +00:00
dc144bb870
Issue 22155. Send outline for both parsed and resolved Dart units.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22155
Review URL: https://codereview.chromium.org//876703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43145 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:39:36 +00:00
a3bf271c88
Initial task support
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//812733004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43120 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 20:18:11 +00:00
23215e71f4
Remove Element.users support.
...
R=brianwilkerson@google.com , pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org//854363005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43032 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 00:48:02 +00:00
9184f33ecc
Invalidate parsing information when a file is added.
...
We resolve directives URIs during parse, so if a referenced file was
added after parsing, it may fix some "Unresolved URI" problems.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22101
Review URL: https://codereview.chromium.org//860903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43030 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 23:11:58 +00:00
252c19c920
Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//857283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43028 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:48:00 +00:00
f7915c7a84
Return outline after parse
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//842533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43027 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:36:14 +00:00
e20c2167a3
Linter API updates.
...
(A trimmed down version of: https://codereview.chromium.org//853123002 in a hopes of not unsettling the build.)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//850343006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43023 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 19:38:14 +00:00
fd6cef8a8b
Don't perform incremental resolution if curly brackets are not balanced.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//834383005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43022 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 19:28:12 +00:00
f5f408e412
send priority instrumentation message on startup with version info
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//859513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43017 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 17:30:47 +00:00
3a7594b9fe
Revert "Lint contribution refactoring.", r42967
...
This reverts commit r42967, https://codereview.chromium.org//853123002 .
The change causes an out-of-memory crash in analyzer batch mode, perhaps
a memory leak.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//834323006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42979 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-19 09:26:45 +00:00
9b132e1032
Lint contribution refactoring.
...
A little shuffle to centralize the linter concern (and reduce the need to touch resolver.dart).
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//853123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42967 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 18:29:41 +00:00
ef7456f199
Update cache size on analysis start/stop.
...
This reduces time of dart2js analysis after rename form 16000 ms
to about 1200 ms, i.e. about 13 times ;-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844493005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42933 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 20:55:57 +00:00
807a4fa8fa
Delegating AST Visitor and Linter refactoring.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//813483007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42923 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:09:42 +00:00
dc96eabde3
Display overlays at /overlays URI.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//823123004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42891 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 00:22:44 +00:00
81b8596681
Add indication of instrumentation active/inactive to analysis server status.
...
The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//847963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42879 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:23:22 +00:00
8a495697e6
Move the class TypeTestProvider from the test directory into the lib directory so that other tools can use the class and other tools such as the ElementFactory which require a TypeProvider
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//853553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42855 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 06:59:51 +00:00
036b652dd1
Use all library units for hints during incremental resolution.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//818173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42846 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 23:23:20 +00:00
493f5bbd00
When the file content is the same as the being removed overlay contents, ignore the change.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//845813006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42833 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:02:39 +00:00
20e0b4b556
Match some constructor-based annotations.
...
It doesn't validate argments (we don't have them in annotation, and even if we had,
it is still not cheap to compare nodes with values, but we could remember source
strings, as we do for default parameter values), but it should not cause
invalid resolution, because we resolve incrementally only changes in methods bodies.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//847173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42822 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:13:43 +00:00
f6cbc73ac8
Remove redundant set of ResolvableLibrary.libraryElement.
...
LibraryElementBuilder.buildLibrary2() always sets it, so there's no
reason for the caller to set it as well.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//839463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42798 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 03:08:13 +00:00
1c24293cb1
Reset compilation unit in notification, as it might be damaged.
...
This should fix the navigation computer crash.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//846973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42792 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 23:07:32 +00:00
e07125e634
Report incremental/full analysis performance via instrumentation.
...
R=brianwilkerson@google.com , lukechurch@google.com
BUG=
Review URL: https://codereview.chromium.org//844683003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42784 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 18:28:11 +00:00
3975cf30d0
Issue 22044. A changes in annotations should be considered as a mismatch.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22044
Review URL: https://codereview.chromium.org//832143007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42783 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:52:55 +00:00
e908f30d46
Pluggable lint verifiers first step and basic lint task tests.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//848463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42778 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:44:57 +00:00
3df7d1b1e2
Remove coverage experiment.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//852433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42775 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:18:17 +00:00
83ca7d2f30
Update errors offsets during incremental comment resolution.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42758 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 22:33:08 +00:00
c63e50307a
Instrument file reads
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//825683005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42748 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 18:26:52 +00:00
9fb54ea3db
Capture log messages via instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//840553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42741 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:06:44 +00:00
afc1893fc5
Use Logger instead of InstrumentationService.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//840083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42719 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 22:09:11 +00:00
501d449ecc
File-based and multicast InstrumentationServer implementations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//833633004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42718 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 21:58:41 +00:00
f9172b8c4c
Validate incremental resolutions results if requested.
...
It works by performing incremental resolution, remembering its results and
then pretending that incremental resolution did not happen. Later, after
the full resolution, we compare "full" result with the incremental one.
If there is a problem, it is sent to the instrumentation.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//839913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42710 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 18:57:23 +00:00
11b1c09a10
Remove the Polymer support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//830893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42709 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 18:43:13 +00:00
de7b21ecea
Error code enum fix [TBR].
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//837393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42708 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 18:16:39 +00:00
eb6aac77be
Lint cleanup.
...
Missed an override in tests; incomplete refactoring of severity.
R=paulberry@google.com
Review URL: https://codereview.chromium.org//843583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42706 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:55:19 +00:00
dd306dc9eb
Enable enum and deferred import support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//829133007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42704 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:51:49 +00:00
68f9016c63
Linter analyzer plumbing.
...
R=brianwilkerson@google.com , danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//841813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42701 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:09:10 +00:00
4fe7a9dd3e
Remove Angular support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42697 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 16:04:17 +00:00
54df418597
Enable async support
...
R=danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//842503003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42666 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:51:14 +00:00
brianwilkerson@google.com