dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
danrubel@google.com cb0be1b4cf improve parser recovery when top level function is missing parameters 
BUG=dartbug.com/23044
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1044383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44822 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 20:49:19 +00:00
danrubel@google.com 39598962a0 fix NSM error when completing imported inherited private fields 
BUG=dartbug.com/23036
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44805 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 16:00:31 +00:00
danrubel@google.com 62d8532dc5 Gracefully degrade if no source for completion 
BUG=dartbug.com/22617
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1044463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44796 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 21:43:05 +00:00
brianwilkerson@google.com b396bc4c96 Support refresh of individual analysis roots (issue 22254) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1047733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44791 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 21:07:23 +00:00
danrubel@google.com a8eb426282 add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes 
BUG=dartbug.com/23039
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44787 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 20:12:29 +00:00
scheglov@google.com 028f13011e Issue 23027. Try to make priority files analyzable. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23027

Review URL: https://codereview.chromium.org//1044463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44786 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 19:50:10 +00:00
scheglov@google.com c4729ac121 Issue 22617. Add/remove overlay-only sources to their containing contexts. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22617

Review URL: https://codereview.chromium.org//1042923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44782 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 16:57:33 +00:00
brianwilkerson@google.com 8c298b499e Recognize nested pubspecs (issue 22907) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1042293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44780 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 16:01:03 +00:00
scheglov@google.com 1dc26d9f06 Issue 23018. Fix for inlining multiline strings with leading whitespaces. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23018

Review URL: https://codereview.chromium.org//1042033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44771 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-28 02:31:07 +00:00
danrubel@google.com 8f4ac8f16b improve parser recovery for incomplete prefixed identifier in method/function parameter list 
BUG=dartbug.com/22526
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1033333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44760 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 20:05:18 +00:00
danrubel@google.com 2c188c493f remove invalid completions in method declaration param list 
BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44758 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 19:42:37 +00:00
danrubel@google.com 6312e784a9 only suggest types when completing from a library prefix in parameter list 
BUG=dartbug.com/22526
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1035283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44756 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 19:39:28 +00:00
scheglov@google.com cdff0e1509 Test that the target node is a SimpleIdentifier. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1040733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44741 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 15:48:39 +00:00
scheglov@google.com 2a7227b15d Fix for computing overridden/implemented members from interfaces. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1037193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44737 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 15:16:21 +00:00
danrubel@google.com c897c1a3cd send completion notification even if offset beyond eof 
BUG=dartbug.com/22884
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1035623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44721 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-26 21:03:16 +00:00
danrubel@google.com 9b7edbfc8b fix exceptions when completing other edge cases 
BUG=dartbug.com/22885
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1022703006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44697 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 20:20:00 +00:00
danrubel@google.com 18758d3d22 fix exception when completing between arglist and body 
BUG=dartbug.com/22885
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44687 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 17:27:44 +00:00
danrubel@google.com ac87c46ebd exclude identifier being completed from list of suggestions 
BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1027693007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44683 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 12:46:08 +00:00
scheglov@google.com 8811f05a1d Fix hints in the analysis_server package. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1027273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44638 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-23 17:28:57 +00:00
scheglov@google.com a640643eeb Quick Fixes for unused catch clause/stack. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1020853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44636 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-23 17:10:14 +00:00
scheglov@google.com 85db3fbe62 Report separate UNUSED_CATCH_CLAUSE and UNUSED_CATCH_STACK hints. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1020243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44635 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-23 16:41:20 +00:00
danrubel@google.com 03cac10578 improve parser recovery of type argument list 
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1025903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44626 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-22 18:33:23 +00:00
scheglov@google.com cd1b09f5c3 Simplify rules for extracting getters. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1026503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44607 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-20 18:54:56 +00:00
scheglov@google.com 9f92f24c59 Issue 22851. Append comment tokens after sorted directives. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22851

Review URL: https://codereview.chromium.org//1019993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44591 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-19 20:54:40 +00:00
brianwilkerson@google.com b36c00f15f Temporarily move plugin support 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1027433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44586 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-19 19:06:22 +00:00
scheglov@google.com 39c3a6c255 Issue 22886. Quick fixes create getter' and 'create field' for hints. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22886

Review URL: https://codereview.chromium.org//1024573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44585 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-19 18:16:04 +00:00
scheglov@google.com 7eae9c4902 Fix for NPE in the field creation Quick Fix. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1013303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44542 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-17 20:29:47 +00:00
scheglov@google.com 4cdce46316 Issue 22757. Update self references on package rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757

Review URL: https://codereview.chromium.org//1010803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44524 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 21:28:57 +00:00
scheglov@google.com ca64df1d44 Casted variable declarations for 'if (v is! Type)' should be declared after IfStatement. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1012913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44517 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 19:26:33 +00:00
scheglov@google.com a28e99b719 Issue 22757. Create pubspec.yaml file change on project rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757

Review URL: https://codereview.chromium.org//1015513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44515 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 18:59:16 +00:00
scheglov@google.com b44673fef0 Quick Fix for adding field formal parameters of not initialized final fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1018433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44514 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 18:18:19 +00:00
scheglov@google.com b34d061d1f Issue 22834. Disable 'Add type annotation' Quick Assist if the type is not accessible. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22834

Review URL: https://codereview.chromium.org//1014503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44509 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:26:58 +00:00
scheglov@google.com a9975332ac Issue 22833. Quick Assist to convert for-each into for-index. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22833

Review URL: https://codereview.chromium.org//1012623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44507 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:06:18 +00:00
scheglov@google.com dbf1e4cbe0 Quick Assist for creating a constructor for selected final fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1009833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44504 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:00:28 +00:00
scheglov@google.com 28764d3a93 Quick Fix for creating a missing part file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1013543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44497 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-15 23:39:50 +00:00
scheglov@google.com da0cecb331 Issue 22845. Rename should prevent the use of invalid identifiers. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22845

Review URL: https://codereview.chromium.org//1011613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44495 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-15 19:55:57 +00:00
danrubel@google.com 0a63518267 include library prefix completions given trailing local method invocation 
BUG=dartbug.com/22790
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1008973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44491 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-14 03:09:29 +00:00
danrubel@google.com 31339e3a62 Completion should not show overridden inherited methods 
and centralize checking for duplicate suggestions

BUG=dartbug.com/22396
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1004343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44490 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-14 03:07:12 +00:00
scheglov@google.com 0c21dc284c Add 'containingClassDescription' to HoverInformation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1003193005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 22:05:05 +00:00
danrubel@google.com 5903f0c31c include unimported sdk lib types as low priority suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1000223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44473 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 19:15:46 +00:00
scheglov@google.com b03f3cd6a3 If the file belongs to any analysis root, check whether we're in it now. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1000203003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44445 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 21:46:43 +00:00
danrubel@google.com 676e027663 remove duplicate completion suggestions 
BUG=dartbug.com/22684
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1001143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44444 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 21:40:55 +00:00
danrubel@google.com e867811d28 include constructor arguments in completion suggestions 
BUG=dartbug.com/22364
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1006593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44438 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 18:46:06 +00:00
danrubel@google.com 47128e2603 completions in map literals 
BUG=dartbug.com/22784
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1002713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44432 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 15:24:57 +00:00
danrubel@google.com 8a04710a47 add completion in type argument list 
BUG=dartbug.com/22584
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1005483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44431 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 15:20:08 +00:00
danrubel@google.com fcc0559acd completions for function return type 
BUG=dartbug.com/22686
R=scheglov@google.com

Review URL: https://codereview.chromium.org//999923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44415 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 21:19:57 +00:00
danrubel@google.com fc4de72889 completion for method return type after comment 
BUG=dartbug.com/22686
R=scheglov@google.com

Review URL: https://codereview.chromium.org//996263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44409 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 17:44:25 +00:00
danrubel@google.com 6c1a40377c fix completion target handling of comments 
The intent is to normalize the completion target returned given different comment arrangements.
This is a precursor to the fix for code completions given preceeding comments.

BUG=dartbug.com/22686
R=paulberry@google.com

Review URL: https://codereview.chromium.org//985183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44408 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 17:38:53 +00:00
scheglov@google.com 51870ff901 Quick Fix for using similarly named field/getter/setter instead of undefined. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//991133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44357 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-10 03:09:00 +00:00
scheglov@google.com 2e77fcdd11 Add an optional 'typeParameters' to Element. 
Also use it in Editor, e.g. in Outline.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//990343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-09 22:02:44 +00:00