dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
Konstantin Shcheglov a3a40c9ef6 Issue 11200. Quick Fix for adding required/positional parameters. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200

Review URL: https://codereview.chromium.org//1159273004
 2015-06-01 14:48:50 -07:00
Konstantin Shcheglov be9cd1c165 Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551

Review URL: https://codereview.chromium.org//1151183003
 2015-06-01 14:19:33 -07:00
Konstantin Shcheglov f1d4ef9164 Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'. 
This fixes the corresponding 'Extract Method' issue.

R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23409

Review URL: https://codereview.chromium.org//1161343002
 2015-06-01 12:40:30 -07:00
Konstantin Shcheglov c1c0354014 Issue 23239. Fix for 'Create Class' Quick Fix i case of prefixed names. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23239

Review URL: https://codereview.chromium.org//1161333002
 2015-06-01 12:26:39 -07:00
Konstantin Shcheglov f118546d06 Issue 23332. Don't compute overrides for static members. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23332

Review URL: https://codereview.chromium.org//1151573011
 2015-06-01 10:42:22 -07:00
Konstantin Shcheglov 5b44136f2a Issue 23389. Report error in the renamed element be invisible after rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23389

Review URL: https://codereview.chromium.org//1153253004
 2015-06-01 10:40:59 -07:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519) 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
 2015-06-01 09:39:02 -07:00
danrubel 0e39092fd0 add enum suggestions 
and update LocalDeclarationVisitor to visit enum declarations

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1157113004
 2015-06-01 12:10:46 -04:00
Brian Wilkerson 089038b085 Move index closer to the plugin API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1156493004
 2015-06-01 08:25:40 -07:00
danrubel ecf44e960d remove keyword suggestions in constructor names and prefixed expressions 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1158413003
 2015-05-29 13:28:34 -04:00
Brian Wilkerson ad2b8a43c8 Fix context creation in tests 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1149723004
 2015-05-22 14:25:29 -07:00
Brian Wilkerson ad52c9eab9 Add support for specifying files needing analysis 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1152013002
 2015-05-21 14:34:04 -07:00
Konstantin Shcheglov d5774c5402 Issue 23481. Fix for creating a new class referenced from an inner local function. 
R=paulberry@google.com, brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23481

Review URL: https://codereview.chromium.org//1144893002
 2015-05-19 12:10:50 -07:00
Konstantin Shcheglov 4013b08863 Quick Fix for missing 'part of' directive. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1146573003
 2015-05-18 16:32:23 -07:00
Konstantin Shcheglov 4936eb8d5d Fix for 'Create part' Quick Fix. 
1. NonExistingSource.modificationStamp should return -1.
2. NonExistingSource.fullName should be always an absolute path, not a URI.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1135073004
 2015-05-18 11:55:23 -07:00
Konstantin Shcheglov a8b7d1afe0 Convert two tests to use async/await. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1140373002
 2015-05-18 09:51:09 -07:00
scheglov@google.com d798e3e262 Issue 23477. Fix for Quick Fixes in overlay-only files. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23477

Review URL: https://codereview.chromium.org//1145443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45826 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 20:47:03 +00:00
scheglov@google.com 2c27356c32 Sort imports by package names, then by file paths. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1131523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45822 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 20:00:44 +00:00
scheglov@google.com 7344dcc35c [WEB-16445] When create a missing imported library/part, add the edit once. 
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-16445

Review URL: https://codereview.chromium.org//1147543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45813 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 16:22:01 +00:00
danrubel@google.com ee3263c22c reduce rethrow keyword relevance 
so that return is prioritized over rethrow

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1135243006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45809 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 02:35:23 +00:00
brianwilkerson@google.com 0bf3812043 Fix exception in code completion (issue 23439) 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1138963005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45805 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 00:00:59 +00:00
scheglov@google.com 3ffb42cd22 Sort enum declarations. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1136413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45801 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-14 22:42:16 +00:00
scheglov@google.com 6e25226a0d Issue 23444. Use ConstructorMember(s) for super constructor fixes. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23444

Review URL: https://codereview.chromium.org//1140963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45765 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-13 16:13:09 +00:00
danrubel@google.com a0099fc922 suggest async for closures 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1135613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45711 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-11 19:30:35 +00:00
danrubel@google.com 4e3e55276a suggest keywords for more expressions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1141443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45708 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-11 19:17:44 +00:00
danrubel@google.com d2164273da check for package lib exist before making package suggestions 
BUG=dartbug.com/23428
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1128833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45706 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-11 18:48:15 +00:00
brianwilkerson@google.com 81e474c43e Clean up many generated constructors 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1131423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45676 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-09 19:06:12 +00:00
kevmoo@google.com 9d88c5c476 pkg/analysis_server: don't explicitly import matcher - use exports from unittest 
This will avoid breaks when the test package is checked in
Also remove exec bit from root files

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1138523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45657 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-08 20:57:44 +00:00
danrubel@google.com 4d0cce227d Sort the containing method first in completions following super 
BUG=dartbug.com/22850
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1121773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45539 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-05 21:11:11 +00:00
danrubel@google.com b05fb8ba98 suggest only superclass elements for "super." 
BUG=dartbug.com/23208
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1127643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45535 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-05 19:09:51 +00:00
danrubel@google.com 0ae83bf868 (TBR) fix the build 
BUG=dartbug.com/23073

Review URL: https://codereview.chromium.org//1126703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45512 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 21:49:54 +00:00
danrubel@google.com be90dce1de fix file uri suggestions on Windows 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1120113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45500 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 18:16:46 +00:00
danrubel@google.com 2c96ad2af5 update relevance for named param suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1120023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45499 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 18:13:41 +00:00
danrubel@google.com 6368514b6d improve import suggestion 
BUG=dartbug.com/19941
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1113063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45497 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 18:02:23 +00:00
brianwilkerson@google.com ac3126da13 Fix exception in stack trace from issue 23348 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1113063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45493 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 16:03:58 +00:00
brianwilkerson@google.com ffd27806a1 More source utilities 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1117183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45492 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 15:03:52 +00:00
scheglov@google.com b909e13241 Ignore synthetic tokens when search for AstNode. 
This fixes the exception you saw during 'Extract Local' refactoring.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1117183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45481 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-03 20:29:38 +00:00
danrubel@google.com 2527d6b840 (TBR) fix the build 
BUG=

Review URL: https://codereview.chromium.org//1118313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45468 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 15:50:21 +00:00
danrubel@google.com e2d3e3b09f suggest part file uris 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45467 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 02:29:27 +00:00
danrubel@google.com e6e1182a6d add import file uri suggestions 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1117963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45464 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 01:37:07 +00:00
danrubel@google.com 85e1841e35 suggest keywords for switch statement and expressions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45463 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 01:35:35 +00:00
brianwilkerson@google.com d741aaf58d Add utilities for creating SourceChanges 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1110583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45461 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-30 14:56:55 +00:00
danrubel@google.com af475ead16 restructure internal request to implement CompletionRequest API, 
move performance tracking out of internal completion request,
and add resourceProvider to request

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1115843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45455 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-30 05:09:03 +00:00
scheglov@google.com ed2f434829 Issue 23337. Quick Fix for removing dead code. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23337

Review URL: https://codereview.chromium.org//1116593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45447 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-29 04:52:24 +00:00
brianwilkerson@google.com 0c90300719 Rename two more classes to prepare for the public API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1087483006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45424 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-27 14:14:22 +00:00
danrubel@google.com a7fa3c85c2 suggest async/await 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1103643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45415 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 21:39:57 +00:00
brianwilkerson@google.com ac3613e2bb Re-apply change to move to plugin package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1094083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 18:54:24 +00:00
danrubel@google.com 6237c8909f add dart: and package: import uri suggestions 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 12:51:52 +00:00
scheglov@google.com 0cb3816eea Fix for linked position offsets when insert directly before. 
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1086273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45394 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 04:51:12 +00:00
brianwilkerson@google.com 3d536efcfe Revert breaking change 
Review URL: https://codereview.chromium.org//1101213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-23 22:12:20 +00:00