dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
Sam Rawlins 19e2f03421 NNBD i13n: Fix non-target reasons and add failing test for method return inheritance 
Change-Id: I3cee0c8972f1657abac89b1d9251ccc5e05d070f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121767
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-15 17:56:08 +00:00
Konstantin Shcheglov abecefd1ac Forward compatible portion of CL that does not set types for identifiers that are not expressions. 
The full CL:
https://dart-review.googlesource.com/c/sdk/+/119761

Change-Id: I9c909a4e1eec5d05f5718849ea45da79f01c5291
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121643
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 17:29:07 +00:00
Ari Aye 70a7ef3f58 Implement pointer mixture network 
Here we can see the mixture network is assigning probability mass
to a new, project-specific name by reference https://i.imgur.com/6Zbs2qf.png.

I also took this opportunity to decrease model size targeting 100M, in line
with our original size goals.

My initial strategy was to implement a separate pointer network
in https://dart-review.googlesource.com/c/sdk/+/117005 but having
a single network that can assign probability mass across local
references and vocabulary lexemes is better since

1) only one network and model file
2) no need to coalesce predictions from multiple models

Change-Id: I23cfc2ece61ce30bb69785149a5a6cf1604af18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121461
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-14 18:25:56 +00:00
Konstantin Shcheglov dc0db066e6 Remove ChangeSet from engine.dart 
Change-Id: I289c5edd0c3e52a873013f8c52d8202bf29cf3be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-14 17:45:56 +00:00
Brian Wilkerson b08d7756bd Prevent NPE in code completion when completing inside unnamed extension (issue 38798) 
Change-Id: Ia7041b236bd3f64662b5e0167de7b7343cfcf68a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121147
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-10 21:32:22 +00:00
pq b8943f7056 improve codegen for unscoped and enum diagnostic properties 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: Ie10dcde92e0e054271fe0e965ed810ac3834120b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121160
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-10 20:57:42 +00:00
Sam Rawlins 7b9a26ee6f NNBD i13n: ctor nav targets and details w/o targets 
* NavigationTargets which are ConstructorDeclarations should point to the
  constructor's name or its return type for unnamed constructors.
* Details which don't included useful targets, like "this parameter is
  optional and has no default value", should just have detail descriptions,
  but not be links.

Change-Id: I3562bb708c40aa1fcf1de5df5519f1f4037517cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120761
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-10 05:30:07 +00:00
Ari Aye 4227933c3a Disallow model-only suggestions if static analysis suggests a named argument 
Bug: https://github.com/dart-lang/sdk/issues/38404
Change-Id: I72b505cb5bee1f463c0ec6b0a1e9e60c5b7ea518
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117767
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-09 18:13:48 +00:00
Brian Wilkerson 9ababcf650 Improve message for overriding methods 
Change-Id: I6fed64a852f94f2323972f511be4015a22fb4ebd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120746
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-09 00:12:50 +00:00
Sam Rawlins 8513b169da NNBD i13n: Fix some navigation targets and text 
Change-Id: Iba6befb86453353823c1702405057f83fff64456
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120723
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-08 20:54:08 +00:00
Konstantin Shcheglov a389015083 Rewrite MethodInvocation to FunctionExpressionInvocation when the target is not a method. 
Failing tests for DDC are tracked in the following issue:
https://github.com/dart-lang/sdk/issues/38749

Change-Id: I96e0fe9bc87509b99ba982be4572d4ad4f133cca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120342
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-08 00:22:39 +00:00
Devon Carew 3e3406d20e [sdk] remove the dart:_chrome package 
Change-Id: I5b62984fb7d4cd5dd9ed6f4a02ed91e08ed71e8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120005
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-06 23:50:09 +00:00
pq 69b612beec diagnostic ref fix for fall-through types 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I5fd1328a5ad234e6216631007ecbcc459bfa36e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-04 23:06:12 +00:00
Devon Carew 73d880b949 [analyzer] add a quick fix for the prefer_relative_imports lint 
Change-Id: Ic69ebe799f425fd09e002b65d66a4382f5f96ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120160
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-10-04 20:13:07 +00:00
Brian Wilkerson 9271895f56 Remove an accidentally committed soloTest annotation (TBR) 
Change-Id: If3791de34f0f063a50570b8713c9340821d901d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-04 19:24:06 +00:00
Mike Fairhurst c3053f0eb2 [nnbd_migration] Restrict downcasts; make all type parameters nullable. 
This makes trial_migration.dart report two new exceptions:

_EdgeBuilder&GeneralizingAstVisitor&_AssignmentChecker._checkAssignment (package:nnbd_migration/src/edge_builder.dart:2169:14) (x30)
_EdgeBuilder&GeneralizingAstVisitor&_AssignmentChecker._checkDowncast (package:nnbd_migration/src/edge_builder.dart:2351:14) (x7)

30 & 7 is not great but not terrible. These also do not break path, logging, or
charcode.

Failing tests show why we cannot correctly cover remaining cases without
a larger CL.

Change-Id: I6e510db147f60cc8ee047d45e4ce2d95d26cccc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119533
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-10-04 18:31:48 +00:00
pq 80f683417b when fixing missing diagnostic refs, add debugFillProperties method if undefined 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: If82922a38243e144ad2ec0038d8642c17f458df8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120140
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-04 17:34:15 +00:00
Brian Wilkerson 42a1ba7e14 Improve the messages from the migration tooling 
Change-Id: I8ed53936cf56f154040d53e88190a114a6133555
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120006
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-04 12:43:45 +00:00
pq 0a63bd4b0a diagnostic fix support for colors, iterables, lists, matrices 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I8d7baa32bcea22f2c162bd9d77c7dd0b95b308de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-03 20:05:33 +00:00
pq 512d763b9d diagnostic property types support 
Adds support for:

* ints
* doubles
* enums
* Strings

Up next: Colors, Iterables, Transforms and a catch-all.

Also note the TODO to change how types are being written (will be needed for Iterables).

See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I9d545ce9e090059ae330f9ae5dadf8e7d4b373c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119725
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-03 02:12:39 +00:00
Brian Wilkerson f2816eeb0d Add a test, a TODO, and a minor display enhancement 
Change-Id: Iee53c429839b36426677916f13878b1a3313bef3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119767
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 22:23:41 +00:00
Brian Wilkerson bb342ec83f Fix a test breaking the windows bot 
Change-Id: I8192597a93ceb043585da0dc51f194e99bc2422c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 20:01:40 +00:00
pq 5a174aa2df getter support for fixing missing diagnostic property references 
Change-Id: Iac5523b90f3f753107cf5dc22c3cd211a21ae040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119681
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 18:11:20 +00:00
Brian Wilkerson fee4fe8241 Generate output files for files outside the migrated package 
This allows navigation to work from migrated files, but some navigation
from unmiograted files doesn't work.

This also causes the content of the output directory to be deleted
before generation starts so that old files won't confuse the user.

Change-Id: I0007d811e56b82cb6b91582e3237c7383ae2d060
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 16:31:19 +00:00
Mike Fairhurst 2590d065f1 Update test_reflective_loader, use @SkippedTest 
Change-Id: I17f8da88a4587a7ad51038ca796f138231021fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119583
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-02 00:02:21 +00:00
pq 23aca57eda fix for adding boolean diagnostic property references 
very constrained support for fixing `diagnostic_describe_all_properties` for the boolean field case.

still todo:

* tests for no debugFillProperties method
* tests for getters
* support for ColorProperty -- for Color
* support for EnumProperty -- for any enum class
* support for IntProperty -- int
* support for DoubleProperty -- double
* support for IterableProperty -- any iterable
* support for StringProperty -- string
* support for TransformProperty -- Matrix4
* support for DiagnosticsProperty for any T that doesn't match one of the other cases

(at least)

See: https://github.com/dart-lang/sdk/issues/38633




Change-Id: Ie6875f49914e54d3b4539fcb51a231da688bdf18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119536
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-01 21:34:00 +00:00
Brian Wilkerson 6ec36b786f Generate a file for each compilation unit rather than for each library 
Change-Id: I9a1e812115ba616d0bea57ad6e813c993d1e65d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119539
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-01 21:31:29 +00:00
Brian Wilkerson 431176ea26 Add non-nnbd-specific navigation 
Change-Id: I7b641a89ed935000c54b6f769f50aaf634cdcda8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119531
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-01 20:15:36 +00:00
Ben Hagen 082e82ed5e Remove optional new keyword when extracting widget 
Closes #38655
https://github.com/dart-lang/sdk/pull/38655

GitOrigin-RevId: 63cd3a9cb6ac0efaa3dee38f5ba6443c17f0f7ba
Change-Id: I97aed6ad2dc740d7c7650aec1234873cab2ceac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-01 15:59:45 +00:00
Mike Fairhurst 328addd2cf Skip timing out mac+linux tests. 
This uses, temporarily, a hack to skip the tests. The `skip_` prefix is
not formally recognized, however, it causes it to not be registered as a
test.

After landing this, I will add a @skippedTest annotation to
test_reflective_loader and switch to that.

This doesn't fix the windows dartfix tests, which are structured differently.

Change-Id: Id1bc1dd801c3182381d2c769af52b26f1ea6fa12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119203
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-09-30 15:58:53 +00:00
Danny Tuppeny 34bdcec877 Don't statically register for LSP document changes when dynamic registration is supported 
Change-Id: I672a3207ab0a0f869721f6cce81b2b81c97db4ea
Bug: https://github.com/dart-lang/sdk/issues/38490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119333
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-09-30 14:51:36 +00:00
Danny Tuppeny 82b25f9e47 Use server snapshot for LSP tests 
This matches the non-LSP tests and has a significant performance improvement.

Bug: https://github.com/dart-lang/sdk/issues/38548

Change-Id: I62772c8e8c1bbbec97406b7993844dd5b16c4350
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119330
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-09-30 13:49:59 +00:00
Brian Wilkerson 343723cdff Support navigation targets in migration tooling 
Change-Id: I13ee9ae0d87272248b83c45ee775dd359d830850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-30 13:38:09 +00:00
Konstantin Shcheglov 595022bdea Remove summary1, part 1. 
Change-Id: I557785ac13fa411280ce032324b0305bf25a0a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119170
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-28 14:30:05 +00:00
Sam Rawlins 7bf76c5925 Change i13n output files to live in a directory structure; fixes #38503 
Bug: https://github.com/dart-lang/sdk/issues/38503
Change-Id: I6838a9b07c6a4acdf49839a3992254ec3c9a1ffd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-27 18:26:56 +00:00
Brian Wilkerson 0829212a2a Add a way to map navigation target offsets to the edited content 
Change-Id: Ia5e10cbc1a3510e6764fa67e5e6d47c9f19dbc48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119165
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-27 16:52:24 +00:00
Brian Wilkerson 61b4c0f770 Cleanup hints and lints in analyzer packages 
Change-Id: I7f1a6ad1ed3610da9616683576ebfb5efd543fd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119164
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-27 16:12:44 +00:00
Brian Wilkerson 6eaebb8463 Add navigation targets to the containing unit info 
Change-Id: I5d4707f019254e9b338eae23bb8a9fb61ef14e54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119085
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-27 13:57:13 +00:00
Devon Carew 40cc975932 Increase the severity of the unused_import hint (to a warning). 
Change-Id: Ie65eb7e9c0f48c54a1c537e821c88a5ea8451266
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-09-27 02:10:22 +00:00
Brian Wilkerson 07db94d454 Add support for details and implement some initial details for regions 
Details provide a way for clients to provide navigation support. I'm
imagining that the description could be used as link text.

The deatils are currently more of a data dump than information. I need
to see more migration results in order to figure out when and how to
pare down the data into actionable information.

We might want to capture all of the navigation targets as we build the
info so that we can create anchors in the HTML.

Change-Id: Ie48622ce7d935d3c028ea42e51cfc8da590db149
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118908
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2019-09-26 18:03:40 +00:00
Sam Rawlins 661816ea06 Use Context.separator in nnbd i13n output; Fixes #38574 
Change-Id: If125bc6d8bc9ae66d949c712921b6ce7da428f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118890
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-26 17:24:12 +00:00
Sam Rawlins c49d3c3486 Use a root directory for NNBD i13n output. 
Change-Id: I4ad9d59136010240d56043609ef37edf44ebc4be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118880
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-26 02:46:22 +00:00
Sam Rawlins 034c529cd1 Ignore failing test on Windows. 
Change-Id: I39cdef152e58666f90970097826cd089ca37c5b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118903
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
 2019-09-25 23:54:12 +00:00
pq 5f74cc1e59 test for eof comment completions 
See: https://github.com/dart-lang/sdk/issues/36037

Change-Id: Ib41d9477322092c7003e982980cbfc0923baaf22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118645
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-25 18:29:41 +00:00
pq 7235115f36 statement completion for expression bodies 
See: https://github.com/flutter/flutter-intellij/issues/3253

Change-Id: Ib892833ecfa4500b726f4f6df42f16f0618c994d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118663
Reviewed-by: Steve Messick <messick@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-25 17:56:45 +00:00
pq fdc34003e9 await futures 
Change-Id: Ia168b46feb2f52fa403f083225e7445c0fc9d96c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-25 13:15:18 +00:00
Brian Wilkerson 763421a88e Add a first test of the InfoBuilder 
Change-Id: I0f2f85d31696290b8b46892289e4c1cebf0e042f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2019-09-25 01:44:27 +00:00
Sam Rawlins 87a369f1d2 Add syntax highlighting to instrumentation_renderer 
In this change, we also push HTML escaping to mustache.

Changes can be seen in x20 pages emailed to the team.

Change-Id: I239668a0844fb5bd7c90848f25a3cbf29e50363d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-23 18:51:55 +00:00
pq 7367b6f192 fix for MISSING_CONST_FINAL_VAR_OR_TYPE 
Change-Id: Ic332128c5981d0a120f169c948bf794d57f3c709
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118202
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-20 01:26:44 +00:00
Sam Rawlins 97346ff476 Initial migration i13n HTML output 
Change-Id: If614fa0719d8ffdaa7a41cca6d0df249772c2437
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117928
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-09-19 22:56:44 +00:00