535cbf5db9
NNBD preview: Text for return type with nullable return type in subclass
...
Change-Id: Ia829b3f8cb7f09b10180478394608a05cdcdbb6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125984
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-11-21 21:07:25 +00:00
8342ec2c71
Fix pub.dev URLs throughout SDK repo
...
Change-Id: I5bcb7c40be12ee1dc887620281b4807469d67bbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125729
Auto-Submit: Kevin Moore <kevmoo@google.com >
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Michael Thomsen <mit@google.com >
2019-11-20 11:30:48 +00:00
c0144141ce
Move TestPluginManager, MockServerChannel, and ServerError into utilities
...
There's no reason these classes need to be in test, and I want to
re-use them in a tool for testing NNBD migrations.
Change-Id: I43686a44d5f8d83f0d1cc23315746250eb766681
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125485
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-18 22:26:00 +00:00
bc449f160b
Fix for dartbug.com/39401 -- quick fix improvement around angular generated files
...
Change-Id: I363b8f14363a53f01fd170e36752a3f0a9ec8e48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125412
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-18 20:58:35 +00:00
ed971fd0c7
NNBD migrator: Add Locations for each edit made in an NN fix
...
Change-Id: I53342cb43910deea2f59f37d5795ddbb70cb6b0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125480
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-18 20:40:25 +00:00
e34e734b56
[nnbd_migration] track causations for substitution nodes
...
Change-Id: I7da4f2923d9b99b0bd6c16644a7adeaeda437340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125463
Reviewed-by: Paul Berry <paulberry@google.com >
2019-11-18 18:49:39 +00:00
7905e78db2
NNBD preview: Better messaging for non-late uninitialized variable
...
Change-Id: Ica0433154f0f72d6f79159a77e0b784bdb1d6f40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-11-18 18:28:23 +00:00
f69935b107
Migration: stop creating union edges for inferred types.
...
Fixes #38341 .
Change-Id: I77e6bebc28ca917a13e5fd9958f5a7b3e0284834
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-11-18 17:14:23 +00:00
8fbb053092
Issue 39021. Guard against invalid generic type alias, without function type.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39021
Change-Id: I0259ef04f95e1935ca273b5540aafb069c7ad455
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125526
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-18 16:06:53 +00:00
fe3fadbdba
Issue 39025. ForEachPartsWithIdentifier does not define anything, don't pretend that it is a LocalVariableElement.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39025
Change-Id: Ieda56c73a1928434a29aa947c44fc29b66a79464
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-18 15:44:13 +00:00
3a17bebf9c
Issue 39028. Guard against mixin constructor in FieldFormalParameter completion.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39028
Change-Id: I78e4df6baa8424231aeb2c8044d9cb5c685dcdbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-18 15:36:48 +00:00
f3ee4d0fe5
Add a failing test case for http://dartbug.com/39401 -- quick fix improvement around angular generated files
...
Change-Id: I784baefaa41db4e45c183335b73e7bb33991070a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-11-15 22:30:16 +00:00
15e5c23167
nnbd preview tool: Better text when inserting 'required'
...
Helps with #39247
Change-Id: I3bb7b25c73d58fc49260d6e3019b58b2f3f6b80a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125440
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-11-15 22:20:16 +00:00
a6635d006b
[nnbd_migration] Show "exact nullability" in output directory.
...
Change-Id: I29545fe358282aa05dee10ed7ff5e86ea899581e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125222
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-11-15 18:27:24 +00:00
faa4eb7808
Partial support for an incremental workflow
...
Change-Id: Ibc18be75d5b4aada7c27cdfae559bd829bd50215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125421
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-15 17:01:45 +00:00
70892fff0c
nnbd preview tool: text for uninitialized field
...
Change-Id: Ie77c381c5e1f80e3efcf861d2cea15850fc9af54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125304
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-11-15 04:05:05 +00:00
812c8d830f
[analysis_server] remove unused class WatchManager
...
Change-Id: I3b0a4723447e4988611a09c6456b470931b0996f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125300
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-14 21:51:29 +00:00
06aef10d76
nnbd preview: Remove descriptionPrefix; don't link Details which will link to some bizarre Never node
...
Bug: https://github.com/dart-lang/sdk/issues/39247
Change-Id: I6f34ecf745e8db75534affdeadc3d47acac079b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125062
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-14 01:09:35 +00:00
8452d2d188
Migration: change behavior of dynamic.
...
Previously, when the migration engine found a type that was implicitly
or explicitly dynamic, it assumed the type was meant to be nullable.
This seemed reasonable (since, after migration, `dynamic` indeed
allows null), but it caused unnecessary nullabilities to be
propagated. With this change, the migration engine tracks whether
dynamic types can be nullable or not, just as it does for all other
types. This cleans up a number of tricky corner cases in the
migration engine that were getting in the way of fixing up uses of
`always` and `never` nodes.
Note that if a `dynamic` type is determined to be non-nullable, it
will still be `dynamic` after migration; this change merely prevents
nullabilities from being needlessly propagated from that dynamic type
to other types.
Note that we still assume `dynamic` is nullable when it occurs in an
already-migrated library or as the result of a dynamic dispatch.
Change-Id: I380d0907f3489d0b84f3fdd7164113daae24274e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2019-11-13 23:10:15 +00:00
30690b1526
Issue 39357. Catch FormatError and report FLUTTER_SET_WIDGET_PROPERTY_VALUE_INVALID_EXPRESSION.
...
Bug: https://github.com/dart-lang/sdk/issues/39357
Change-Id: Ia0d5eb7907dbe16ad03dd70a4f3ede226c2edaaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125129
Reviewed-by: Jacob Richman <jacobr@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-13 22:41:55 +00:00
bc4ced0738
Fix the list of migrated files to not include non-migrated files
...
Change-Id: I87010a5f1e318ef074791fd706d3d6a32262a0bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125142
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-13 20:31:44 +00:00
39194779c1
nnbd preview tool: Add better text for dynamic values
...
Change-Id: I926970d765a9cfb9b2d96f8180e8388516d8ebfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-11-13 18:36:00 +00:00
12265c4e42
Hacky prototype of how to fix the seventh item from #39247
...
The issue is:
lib/src/logger.html, line 107, inserted !:
In this case the single reason detail reads "node with no info (type(2171))" with no destination.
The problem is that InstrumentationInformation.nodeInfoFor is only
considering a limited set of possible sources of nullability nodes
(the primary nodes of decorated types passed to the instrumentation
listener methods `implicitReturnType`, `implicitType`, and
`implicitTypeArguments`). It needs to also consider decorated types
passed to `explicitTypeNullability`, `externalDecoratedType`, and
`externalDecoratedTypeParameterBound`, and it needs to walk these
decorated types recursively to discover all the nodes they point to.
Additionally, the logic in InstrumentationInformation.nodeInfoFor is
inefficient; it walks through all the implicit types in every source
file, which means that it is O(N) in the size of the code being
migrated. Since it is called O(N) times, this is an overall runtime
complexity of O(N^2).
I've prototyped a possible fix using an expando to compute
NodeInformation for each node once at the time it's reported to
instrumentation. This is incomplete and intended as a starting point
for discussion. Work that still needs to be done:
- We don't produce a sensible description string for nullability nodes
associated with AST nodes, so we present unhelpful text to the user
like "A nullable value can't be used as the explicit type ???"; it
would be nicer to say something like "A nullable value can't be used
as positional argument 0 of Level.>=". We may want to consider
modifying the instrumentation API to make it easier to generate a
useful string here.
- I haven't verified that the description string we produce for
external decorated types is helpful.
- I haven't verified that the we produce a useful link for external
decorated types.
- We should probably get rid of the data structure
NodeInformation.explicitTypeNullability (which has similar
inefficiencies) and change over code that was using it to use the
new approach.
Change-Id: I2cf2fe47cd70d7e5cc6e3da309851288668e8a62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124902
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-12 22:18:01 +00:00
942419e6ba
[analysis_server] Funnel sendServerErrorNotification through logException
...
Change-Id: I266a8b3c404da8c9892aa6e1a49e1f1c9bdcf530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-11-12 21:45:24 +00:00
26cabb72c3
[analyzer] Add [SilentException] where previously not reported to users.
...
New errors *not* changed to silent exceptions:
https://dart-review.googlesource.com/c/sdk/+/123328/9/pkg/analyzer/lib/src/dart/sdk/sdk.dart
https://dart-review.googlesource.com/c/sdk/+/123328/9/pkg/analysis_server/lib/src/analysis_server_abstract.dart
These seem worth keeping.
Change-Id: I534b07f6cf50c5b251867b647ed6df96a9134c56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-11-12 21:37:49 +00:00
667f77ed60
Add an http server for the interactive preview mode
...
Change-Id: I727cc2b3d393b426f09a06e7b89c115864581962
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124760
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2019-11-12 17:39:22 +00:00
e3e0ef8548
Make explanations for unchanged types optional and disabled by default
...
Change-Id: I653f5ed1807cef7b444e014d8629bc8ef772f6f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124588
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-08 20:20:48 +00:00
cb0e5c5a3e
Set operator== parameter type to dynamic if directly from Object.
...
See https://github.com/dart-lang/language/issues/569
See https://github.com/dart-lang/sdk/issues/38339
Change-Id: I8d42135985aa4d55ffcc65cdf849572736cb9198
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124284
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-07 20:07:29 +00:00
5bae0f23cf
Increase completion model token lookback to 100
...
In moving to a pointer mixture network from a traditional language
model I had initially decreased model lookback to 50 tokens to
facilitate faster model training iteration. Now that we've landed
on a configuration that works well, increasing lookback to 100 tokens
improves accuracy further.
I also went ahead and followed a recommendation from Jacob to
oversample Flutter sources since they're greatly underrrepresented
in our training corpus compared to our users' code at prediction time.
Change-Id: I885ddb606270394198f3aca2554e381f4465bdae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-11-04 18:00:16 +00:00
924ec34e01
Remove analysis logger, replace with calls to InstrumentationService
...
Change-Id: Ifddd58b731aa0af8f76a91261757997dc52a9fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123328
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-31 21:26:44 +00:00
84a8a2db33
Issue 39192. Fix codeLength / codeOffset, store it into the cached data.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39192
Change-Id: I17fe30839dd8a51c047103e028eea145ced1ec87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123689
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-31 20:03:58 +00:00
fde7cbf293
support type params in stateful widget conversion
...
Open question:
Should we generate:
`class _MyWidgetState<T> extends State<MyWidget<T>>` ?
Fixes: https://github.com/flutter/flutter-intellij/issues/4033
Change-Id: Ieffbb56d84a645f84661b2160eda14957c1539f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123507
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-10-30 23:13:55 +00:00
c0163f15a5
Add an optional port to the dartfix request to allow changes to be previewed
...
Change-Id: I6f7a8f880883195fd6558f5533f82da416c777bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-10-29 17:16:34 +00:00
a3ca5c3c54
[analysis_server] remove session id from connected params
...
Change-Id: I313d3f0b0c5df2148a3cbceddd4db54fecdc74a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122082
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-10-25 23:14:53 +00:00
5edeee8907
Transform hexadecimal numbers coming into model to <num> like we do for decimal numbers
...
Not hugely important since hexadecimal usage is very low in Dart in general, but
this is consistent with the transformation we apply at training time.
Change-Id: I45875fd46cd172374acba14251a8d86264339c47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-10-24 21:45:07 +00:00
f2e2b3257b
Fix code completion performance regression introduced by pointer mixture network
...
Latency had grown to over 100ms and after this change we're consistently
under 100ms https://i.imgur.com/CCo0iQa.png . In addition, I was able to reduce
the number of isolates to two from four, lowering the memory footprint of model.
The biggest change is that we're moving from taking a map of size |V| = 100k
like {"foo" => 0.2, "bar" => 0.3} and sorting it to find the top n completions
to simply filtering / selecting lexemes with probability greater than a min
threshold (set for now to be a percent of a percent, 0.0001).
Change-Id: I721e6de343add6b8ebcf3ef4fad20f136302808e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122842
Commit-Queue: Ari Aye <ariaye@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-24 20:31:52 +00:00
bc5fb05def
NNBD i13n: Highlight non-nullable types with upstream triggered edges
...
Change-Id: I10fc2f731381ab60f0f724b2d463533895348500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122405
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-10-22 20:06:06 +00:00
cb9eefca4f
Issue 142793249. Never remove directive with unresolved URIs.
...
Bug: https://buganizer.corp.google.com/issues/142793249
Change-Id: I5ced1bcf4cb5d634f8e11555bb464f10c4bac68c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121926
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-18 17:06:50 +00:00
8a92058226
Support omitted name args; fix as-expressions, refactor tests
...
Fixes #38919
Change-Id: Ia302e7d56aa20ebd1d9b7afa8ceda249ba31015b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122021
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-10-17 20:19:46 +00:00
1c2dc77f64
Issue 38947. Support for then/else widgets in ConditionalExpression.
...
Bug: https://github.com/dart-lang/sdk/issues/38947
Change-Id: Iec498eb9368d1090e8ba9e2221d00205df1ac746
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121925
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-17 17:49:16 +00:00
680a880c10
Move string utils from services/correction to utilities; more generally used
...
Change-Id: Idb81b54fe380e6af00af5ddee3977705ff58c741
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121912
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-10-17 15:04:00 +00:00
8e7fa2a35b
NNBD i13n: Proper messages for nullable values in collection literals
...
Change-Id: I5eccfeb7d88f3f4adb57f3734f170dce82c1fd2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121906
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-17 03:41:11 +00:00
3e992eb8fe
NNBD i13n: Add line numbers to a few messages
...
fixes #38920
Change-Id: I6656a2e47901cbe66ccbd040d3d2fe6913f7031a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121867
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-16 22:52:01 +00:00
f1657ab934
NNBD i13n: Handle returned values in deeper expressions
...
Change-Id: I109ce111f0e0eb9c2b172c9f86aa4e3cbda482c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121769
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-16 00:41:22 +00:00
2e6695f6f9
NNBD i13n: Add line numbers
...
Change-Id: Ifd81b3e99a3e8c0a1b1a0b6dbe29ad545f6e50f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121779
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-10-15 23:48:32 +00:00
cfe25c7e95
NNBD i13n: Sort navigation links
...
Change-Id: I32d21b26f3c813907308e9768a01a4cb9d45d1fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121768
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-15 22:37:08 +00:00
e642af52a5
Fix behavior of ML query construction
...
This is one of the rare cases where the comment was correct
and the code was wrong. If we've typed class FooB^ then the
query should be ['class'] whereas typing void main(^ should
result in the query ['void', 'main', '('].
Change-Id: I5f53fa70c1ddfd1803e5697cdaaaf7d3b73f5ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121778
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-10-15 22:33:25 +00:00
c5498891fc
Don't suggest class member completions for ExtensionOverride targets.
...
Change-Id: Ic3e2ef31cc42ccf4d16688050b894a50e5a8f51e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121765
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-15 20:58:29 +00:00
5300ce4a2d
ADD_DIAGNOSTIC_PROPERTY_REFERENCE assist
...
Change-Id: I0acd3254eb309e95cce211612d6c1a11db5789bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121800
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-10-15 19:54:59 +00:00
3e497dd00a
diagnostic function field support
...
See: https://github.com/dart-lang/sdk/issues/38633
Follow-up from: https://github.com/flutter/flutter/pull/42447#discussion_r335025065
Change-Id: Idd3cbc4b3419e792d6b81e02bd556b35faaef8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121770
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-10-15 19:06:19 +00:00
Sam Rawlins
