dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
Mike Fairhurst 3ae91fc8c5 [nnbd_migration] Add an edge origin for return; 
Change-Id: I94e56933c4fb8d8c8b80ca0c427fc34c56674d04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137841
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-28 23:26:22 +00:00
Mike Fairhurst 1d1f3a5049 [nnbd_migration] Origin for inferred instance creation bounds 
Change-Id: Ice51e241833e4eb70f7b41accc3908717ca8bd72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137659
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-28 23:26:22 +00:00
Mike Fairhurst e9df1ee07a [nnbd_migration] Add an edge origin for inferred parameter substitution 
Change-Id: I37ce933e05a6b7ad7b8fdcc26f44968ae92516be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137658
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-28 23:26:22 +00:00
Mike Fairhurst 42d0c8245d [nnbd_migration] Add edge origin for explicit instantiation params 
Change-Id: I9feebb693d8e97027019b5ff2e936ce0fd69bd3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137655
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-28 23:26:22 +00:00
Mike Fairhurst 18814410a4 [nnbd_migration] Record edge origin for explicit call parameters 
Change-Id: I33ccf611d1998478c84c4b3e0576ab2e3db906bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137651
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-28 23:26:22 +00:00
Mike Fairhurst c0bcfb7d0c [nnbd_migration] Add a description for type parameter instantiation 
Change-Id: Id8e3c4c98f3569b794e90d8a7a74d245f6f89504
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137648
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-28 23:26:22 +00:00
Konstantin Shcheglov 34fcc56458 Fix for renaming named formal parameters from invocations, when synthetic. 
R=brianwilkerson@google.com

Change-Id: I4dc57cfc2a941229f2ba8b8b262ed49ecdd6b170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 23:11:00 +00:00
Konstantin Shcheglov f1e60ccf03 Fix REMOVE_UNUSED_ELEMENT crash when not the only variable. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I5201d957f59aa9f81478ab51db5870ec57ad6868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137845
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-28 21:54:40 +00:00
Konstantin Shcheglov 3852fe2d79 Fix for cast exception in LintNames.empty_catches fix. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I965ec72d98f3bc3edb9d04c7d1d254603e2e3f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 20:24:00 +00:00
Brian Wilkerson b46f993f84 Add a fix for non-type-in-catch-clause (issue 40778) 
Change-Id: Iebbdf639c76f6cdd061c94673319c2f6c89aec76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137423
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 23:33:27 +00:00
Konstantin Shcheglov c9884ccf52 Analyze SDK with non-nullable experiment enabled, update MockSdk. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/134401
Reverted: https://dart-review.googlesource.com/c/sdk/+/134802

Internal presubmit is green.
https://test.corp.google.com/ui#id=OCL:294345942:BASE:297377939:1582738004318:fb4ae9fe

Change-Id: I25e6445bd0241a89850dff3d88ece0edd768053a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 21:08:21 +00:00
pq 7eaafa01cc linter 0.1.111+1 
Change-Id: I9e311527a41f65b888c4208615158715e3ff6dbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137321
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-26 20:34:31 +00:00
Konstantin Shcheglov 5940821f4e Issue 37487. Add CompilationUnit.languageVersion override. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/136802
Reverted: https://dart-review.googlesource.com/c/sdk/+/136851

Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: Ida3bf049840e7bda32ecdd54309ea0b141aa6800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 18:08:07 +00:00
Brian Wilkerson a7167dd307 Fix the placement of modifier in add-static fix 
Change-Id: Ic4fa82c739e2157e1d5cee935f8ff821d95a2857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137251
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-26 17:39:17 +00:00
Konstantin Shcheglov ddd0e5d598 Update String.splitMapJoin() in MockSdk to the style in unforked SDK, fail a test. 
R=brianwilkerson@google.com

Change-Id: I3ece2a7aec27500eaff30bd40249b37977f78dcc
Bug: https://github.com/dart-lang/sdk/issues/40578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136856
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-25 20:45:29 +00:00
Paul Berry b0b06bff31 Revert "Issue 37487. Add CompilationUnit.languageVersion override." 
Reason for revert: it was a breaking change to the analyzer public API.

There were two breakages:

- A @required `languageVersion` parameter was added to
  AstFactory.compilationUnit, which is part of the officially
  supported analyzer public API.

- A @required `languageVersion` parameter was added to the Parser
  constructor, which is not part of the officially supported analyzer
  public API, but is part of its de facto public API due to the fact
  that it is used by dart_style.

This reverts commit ce26dfda7d.

Change-Id: I507103ea6f6ffabf915d6f56e9f24454725c3930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136851
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-02-25 04:39:10 +00:00
Brian Wilkerson ed40a9d77e Add a fix to remove dead null-aware operators 
Change-Id: I4573eb87b1e454923655b2b7010ab84f4698ce79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136922
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-23 21:27:54 +00:00
Konstantin Shcheglov f8f4b5ddd7 Transition DAS to analysis / idle when setAnalysisRoots with no Dart files. 
Bug: https://github.com/dart-lang/sdk/issues/40096
Change-Id: I84b83d374e325f1c3c90be30c5c33ed6007b8849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-23 21:04:47 +00:00
Konstantin Shcheglov ce26dfda7d Issue 37487. Add CompilationUnit.languageVersion override. 
Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: I57fbcdd6771d9004ba1fc43902c19514dab2a23d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 20:19:43 +00:00
Paul Berry 7911b6a989 Migration: fix handling of part files. 
This CL fixes several minor bugs:

- In info_builder.dart, we were trying to apply SourceInformation from
  the defining library to all its parts.

- In NnbdMigrationTestBase, we were trying to fully migrate each file
  before processing any other files.  We need to prepare each input,
  then process each input, then finalize each input.

- In NodeBuilder, we were failing to send part file sources to
  NullabilityGraph.migrating().  As a result, methods declared in part
  files were being treated as already migrated, so they were getting
  the wrong kinds of nullability nodes.

- In _ProvisionalApiTestBase, we were sometimes visiting parts before
  discovering what libraries they were part of, causing inconsistent
  resolution results.

I'm hoping this will be sufficient to address
https://github.com/dart-lang/sdk/issues/40670.

Change-Id: I07d693b31b6cf64bc6f72126f5ef4792b29e5029
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136521
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-02-20 19:55:18 +00:00
pq 6da009031c add static fields and getters to available suggestions 
Fixes: https://github.com/dart-lang/sdk/issues/40699

Change-Id: Id60307de949395c2274cb35ac4d14521b301437d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-20 03:24:35 +00:00
pq fb840da85f update test expectations for changes in available declarations 
Updated to keep up with changes to available declarations.

Change-Id: I80405f396e4946ebae93bc9501a68855d45dd3fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136540
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-19 23:37:35 +00:00
Brian Wilkerson 8517b53e26 Fix bug in create-method quick fix that omitted required parameter names 
Change-Id: Ic9e15703d4f50ea237046ca72ef12692d610c55e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136407
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-19 21:43:07 +00:00
pq 34cdc8112e getter/setter suggestion tests 
See: https://github.com/dart-lang/sdk/issues/40689

Change-Id: I87837592d4af458583b1710190beee4672ae4cfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136408
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-19 21:19:45 +00:00
Paul Berry d81549e2b2 Migration: fix offset handling when there are deletions. 
Since deleted code is shown in red in the preview tool (rather than
being deleted), we should only look at insertions when computing the
offsets for applying navigation links to the preview text.

Fixes a bug wherein a large block of deleted text near the top of a
file would cause a crash due to a bogus negative offset.

Change-Id: I704b2cecaf4b93eeb91f16d9bd5890ad3e3080e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136403
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-02-19 20:33:44 +00:00
pq 75fff78f68 suggest mixins test 
Change-Id: I01ee6a020342424fccba3f3f0fbdf5b7d8ffd626
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135967
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-14 20:18:17 +00:00
pq a2c65a6ef1 tests for known ranking issues 
Change-Id: Ia8fbd127ee95a02f0fb21678353e77f08b01d0a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-14 19:28:42 +00:00
pq f83770e1fe add available suggestions for getters/setters 
Fixes: https://github.com/dart-lang/sdk/issues/40626

Change-Id: I765928864c719a4c7202f9bdc768c7a6e4d8e850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135789
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-14 17:42:39 +00:00
Danny Tuppeny 3b4e9f6db0 Fix LSP workspace symbols to always have a SymbolKind 
Bug: https://github.com/dart-lang/sdk/issues/40636
Change-Id: I28855dac790291a16717c20cf46c33dfae23e9ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-02-14 16:45:27 +00:00
pq 9e2d9ecd92 tests for missing getter/setter available suggestions 
See: https://github.com/dart-lang/sdk/issues/40626

Change-Id: I3e35b5d7bf849c1afd20b5bd512b7e8b201e2200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135783
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-13 22:46:39 +00:00
pq 867d6537df enum constant and named cons test cases 
Verifies that our client algorithm addresses issues seen in IntelliJ (https://github.com/dart-lang/sdk/issues/40620) and worked around in VSCode (https://github.com/Dart-Code/Dart-Code/commit/ea7443dab3378a7a86b3bbe40db6843ab1d05ffd)

Change-Id: I2029d89559625ff666c947186d90484794f6b38b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-13 21:24:48 +00:00
Brian Wilkerson b03ef5b3fe Convert more doc comments in analysis_server 
Change-Id: I333d0af4444226a8152e840c4d9015fb4c30bd32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-13 19:29:28 +00:00
pq d42b7bc15a partition imported/not-imported suggestion sets / de-dup 
Change-Id: Iba72b3599e9153e9fac3dd883d7bdb272c25fa65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-13 15:57:28 +00:00
Brian Wilkerson 16033f922d Enable prefer_contains in analysis_server 
Change-Id: Idac9828eb452f685452a33e6946ece2ba0d197f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-13 14:52:08 +00:00
pq a0323c755f convert test path (for windows) 
Change-Id: I8abb8605d1161147ae6bbcdb2139767b2ad020a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135621
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-13 13:53:48 +00:00
Konstantin Shcheglov 5c332bea91 Stop using 'factory something() => null;' in most cases. 
I did not change MockSdk, to avoid conflict with
https://dart-review.googlesource.com/c/sdk/+/135241

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40603
Change-Id: I9f0af20f5914b5ac1aefee02aa8052db269529b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135532
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-12 22:58:57 +00:00
pq afaeb04137 sanity check project files for errors 
Change-Id: Ie530f0aec435440abbcf4a1feb34ee7cb53ebab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-12 21:12:37 +00:00
pq 5fd18be9c5 track analysis errors 
Adds analysis error tracking and fixes the enum declaration to not produce a warning.

I'm not happy with `assertNoAnalysisErrors` and would like something more configurable and context-aware but haven't thought it fully through.

Maybe something like:

```
assertNoErrors(
  except: ['unused_import'],
);
```

(And maybe a file and line number?)

Alternatively, we could add ignores to the test sources:

```
import 'a.dart'; // ignore: unused_import
```

and maybe special case the line we're completing on:

```
f(^);
```


Still mulling it all over but your thoughts are welcome!


Change-Id: I1d0c5fbd72c80dde13ae98cb76c3728ab00a12f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135440
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-12 15:42:57 +00:00
Devon Carew 0299903f3e [nnbd preview] restore navigation in the code editor 
Change-Id: I4f3678c8edc5ce606d727ce964806689bcf4a38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135383
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-12 01:12:05 +00:00
pq 42e840c6ae convert all paths 
Change-Id: I6d32fd26e9959ad4b880e90a9ca61504d4e9be0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135345
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-11 19:24:44 +00:00
pq b9fbf58e33 filtering on kinds; relevance boosting 
Change-Id: I4eaacd5da1b5435b116fdff7c1615e265d5ba96e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135321
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-11 18:42:54 +00:00
pq 30151a6541 wait for SDK suggestions 
Change-Id: I7439daff3bf828406520a5a3c061928695258c84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135240
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-11 04:30:31 +00:00
Konstantin Shcheglov abf7d1fc08 Issue 40572. Pass Packages to AnalysisDriver. 
Just as SourceFactory is given to AnalysisDriver, so should be Packages.
Understanding --packages and discovery in out of scope.

Bug: https://github.com/dart-lang/sdk/issues/40572
Change-Id: Id120fba0f23a4423797fa9976c4cda5ed54dad53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135188
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-11 00:57:45 +00:00
pq 5457012b81 driver test suggestion support 
Still some simplifying assumptions but on the path to correct.

Change-Id: I3f0d86fc3152ce3333b9d615ac700b703aa3b071
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135205
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-10 23:40:05 +00:00
pq 10f2b8fc76 migrate path specification to driver clients 
(Hard-wired paths are making tests harder to write.)

Change-Id: Ifb996e78c18cc8249b9ee0f18e6db52097778d47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-02-10 19:06:25 +00:00
pq 3d97d22fe5 completion driver suggestions 
The absolute minimum to see suggestions wired through.

Lots of work to flesh out the client-implemented algorithms.

For reference:

* https://github.com/Dart-Code/Dart-Code/blob/master/src/extension/providers/dart_completion_item_provider.ts
* https://github.com/JetBrains/intellij-plugins/blob/master/Dart/src/com/jetbrains/lang/dart/ide/completion/DartServerCompletionContributor.java

Change-Id: Idc78fca787b095e5b6236481b89ddb21c0ed9c94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134877
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-10 17:07:29 +00:00
Brian Wilkerson c6b0ee3931 Convert the remaining fix tests using a lint marker and remove the ability to use a marker 
Several of the tests were testing conditions that cannot occur and hence
were either re-written or removed. There's one test that I couldn't get
working so I marked it as failing. I marked another test as failing
rather than remove it because I think we want to update the lint to
catch that case (it's failing because no lint is produced).

Change-Id: I852c3c4595b0993ce2a64cbd9da1b6c7339dd59b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-07 20:22:26 +00:00
Sam Rawlins af7b5fa4c6 NNBD preview: Nav tree hrefs should always use forward slashes 
Change-Id: I64cfb42f8623649707b153fbefa3a6cccf343a5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134788
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-02-07 00:21:34 +00:00
pq f0df6039bf extended member completions in extensions 
See: https://github.com/dart-lang/sdk/issues/39093

Change-Id: I1848be7f9da0e9f424bcfe3c2dd7e50c194e5f0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134784
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-06 23:31:54 +00:00
Konstantin Shcheglov 1f47e5b23d Revert "Analyze SDK with non-nullable experiment enabled, update MockSdk." 
This reverts commit 545b80ef0e.

Reason for revert: this is a breaking change for MockSdk users, actually much more serious issue for un-forking SDK. https://github.com/dart-lang/sdk/issues/40500

Original change's description:
> Analyze SDK with non-nullable experiment enabled, update MockSdk.
> 
> Change-Id: I80264a6533045c33ed794a5938f6719f3b5a6d0b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134401
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: If8c3d8322986b01012fa76f9c928f35309c00e3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-06 22:55:29 +00:00