dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
Mike Fairhurst 23b636ae29 [nnbd_migration] Add three new offset mappers: insert, sequence, rebase 
Change-Id: I5c11a98acf54735c21e7bf399ef099f371ebdb39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143281
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-14 21:05:25 +00:00
Danny Tuppeny fad05e89dc Require exact type matches for equality in LSP classes 
Change-Id: Ia3f502a315e2c6fbc62eb6fbe3785dad86c782cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142992
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-14 15:47:01 +00:00
Danny Tuppeny 2fbe4d9194 Resolve type aliases when generating LSP equals methods 
Change-Id: Iccecfa8dc8d77cb0d4358db1f7fa54607ffaa428
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142991
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-14 15:47:01 +00:00
pq 7fe16ba812 sort_directives quick fix 
Fixes: https://github.com/dart-lang/sdk/issues/41464

Change-Id: I9c5804ef8ec872b8420feba3d9a0f0da5fb757d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143303
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-14 00:45:18 +00:00
Brian Wilkerson b68334052a Support macro expansion of Dartdoc in code completion 
Change-Id: Idbde9584da82606949cce79849088c6432d0602a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-13 21:37:09 +00:00
Sam Rawlins e1822e9626 Migrator: Add new fix kinds: replaceVar, addType 
Fixes #41410

Change-Id: I127d309e84423c24eb2563063af433187b9bf057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143222
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-13 20:11:32 +00:00
Konstantin Shcheglov 115fb42a01 Fix warnings in nnbd_migration. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I56fd93eec4a300ed869c0208e2b1544d18fa183b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:35:56 +00:00
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type 
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 03:42:35 +00:00
Paul Berry 3a8cfa3547 Migration: don't generate traces for casts that don't involve nullability. 
Change-Id: I9dca37cb5542d27485b28a012d32eb0e05f45044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143016
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-10 23:32:03 +00:00
Mike Fairhurst 254d115a80 Fix analyzer windows bot 
Change-Id: Ic95b3121461765622fd577409faa8163d7740c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142660
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2020-04-09 17:33:09 +00:00
Paul Berry 0923668147 Migration: remove preview section "edit rationale" 
Also remove the code to generate it, and associated tests.  This
feature is no longer useful now that we have the "stacktrace" view,
and there's a considerable amount of complex logic backing it that's
interfering with other work I'm trying to do.

Fixes #41387

Change-Id: I552ffbfea8573e5d640ec98a3a196bd0eb36cdb9
Bug: https://github.com/dart-lang/sdk/issues/41387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142886
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-09 17:30:09 +00:00
Danny Tuppeny b11da4d65e Get go-to-definition working with plugins for LSP 
Change-Id: I49c469a15a651718ed21850e6c1a8fac798392c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142378
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-09 17:01:19 +00:00
Jaime Wren 489d7b1695 Follow up on https://dart-review.googlesource.com/c/sdk/+/142705 to fix the assertion in the new completions in FieldDeclarations 
Change-Id: Id50663401c5dff67cb69fd30aece229f5c1f6617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142883
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 19:47:24 +00:00
Jaime Wren eddc9271ab Suggest type names before names in FieldDeclarations, even when they are documented with dartdoc 
Similar to https://dart-review.googlesource.com/c/sdk/+/142545

Change-Id: I217a17324bcfd9efb7e9bd1a53332fd06d1dc024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-07 20:53:46 +00:00
Paul Berry 03c15848d6 Migration: distinguish inserted casts based on whether they are downcasts. 
Inserted casts that aren't downcasts are much less likely to be safe
than inserted downcasts.

Change-Id: I21e0ef54b1c4d58c54724a510b25828fc3018142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142552
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-07 18:35:56 +00:00
Paul Berry 8c982a1373 Migration: categorize changes shown in the preview tool. 
We now sort changes into the following categories (in order):
- Dead code removals
- Casts added
- Null checks added
- Required keywords added
- Types made nullable
- Casts now unnecessary
- Language version comments removed

The reasoning is that this corresponds roughly to how important it is
for a human to inspect each kind of change to make sure it is safe
(dead code removals, for example, are highly likely to indicate an
incorrect migration, where as dropping of unnecessary casts is benign
and almost certainly correct).

Change-Id: I49e3adac3ac98de1a9298f9caadb76c73a9c67d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142542
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-07 18:35:56 +00:00
Jaime Wren faab097e01 Suggest type names before names in TopLevelVariableDeclarations, even when they are documented with dartdoc. 
The test test_TopLevelVariableDeclaration_type_after_comment3, fails without the change to optype.dart, the other tests were added simply to have more coverage.

Change-Id: I11512f1a97e72796b6e0656b7555206640e2a8f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142545
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 18:07:16 +00:00
Jaime Wren f0f3199daa Improve the completion of return types on FunctionTypedFormalParameters in FormalParameterLists 
Change-Id: I7c7446f5077844daadf935f5ec0af5b12da739fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142600
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 17:51:16 +00:00
Mike Fairhurst 7e68842b8e [nnbd_migration] Add sanity checks before writing to disk. 
Change-Id: I09e8f1bebd12747c06538f7cc5976a8601e8cbee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142210
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-06 18:26:14 +00:00
Mike Fairhurst 5d9eb40f20 [nnbd_migration] Change edit links to buttons. 
Change-Id: I7ac1b19021849c93a23aa6ffc739c318b7770664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142214
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-04-06 18:12:34 +00:00
pq 1e4a56ee72 remove type params for list param args 
Fixes: https://github.com/dart-lang/sdk/issues/41303

Change-Id: I733cef8d7ed94cab931a5e13c1a0a0f7d9f36c66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142420
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-04 02:35:37 +00:00
Jaime Wren 8eab8bfc0c Bug fix in inherited_reference_contributor.dart, completions inside of ConstructorDeclarations should include inherited members. 
Change-Id: I9f91087e98c8925b5b733b4b4a0a852f53073b82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142208
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-02 22:16:59 +00:00
Brian Wilkerson 1de74f0739 Remove an unnecessary type annotation to satisfy a lint 
Change-Id: I6ca927c2c97235e464b039a3aabad046b79ed5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142082
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-02 16:15:45 +00:00
Paul Berry b7130b0bf7 Migration: improve preview tool display when ! is added due to an explicit hint. 
Change-Id: Ie9b2a6cabaf02c46da2e8b8ac1bffa0e699acc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141741
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-31 22:04:46 +00:00
Konstantin Shcheglov ca6b0fd0df Fix for crash in WrapInText when the parameter is not InterfaceType. 
There was a crash in the logs.

_TypeError: type 'GenericFunctionTypeElementImpl' is not a subtype of type 'ClassElement'
at WrapInText.compute	(wrap_in_text.dart:26 )
at FixProcessor._addFromProducers.compute	(fix_internal.dart:4506 )
at FixProcessor._addFromProducers	(fix_internal.dart:4520 )
at FixProcessor.compute	(fix_internal.dart:762 )
at DartFixContributor.computeFixes	(fix_internal.dart:82 )


R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I187b3348a212391cc6c64ab2c412653bd2319334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-31 15:56:40 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Konstantin Shcheglov 3a0bf3ad36 Fix for creating a setter when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I3c364f01c9cb31166e24f2b28d6a4640fa7d8c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 21:00:23 +00:00
Brian Wilkerson 7e724e70b0 Sort non-generated files in analyis_server and add a test to ensure they stay that way 
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:03 +00:00
Mike Fairhurst 62c4b1fb2e [nnbd_migration] Add a "rerun from sources" button. 
Change-Id: I09f1c76cb41549b81218783ec69d190271508ba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141028
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-27 16:50:12 +00:00
Mike Fairhurst 3095a082cd [analyzer] Add an API to get a language comment token off a unit. 
Change-Id: I377fdc44d5e514d6d9a601b3947c3908e5a4497a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 03:47:57 +00:00
Brian Wilkerson d194838578 Add new relevance scores to LibraryElementSuggestionBuilder, which covers both LibraryMemberContributor and CombinatorContributor 
This should have tests, but I (or someone else) need to do some data
mining to figure out the correct relevance values and hence the correct
ordering to test for.

Change-Id: I7782d7b7e13ff38a785c445cd0d6fc82a388a6aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141000
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-25 22:49:26 +00:00
Mike Fairhurst 5f20fe7d83 Revert "Trim not useful bottoms off of the non/nullability stack traces" 
This reverts commit a225178919.

Reason for revert: This seems to remove useful info from the stack trace. Will revert, then hopefully land an improved version.

Original change's description:
> Trim not useful bottoms off of the non/nullability stack traces
> 
> Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,mfairhurst@google.com,srawlins@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9a2fb07e387d57394242b694e27456333f2cf2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140908
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-25 20:57:36 +00:00
Brian Wilkerson 3abbcd0da9 Attempt to fix windows bot failure 
Change-Id: I6288838fe5dea2cb7b8e0d79ee90d09c91496769
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140901
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-25 20:39:56 +00:00
Paul Berry 244b4247e9 Migration: better description text for edges. 
Change-Id: I58651c927a741721283c3c4c951673a86aa7a1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140883
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-25 19:38:34 +00:00
Jaime Wren 81894b958f Fix another case of the form described in https://github.com/dart-lang/sdk/issues/41039, this fixes the FunctionDeclaration case. 
Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I03df7f8d92b1e7754410dc88e1c09ad83476960e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-24 19:11:15 +00:00
Brian Wilkerson 2d0fed35bb Update the ArgListContributor to have new relevance scores 
This also includes a new metric computation showing how often function
typed parameters have closures as arguments.

Change-Id: I8999cc3935bcc7514ebba90a8a4d246b2f236c42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-03-24 17:00:55 +00:00
Devon Carew 1e45051341 [analyzer] initial implementation of SDK, file based configuration of the analysis server 
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 14:07:59 +00:00
Erik Ernst e3af7e724f Update usage of int/String fromEnvironment 
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.

Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-24 11:19:14 +00:00
Konstantin Shcheglov 6b7d7aa2c1 Type Function should be excluded from extended / implemented / mixed types. 
Change-Id: If225400a976657f042856bfdaf95b285f98cebb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 20:35:37 +00:00
Jaime Wren 6f76f194b1 Fix the common case of https://github.com/dart-lang/sdk/issues/41039, around MethodDeclarations 
Code completion will now include void, dynamic and other class declaration keywords in the return type location, in the following snippet: '@override void someMethod(...) {}'

This is relatively common, this happens 103 times in the collection package.

Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I28129f2d735d2ff7d0a0e65194b7963c74b01c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-23 18:03:44 +00:00
Jaime Wren dd95365f76 Optimization for the MeanReciprocalRankComputer.  This change doesn't have the object hold onto the list of ranks for the entire duration of a run, but has a running sum instead (similar to ArithmeticMeanComputer). 
This would have been an over-optimization originally, but at this point, we have 10 of these computer objects in completion_metrics.dart, and we are running this algorithm with up to 1.2 million ranks.

(Assuming that an int takes 4 bytes which I believe is true...) On a recent run of Brians, 29.4 MB of data was the running total of all the ranks.  With this change, the same data will be stored with 10 doubles and 10 ints.

Change-Id: If97ca18e78782c02a3ca0a3ed9d6a9725f5a05ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-21 19:50:36 +00:00
Sam Rawlins b6ef199bc0 Migrator: fix test to assert on information region when not making a parameter nullable 
Change-Id: I1df34c06ec0f6ffac29fcef873ab7a83e7636044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140249
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-20 18:30:28 +00:00
pq a3499f0849 quickfix for prefer_const_constructors_in_immutables 
Fixes: https://github.com/dart-lang/sdk/issues/41097

Change-Id: I2ff001437ff4a4174bc7ba10b9f6ea5fab89317e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-20 17:04:29 +00:00
Jens Johansen 71e05a8d37 [analyzer] Make setters work in 'Add explicit 'show' combinator' 
Fixes #41069

Change-Id: I12586b761b92b25be592bb61b4df11a0f1ebbfe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-20 08:19:40 +00:00
Brian Wilkerson ce67d6ae27 Consolidate relevance tests into a single directory 
Change-Id: Iee3a3553b17d2e8b3b6f479159e6fe560e44192f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140120
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 20:51:38 +00:00
Sam Rawlins a225178919 Trim not useful bottoms off of the non/nullability stack traces 
Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-19 18:13:33 +00:00
Brian Wilkerson dcdde433b6 Use the deprecated feature for static members 
Change-Id: I718a30d9c392ebae2fe611b402c13cdb60a90825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140080
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 16:09:59 +00:00
Brian Wilkerson 2a2855c781 Perform new relevance computations for extension members 
Sorry for the size of the change.

This started out looking like a fairly simple task of repeating the work
done for type mambers, but it was too similar so I ended up doing some
refactoring in order to share the code.

Along the way I realized that we didn't yet have a feature for demoting
deprecated members, so I added it.

Then I discovered some more places where the old and new logic were
getting intertwined, so I straightened that out as well.

Change-Id: Ic24babd30bbbeeae9709a8019642e497a2ebb65d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139949
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 13:34:19 +00:00
Paul Berry 096bf5769d Migration: add "why not nullable" traces to preview tool. 
Change-Id: If945d32f33124e5e85429bd76c1db14167c0024e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139960
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Paul Berry 41b67a9b52 Migration: add grayed-out spaces to indicate types not being made nullable. 
Change-Id: I4fa076693c25cf9466d33332030df3983043ffd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139940
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00