Commit Graph

640 Commits

Author SHA1 Message Date
jwren@google.com 2ceb165494 Fix for 18468- T << Type where T is a type parameter and Type is the type Type from dart.core
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//252693006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35501 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 22:10:11 +00:00
sra@google.com 93ef680621 Mark Safari lib/mirrors/to_string_test as working
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//248873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35304 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 07:03:00 +00:00
rmacnak@google.com 7ba8ca5753 Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
With fix for uninitialized is_dart_scheme_ when read from snapshot.

BUG=http://dartbug.com/15274
R=iposva@google.com

Review URL: https://codereview.chromium.org//247683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35289 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:05:08 +00:00
jwren@google.com 4f4507b9ef Fix for 14221/ 15553/ 16673- X isSubtypeOf E now returns false when X is some type and E is a type parameter. This fixes a few issues, but also breaks some assertions (language tests that now have valid warnings from the analyzer).
Additional work will need to be done to fix the language tests, and to investigate the case of X isSubtypeOf E where X is of type Type.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//247313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35281 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:07:54 +00:00
ricow@google.com 00c28d1198 Mark lib/mirrors/invoke_natives_fuzz_test as failing on command line javascript engines
Review URL: https://codereview.chromium.org//247013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35254 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 11:16:57 +00:00
ricow@google.com 6beeb38f35 Remove suppression for lib/mirrors/invoke_natives_fuzz_test on dart2js
This is passing on all configurations as far as I can see

Also, I don't really see why the second of the removed headings is needed, since it seems to be containted in the first

This may be due to commit - status file update - revert.

Review URL: https://codereview.chromium.org//246253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35247 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 07:01:08 +00:00
rmacnak@google.com 7840906011 Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
Review URL: https://codereview.chromium.org//246173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35238 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 00:08:52 +00:00
rmacnak@google.com 69d82c334b Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation).
Ensure invocation_fuzz_test doesn't exit prematurely.

Also visit instance methods defined in superclasses.

Complete blacklist so invocation_fuzz_test passes on the VM.

B=http://dartbug.com/15274
R=iposva@google.com

Review URL: https://codereview.chromium.org//241993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35234 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 23:24:17 +00:00
rmacnak@google.com fe5088a04e Update mirrors/invoke_natives_fuzz_test status.
Review URL: https://codereview.chromium.org//243193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35172 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 16:54:01 +00:00
rmacnak@google.com cf10eda0f1 Syntax error in test status heading.
Review URL: https://codereview.chromium.org//242253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35159 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 23:28:23 +00:00
rmacnak@google.com cd09aca632 Mark invoke_natives_fuzz_test as passing in Dartium, FF, Safari, Chrome, IE.
Review URL: https://codereview.chromium.org//242213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35158 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 23:22:22 +00:00
rmacnak@google.com e321ed387f Add fuzz test for reflective invocation.
B=http://dartbug.com/15274
R=gbracha@google.com

Review URL: https://codereview.chromium.org//241483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35155 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 21:48:23 +00:00
sra@google.com a6a11ab53c Update status for two tests fixed by r35000
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//229103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35003 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-12 00:53:27 +00:00
jwren@google.com b2be15f8ed Fix for first half of 16078- clarifications on the StaticWarningCode.FUNCTION_WITHOUT_CALL warning
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//231473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35002 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-12 00:35:36 +00:00
lrn@google.com 2ab1f1238f Trying to make preamble for d8.
Preamble handles timers and task queue.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//201873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34967 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 10:29:06 +00:00
floitsch@google.com 07b6c4739e Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556

Committed: https://code.google.com/p/dart/source/detail?r=34779
Reverted: https://code.google.com/p/dart/source/detail?r=34782

Committed: https://code.google.com/p/dart/source/detail?r=34818
Reverted: https://code.google.com/p/dart/source/detail?r=34820

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34823 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:27:37 +00:00
floitsch@google.com 8cdf6bde8e Revert "Add support for closure calls through getters."
This reverts commit r34818.

Review URL: https://codereview.chromium.org//228023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34820 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:06:15 +00:00
floitsch@google.com 6c9c0642a0 Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556

Committed: https://code.google.com/p/dart/source/detail?r=34779
Reverted: https://code.google.com/p/dart/source/detail?r=34782

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34818 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:27:00 +00:00
floitsch@google.com b7fefddf34 Revert "Add support for closure calls through getters."
This reverts commit r34779.

Review URL: https://codereview.chromium.org//227203007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34782 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 15:58:49 +00:00
floitsch@google.com 569e0f50ed Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34779 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 15:02:01 +00:00
floitsch@google.com 47a1edad2b Move mirrors-test from dart2js_extra to lib/mirrors.
R=ahe@google.com

Review URL: https://codereview.chromium.org//223673007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34728 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-04 09:48:31 +00:00
kevmoo@google.com 6e3128596c lib/convert: removed unused import, removed redundant test
Re-enabled checks in existing test

R=ricow@google.com

Review URL: https://codereview.chromium.org//223053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34703 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 13:41:55 +00:00
zra@google.com 2fe51715e5 Begins work on ARM64, first assembler test.
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}

The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.

R=regis@google.com

Review URL: https://codereview.chromium.org//221133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
floitsch@google.com 4cf0157e5e Allow getField of methods.
BUG= http://dartbug.com/13002
R=karlklose@google.com

Review URL: https://codereview.chromium.org//217963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34598 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 14:04:49 +00:00
floitsch@google.com ff402648a2 Revert "Add support for closure calls through getters."
This reverts commit r4555.

Review URL: https://codereview.chromium.org//219493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34556 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 15:21:27 +00:00
floitsch@google.com 86303df642 Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34555 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 14:22:42 +00:00
rmacnak@google.com f0626388f5 VM: Evaluate metadata on a class in the scope of its library not the scope of the class.
BUG=http://dartbug.com/17795
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//217543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34537 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:38:32 +00:00
kevmoo@google.com 264d172ab0 lib.status: de-duped JSON serialization in Dart2Dart + minified
R=karlklose@google.com

Review URL: https://codereview.chromium.org//215063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34508 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 16:52:31 +00:00
rmacnak@google.com 9c105f7c9c Handle creating ParameterMirrors for the parameters of forwarding constructors.
BUG=http://dartbug.com/17823
R=hausner@google.com, regis@google.com

Review URL: https://codereview.chromium.org//212883009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34494 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 01:22:03 +00:00
hausner@google.com 09f4894a9c Fix mirrors test expectation
Review URL: https://codereview.chromium.org//215633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34484 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 22:11:32 +00:00
srdjan@google.com 36d8c9a39c Fix bug in divpd x64.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//213193009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34475 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 16:43:40 +00:00
karlklose@google.com 56d8742555 Fix test expectations for convert/json2_test.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//212653009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34465 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 08:11:34 +00:00
srdjan@google.com a0ac63bd57 Fix broken build, by disabling test; investigate failure leisurely.
Review URL: https://codereview.chromium.org//212623007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34459 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:28:47 +00:00
lrn@google.com 6e1d5c293a Update expectations to mark lib/mirrors/immutable_collection_test as failing.
BUG= http://dartbug.com/17823

Review URL: https://codereview.chromium.org//212543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34433 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 15:41:40 +00:00
rmacnak@google.com 78ab60a0de Implement MethodMirror.location in the VM.
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//211243009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34400 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 00:44:54 +00:00
ajohnsen@google.com 877658b6ec Fix status file.
BUG=

Review URL: https://codereview.chromium.org//206613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34395 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 22:50:38 +00:00
ajohnsen@google.com 38e2e4a18c Mark deferred_mirrors_metadata_test as crashing with dart2js.
BUG=https://code.google.com/p/dart/issues/detail?id=17732

Review URL: https://codereview.chromium.org//199793018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 13:35:19 +00:00
johnniwinther@google.com 7c9b135629 Remove cancel and make crash exit with code 253.
BUG=http://dartbug.com/17557
R=karlklose@google.com

Review URL: https://codereview.chromium.org//206193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34238 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:44:42 +00:00
sigurdm@google.com 30ac6d116d Introduces the new syntax for deferred loading
import "lib.dart" deferred as lib;

And then injecting a function of the name "loadLibrary" into the
namespace of the import prefix.

This FunctionElement is a triggers the builder to emit special code that causes _loadLibraryWrapper in js_helper to be called.

Dart2dart will not crash on deferred loading, but calls to
loadLibrary will become calls to a (not-existing) top-level function
loadLibrary.

The old syntax (using metadata) is still working

For now keeping the language tests with the old syntax in addition to
the updated tests.

R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//201613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34230 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 07:50:08 +00:00
whesse@google.com 62c79adbd0 Add entries for ContentShellOnAndroid runtime to status files.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//203373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33807 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 14:47:56 +00:00
rmacnak@google.com f8c59de4d6 Clean up ClosureMirror.invoke(#call, ...).
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//196513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33790 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 23:43:32 +00:00
johnniwinther@google.com f744481c8e Mark various tests as slow for FYI
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//199893004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33743 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:26:25 +00:00
johnniwinther@google.com 7d19bc6001 Skip deferred tests on d8 on Windows.
BUG=
R=sgjesse@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//198853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33691 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 10:39:51 +00:00
rmacnak@google.com 8c0e1a602e Fix LibraryMirror.invoke to call through the contents of an implicit getter.
BUG=http://dartbug.com/17452
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//196953007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33682 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 01:14:06 +00:00
rmacnak@google.com 10ecef7968 Remove ObjectMirror.[].
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//165773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33543 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 18:21:13 +00:00
rmacnak@google.com 57dd1321d1 Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies.

BUG=http://dartbug.com/10360

Review URL: https://codereview.chromium.org//189843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
rmacnak@google.com 62ad4b82ce Revert "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Review URL: https://codereview.chromium.org//189293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33402 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:45:29 +00:00
rmacnak@google.com 2d0e54a94d Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors.
BUG=http://dartbug.com/10360
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//154733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33397 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:02:29 +00:00
rmacnak@google.com d515f61a35 Work around bug where closures are missing #call to support delegation of #call to closures.
BUG=http://dartbug.com/16995
R=iposva@google.com

Review URL: https://codereview.chromium.org//183923018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33303 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:10:04 +00:00
rmacnak@google.com d3a92a0f3d Hoist hasReflectedType and reflectedType from ClassMirror to TypeMirror.
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//183853022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33291 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 19:01:26 +00:00