a4b84a722a
Ensures that stubs added to each object pool on x64
...
are generated before they are used by reordering the
list of stubs.
R=iposva@google.com
Review URL: https://codereview.chromium.org//258133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35524 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 14:48:00 +00:00
15eff079d7
Collect samples during isolate startup
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//250883017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35522 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 14:17:31 +00:00
84bc2d6409
Remove accidental code.
...
BUG=
Review URL: https://codereview.chromium.org//257063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35521 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 11:49:20 +00:00
3265fb5d09
Make FileStat have millisecond precisions, for linux, mac and android.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18442
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//252123005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35520 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 11:38:50 +00:00
b5ff19d3e8
Update documentation of StreamSubscription.cancel.
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//256233005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35519 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 10:35:24 +00:00
075cd1c904
Extend closure tracer to also trace dynamic tear offs and use the result to identify closures that might be passed to Function.apply
...
BUG=
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=35057
Reverted: https://code.google.com/p/dart/source/detail?r=35062
Review URL: https://codereview.chromium.org//223403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35518 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 09:46:07 +00:00
7d956b24df
pkg/collection: define delegating collection constructors as const
...
Allows creating a singleton const instance for common values
R=lrn@google.com
Review URL: https://codereview.chromium.org//252133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35517 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 09:42:40 +00:00
f0565a0eea
Fix dart2js replace to escape all dollar characters in the replacement string.
...
BUG= http://dartbug.com/17886
R=herhut@google.com
Review URL: https://codereview.chromium.org//251373006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35516 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 08:01:33 +00:00
2151658634
Use accept and not accept4.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18446
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//257153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35515 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 07:40:05 +00:00
def72d3fd4
Update status after updating firefox to v28 on linux
...
Review URL: https://codereview.chromium.org//260303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35514 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 06:36:50 +00:00
54397efcc5
Minor cleanup.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//259143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35512 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 00:32:22 +00:00
16e405af4c
- Fix for unsuccessful hoisting of CheckSmi in _HashMap.[]=
...
R=srdjan@google.com
Review URL: https://codereview.chromium.org//257123004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35511 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 23:43:19 +00:00
f5dd5598ac
Don’t set more than one code breakpoint per token position
...
Some time ago when operator== calls had inlined null checks at
the call site, the debugger had to instrument multiple code breakpoints
that were all mapping to the same source position. This is no longer
necessary. This change makes sure we set a code breakpoint only at
the lowest compiled code address, so that expressions like i++ no longer
result in 2 or 3 breakpoints (one each for load filed, add, store field).
Fixes 18397.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//256243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35510 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 23:40:34 +00:00
8203405e13
Avoid generating VariableUse nodes with non-identifier names
...
The change uses of VariableUse where the the 'name' is a JavaScript expression. This is very naughty, since the minifier can't tell which names are free in a function.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//255843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35508 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 23:30:25 +00:00
201fc559bf
Provide table of wrapper types for dart:blink
...
R=leafp@google.com
Review URL: https://codereview.chromium.org//252993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35502 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 22:12:03 +00:00
2ceb165494
Fix for 18468- T << Type where T is a type parameter and Type is the type Type from dart.core
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//252693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35501 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 22:10:11 +00:00
970367e227
Rename blink -> _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//258733009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35499 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 21:56:19 +00:00
b6c9989ff5
Allow a NumberFormat to be passed a currency name/symbol at creation
...
BUG=https://code.google.com/p/dart/issues/detail?id=18499
R=efortuna@google.com
Review URL: https://codereview.chromium.org//259093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35496 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 20:46:18 +00:00
2388b7d73d
Change the error for importing a deferred library with a top-level 'loadLibrary' to being a hint. Also, the logic for checking for the 'loadLibrary' from the element model into the hints phase (BestPracticesVerifier).
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//253493010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35495 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 20:13:59 +00:00
2f2c4b5b1f
JavaScript Binary expressions not subclass of Call
...
About a 15% decrease in VariableUse nodes and a similar number of small lists (two Lists for each Binary/Prefix/Postfix - a short growable List and it's backing fixed size List).
R=floitsch@google.com
Review URL: https://codereview.chromium.org//256003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35494 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 19:57:03 +00:00
a4822e49a5
Rollback to 1024m max heap.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//252063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35492 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 19:12:58 +00:00
72b3e8e635
Functional JavaScript AST source position updates
...
Functional update of source positions means that trees can be shared more freely.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//251593006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35491 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 18:59:08 +00:00
b3098a263b
Fix polymorphic inlining of method dispatchers.
...
Field dispatchers and noSuchMethod dispatchers are generated by the VM
compiler and should always be inlined - this CL fixes the case of polymorphic
inlining where dipatchers were not inlined in the same way as for monomorphic
calls sites.
R=iposva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//235013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35490 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 18:01:57 +00:00
8e56764233
Fix registration of closure functions
...
Closure functions get registered in the class by the
compiler backend. The incorrect assumption was that each
closure only gets visited once. However, closures in finally
clauses are duplicated when the AST nodes of the finally
clause are inlined. This change avoids the duplicate registration.
Fixes issue 18225
R=srdjan@google.com
Review URL: https://codereview.chromium.org//252893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35487 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 17:20:09 +00:00
66c18e7c7d
Address comments on Issue 258563004.
...
Review URL: https://codereview.chromium.org//252873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35486 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 17:17:38 +00:00
6723f390fa
Disable optimizing compiler on SIMARM64.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//256103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35484 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 16:02:28 +00:00
75bfb7b473
Use new --clear_browser_cache on the dart2js bots
...
We are deprecating --clear_safari_cache in favor of a more general flag the individual browser implementations can use.
R=whesse@google.com
Review URL: https://codereview.chromium.org//257803014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35483 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 13:30:14 +00:00
d460d7d9f9
Use UnmodifiableMapView in compiler
...
Redo of https://code.google.com/p/dart/source/detail?r=35379
Which was reverted in https://code.google.com/p/dart/source/detail?r=35381
R=herhut@google.com
Review URL: https://codereview.chromium.org//258753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35482 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 13:12:03 +00:00
d6a42d28a6
Change what we run on pub debug bots
...
Only run pkg and docs tests for now, we are timing out on a bunch of pkgbuild tests.
R=whesse@google.com
Review URL: https://codereview.chromium.org//256993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35481 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 13:11:20 +00:00
c99c88e2f6
Remove suppression for html/element_types_test/supported_content on firefox
...
This no longer fails after ff updated.
Review URL: https://codereview.chromium.org//256033006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35480 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 12:00:48 +00:00
5d2cc9e274
Add support for running debug mode pkg, docs tests
...
Currently disable pub tests in debug, see issue 18479
R=whesse@google.com
Review URL: https://codereview.chromium.org//252853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35479 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 11:05:40 +00:00
9a9ca47034
Add clear_browser_cache flag to test.dart
...
This can be used by any browser implementation to flush browser specific caches if set
clear_safari_cache is left in as a synonym for now, I will remove if after I update the bots
Review URL: https://chromiumcodereview.appspot.com//252653007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35477 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 09:38:31 +00:00
25d589e750
Correctly minify magic [call] property of [Closure].
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//253753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35476 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 09:06:21 +00:00
1aba267aa7
Add git and svn to task_kill which we run on the bots.
...
We are occasionally seeing orphaned git processes when running pub tests on windows.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//259963007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35475 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 07:32:45 +00:00
8e34dc3546
Allow a closure to be torn off from itself via .call.
...
BUG= http://dartbug.com/17474
R=floitsch@google.com
Review URL: https://codereview.chromium.org//252693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35473 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 06:46:48 +00:00
496aa45ed1
New analyzer snapshot. Sorted unit members.
...
New Character utilities.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//259773005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35468 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 22:37:24 +00:00
77fbba6bf0
Translate parts of engine.services project.
...
Some tweaks for Java implementations to get valid or better Dart code.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//250823006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35466 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 19:01:13 +00:00
f65b47dd21
Don't emit repeated null SourceLocations
...
80% of CodeBufferMarkers were redundant null markers occupying 2% of the heap.
Review URL: https://codereview.chromium.org//259643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35463 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 16:16:30 +00:00
5ce61408ae
Fix SIMARM64 to compile on Mac, fix compilation because of ICData change.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//257793005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35460 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 00:13:32 +00:00
93cf4041e4
Fix crashes: ComparisonInstr now has also kinds kIS and kISNOT: implement negation for those.
...
Review URL: https://codereview.chromium.org//251883004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35459 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:54:38 +00:00
e0ab99b0b2
Remember all deopt reasons in ic_data, not just the last one.
...
Remember if a JS warning was issued in ic_data.
Save a word in ic_data on 64-bit platforms.
R=iposva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//254723003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35457 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:45:14 +00:00
2cc32fd9fc
Fix types in test.
...
Review URL: https://codereview.chromium.org//256623010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35456 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:39:56 +00:00
0c2b0af123
Copy of Issue 231383002 after hard disk crash: First step in improving instance of test for a fixed set of value cids returning different results.
...
Review URL: https://codereview.chromium.org//258563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35455 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:21:12 +00:00
64481d6783
Undo skip, tests now pass
...
BUG=http://dartbug.com/18447
R=leafp@google.com
Review URL: https://codereview.chromium.org//259923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35454 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:09:59 +00:00
2d568a5b5b
Add missing comma to libraries.dart
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//255943005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35451 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 22:13:57 +00:00
ee6786c03f
Add missing dart:blink references
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//258853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35450 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 21:56:28 +00:00
26068ad107
Move conditional skip after unconditional skips
...
TBR=iposva@google.com ,leafp@google.com
Review URL: https://codereview.chromium.org//252583006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35449 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 21:42:07 +00:00
3274258b4d
Enables all codegen tests for arm64.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//259903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35448 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 21:28:48 +00:00
5e37b291bb
Disable an assertion until bug 18384 is fixed.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//248173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35445 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 20:48:17 +00:00
18a8d7fe4c
Fixes bug where we would occasionally materialize a corrupted object.
...
On the slow path for a stack overflow check we manually spill the live
registers before our call to the runtime function. We were updating
all uses of these spilled registers in the Environment object but this
was not enough - we also need to update any uses of these spilled
registers in MaterializeObjectInstrs which are hanging off of the
Environment.
This would fail when a deoptimization was triggered during a stack
overflow check and a materialized object happened to refer to
registers.
I've been chasing this for a while and I was able to get it to
reliably reproduce by using the --stacktrace_every=N and the
--stacktrace_filter flags, which were added for this purpose.
ALSO:
Set the top context to null on exceptions/errors. This is needed for
the --verify-incoming-context flag.
Minor printing improvements.
R=fschneider@google.com
Review URL: https://codereview.chromium.org//246303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35443 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 20:24:27 +00:00
zra@google.com