zra@google.com
a4b84a722a
Ensures that stubs added to each object pool on x64
...
are generated before they are used by reordering the
list of stubs.
R=iposva@google.com
Review URL: https://codereview.chromium.org//258133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35524 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 14:48:00 +00:00
herhut@google.com
075cd1c904
Extend closure tracer to also trace dynamic tear offs and use the result to identify closures that might be passed to Function.apply
...
BUG=
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=35057
Reverted: https://code.google.com/p/dart/source/detail?r=35062
Review URL: https://codereview.chromium.org//223403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35518 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 09:46:07 +00:00
lrn@google.com
f0565a0eea
Fix dart2js replace to escape all dollar characters in the replacement string.
...
BUG= http://dartbug.com/17886
R=herhut@google.com
Review URL: https://codereview.chromium.org//251373006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35516 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 08:01:33 +00:00
ricow@google.com
def72d3fd4
Update status after updating firefox to v28 on linux
...
Review URL: https://codereview.chromium.org//260303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35514 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 06:36:50 +00:00
jwren@google.com
2ceb165494
Fix for 18468- T << Type where T is a type parameter and Type is the type Type from dart.core
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//252693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35501 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 22:10:11 +00:00
jwren@google.com
2388b7d73d
Change the error for importing a deferred library with a top-level 'loadLibrary' to being a hint. Also, the logic for checking for the 'loadLibrary' from the element model into the hints phase (BestPracticesVerifier).
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//253493010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35495 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 20:13:59 +00:00
ricow@google.com
c99c88e2f6
Remove suppression for html/element_types_test/supported_content on firefox
...
This no longer fails after ff updated.
Review URL: https://codereview.chromium.org//256033006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35480 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 12:00:48 +00:00
herhut@google.com
8e34dc3546
Allow a closure to be torn off from itself via .call.
...
BUG= http://dartbug.com/17474
R=floitsch@google.com
Review URL: https://codereview.chromium.org//252693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35473 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 06:46:48 +00:00
srdjan@google.com
2cc32fd9fc
Fix types in test.
...
Review URL: https://codereview.chromium.org//256623010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35456 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:39:56 +00:00
srdjan@google.com
0c2b0af123
Copy of Issue 231383002 after hard disk crash: First step in improving instance of test for a fixed set of value cids returning different results.
...
Review URL: https://codereview.chromium.org//258563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35455 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:21:12 +00:00
rmacnak@google.com
f848586f7f
Prevent unbounded growth of the getField/setField closure caches.
...
BUG=http://dartbug.com/16539
R=iposva@google.com
Review URL: https://codereview.chromium.org//241703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35433 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 17:47:15 +00:00
paulberry@google.com
6c000ea2cb
New analyzer snapshot, based on r35422.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//257773008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35426 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:18:19 +00:00
ahe@google.com
80238d2c62
Don't use fatal errors in message_kind_test.dart.
...
BUG=http://dartbug.com/18363
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//246733004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35422 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 12:53:44 +00:00
asgerf@google.com
402931f341
dart2dart backend: AST and unparser for backend.
...
Note that the AST and unparser are not yet integrated with the actual code generation.
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//250523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35421 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 12:35:35 +00:00
ahe@google.com
740542e755
Complain if there are pending classes.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//233353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35420 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 09:11:49 +00:00
ahe@google.com
579f7b73bc
Easier-to-read expectations.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//258673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35419 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 09:04:30 +00:00
ahe@google.com
d99d6aaa5b
string_case_test/02 no longer fails on Chrome.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//257833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35418 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 08:45:39 +00:00
herhut@google.com
16e142f117
Always treat [call] members as closures during tracing.
...
BUG= http://dartbug.com/18383
R=sra@google.com
Review URL: https://codereview.chromium.org//250553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35417 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 06:49:41 +00:00
koda@google.com
a5287e494f
Fix GC triggering test by limiting its initial heap growth.
...
(Increasing the allocation size makes the test time out in debug mode.)
TBR=iposva@google.com
Review URL: https://codereview.chromium.org//259693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35412 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 23:02:21 +00:00
ahe@google.com
579d8aaaae
Change ErrorNode to masquerade as a null literal.
...
BUG=http://dartbug.com/18072
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//246963005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35388 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 18:13:34 +00:00
ahe@google.com
24d1437b2e
Update Try Dart to new scanner behavior.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//257613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35377 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 15:44:14 +00:00
ahe@google.com
4efb06b55c
Improve error-recovery from unmatched braces.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//251523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35372 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 14:48:02 +00:00
lrn@google.com
bd622a6960
Change the badly named RegExp.pattern to return the original source.
...
On dart2js, it returned the .source property of the underlying JS
regexp, which may not be the same (e.g., for "/" and "").
BUG= http://dartbug.com/17998
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//250573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35368 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 12:33:26 +00:00
johnniwinther@google.com
b830dd1f9f
Update status.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//252393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35364 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 10:55:58 +00:00
lrn@google.com
2a93b93c1c
Remove unmodifiable map wrappers that could instead use UnmodifiableMapView.
...
R=sgjesse@google.com
Committed: https://code.google.com/p/dart/source/detail?r=35244
Review URL: https://codereview.chromium.org//214723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35361 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 08:51:41 +00:00
johnniwinther@google.com
41d98f8427
Handle generic parameters in synthesized constructor for mixin applications.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//246563006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35359 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 08:35:28 +00:00
sigurdm@google.com
00910f947b
Insert checks before deferred calls and accesses.
...
These checks will throw an error if the library was not loaded.
R=floitsch@google.com , johnniwinther@google.com
Committed: https://code.google.com/p/dart/source/detail?r=35306
Was reverted by Issue 247863005 r35308 due to failing co19-test
Review URL: https://codereview.chromium.org//232563006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35355 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 07:51:35 +00:00
iposva@google.com
e1ec7a2c5f
- Update status file to mark crashing test while investigating.
...
- Remove unused fields from socket code.
R=asiva@google.com
Review URL: https://codereview.chromium.org//257433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35346 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 00:37:55 +00:00
iposva@google.com
fd8565b071
- Add a minimal implementation of Capability.
...
- Make RawReceivePort and SendPort VM internal objects.
- Rationalize the creation of ports and their handling within the VM.
R=asiva@google.com
Review URL: https://codereview.chromium.org//243973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 19:44:03 +00:00
kustermann@google.com
ebd8317290
Extract common code, add host IP to --debug and --enable-vm-service options
...
R=hausner@google.com , johnmccutchan@google.com
Review URL: https://codereview.chromium.org//239303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35312 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 13:09:10 +00:00
sigurdm@google.com
a31796ed37
Revert "Insert checks before deferred calls and accesses."
...
This reverts commit r35306.
Review URL: https://codereview.chromium.org//247863005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35308 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 09:23:33 +00:00
sigurdm@google.com
910fffd40d
Insert checks before deferred calls and accesses.
...
These checks will throw an error if the library was not loaded.
R=floitsch@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//232563006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35306 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 07:56:03 +00:00
sra@google.com
93ef680621
Mark Safari lib/mirrors/to_string_test as working
...
TBR=floitsch@google.com
Review URL: https://codereview.chromium.org//248873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35304 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 07:03:00 +00:00
sra@google.com
8129aff312
Redo "JS templates"
...
Improve Primitives.objectTypeName
The slightly different layout of the functions (they are now parsed and pretty-printed) confused a heuristic for getting a plausible type name from an arbitrary JS object's constructor function. Fix is to improve the heuristic.
TBR=floitsch@google.com
BUG=
Review URL: https://codereview.chromium.org//248473004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35301 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 04:44:07 +00:00
sra@google.com
5c9f933f2d
Revert "JS templates"
...
TBR=floitsch@google.com
BUG=
Review URL: https://codereview.chromium.org//246633006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35299 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 03:41:56 +00:00
sra@google.com
40b540d93c
JS templates
...
This CL mostly removes the 'fluent' API and replaces it with templates.
The JS code is parsed and converted (compiled) into an instantiation function.
The instantation function can be reused to stamp out similar copies.
This has made the large helper functions more readable since they are now mostly real JavaScript code.
Notes:
'if (#) stmt' adds a conditional statement if the argument is a Dart
bool. It constructs the tree if the argument is a JS Expression.
Fixed the statement template arguments so that '#;' is required.
There is a template manager that reuses templates with the same source.
This is persistent between compilation since the strings should be all 'constant'.
I am currently hunting down the strings parsed by 'js(string)'.
I have reduced it from 18k to O(500) for vampire.
The blocker is the runtime type parameters system - it generates an AST, prints it, and reparses it, giving an unbounded number of small templates, mostly with no parameters. So these templates are not cached and pay the price of repeated compilation.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//237583014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35296 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 03:30:50 +00:00
rmacnak@google.com
a8eacc8abf
Blacklist SystemEncoding.decode/encode.
...
Review URL: https://codereview.chromium.org//248133006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35293 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:58:47 +00:00
rmacnak@google.com
7ba8ca5753
Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
...
With fix for uninitialized is_dart_scheme_ when read from snapshot.
BUG=http://dartbug.com/15274
R=iposva@google.com
Review URL: https://codereview.chromium.org//247683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35289 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:05:08 +00:00
regis@google.com
98bcbb0dae
Do not ignore side effects of a type test or type cast as expression, such
...
as bound errors in checked mode.
Added tests.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//246293008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35284 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:48:13 +00:00
jwren@google.com
4f4507b9ef
Fix for 14221/ 15553/ 16673- X isSubtypeOf E now returns false when X is some type and E is a type parameter. This fixes a few issues, but also breaks some assertions (language tests that now have valid warnings from the analyzer).
...
Additional work will need to be done to fix the language tests, and to investigate the case of X isSubtypeOf E where X is of type Type.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//247313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35281 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:07:54 +00:00
scheglov@google.com
d1cc18b5e1
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//247053004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35270 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 17:10:47 +00:00
brianwilkerson@google.com
56ebb916fc
Fix for issue 18273
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//244253009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35260 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 14:43:35 +00:00
ricow@google.com
00c28d1198
Mark lib/mirrors/invoke_natives_fuzz_test as failing on command line javascript engines
...
Review URL: https://codereview.chromium.org//247013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35254 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 11:16:57 +00:00
ajohnsen@google.com
f9a46128a4
Add HttpClient:put/delete/head/patch.
...
BUG=http://code.google.com/p/dart/issues/detail?id=18168
R=lrn@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//246923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35252 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 10:58:46 +00:00
ricow@google.com
6beeb38f35
Remove suppression for lib/mirrors/invoke_natives_fuzz_test on dart2js
...
This is passing on all configurations as far as I can see
Also, I don't really see why the second of the removed headings is needed, since it seems to be containted in the first
This may be due to commit - status file update - revert.
Review URL: https://codereview.chromium.org//246253004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35247 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 07:01:08 +00:00
rmacnak@google.com
7840906011
Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
...
Review URL: https://codereview.chromium.org//246173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35238 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 00:08:52 +00:00
rmacnak@google.com
69d82c334b
Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation).
...
Ensure invocation_fuzz_test doesn't exit prematurely.
Also visit instance methods defined in superclasses.
Complete blacklist so invocation_fuzz_test passes on the VM.
B=http://dartbug.com/15274
R=iposva@google.com
Review URL: https://codereview.chromium.org//241993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35234 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 23:24:17 +00:00
scheglov@google.com
314fd76902
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//243263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35179 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 19:55:14 +00:00
rmacnak@google.com
fe5088a04e
Update mirrors/invoke_natives_fuzz_test status.
...
Review URL: https://codereview.chromium.org//243193003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35172 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 16:54:01 +00:00
paulberry@google.com
b8b2b5e454
Change UNDEFINED_FUNCTION from an error to a warning (issues 18274, 15315).
...
Also update the spec quote for the error enum, and add a unit test for
a case that wasn't previously covered
(test_undefinedFunction_inImportedLib).
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//241823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35163 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 13:44:26 +00:00