dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
23,632 Commits 2 Branches 0 Tags
a4b84a722ac052d57c1946237fc3e18de31a704c
Commit Graph

410 Commits

Author SHA1 Message Date
iposva@google.com fd8565b071 - Add a minimal implementation of Capability. 
- Make RawReceivePort and SendPort VM internal objects.
- Rationalize the creation of ports and their handling within the VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org//243973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 19:44:03 +00:00
asiva@google.com 4eb6d5f7d8 Modify the Weak Reference Set creation API to make it easier to create 
these sets in the GC Prologue code.

When this new API is not used in dartium:
  Without prolog callbacks in New  gen GC:
    dom-modify createElement runs-per-second 260.94890510948903
    dom-modify createTextNode runs-per-second 172.0

  With prolog callbacks in New  gen GC:
    dom-modify createElement runs-per-second 316.0
    dom-modify createTextNode runs-per-second 197.60479041916167


When this new API is used in dartium:
  Without prolog callbacks in New  gen GC:
    dom-modify createElement runs-per-second 310.0
    dom-modify createTextNode runs-per-second 174.4765702891326

  With prolog callbacks in New  gen GC:
    dom-modify createElement runs-per-second 416.0
    dom-modify createTextNode runs-per-second 241.75824175824175

R=iposva@google.com

Review URL: https://codereview.chromium.org//238063011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35215 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-21 18:31:15 +00:00
asiva@google.com a561e2bd17 1. Provide a framework to traverse persistent prolog weak handles. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//231053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35066 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-15 16:32:55 +00:00
johnmccutchan@google.com ef666553a1 Add runtime and native entry tags 
- Split runtime and native entry tags.
- Set runtime / native entry address as vm tag in stubs.
- Add reverse native entry resolver (pc to name) to public API (breaking change).
- Hookup reverse resolver for standalone VM (io + bootstrap + builtin natives).
- Runtime entries are registered with tags.
- Profiler queries for tag names via the reverse native entry resolver.
- Profiler outputs named entry tags as children under parent tag (runtime or native).

R=asiva@google.com

Review URL: https://codereview.chromium.org//227433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34941 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-10 20:26:45 +00:00
asiva@google.com db11f77af7 Use ASSERT instead of CHECK_ISOLATE in cases where we derive the isolate from the native Arguments structure. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//215293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34488 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-27 23:05:57 +00:00
hausner@google.com ed24226376 Support deferred library prefix syntax 
First step towards deferred library support:
- Parse the “deferred as” import clause.
- Implement p.loadLibrary() which returns a future that
  completes when the library is loaded.
- Treat type annotations of deferred types as malformed.
- Throw NoSuchMethodError when calling functions from
  unloaded libraries.
- Libraries are still read synchronously, but items in the
  library won’t be visible through the deferred prefix until
  the future returned by loadLibrary() completes.

Review URL: https://codereview.chromium.org//208323015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34481 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-27 21:20:47 +00:00
iposva@google.com 0977a3bf2b - First step in refactoring ports with the goal of moving 
them closer into the VM implementation.

R=asiva@google.com

Review URL: https://codereview.chromium.org//196443009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34438 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-26 17:30:39 +00:00
asiva@google.com 8c2df33d13 Use a bit in the handle structure to indicate if it is a prologue weak handle instead of the tagging the address. 
R=koda@google.com

Review URL: https://codereview.chromium.org//208443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34258 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-21 17:23:33 +00:00
asiva@google.com d302dc431a Auto delete persistent weak handles during finalization after invoking the callback associated with the weak handle. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//205153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34208 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-20 21:45:43 +00:00
asiva@google.com fafba0f6d9 Fix an incorrect usage of reusable handles in Dart_Allocate. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//206633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34184 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-20 17:07:45 +00:00
johnmccutchan@google.com 762b9a400c Set VMTag from stubs when transitioning between Dart and Native 
R=asiva@google.com, zra@google.com

Review URL: https://codereview.chromium.org//200693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34065 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-18 21:26:07 +00:00
johnmccutchan@google.com 25146ce058 Basic tag infrastructure 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//195733009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33701 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-14 16:16:21 +00:00
iposva@google.com 021fca847c - Implement a PauseTimerScope so that we can properly exclude 
times when a TimerScope is active.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//196413011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33662 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-13 20:38:24 +00:00
asiva@google.com 76b153643c Remove Dart_AddGcPrologueCallback and Dart_RemoveGcPrologueCallback from the Dart API. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//198103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33657 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-13 18:10:06 +00:00
asiva@google.com a611f736e0 Remove the ability to allow multiple gc prologue and gc epilogue callbacks 
to be registered at any given time. Dartium seems to use only one.

R=iposva@google.com

Review URL: https://codereview.chromium.org//197963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33622 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-12 22:39:15 +00:00
asiva@google.com 3f048502d4 Use CHECK_ISOLATE instead of DARTSCOPE for Dart_GetNativeInstanceField after 
fixing Instance::IsValidFieldOffset to use a reusable handle instead of
creating a new one (this was the issue last time which caused assertions).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//196243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33566 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-12 00:14:03 +00:00
asiva@google.com 4dce3eb30d Return error object from Dart_Allocate when an error occurs. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//193513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33559 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-11 22:07:22 +00:00
asiva@google.com 3af18cc4c0 1. Restructure reusable handles to make individual Scopes for each handle type 
2. Add a convenience macro to make use of reusable handle scopes easier

R=iposva@google.com

Review URL: https://codereview.chromium.org//187503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33471 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-08 00:26:29 +00:00
koda@google.com a69d028eb3 Track external allocated memory for weak persistent handles. 
The amount of external allocation is tracked per generation
and informs GC policy.

BUG=dart:11471
R=asiva@google.com

Review URL: https://codereview.chromium.org//187113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33467 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-07 23:53:32 +00:00
koda@google.com 87fbe42a46 Pretenure large external typed data and strings. 
Also fix an incorrect API comment about handle return type.

BUG=dart:17284
R=iposva@google.com

Review URL: https://codereview.chromium.org//180113009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33344 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-05 21:09:19 +00:00
asiva@google.com e380b175f8 Pass in the isolate parameter to the weak persistent callback handler so that 
there is no need to access the current isolate in the callback and delete
path (this code is run while a GC is in progress).

See https://codereview.chromium.org/185643003/ for corresponding changes
in dartium

R=iposva@google.com

Review URL: https://codereview.chromium.org//186003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33282 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-04 18:11:19 +00:00
asiva@google.com 8e0129970c Use a tag bit for indicating prologue weak persistent handles, this avoids 
the costly lookup to determine if a handle is a prologue weak persistent
handle or a regular weak persistent handle in Dart_DeleteWeakPersistentHandle

R=iposva@google.com

Review URL: https://codereview.chromium.org//177093010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33254 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-04 00:35:45 +00:00
asiva@google.com 3462e9a809 Fix dartium crasher, use DARTSCOPE when getting/setting native fields as it creates a Handle. 
Review URL: https://codereview.chromium.org//180153009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33148 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-28 03:22:16 +00:00
asiva@google.com c059ba6f6d 1. Added new versions of Api::UnWrapStringHandle Api::UnWrapInstanceHandle to 
use a reused handle instead of creating a new one
2. Use CHEK_ISOLATE instead of DARTSCOPE in some of the API functions where
   no handles are created

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//181843007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33142 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-27 23:38:39 +00:00
fschneider@google.com 16857e0b13 Revert r32930 (Add more timing information in the VM to track time...) 
It caused severe performance regressions that should be addressed.

TBR=asiva@google.com

Review URL: https://codereview.chromium.org//177733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32959 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-24 12:15:55 +00:00
asiva@google.com 6d313d3797 Add more timing information in the VM to track time spent is dart code Vs native code. 
R=johnmccutchan@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//137483010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32930 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-21 21:30:29 +00:00
asiva@google.com 04d7a5350f Add Dart_GetNativeFieldsOfArgument to get all the native fields of a dart 
object. This is especially useful for dartium which has two native fields
the type id and the native implementation field for the wrapper. This allows
for both values to be extracted in one call.

R=vsm@google.com

Review URL: https://codereview.chromium.org//174393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32905 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-21 16:53:23 +00:00
iposva@google.com f2a6f1b4b6 Another round of cleanups for http://www.dartbug.com/15922 
- Address warnings about 64-bit to 32-bit conversions.

R=ajohnsen@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//169893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32831 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-19 23:35:55 +00:00
johnmccutchan@google.com 2820a12766 Allow for embedder provided service request handlers 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//170943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32769 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-18 22:38:11 +00:00
regis@google.com 7830430adf Implement eager instantiation and canonicalization of type arguments at run 
time using a cache in uninstantiated type arguments.
Remove InstantiatedTypeArguments class.
Fix a bug in optimized code: do not update unused type test cache for Smi.
Fix a bug in optimized code on ARM and MIPS in type test cache lookup.

R=iposva@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//154393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32447 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-07 19:54:33 +00:00
asiva@google.com addb9ed934 Add new Dart API function Dart_IsolateData which returns the peer isolate data associated with an isolate. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//148453016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32397 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-07 00:43:18 +00:00
asiva@google.com 732d1a44de Add a UpdatedGuardedCidBit to Class object so that we don't have 
to iterate over all the classes and it's fields to update the
GuardedCid value on each call to Dart_Allocate.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//153103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32271 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-04 01:12:55 +00:00
turnidge@google.com b891e78325 Post-meetup feature extravaganza. 
Remodel the top-level isolate summary page.

Add variables to stack frames in the stack trace.

Stop putting small integers and bools in the object id ring.

Rework how we pass down null references (and null-like references like
uninitialized values).

Collect all isolate timers by default.

Change the lifetime of IsolateSpawnState so that we can refer to it
later to know how an isolate started up.  Stop pretending that
IsolateSpawnState is a void*.  Clean up vestigial IsolateStartData.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//145323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32128 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 18:40:12 +00:00
hausner@google.com 0c434b3073 Rename kDummyTokenIndex to kNoSourcePos 
Addresses comment to previous change list.

R=regis@google.com

Review URL: https://codereview.chromium.org//144343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31969 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-21 23:46:26 +00:00
lrn@google.com 9357caa547 Revert "Make VM TypedList not implement ByteBuffer." 
Html transferable test fails to send buffer as buffer.

Review URL: https://codereview.chromium.org//137783019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31875 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 11:48:07 +00:00
lrn@google.com c2f6609181 Make VM TypedList not implement ByteBuffer. 
BUG= http://dartbug.com/10136
R=asiva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//138033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31873 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 10:18:41 +00:00
johnmccutchan@google.com 8205cbf364 Fix mac build breakage in dart_api_impl.cc 
BUG=

Review URL: https://codereview.chromium.org//137443008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31811 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 23:05:57 +00:00
johnmccutchan@google.com c76b6eb1c2 Split service into VM and embedder specific bits. 
Move most service sources into the VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org//125103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31809 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 22:34:43 +00:00
asiva@google.com 88de88feb5 Add Dart API method Dart_SetPersistentHandle to enable setting the value of 
a persistent handle.

R=iposva@google.com

Review URL: https://codereview.chromium.org//116473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31443 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 18:47:38 +00:00
asiva@google.com 7f1055df45 Implement GetNativeReceiver without handles under a NoGCScope, this should 
eliminate the hot InitializeHandle calls that were observed in the profile.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//101153005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31405 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-30 19:55:28 +00:00
asiva@google.com 491035987f Change Dart_GetNativeBooleanArgument to use class Ids and direct 
pointer comparision of the singleton objects to determine value.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//113763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31311 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-20 00:15:13 +00:00
asiva@google.com a576fec3c0 Allow the native resolver to setup whether it needs the Dart API scope to 
be setup automatically or not when a native function is invoked.
This would allow the embedder to treat some native functions as leaf
functions whose invocation can be very light.

R=hausner@google.com, zra@google.com

Review URL: https://codereview.chromium.org//117723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31286 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 17:47:56 +00:00
turnidge@google.com b640712e6b Handle vmservice messages while at breakpoint. 
Allow rudimentary inspection of breakpoints from vmservice.

R=hausner@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//113513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31233 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-18 17:45:17 +00:00
iposva@google.com 1e8061f060 - Remove the reply_port from the VM internal message object. 
- Adjust all the uses of this API.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//93873015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31205 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-17 21:11:18 +00:00
srdjan@google.com 3274f92827 Rename FinalizeTypeHierarchy to ProcessPendingClasses. 
R=regis@google.com

Review URL: https://codereview.chromium.org//83983004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30688 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-27 00:11:32 +00:00
srdjan@google.com 3485989ae7 Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ and only invalidate optimized code at finalization of the class. 
Rename FinalizePendingClasses to FinalizePendingClassInterfaces as the class finalization occurs lazily.
TODO: add dependency information to deoptimize/remove only relevant optimized code.

R=regis@google.com

Review URL: https://codereview.chromium.org//81333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30582 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-22 17:59:23 +00:00
regis@google.com db2cec593d Distinguish between malformed and malbounded types more efficiently using the 
recently introduced LanguageError 'kind' field.

R=hausner@google.com

Review URL: https://codereview.chromium.org//75713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30383 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-18 23:31:12 +00:00
srdjan@google.com 5cd22e2dd3 Fixes issue 14742. Dart API may allocate objects without calling the constructor, this messes up the nullability tracking in the VM. Simple fix for now: initialize fields nullability, type, length if allocated via Dart API. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//70983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30233 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-13 16:01:41 +00:00
regis@google.com e3da5e16e4 Check type bounds of redirecting factories (issue 14699). 
Add tests for malbounded redirecting factories.
Clean up bound checking code and type error reporting code.

R=hausner@google.com

Review URL: https://codereview.chromium.org//66033006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30177 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 22:59:48 +00:00
iposva@google.com 070d3dedf7 - Add a per-isolate pseudo random number generator to the 
VM internals. This PRNG is not used to generate random
  numbers in Dart code.
- Use the PRNG to generate JIT cookies for large constants
  if needed during assembly.
- Add the possibility to set an external entropy source
  for the PRNG through the C API.

R=asiva@google.com

Review URL: https://codereview.chromium.org//59773007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29950 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 00:59:46 +00:00