dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
23,632 Commits 2 Branches 0 Tags
a4b84a722ac052d57c1946237fc3e18de31a704c
Commit Graph

1465 Commits

Author SHA1 Message Date
ajohnsen@google.com 84bc2d6409 Remove accidental code. 
BUG=

Review URL: https://codereview.chromium.org//257063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35521 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-29 11:49:20 +00:00
ajohnsen@google.com 3265fb5d09 Make FileStat have millisecond precisions, for linux, mac and android. 
BUG=https://code.google.com/p/dart/issues/detail?id=18442
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//252123005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35520 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-29 11:38:50 +00:00
ajohnsen@google.com 2151658634 Use accept and not accept4. 
BUG=https://code.google.com/p/dart/issues/detail?id=18446
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//257153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35515 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-29 07:40:05 +00:00
zra@google.com 47d03a04a0 Adds AI_ADDRCONFIG back to address lookup on Android. 
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//257613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35425 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-25 14:45:34 +00:00
ajohnsen@google.com ca58691974 Mark pipe as close-on-exec. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//251403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35354 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-24 07:34:07 +00:00
ajohnsen@google.com df14081452 Make opendir test for EINTR again and make NO_RETRY_EXPECTED check in release mode. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//253413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35352 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-24 06:38:16 +00:00
iposva@google.com e1ec7a2c5f - Update status file to mark crashing test while investigating. 
- Remove unused fields from socket code.

R=asiva@google.com

Review URL: https://codereview.chromium.org//257433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35346 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-24 00:37:55 +00:00
zra@google.com 37baacb116 Small fixes for Android. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//254383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35342 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 23:20:24 +00:00
hausner@google.com 3f40651e3a Support evaluation of expressions in context of a stack frame 
This change adds a debugger API function to evaluate an expression
in the context of a particular stack frame. The expression can
refer to local variables accessible in the frame, but it cannot
alter the variables.

R=regis@google.com

Review URL: https://codereview.chromium.org//249533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35340 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 22:56:23 +00:00
iposva@google.com fd8565b071 - Add a minimal implementation of Capability. 
- Make RawReceivePort and SendPort VM internal objects.
- Rationalize the creation of ports and their handling within the VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org//243973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 19:44:03 +00:00
koda@google.com f394f4b7dc Object size on heap map hover. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//247713006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35324 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 19:41:08 +00:00
koda@google.com a36796b587 Connect heap map to instance view. 
Clicking anywhere on the heap map sends an 'address' message to look up the object spanning the corresponding address.

Also fix issue with free list elements (which cannot be wrapped in handles).

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//249553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35315 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 17:00:01 +00:00
kustermann@google.com ebd8317290 Extract common code, add host IP to --debug and --enable-vm-service options 
R=hausner@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//239303004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35312 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 13:09:10 +00:00
ajohnsen@google.com ab53006509 Fix recursive directory deletion, to not leak file descriptors (and pointers). 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//249233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35310 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 12:09:12 +00:00
ajohnsen@google.com 8f41c24471 Make server-sockets level triggered. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//234843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35302 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-23 06:05:46 +00:00
johnmccutchan@google.com 1e72c0f6c4 Disable applyAuthorStyles 
This allows us to remove the dependency on bootstrap.css (removal of bootstrap.css from third_party will happen in follow up CL).

As a side effect of this, the following changes have occurred:

- Removed Google Charts Table from allocation profile pane.
- Add a SortedTable view-model (used in allocation profile).
- Changes to CPU profile tree view.
- Consolidate string formatting utility functions.

There is some UI regression (font size is one size too small) that will have to be addressed in follow up CLs.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//237683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35266 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-22 16:01:14 +00:00
ajohnsen@google.com fffd6da770 Use AI_ADDRCONFIG on Windows as well. 
BUG=http://code.google.com/p/dart/issues/detail?id=16742
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//246843005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35251 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-22 10:46:47 +00:00
hausner@google.com ea84b80f47 Add class id to debugger stack trace 
Add the class id of the origin class of each activation frame’s function.
Top-level functions have no class id. The wire protocol for an activation
frame now looks like this:

CallFrame =	“{“ functionName “:” String “,”
                    [ location “:” Location “,” ]
                    [ classId “:” Integer “,” ]
                    locals “:” NamedObjList “}“

R=devoncarew@google.com

Review URL: https://codereview.chromium.org//242453011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35232 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-21 23:16:41 +00:00
johnmccutchan@google.com c3a88f02c0 Register existing isolates when service isolate is started 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//242493007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35227 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-21 22:16:34 +00:00
johnmccutchan@google.com fdaf1b59bf Undo r35207 
Review URL: https://codereview.chromium.org//243583008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35208 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-21 16:03:52 +00:00
johnmccutchan@google.com 1606fce42f Add TraceBuffer log to all Functions (plus small tweaks to function-view) 
BUG=
R=srdjan@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//227423005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35207 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-21 15:57:09 +00:00
ajohnsen@google.com 94f53d4d2b Fix *ServerSocket's handling of zones. 
A stream's zone is the one it has when listening to. Use that, and not
the one active when creating the socket.

BUG=https://code.google.com/p/dart/issues/detail?id=17468
R=floitsch@google.com

Review URL: https://codereview.chromium.org//239613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35071 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-15 18:44:14 +00:00
johnmccutchan@google.com febba444a4 Fix heap report bug and add checked mode display to VM page 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//233523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35060 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-15 14:16:15 +00:00
ajohnsen@google.com 82f487f92f Fix File:copy FD leak, and add file-closes to some tests. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//233053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34961 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-11 07:48:49 +00:00
johnmccutchan@google.com ef666553a1 Add runtime and native entry tags 
- Split runtime and native entry tags.
- Set runtime / native entry address as vm tag in stubs.
- Add reverse native entry resolver (pc to name) to public API (breaking change).
- Hookup reverse resolver for standalone VM (io + bootstrap + builtin natives).
- Runtime entries are registered with tags.
- Profiler queries for tag names via the reverse native entry resolver.
- Profiler outputs named entry tags as children under parent tag (runtime or native).

R=asiva@google.com

Review URL: https://codereview.chromium.org//227433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34941 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-10 20:26:45 +00:00
iposva@google.com 090e15d537 Do not try to move lines around after test! 
- Fix typo in field name.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//233313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34935 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-10 17:58:47 +00:00
iposva@google.com 9adfe60489 - Apply review comments from https://codereview.chromium.org/232223004/ 
- Use isWindows where appropriate.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//233093004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34934 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-10 17:49:31 +00:00
ajohnsen@google.com 5aa521fa7b Report the correct error, when recursive delete fails on Windows. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//227913007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34933 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-10 17:13:02 +00:00
iposva@google.com 566ec5d5b9 - Do not keep the environment alive past the process spawn. 
- Avoid creation of many temp objects while creating the process
  environment.
- "if (identical(true, value))" makes no sense.

R=asiva@google.com

Review URL: https://codereview.chromium.org//232223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34907 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-10 00:15:47 +00:00
johnmccutchan@google.com 431761e878 Miscellaneous Observatory UI improvements 
Update cursor over expander in profiler

Ressurect json-view

Show arrow in profiler tree

Clicking on <code-ref> link in profiler doesn't expand tree

<code-ref> only shows a link for Dart code

Port script-view to use script-inset

Add function source to function view

Add counters to isolate view

Add counters to isolate summary

R=turnidge@google.com

Review URL: https://codereview.chromium.org//221263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34661 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-02 18:30:01 +00:00
zra@google.com 2fe51715e5 Begins work on ARM64, first assembler test. 
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}

The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.

R=regis@google.com

Review URL: https://codereview.chromium.org//221133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-02 17:39:32 +00:00
johnmccutchan@google.com ab19ef4f31 Redo allocationprofile options 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//217323006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34620 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 22:05:39 +00:00
turnidge@google.com cc82321046 Add <eval-link> - a custom element for evaluating an expression. 
Use <eval-link> to add a convenience toString() link for instances.

In the future I plan to use <eval-link> to provide easy access to getters.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//213853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34616 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 20:18:17 +00:00
turnidge@google.com b373e6c423 Change how we provide value previews in the vm service. 
Rename the 'preview' property to 'valueAsString'.

Rework printing so that we only add 'valueAsString' when we need it
(num, String, etc.).

Change ToUserCString to be a String-only method.  Drop ToUserCString
for lists -- it was hokey and unused.  Max string length is now 1024
instead of 40.

Update tests.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//219333011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34612 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 19:45:57 +00:00
ajohnsen@google.com 59fcec073c Don't make the signal-pipe non-blocking. 
This is an attempt to make it run on MIPS. The non-blocking is not
needed here.

BUG=https://code.google.com/p/dart/issues/detail?id=17826
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//220863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34594 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 12:15:21 +00:00
ajohnsen@google.com 45d35b1588 Make non-copying version of BytesBuidler and make file-reads faster. 
The non-copying version is internally, as this is always the behaviour
we want, when receiving data from the system.

File-reads are also further improved, by only reading data in chunks, if
initial length is 0. This is a special case where the file can be a
character device. Overall improvement is around a factor of 6.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//218493012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34589 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 10:56:19 +00:00
iposva@google.com e78cc1544d - Make ports be less predictable. 
- Limit the range of port numbers to 30-bits.
- Parse the ports as 64-bit values when reading from the wire in the debugger protocol.

R=hausner@google.com

Review URL: https://codereview.chromium.org//217693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34542 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-28 23:39:36 +00:00
turnidge@google.com 9b814028a3 Minor fix in isolate-view. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//217473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34530 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-28 22:09:53 +00:00
turnidge@google.com 3e86631f02 Use tokenPos instead of line/col in the vm service. 
Add line number information to the Script response.

Parse line number information in the observatory.

Update <script-ref> to take a pos argument

Add a new <script-inset> element which shows a code snippet.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//216883008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34528 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-28 21:24:24 +00:00
turnidge@google.com 3adcbe1071 Rework the <field-view> page. 
Give fields/functions a consistent notion of ownership.

Add field's script to the JSON.

Make page reload work again.

Fixup closure printing a bit.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//215213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34520 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-28 20:21:09 +00:00
turnidge@google.com 99fca31c02 Support Types in instance-ref/instance-view. 
Refactor JSON printing for all instances to share more code.  This allows Types to act like Instances in Observatory.

Update the look and feel for the function-view page.

Add script info for functions.

Update tests.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//211283004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34435 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-26 17:13:03 +00:00
ajohnsen@google.com 862687a1ad Don't use ThreadSignalBlocker in mac eventhandler. 
Turns out kevent can modify the current sigmask.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//212193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34408 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-26 06:21:38 +00:00
johnmccutchan@google.com 182fcd0921 Add isolate tag-profile model and UI. 
Distinction between a Dart Error and a ServiceError/ServiceException.
Better Observatory behaviour when a ServiceError/ServiceExceptions occurs.
Display isolate's sticky error.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//205713004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34377 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-25 18:09:02 +00:00
ajohnsen@google.com 644e1f50aa Fix mac part of previous commit. 
BUG=

Review URL: https://codereview.chromium.org//207553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34362 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-25 14:20:45 +00:00
ajohnsen@google.com 1a8f76beb3 Only return eventhandler tokens in stacks of 8, to avoid runtime calls. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//208653012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34359 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-25 13:44:01 +00:00
ajohnsen@google.com 4f613457d6 Speed up GetRandomBytes by only entering signal-blocking scope once. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//209333014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34356 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-25 13:06:37 +00:00
johnmccutchan@google.com ffdca5647a Fix PrintToJSONStream for oddball functions 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//196173022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34338 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-24 21:58:45 +00:00
turnidge@google.com 23d06d9db0 Rework how ServiceObjects are created and cached in Observatory. 
We now use a single cache, rather than per-type caches which simplifies the get() logic and makes it easier to add more model-types in the future.

Rework how isolates are created/stored/retrieved.  IsolateList is gone.

Add canCache and immutable to ServiceObjects and use them to inform when an object should be cached or reloaded.

Remove cache.dart, service.dart.

Add a notion of a ServiceObjectOwner.

Cleanups.

Etc.

Etc.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//204983008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34333 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-24 21:42:26 +00:00
ajohnsen@google.com f79179cbdb Be sure we to read all bytes requested, in GetRandomBytes. 
BUG=https://code.google.com/p/dart/issues/detail?id=17723
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//209983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34305 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-24 13:40:29 +00:00
johnmccutchan@google.com f13a5b700f Allow built in Observatory to work on any port 
https://code.google.com/p/dart/issues/detail?id=17537

R=turnidge@google.com

Review URL: https://codereview.chromium.org//208243006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34267 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-21 20:06:24 +00:00