dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
23,632 Commits 2 Branches 0 Tags
a4b84a722ac052d57c1946237fc3e18de31a704c
Commit Graph

59 Commits

Author SHA1 Message Date
nweiz@google.com 9da7f8aa3f Change ScheduledProcess's output streams over to be ScheduledStreams. 
This will help test "pub serve" with multiple entrypoints.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//164773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32770 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-18 22:56:58 +00:00
nweiz@google.com c5d1ec4384 Add some additional debugging prints to the mac os watcher. 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//146693014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32139 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 21:06:50 +00:00
nweiz@google.com ef19c6611d Take a broader approach to filtering out bogus Mac OS watcher events. 
With luck, this should unflake the test.

R=rnystrom@google.com
BUG=16079

Review URL: https://codereview.chromium.org//140013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31853 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 21:49:31 +00:00
nweiz@google.com 138a416ccc Fix a flaky test and work around issue 16003 in pkg/watcher. 
There's an additional flaky test that this CL is not likely to fix. Additional
debugging is added to help track down the cause of that flake.

R=rnystrom@google.com
BUG=16079

Review URL: https://codereview.chromium.org//134963007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31815 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 23:49:01 +00:00
kevmoo@google.com 97835dc3a6 pkg/unittest: added LICENSE 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//135343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31750 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 18:07:45 +00:00
nweiz@google.com 2be0bb8285 Stop working around issue 15458 in pkg/watcher. 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//134773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31709 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-10 21:27:08 +00:00
nweiz@google.com fb7ec85e6a Use stream matchers to unflake the mac OS watcher tests. 
R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//129473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31705 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-10 20:36:33 +00:00
rnystrom@google.com 247a436a58 I guess Linux doesn't iterate over folders alphabetically. 
R=nweiz@google.com

Review URL: https://codereview.chromium.org//127033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31591 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-07 23:39:17 +00:00
rnystrom@google.com 288f99189b Don't test for file differences in the polling watcher. 
The non-polling forms don't do this, so this makes the polling
style behave the same. It also has two important benefits:

1. On Windows, this avoids opening the files being watched.
   Since opening a file prevents it from being deleted on
   Windows, this causes the watcher to interfere with the
   files and leads to some flaky tests and buggy user
   behavior.

2. It saves some time and memory since we don't need to store
   the SHA1 for every file being watched.

BUG=http://dartbug.com/13026, http://dartbug.com/15431
R=nweiz@google.com

Review URL: https://codereview.chromium.org//122573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31574 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-07 21:09:58 +00:00
nweiz@google.com 113bd79bc6 Make pkg/path 1.0.0 and upgrade dependencies appropriately. 
All existing packages that use pkg/path (other than pkg/stack_trace,
which has already been updated) are compatible with both the pre-1.0
and post-1.0 path API, so I've marked their version constraints as
">=0.9.0 <2.0.0". I've also incremented their patch versions and I
intend to release new versions as soon as this CL lands.

R=alanknight@google.com, efortuna@google.com, jmesserly@google.com, rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//110873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31005 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-10 00:24:01 +00:00
nweiz@google.com 6611756318 Increment package versions for stack trace changes. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//110613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30997 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-09 20:44:05 +00:00
nweiz@google.com 04a2a02fa8 Add debugging prints to the Mac OS directory watcher. 
This is a temporary CL that will make it easier to track down and fix the errors
in the mac watcher.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//107403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30919 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-05 22:49:03 +00:00
nweiz@google.com b3fc09ef15 Update the Mac OS watcher in pkg/watcher. 
The behavior of Directory.watch has changed, and this updates the
watcher to match the new behavior.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//100823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30915 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-05 20:26:18 +00:00
nweiz@google.com 946df0e955 Add a missing import to pkg/watcher. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//104033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30914 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-05 20:24:10 +00:00
nweiz@google.com cbbad67d58 Add stack chain support to pkg/watcher and pkg/http. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//94093007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30912 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-05 19:31:19 +00:00
nweiz@google.com 165f8eb4b5 Update the Linux watcher to accommodate changes in [Directory.watch]. 
This also removes the extra time allotted for the test since issue
14606 is now mitigated.

R=rnystrom@google.com
BUG=15446

Review URL: https://codereview.chromium.org//99483006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30874 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-04 22:31:18 +00:00
nweiz@google.com e5014cd8a9 Properly close the Linux directory watcher when listing a subdirectory fails. 
R=rnystrom@google.com
BUG=15279

Review URL: https://codereview.chromium.org//89503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30690 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-27 01:16:56 +00:00
nweiz@google.com 69f1243709 Add a missing import to mac_os_watcher. 
TBR

Review URL: https://codereview.chromium.org//68523020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30330 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-16 01:10:23 +00:00
nweiz@google.com 205f55ad4a Remove debugging prints from the Mac OS directory watcher. 
R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//63643008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30329 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-16 01:05:45 +00:00
nweiz@google.com 1c828f6820 Fix the Mac OS directory watcher tests on the bots. 
R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//58903015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30328 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-16 00:54:50 +00:00
nweiz@google.com 1bface13de Re-mark directory_watcher/mac_os_test as passing. 
As before, this test is expected to fail. It's only failing on the
bots so we need to get the debug information from the bots to figure
out how to fix it.

This also adds some additional debug information to help clarify some
confusing output from the most recent failing log.

R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//64383004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30315 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-15 21:43:50 +00:00
nweiz@google.com e7ba1a8663 Roll forward r30205. 
Unlike previous versions of this CL, the debug info will only be printed when
running directory_watcher/mac_os_test, so it won't break the pub bots.

R=rnystrom@google.com
BUG=15042

Review URL: https://codereview.chromium.org//71353011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30254 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-13 21:56:52 +00:00
jmesserly@google.com 85bc44d154 "Reverting 30205" 
Review URL: https://codereview.chromium.org//69863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30217 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-13 03:03:33 +00:00
nweiz@google.com 5a33f0b1e8 Be sure we don't forward an error to a closed event stream. 
R=rnystrom@google.com
BUG=15034

Review URL: https://codereview.chromium.org//68253010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30210 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 22:17:01 +00:00
nweiz@google.com b58d984659 Add a bunch of debugging prints to the Mac OS watcher. 
This reverts r30184, which in turn reverted r30181. It correctly detects whether
it's running on a buildbot in a way that will work for the vm-mac-release bot.

This is a temporary CL intended to help provide information about a test failure
that's only reproducing on the build bot. It will be rolled back as soon as
sufficient information is gathered.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//69933007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30205 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 20:08:41 +00:00
nweiz@google.com 0a5afb6654 Revert "Add a bunch of debugging prints to the Mac OS watcher." 
This reverts r30181. This CL causes the pub tests to fail due to excess output,
so I didn't want to leave it in the build overnight. In addition, it didn't seem
to be working; no additional output was being printed in the tests. It's
possible BUILDBOT_BUILDERNAME isn't being set on vm-mac-release.

This also marks the directory_watcher/mac_os_test as flaky.

R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//68203008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30184 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 02:23:05 +00:00
nweiz@google.com ea9d92f3f4 Fix a synchronous event bug in futureStream. 
R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//68713004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30182 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 01:56:18 +00:00
nweiz@google.com f289c34b8f Add a bunch of debugging prints to the Mac OS watcher. 
This should help debug the intermittent, difficult-to-reproduce issues
on the vm-mac-release bot.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//68293005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30181 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 01:43:38 +00:00
nweiz@google.com 0a4fb91145 Properly close watcher streams during tests. 
This also makes [futureStream] pass cancellations through to the underlying
stream, and adds the ability for it to return broadcast streams.

R=rnystrom@google.com
BUG=14943

Review URL: https://codereview.chromium.org//66293008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30180 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 01:42:00 +00:00
nweiz@google.com db4cfbd3bf Work around a flake in the Mac OS watcher test on the bots. 
Issues 14373 and 14793 were tag-teaming to cause no_subscription_test
to fail for the Mac OS watcher occasionally.

This also marks directory_watcher/mac_os_test as timing out, apparently due to
issue 14943.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//59143006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30174 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:26:11 +00:00
nweiz@google.com d7c3ee487b Fix a typo in path_set_test. 
I'd have sworn I fixed this in the orignal CL.

R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//67973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30173 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:20:51 +00:00
nweiz@google.com 28ef6879f5 Fix some analyzer warnings and hints in pkg/watcher. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//69013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30172 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:02:06 +00:00
nweiz@google.com c5d6dd178d Make path_set_test use Windows-friendly paths where necessary. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//68683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30171 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:01:41 +00:00
nweiz@google.com 03337e9e5f Wrap Directory.watch on Mac OS for the watcher package. 
R=rnystrom@google.com
BUG=14428

Review URL: https://codereview.chromium.org//66163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30168 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 19:47:18 +00:00
nweiz@google.com 578e9a5281 Fix an analyzer error in the linux directory watcher. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//65533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30093 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-08 01:46:11 +00:00
nweiz@google.com 73e68b810f Fix the watcher tests on Windows. 
The tests were assuming POSIX paths.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//66073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30091 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-08 01:44:53 +00:00
nweiz@google.com 500eb1266b Wrap Directory.watch on linux for the watcher package. 
R=rnystrom@google.com
BUG=14428

Review URL: https://codereview.chromium.org//46843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30081 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 22:49:18 +00:00
dgrove@google.com 18ca7d0036 Re-land r29957 (add versions and constraints for packages and samples), with 
SDK constraints bumped from 1.0.0 to 0.8.10+6 .

R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//62473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 18:28:22 +00:00
ajohnsen@google.com 61f6c51990 Revert "add versions and constraints for packages and samples" 
This is currently blocking us from testing samples.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//59513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 09:09:18 +00:00
jmesserly@google.com 02638c5760 add versions and constraints for packages and samples 
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"

R=sigmund@google.com

Review URL: https://codereview.chromium.org//59763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 03:27:58 +00:00
jmesserly@google.com 308c960be6 fix csslib and watcher warnings 
R=rnystrom@google.com, terry@google.com

Review URL: https://codereview.chromium.org//50703011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29632 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 02:43:00 +00:00
whesse@google.com 69205c207c Remove uses of Options from pkg, samples, tests, and third_party directories. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//52573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29552 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 15:17:01 +00:00
ajohnsen@google.com 103eac574c Remove FileException, DirectoryException and LinkException from dart:io and use FileSystemException instaed. 
BUG=https://code.google.com/p/dart/issues/detail?id=12461
R=nweiz@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//26968003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29168 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 12:17:20 +00:00
floitsch@google.com 4be547c705 Adapt streams for additional stackTrace argument. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//25094002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28511 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-11 12:02:20 +00:00
rnystrom@google.com cd88620191 Bump wait time for watcher test. 
This is to see if it makes the test less flaky on the bots,
in particular the ARM ones.

BUG=https://code.google.com/p/dart/issues/detail?id=13705
R=nweiz@google.com

Review URL: https://codereview.chromium.org//26398002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28341 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-08 00:14:44 +00:00
whesse@google.com 428e84e7d4 Use Directory.systemTemp getter in pkg subdirectory of repository. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//25731003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28218 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 13:12:10 +00:00
nweiz@google.com 9300846114 Use filtered stacks in pub, barback, and watcher tests. 
This also exposes more unittest stuff to users of scheduled_test.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//23582003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26751 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 23:13:30 +00:00
rnystrom@google.com 6c2fe4dea5 Normalize test paths. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//23183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26160 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 21:46:41 +00:00
rnystrom@google.com 79743b6a93 Fix error handling in watcher. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//23085006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26156 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 21:28:31 +00:00
rnystrom@google.com a07415d196 Handle watching a non-existent directory. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//22999008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26153 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 21:02:02 +00:00