Commit Graph

142 Commits

Author SHA1 Message Date
scheglov@google.com 496aa45ed1 New analyzer snapshot. Sorted unit members.
New Character utilities.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//259773005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35468 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 22:37:24 +00:00
paulberry@google.com 0af02e38a1 Comment out generated resolver tests (TBR).
Review URL: https://codereview.chromium.org//252723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35427 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:38:43 +00:00
paulberry@google.com 6c000ea2cb New analyzer snapshot, based on r35422.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//257773008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35426 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:18:19 +00:00
scheglov@google.com d1cc18b5e1 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//247053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35270 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 17:10:47 +00:00
scheglov@google.com 314fd76902 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//243263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35179 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 19:55:14 +00:00
pquitslund@google.com 9f93ab5937 Annotation whitespace convention fixes (dartbug.com/17837).
R=scheglov@google.com

Review URL: https://codereview.chromium.org//225863005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34902 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 22:22:31 +00:00
scheglov@google.com f8e1c92a55 Comment out resolver tests to fix VM bot.
TBR

R=jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//228323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34895 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:46:57 +00:00
pquitslund@google.com 3edb0efcf4 Fix constructor initializer space conventions (dartbug.com/17642).
R=scheglov@google.com

Review URL: https://codereview.chromium.org//231743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34893 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:25:36 +00:00
scheglov@google.com e5652e0e90 New analyzer snapshot with MapIterator.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//229653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34891 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:18:01 +00:00
brianwilkerson@google.com b4cdb0dc98 Add new performance option to get both cold and warm timings.
@Rico: Does it matter that the errors will be written between the two sets of timings?

R=scheglov@google.com

Review URL: https://codereview.chromium.org//227533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34817 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:08:36 +00:00
scheglov@google.com bd532a6990 Correct or pause previous TimeCounters.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//225183020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34809 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 05:08:08 +00:00
scheglov@google.com 6da7a82a20 Fix for translation of \!= to \!identical(), but use == and \!= for Enum.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//221483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34636 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 03:09:22 +00:00
scheglov@google.com d5780f88b9 Rollback 215463002.
R=brianwilkerson@google.com, ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//215683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34491 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 23:57:32 +00:00
scheglov@google.com 5a9afd5f64 Move Dart-based analyzer script to packages.
Rico, can you please change the performance tool to use this pkg/analyzer/bin/analyzer script?

R=brianwilkerson@google.com, ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//215463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34483 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 21:38:35 +00:00
scheglov@google.com 1145c19860 Rollback pkg/analyzer that breaks code_transformers
R=blois@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org//214593008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34479 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 20:29:08 +00:00
scheglov@google.com 240b4138ce Translate Java enums to Dart constants.
1. Restore "this.field" field formal initializers.

2. Tweaks for several Java places - mostly to the constructors; but also duplicate HintCode messages (in Dart we cannot get values of constant values final fields).

3. Translate field that are not written to Dart final fields and also to field initializers, even if there are no property for them.

4. And constant enums.

5. pkg/code_transformers/test/resolver_test has to be skipped, I cannot fix it myself.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//214253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 15:37:37 +00:00
scheglov@google.com 920a3e9c23 Switch the command line Dart-based analyzer back to the synchronous API.
This improves timing for dart2js analysis from 8000 ms to 7700 ms (vs. 7300 ms for Java-based analyzer).

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//210463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34332 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:32:20 +00:00
scheglov@google.com eedaae10e6 Optimizations for hashCode.
This improves Dart-based analyzer performance.

dart2js:   12500 -> 11600 ms, about 900 ms or 7%.
blueshift: 23500 -> 21500 ms, about 2000 ms or 8%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 18:18:14 +00:00
scheglov@google.com 624addf47e Don't print TODOs in Dart based analyzer.
Java based doesn't print them too.

This improves dart2js analysis from 12500 to 11300 ms, i.e. about 1200 ms or 10%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34254 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 16:14:11 +00:00
brianwilkerson@google.com 8be101185a Fix analysis of parts
R=scheglov@google.com

Review URL: https://codereview.chromium.org//200783006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34253 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 16:10:17 +00:00
scheglov@google.com d12545d5fa New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34227 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 05:09:57 +00:00
brianwilkerson@google.com 3185364c4e Partial fix for AST cloning. This change won't get made by the translator, but you might want to just copy it into the CL with translator changes in order to reduce the number of times we have to increment the version number.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//205243008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34202 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 20:33:50 +00:00
scheglov@google.com 5edf555a9a New analyzer snapshot.
R=blois@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//197213036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34188 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 17:38:28 +00:00
jwren@google.com e5ae9bf8ff Update package version for analyzer.dart for the args pub package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//205183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34136 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 20:47:06 +00:00
sigmund@google.com 56334078ae Fix analyzer and code_transformers versions
R=blois@google.com

Review URL: https://codereview.chromium.org//195893046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34127 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 18:15:44 +00:00
blois@google.com 2c034bfe3f Updating code_transformers to not fail on syntax errors
Recent changes started using the Analyzer's parseCompilationUnit method which throws exceptions on syntax errors, but this is undesirable in many cases. Adding an option to disable this behavior and using that in code_transformers.

BUG=
R=scheglov@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//204033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34070 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:09:17 +00:00
jwren@google.com ed38678776 Collect analysis errors from change notifications.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//202633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33780 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 22:14:25 +00:00
jwren@google.com c3cb70a124 Fix batch mode to now print out errors, this gets us closer to the FYI bot passing
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//200423006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33725 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 22:20:44 +00:00
scheglov@google.com d160c5b259 Forgotten change in analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//200613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33711 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:44:39 +00:00
jwren@google.com b3be009788 Restore batch mode in the Dart-based Dart analyzer
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//200523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33709 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:09:22 +00:00
scheglov@google.com 206c643c4e Analyzer snapshot with disabled 'this.field' generation.
This should help to workaround https://code.google.com/p/dart/issues/detail?id=17483 is Spark.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//200583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33708 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 18:22:14 +00:00
jwren@google.com c89d80e9e8 Addtional tests in options.dart to cover 'log' case, and other missed flag tests as they were added.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//199543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33668 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 21:51:13 +00:00
jwren@google.com b39018a1ba New verbose flag for the dart command line analyzer
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//196223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33656 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 17:13:09 +00:00
scheglov@google.com b058e9b442 New analyzer snapshot.
It includes optimization that Jaime made today.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//198453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33636 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 06:34:29 +00:00
pquitslund@google.com 8a54c6f9d2 Fix handling of 'else if' statement blocks (dartbug.com/17363).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//196983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33613 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 21:11:30 +00:00
jwren@google.com 84de116968 Nit change in the Dart command line analyzer and analysis server.
Logger.logError takes a String, not Error types.  This will enable the exception to be printed, instead of the message '<SomeError> is not a String'.

Also, in the command line version of the dart analyzer, I put in a commented out stdout/stderr logger for developers.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//196373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33587 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:30:23 +00:00
pquitslund@google.com 979ef447b0 Formatter space/tab width configuration fixes (dartbug.com/16969).
R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//196243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33586 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:25:45 +00:00
jwren@google.com 978872b5ad Convert the command line dart analyzer to be async.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//195483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33558 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 22:05:37 +00:00
scheglov@google.com f68715dd64 Increase Dart based command line analyzer cache size to 512.
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//195563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33554 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 21:07:57 +00:00
danrubel@google.com 02f702ee9e add indent option to cmdline formatter
BUG=dartbug.com/16991
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//189063006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33528 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 14:29:15 +00:00
scheglov@google.com 0d6637eb53 Translate Java's @Override into Dart's @override.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//192363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 02:20:23 +00:00
scheglov@google.com 34255da9a2 Support for @DartName and @DartOptional annotations.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//192303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33472 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 01:12:42 +00:00
scheglov@google.com 844751f9ed Support for DartBlockBody, DartExpressionBody, DartOmit in java2dart.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189433006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33468 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:53:28 +00:00
jwren@google.com dbed544450 Analzyzer test fixes
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//189443009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33464 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:18:17 +00:00
scheglov@google.com a674327095 Translate private Java members to private Dart members.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33453 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:59:57 +00:00
jwren@google.com f4a2d2ae9b Change to dart command line analyzer- Remove the rich toString in AnalyzerError to prevent .contents from being called on a source.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//189913004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33452 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:55:25 +00:00
scheglov@google.com 151c4c3a7d Improved 'has' properties translation.
New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33399 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:18:26 +00:00
scheglov@google.com 9d622fc1d9 Unroll 'synchronized {}' in java2dart.
...and corresponding 'analyzer' snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//185403018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 02:30:21 +00:00
scheglov@google.com 12558a8511 New analzyer snapshot.
Replace isInstanceOf() with a predicate.

Tweaks for other packages.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//186153005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:50:40 +00:00
scheglov@google.com 1f8c20a04d Update and analyzer snapshot with AST -> Ast rename.
R=brianwilkerson@google.com, rnystrom@google.com, blois@google.com, karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//185603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33296 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 20:02:28 +00:00