7d956b24df
pkg/collection: define delegating collection constructors as const
...
Allows creating a singleton const instance for common values
R=lrn@google.com
Review URL: https://codereview.chromium.org//252133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35517 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 09:42:40 +00:00
def72d3fd4
Update status after updating firefox to v28 on linux
...
Review URL: https://codereview.chromium.org//260303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35514 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 06:36:50 +00:00
b6c9989ff5
Allow a NumberFormat to be passed a currency name/symbol at creation
...
BUG=https://code.google.com/p/dart/issues/detail?id=18499
R=efortuna@google.com
Review URL: https://codereview.chromium.org//259093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35496 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 20:46:18 +00:00
d460d7d9f9
Use UnmodifiableMapView in compiler
...
Redo of https://code.google.com/p/dart/source/detail?r=35379
Which was reverted in https://code.google.com/p/dart/source/detail?r=35381
R=herhut@google.com
Review URL: https://codereview.chromium.org//258753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35482 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 13:12:03 +00:00
496aa45ed1
New analyzer snapshot. Sorted unit members.
...
New Character utilities.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//259773005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35468 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 22:37:24 +00:00
77fbba6bf0
Translate parts of engine.services project.
...
Some tweaks for Java implementations to get valid or better Dart code.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//250823006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35466 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 19:01:13 +00:00
64481d6783
Undo skip, tests now pass
...
BUG=http://dartbug.com/18447
R=leafp@google.com
Review URL: https://codereview.chromium.org//259923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35454 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 23:09:59 +00:00
26068ad107
Move conditional skip after unconditional skips
...
TBR=iposva@google.com ,leafp@google.com
Review URL: https://codereview.chromium.org//252583006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35449 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 21:42:07 +00:00
99e84132c6
- Skip pkg/polymer tests.
...
Review URL: https://codereview.chromium.org//251683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35442 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 19:47:16 +00:00
5e718a35d0
verifyNoMoreInteractions() and verifyZeroInteractions()
...
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//250813003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35441 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 19:18:28 +00:00
424b56b16c
Add a Cascade helper to Shelf.
...
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//258633006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35437 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 18:24:30 +00:00
3c27e52cbb
Make sure handler errors won't bring down a shelf server.
...
Also add more documentation to the README.
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//252393007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35436 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 18:16:38 +00:00
ceb5f9858e
Upgrade analysis server to use analyzer-0.14.2
...
This picks up the fix for dartbug.com/18379, so source strings are
correctly encoded now.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//250963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35432 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 16:58:42 +00:00
d0763d1997
verify() for mocks
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//257783005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35428 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 16:14:18 +00:00
0af02e38a1
Comment out generated resolver tests (TBR).
...
Review URL: https://codereview.chromium.org//252723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35427 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:38:43 +00:00
6c000ea2cb
New analyzer snapshot, based on r35422.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//257773008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35426 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:18:19 +00:00
c846bdd7c6
Restore thenReturnList().
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//251733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35423 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 14:05:25 +00:00
7166546aaa
Argument matchers for mocks.
...
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//255503005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35415 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 23:49:37 +00:00
1544c07521
Typed mocks library.
...
R=danrubel@google.com , brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//252463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35399 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 20:22:42 +00:00
1c873d4a38
Use @MirrorsUsed to prevent analysis server tests from slowing down in dart2js.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//254533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35396 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 20:11:26 +00:00
0b63b64bc5
Mark analysis server tests as slow under dart2js (TBR).
...
Because of the use of mocking, analysis server tests are very slow
with dart2js. Go ahead and let them timeout.
Review URL: https://codereview.chromium.org//251563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35385 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 17:27:09 +00:00
9271ac7a8f
Rework some analysis server tests using mocks.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//252373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35374 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 15:05:11 +00:00
5d44255126
Trigger analysis when context.applyChanges request is received.
...
With this change, the analysis server is now capable of analyzing a
source file and responding with error notifications.
R=jwren@google.com
Review URL: https://codereview.chromium.org//246013007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35373 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 14:58:15 +00:00
629a132ab1
Mark angular_todo as failing when using the repository packages.
...
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//254443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35370 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 13:33:40 +00:00
a59818ea8b
Revert "Update all Angular libs (run update_all.sh)."
...
This reverts r35366.
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//256553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35367 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 12:29:05 +00:00
c9013a859f
Update all Angular libs (run update_all.sh).
...
R=ricow@google.com , blois@google.com
BUG=
Review URL: https://codereview.chromium.org//257423008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35366 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 11:34:18 +00:00
2a93b93c1c
Remove unmodifiable map wrappers that could instead use UnmodifiableMapView.
...
R=sgjesse@google.com
Committed: https://code.google.com/p/dart/source/detail?r=35244
Review URL: https://codereview.chromium.org//214723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35361 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 08:51:41 +00:00
13e6aefffa
Mark polymer/test/build/script_compactor_test as slow.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//258603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35357 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 08:25:13 +00:00
138d51829f
Move common streams in barback to their own class.
...
This cleans up some duplication and will make it easier to change or
add common streams in the future.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//249183005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35341 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 22:58:50 +00:00
f6e23765e6
Fix analyzer errors in the http_parser web socket test.
...
R=kevmoo@google.com
TBR
Review URL: https://codereview.chromium.org//247893005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35331 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 21:05:49 +00:00
1c9e292b2c
Re-apply "Add a non-dart:io WebSocket implementation to http_parser."
...
Re-apply "Fix an analyzer error in http_parser's WebSocket implementation."
This also marks the web socket test as failing on dart2js nad the browser.
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//250073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35330 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 20:53:17 +00:00
22ee284c47
Serialize AnalysisErrors to JSON in the analysis server.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//247893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35329 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 20:35:43 +00:00
2424320373
Don't make assumptions about source encoding in analysis server tests (TBR).
...
On Windows, the encoding of an absolute path like "/foo.dart" contains
a drive letter (e.g. "102file:///e:/foo.dart"); on Mac and Linux it
doesn't. Call ".encoding" from the test so that we don't depend on
the specific file name encoding in use.
As a side benefit, this makes the test independent of bug 18379.
Review URL: https://codereview.chromium.org//247143009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35327 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 20:02:18 +00:00
19572ac352
Use AnalysisServer.running only to track whether server has been shut down.
...
Previously, AnalysisServer.run() and AnalysisServer.performTask() also
tried to use this variable to track whether there was a pending call
to performTask() on the event queue. The resulting confusion
prevented analysis from ever running.
It turns out that we don't need to separately track whether there is a
pending call to performTask(), as long as we enforce the invariant
that there is a pending call to performTask() exactly when
contextWorkQueue is non-empty.
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//246603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35323 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 18:35:58 +00:00
d77b7e50a2
Support unmapped areas in source maps.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//237123003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35307 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 07:57:14 +00:00
0ee8654ab7
Revert "Add a non-dart:io WebSocket implementation to http_parser."
...
Revert "Fix an analyzer error in http_parser's WebSocket implementation."
TBR=nweiz@google.com
Review URL: https://codereview.chromium.org//248463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35297 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 03:39:30 +00:00
8ecdcb71a7
pkg/docgen: skip tests on arm and mips
...
BUG= https://code.google.com/p/dart/issues/detail?id=17003
R=alanknight@google.com
Review URL: https://codereview.chromium.org//247313005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35291 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:55:31 +00:00
5738fa910b
Fix an analyzer error in http_parser's WebSocket implementation.
...
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//247003008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35288 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:02:29 +00:00
16e6f87073
Add a non-dart:io WebSocket implementation to http_parser.
...
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//247313006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35287 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 23:40:26 +00:00
862e9b046e
pkg/docgen: fix type warnings
...
BUG= https://code.google.com/p/dart/issues/detail?id=18232
R=alanknight@google.com
Review URL: https://codereview.chromium.org//247973004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35286 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 22:52:30 +00:00
4476df500e
Fix barback test failures.
...
The timing changes caused by allowing transformers to return
non-Futures tickled a race condition in the tests for running
declaring transformers eagerly. This avoids that race condition by
ensuring that the transformers are fully declared before any assets
are requested.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//247813004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35283 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:44:47 +00:00
ff0a4d93bb
pkg/docgen: update test for broken doc comment lookup under typedef
...
Related to https://code.google.com/p/dart/issues/detail?id=18352
R=alanknight@google.com
Review URL: https://codereview.chromium.org//247903003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35282 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:34:34 +00:00
4f4507b9ef
Fix for 14221/ 15553/ 16673- X isSubtypeOf E now returns false when X is some type and E is a type parameter. This fixes a few issues, but also breaks some assertions (language tests that now have valid warnings from the analyzer).
...
Additional work will need to be done to fix the language tests, and to investigate the case of X isSubtypeOf E where X is of type Type.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//247313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35281 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:07:54 +00:00
e1ebd97e7c
Don't require Transformer methods to return Futures.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//243793005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35280 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 19:59:26 +00:00
d30621796b
Run declaring transformers eagerly if possible, even if their inputs are deferred.
...
R=rnystrom@google.com
BUG=18270
Review URL: https://codereview.chromium.org//243103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35279 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 19:49:41 +00:00
89c918f8f4
New analysis services snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//247813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35271 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 17:30:49 +00:00
d1cc18b5e1
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//247053004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35270 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 17:10:47 +00:00
e14efea977
Only list dart files in pkg files dependency
...
Review URL: https://codereview.chromium.org//246253005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35257 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 13:31:48 +00:00
dcf45d898e
Fix mac gyp generation by moving target to seperate file.
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//247273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35256 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 13:01:48 +00:00
5080e18fc4
Create targets for dart2js files, pub files, pkg files.
...
We are seeing issues on mac 10.7 where the list of inputPaths in xcode files becomes to long (this is also dependent depth of your build directory).
The build silently fails without giving any error.
BUG:18333
Also see:
http://build.chromium.org/p/client.dart/builders/dart2js-safari-mac10.7-1-3-be/builds/4640/steps/Build%20SDK/logs/stdio
R=ahe@google.com
Review URL: https://codereview.chromium.org//247073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35255 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 11:34:13 +00:00
kevmoo@google.com