dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
105,566 Commits 2 Branches 0 Tags
a4a4ca8a412262c0b47c31fbd4235af309ddec00
Commit Graph

105566 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nate Biggs a4a4ca8a41 [dart2wasm] Dynamic modules 
Missing from this implementation:
- Closure/dynamic calls with differing signatures
- Overrides with extra optional parameters
- Records with same shape defined in different dynamic modules
- Avoiding running TFA on dynamic module.
- Recompilation of only updateable functions from main module.
- Persist wasm def types from main module.

Testing is currently done locally via the dynamic_modules package test suite:
dart pkg/dynamic_modules/test/runner/main.dart --runtime=dart2wasm

Immediately after this lands we can introduce a new step to one of the wasm test matrix configurations that runs the above test suite (the VM has a similar configuration).

Change-Id: I3386d84be11b773842d45f4268a62a54c47e352b
Tested: Tested via new tests in dynamic_modules package. Tests run locally but will add to existing config.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397721
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2025-02-11 13:59:46 -08:00
Devon Carew aec2f8cd89 [deps] bump dart-lang/tools 
Change-Id: I9cc3db7cada038221e194037c853e6a65072a08b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408885
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
 2025-02-11 13:13:12 -08:00
Ryan Macnak 5c6f92fe47 [test] Unskip many tests in reload stress testing. 
Change-Id: I9ef008b00bb043b210d18659a49ee07fde081f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409202
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2025-02-11 12:49:41 -08:00
Alexander Aprelev 413d9e9be4 [vm] Fix liveness calculation to correctly account for try-catch flow. 
Ensure that liveness analysis as part of register allocation takes into account try-catch implicit data flow.

Fixes https://github.com/dart-lang/sdk/issues/60017
TEST=nested_try_throw_environment_test

Change-Id: I6013942f8f4b78655938765e11859008c28cb9e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408421
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2025-02-11 12:23:19 -08:00
Nicholas Shahan 39c60997ec [ddc] Add initial hot reload metadata 
* Demonstrates the ability to generate metadata when inspecting the
  last accepted and delta components.
* Attach the metadata to the component right before compiling with DDC.
* Use the metadata to avoid deoptimizations in the initial compile
  when they are only required to support a hot reload.
  * Deletion of all type rules for classes that extend Object in the
    initial compile. In the future this should be reduced further to
    only the classes that had a hierarchy change in a hot reload.
  * Type checks on the return value of getters used to represent
    fields.

Change-Id: I2812b564bc3f4d72f005d4bd11fa55ec0eb394ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404940
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2025-02-11 12:04:50 -08:00
Martin Kustermann e072cdb204 [vm] Add test to ensure class hierarchy is present in output of analyze_snapshot 
go/dart-ama

Change-Id: I533ca49d0e27a59f2f2763cc14c69485a470c281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408561
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2025-02-11 11:40:24 -08:00
Ryan Macnak fc34e6ec9d [test] Skip named_pipe_script_test in reload stress testing. 
It's not possible to re-read source from a pipe.

Bug: https://github.com/dart-lang/sdk/issues/36254
Change-Id: I22cafd5ce0eaadc7d3d172219cb5cb8bbed27f91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409201
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2025-02-11 10:38:49 -08:00
Konstantin Shcheglov 1432e309a5 Elements. Migrate FieldNameNonPromotabilityInfo. 
Change-Id: Ib7f566f3ff93e3a1eee66df7af1cb8639f0cac7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409200
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-02-11 10:27:43 -08:00
Konstantin Shcheglov ff3cd6bb6b Elements. Migrate UnknownInferredType. 
Change-Id: I20bfdc150511f4c50762be3b06db168d933134e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-02-11 10:24:42 -08:00
Konstantin Shcheglov 1a057e0a03 Elements. Migrate RecursiveTypeVisitor. 
Change-Id: I3d94c61f0e73973b53ca3cf1f19ba28e9f993a39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-02-11 10:19:39 -08:00
Konstantin Shcheglov d87c88aa7a Elements. Migrate ElementResolver. 
Change-Id: I69da244e10f913bebed2e14bf5b0e471da39ec0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408923
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-02-11 10:16:39 -08:00
Alexander Markov ce600d0f50 [vm] Fix TSAN data race when accessing Thread::top_ 
This is a possible fix for the following benign TSAN error:

WARNING: ThreadSanitizer: data race (pid=40436)
  Read of size 8 at 0x7b7c000bfa48 by thread T6 (mutexes: write M0):
    #0 dart::Page::object_end() const out/ReleaseTSANX64/../../runtime/vm/heap/page.h (dart+0x25ade83)
    #1 dart::Page::used() const out/ReleaseTSANX64/../../runtime/vm/heap/page.h:107:34 (dart+0x25ade83)
    #2 dart::SemiSpace::used_in_words() const out/ReleaseTSANX64/../../runtime/vm/heap/scavenger.h:46:18 (dart+0x25ade83)
    #3 dart::Scavenger::UsedInWords() const out/ReleaseTSANX64/../../runtime/vm/heap/scavenger.h:157:17 (dart+0x25ade83)
    #4 dart::GetProcessMemoryUsageHelper(dart::JSONStream*)::$_0::operator()(dart::IsolateGroup*) const out/ReleaseTSANX64/../../runtime/vm/service.cc:4729:50 (dart+0x25ade83)

  Previous write of size 8 at 0x7b7c000bfa48 by thread T9:
    #0 dart::Thread::set_top(unsigned long) out/ReleaseTSANX64/../../runtime/vm/thread.h:698:34 (dart+0x2622071)
    #1 dart::Scavenger::TryAllocateFromTLAB(dart::Thread*, long) out/ReleaseTSANX64/../../runtime/vm/heap/scavenger.h:256:13 (dart+0x2622071)
    #2 dart::Scavenger::TryAllocate(dart::Thread*, long) out/ReleaseTSANX64/../../runtime/vm/heap/scavenger.h:139:12 (dart+0x2622071)
    #3 dart::Heap::AllocateNew(dart::Thread*, long) out/ReleaseTSANX64/../../runtime/vm/heap/heap.cc:84:27 (dart+0x2622071)
    #4 dart::Heap::Allocate(dart::Thread*, long, dart::Heap::Space) out/ReleaseTSANX64/../../runtime/vm/heap/heap.h:87:16 (dart+0x2416cab)

TEST=ci

Change-Id: Id9077cff2c1143adf999b2b26c941701d63cd844
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409180
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2025-02-11 09:39:20 -08:00
Konstantin Shcheglov 0c412862d8 Elements. Migrate RenameImportRefactoringImpl. 
Change-Id: I0e295b36fdc6c9e47c3cf5b0e648891d12fad031
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-02-11 08:59:50 -08:00
Danny Tuppeny e758dffdbb [analysis_server] Add missing bool completions for strict language options in analysis_options 
Fixes part of https://github.com/dart-lang/sdk/issues/59827, but not the main issue.

Change-Id: I7f9d6cfd5163a1bf6c72f9eea4bb71872d3dfa15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-02-11 08:27:51 -08:00
Robert Nystrom 334152ab23 Format tests/language/o*. 
Lot of trailing commas and filling in some unspecified errors.

Change-Id: Ia231b7cde0b91b45362b1e6b8fd0c86dcf093eed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408888
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2025-02-11 08:09:22 -08:00
DEPS Autoroller 7af1b8b1be Roll Fuchsia SDK from 27.20250204.4.1 to 27.20250211.1.1 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Ief62b7558d2b66f9ad91fe7ca62d1a80716197c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409040
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zijie He <zijiehe@google.com>
 2025-02-11 07:19:09 -08:00
Sam Rawlins 50c1d9e1a3 analyzer: Fix remaining comment reference issues 
Change-Id: I345c8d25e9f27dedffc596a2040cd89e059eb46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-02-11 07:12:20 -08:00
Chloe Stefantsova 014cda46e0 [cfe] Remove more nullability-based reasoning from shape checks 
Closes https://github.com/dart-lang/sdk/issues/60076

Change-Id: Ia32f12be5399ae1a04243fb69a28541df98ede5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408800
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2025-02-11 04:26:25 -08:00
FMorschel 2eec09dcd4 [DAS] Makes EXTENSION_DECLARES_INSTANCE_FIELD trigger on all field names 
R=jensj@google.com, paulberry@google.com

Fixes https://github.com/dart-lang/sdk/issues/59847

Change-Id: Ic4b41973d0d74d809d813ba57b85f50fab4c9a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407080
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2025-02-11 03:15:31 -08:00
Martin Kustermann a14aa2612c [web] Roll jsc version with WasmGC bugfixes 
Issue https://github.com/dart-lang/sdk/issues/60045

Change-Id: I3772c2b326299e1b913c3973927ce5d806b6d789
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409060
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2025-02-11 01:25:46 -08:00
David Morgan 92720c40e4 [analyzer] Accept optional FileContentCache in build_resolvers.dart. 
The default `FileContentCache.ephemeral` reads files as bytes then
converts them to `String` and hashes them. `build_runner` does the
same, so by injecting a `FileContentCache` it can deduplicate the
work.

R=scheglov@google.com

Change-Id: Id046fee8c98263719098c77981bbe10bd1b84658
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408701
Commit-Queue: Morgan :) <davidmorgan@google.com>
Auto-Submit: Morgan :) <davidmorgan@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-02-11 00:42:53 -08:00
Robert Nystrom 1c24e58896 Format tests/language/m*. 
Change-Id: I325ac267e5d1d1beb882e7cf08bbd7bfb99138ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408980
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
 2025-02-11 00:23:41 -08:00
FMorschel 3f71a43464 [DAS] Adds new fix for importing multiple names in combinantors 
R=srawlins@google.com

Fixes https://github.com/dart-lang/sdk/issues/56608

Change-Id: I3f48517b927aeaa3c410b6f04fcf75b3beead923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399021
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-02-10 23:51:30 -08:00
Nate Biggs 4dd1522635 [ddc] Add tests for '--reload-delta-kernel' and '--reload-last-accepted-kernel' flags. 
Change-Id: I643957dcd8cc6611108c9ff67a9610bb19475af4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408924
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2025-02-10 17:29:21 -08:00
Nicholas Shahan 16960a8638 [tests] Fix tests for changing type parameters 
* Handle inconsistencies in the type of a notice in reload reports.
* Update expected error messages when the type parameters of a class
  change.
* Fail reload tests if rejection error was expected but the actual
  error is null.
* Cleanup unused imports in tests.
* Delete change_instance_format7 test because it was split into DDC
  and VM specific versions.

Change-Id: I3b4d6cb3126d7c1fad688c393677e053a005687f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408883
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2025-02-10 16:26:00 -08:00
Ryan Macnak 9e8a21bf52 [vm] Improve the hash for function type parameters. 
AOT compiling the isolate stress test spends the majority of its time canonicalizing function types.

In release mode, 2:45 -> 1:43 (-38%)

TEST=ci
Change-Id: I58ef0157612930d582784c7bea7de177c1219a0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408941
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2025-02-10 16:02:30 -08:00
Ryan Macnak 4cf27cc968 [vm, compiler] Fix assert assembling add/subs with extended register. 
This is not symmetric with add/sub, accepting ZR instead of CSP.

TEST=vm/cc/Assembler_CmpExtReg, dartfuzz
Bug: https://github.com/dart-lang/sdk/issues/60092
Change-Id: Icc24f7883a113eac504fd8fc29c0d6f781cb7657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408901
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2025-02-10 15:16:50 -08:00
pq d21fd1ff4b [PE] document registerFixForRule 
Change-Id: Ie0f2f9bd85207ec6a25d881fbd8182c6506620f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408884
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-02-10 15:01:19 -08:00
Ryan Macnak d9503428fa [vm, reload] Restore assertion that the reload context is gone before shutdown. 
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/32796
Change-Id: Idae5f2240af6069bf5bb4f1bb5868b2f39cead3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408202
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2025-02-10 14:36:31 -08:00
pq 4d1b785239 [productivity] add “current file” launch configs 
Bug: https://github.com/dart-lang/sdk/issues/60070
Change-Id: I003a492e6004d2dcaf6c2c52688c733d7f43e53c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408900
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-02-10 14:31:52 -08:00
Konstantin Shcheglov 3672b4e5ac Elements. Migrate NamedTypeResolver. 
Change-Id: I310115b805f97bfdb384cb14b2bf9ab7ef0c898f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408920
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-02-10 12:58:04 -08:00
Jake Macdonald e6df5493c9 support renamed parameters when adding super calls 
Bug: https://github.com/dart-lang/sdk/issues/59745
Change-Id: I177e4f748954ddfea1b300085800c8c9a87bed3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408840
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-02-10 12:48:10 -08:00
Devon Carew ddfd4604dc Bump protobuf to d00f905450c562493d918884e02048b7aacc00a3 
Changes:
```
> git log --format="%C(auto) %h %s" b7dd58c..d00f905
 https://dart.googlesource.com/protobuf.git/+/d00f905 Fix slow handling of protobuf comments (955)
 https://dart.googlesource.com/protobuf.git/+/12f0f4a Fix formatting of benchmarks/lib/readfile.dart (956)
 https://dart.googlesource.com/protobuf.git/+/da083a3 Fix Wasm benchmarks (954)
 https://dart.googlesource.com/protobuf.git/+/06accdd Bump SDK dependency to 3.3.0, replace removed `dart:typed_data` type in test code (953)

```

Diff: https://dart.googlesource.com/protobuf.git/+/b7dd58cdbd879beee4c3fbf8ee80fce8e97bad26..d00f905450c562493d918884e02048b7aacc00a3/
Change-Id: Id627d405a531822fcecb602f455b142db55395c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408862
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
 2025-02-10 12:28:12 -08:00
Matthew Nitschke 64e60fedac Fixed 'order' node typo in split_constraints documentation 
Closes https://github.com/dart-lang/sdk/pull/60091

GitOrigin-RevId: 3e4a62f56820c02997ea78cfb95ef5b632cc12af
Change-Id: Ie5b0adfdf4bc05435e0d5f07dc6ae36b1d413f76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408881
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2025-02-10 12:04:07 -08:00
DEPS Autoroller 5aab9adb21 Roll BoringSSL from 6b1c6f324d49 to 0147d7f28324 (1 revision) 
https://boringssl.googlesource.com/boringssl.git/+log/6b1c6f324d49..0147d7f28324

2025-02-08 felobato@google.com HPKE DHKEM-P256 BoringSSL Rust

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I55b09084d3efe7c8b30f80d09b4c40fb3d0cdbe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408583
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2025-02-10 11:00:49 -08:00
Devon Carew e4be14bc28 [deps] rev core, http, test 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/2458e1a..a896913):
  a8969137  2025-02-06  Devon Carew  normalize the workflow files (dart-lang/core#857)

http (https://github.com/dart-lang/http/compare/c7cc4f8..b7cdf61):
  b7cdf61  2025-02-07  Vladislav  Fix Default Encoding for application/json Content-Type in HTTP Responses (dart-lang/http#1422)
  aadf836  2025-02-05  Brian Quinlan  Use the same Java/Kotlin versions as the flutter android template (dart-lang/http#1708)
  2e1a9a6  2025-02-05  Brian Quinlan  Upgrade to `jni`/`jnigen` 0.14.0 (dart-lang/http#1707)

test (https://github.com/dart-lang/test/compare/2ccfc5c..17609bf):
  17609bf9  2025-02-07  Kevin Moore  [test] allow the latest version of pkg:shelf_web_socket (dart-lang/test#2457)
  73d629d2  2025-02-06  Kevin Moore  Enable and fix unnecessary_ignore lint (dart-lang/test#2456)

Change-Id: Ie9f773289e94f04caeab10fb4902f78443292705
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408861
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
 2025-02-10 10:40:50 -08:00
Danny Tuppeny 3ded147e2e [analysis_server] Make format of LSP completion tests more consistent 
No functional changes here, only formatting/code style:

- Remove additional intending from embedded code in some tests (which didn't match others in this file or the style of other tests in the server)
- Change expression-bodied-tests to block bodies where they're not on a single line

Change-Id: I2c15bbcf7b7accff85f34a4e9ad5afa3e0a0a221
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2025-02-10 10:27:40 -08:00
Konstantin Shcheglov a0bc103d64 Elements. Migrate TypePropertyResolver. 
Change-Id: Id7d76e4318c429fe8aab2661fa33e618e501200e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408720
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-02-10 09:47:44 -08:00
Ryan Macnak 2a08770912 [vm] If waiting for an active mutator slot for too long, steal a slot from a thread at a native safepoint. 
The thread whose slot was stolen will take the slow path attempting to exit its safepoint and wait to reacquire an active mutator slot.

TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/54687
Change-Id: I49c4c12b38d38d7afa4df6b346c2a464f75ef6e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406404
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2025-02-10 09:38:42 -08:00
Johnni Winther a78235cf01 [cfe] Create constructors through fragments 
Change-Id: If2a7095c09dcf2d73d326b6ba6d796acfa882c55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408780
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2025-02-10 07:09:07 -08:00
Martin Kustermann 3b750c5545 [dart2wasm] Generate *.support.js feature detection files 
The file will contain a JS expression that evaluates to a boolean.
If it (at runtime) evalutes to

  * `true` it means that all required features are supported by the JS
    environment and the dart2wasm-compiled app can be used

  * `false` it means some features were not present in the JS
    environment and the dart2wasm-compiled app shouldn't be used,
    instead a dart2js fallback may be used

We introduce this mechanism to allow users, at compilation time, to tell
dart2wasm to take advantage of new spec features and allow the runtime
to self-detect whether they are available and fallback to dart2js if
not.

The first feature we introduce (already in this PR) is
`--require-js-string-builtin` that will tell dart2wasm it can assume the
`js-string` builtin is available (and emit corresponding `*.support.js`
code to detect it).

If the flag was passed, we take advantage of the `js-string` import
mechanism for string constants that doesn't require emitting them in the
mjs file (which significantly reduces code size and improves startup
time - compared with emitting JS strings in the mjs file).

We enable `--require-js-string-builtin` on one CI configuration for
testing that if we don't use any polyfill, the imports of the builtin
functions as well as magical utf8-encoded wasm imports work.

We also use a template mechanism to generate `*.mjs` as the code
becomes more readable (e.g. to conditionally include the js string
polyfill)

Issue https://github.com/dart-lang/sdk/issues/59951

Change-Id: Ic7e7818a2d5269095935022941352beeb9fed731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408781
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2025-02-10 06:17:49 -08:00
Keerti Parthasarathy 0246cc613f [Completion] Show enum constants when completion is in the declaration. 
Fixes https://github.com/dart-lang/sdk/issues/56971

Change-Id: Ib33a58e774f5540c426f5d5ffb7a387414dcf9f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2025-02-09 22:41:31 -08:00
Sam Rawlins 093ab49d6f DAS: Correct several broken comment references 
Change-Id: Id0e80d5566a5c05296a5941746888a48284c4ae0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407861
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-02-09 08:40:07 -08:00
Sam Rawlins 03c0855f9d DAS: Tidy snippet_producer.dart 
While fixing the doc comments for DartSnippetProducer.addImports, I
saw that it references two methods only found in the subclass,
FlutterSnippetProducer ("Adds public imports for any elements fetched
by [getClass] and [getMixin]").

It turns out that the `addImports` method and the `requiredElementImports` are only needed in the subclass,
FlutterSnippetProducer, so I just moved them over. Now the doc
comment references resolve correctly.


Change-Id: Id90e8257b4096308b8cd3ce19b14708ca1b5e365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-02-09 08:30:03 -08:00
Kevin Moore 143dc05381 [pkg:js] Clarify and improve discontinue message 
Add library-level docs duplicating the discontinue message

Related to https://github.com/dart-lang/sdk/issues/59716

Change-Id: Ib414a56c4412db0d9701c3d11f75354295775f9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408642
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
 2025-02-08 18:34:27 -08:00
Paul Berry 274f5639f7 [Flow analysis] Remove PropertyNotPromoted.staticType. 
This field was only used to populate expectation strings in "id"
tests; it did not affect any user-visible behavior of the analyzer or
CFE.

Including information in "id" tests that doesn't affect any
user-visible behavior isn't helpful. Removing this field will enable
some upcoming flow analysis refactoring work (I intend to remove the
`ExpressionInfo._type` field, replacing its remaining usages with a
more reliable mechanism).

Change-Id: Id4c6593fae4ef25b8c21f0625e6c1f9eaa766e17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406403
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2025-02-08 16:51:15 -08:00
Paul Berry eb5983869c [analyzer] Fix PartElementImpl.enclosingUnit. 
`PartElementImpl.enclosingElement3` has static type `Element?`, but in
practice it is always of type `CompilationUnitElementImpl`, due to
this code from `CompilationUnitElementImpl.parts=`:

    set parts(List<PartElementImpl> parts) {
      for (var part in parts) {
        part.enclosingElement3 = this;
        var uri = part.uri;
        if (uri is DirectiveUriWithUnitImpl) {
          uri.unit.enclosingElement3 = this;
        }
      }
      _parts = parts;
    }

Therefore, `PartElementImpl.enclosingUnit` can just cast
`enclosingElement3` to the proper type and return it.

This behavior was untested, so I've added a test in
`part_test.dart`. Without the fix, the test throws a `TypeError`.

Change-Id: I3e6f186826aa92cda9c3887c85c5eddc1fea7f31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408641
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-02-08 08:15:19 -08:00
DEPS Autoroller 4227821323 Roll BoringSSL from 8ec37a156c8a to 6b1c6f324d49 (7 revisions) 
https://boringssl.googlesource.com/boringssl.git/+log/8ec37a156c8a..6b1c6f324d49

2025-02-07 agl@chromium.org FIPS.md: update wording to align with FRR7.
2025-02-07 agl@chromium.org FIPS.md: add build instructions for the update stream.
2025-02-07 daniel@binaryparadox.net util/fipstools: KDA OneStepNoCounter mode support
2025-02-07 daniel@binaryparadox.net util/fipstools: generalize hkdf KDA subprocess
2025-02-06 davidben@google.com Add a missing word to documentation on the upstream stream
2025-02-06 agl@chromium.org Add a section on the latest FedRAMP policy to FIPS.md.
2025-02-05 dhuan@google.com Add CBS APIs for fetching an implicitly tagged int64/uint64 fields.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I96e8c5ec31f054af94558d213aa59eabd0306f7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408582
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2025-02-07 20:08:50 -08:00
DEPS Autoroller 77e2e9461a Roll Fuchsia Test Scripts from 2fowg5AX8Ry8Vf_Ku... to C6yhaOWh41d1qQqUX... 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia Test Scripts: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I781409d71b766b888eb531d0ca558c54787b1374
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407883
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
 2025-02-07 15:37:40 -08:00
Konstantin Shcheglov c3a4f56e69 Fine. Return from LibraryContext without logging if the cycle is already loaded. 
It writes too much, and with fine grained dependencies this is especially
prominent, we don't do analysis for most of files afterwards.

Change-Id: Idccef82f3b46980b6942c403871f588e21e128c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408680
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2025-02-07 15:24:49 -08:00