dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
45,113 Commits 2 Branches 0 Tags
91cf66ed5de50e7cdf5c429dc3306b00a67cc834
Commit Graph

13952 Commits

Author SHA1 Message Date
Konstantin Shcheglov 91cf66ed5d Fix for parsing empty compilation units with Fasta. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2738693003 .
 2017-03-07 09:48:29 -08:00
Konstantin Shcheglov 7aa9b301e5 Fix for 'const C.named()' type inference when 'C' is resolved and has type parameters, but 'named' is unresolved. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2735033002 .
 2017-03-07 08:49:05 -08:00
Brian Wilkerson 0fa6715bd8 More support for generic function types 
Review-Url: https://codereview.chromium.org/2736643006 .
 2017-03-07 08:04:01 -08:00
Peter von der Ahé 2934dfaf16 Avoid crashing on function syntax. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2730093002 .
 2017-03-07 16:54:09 +01:00
Jens Johansen a58fe4898d [Fasta] include source code in dill 
At least for now, only when passing --include-source

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2729913005 .
 2017-03-07 15:48:25 +01:00
Claire Sarsam 1f8111e081 Fix typo in the MUST_CALL_SUPER hint message (#28971) 2017-03-07 06:32:44 -08:00
Peter von der Ahé b05dacd6f6 Add missing test from previous CL. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2728123002 .
 2017-03-07 14:57:47 +01:00
Peter von der Ahé ac9d87b707 Keep track of references to guide. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2739593004 .
 2017-03-07 14:50:57 +01:00
Peter von der Ahé 3835ccf907 One shared guide for diagnostics. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2718023003 .
 2017-03-07 13:44:39 +01:00
Jens Johansen 067b377a3c Mark new debugging stuff as flaky as it fails on mac/win/whatnot 
BUG=

Review-Url: https://codereview.chromium.org/2732973006 .
 2017-03-07 10:34:52 +01:00
Jens Johansen 9837563cd1 Kernel debugging; service tests 
- Offsets on more stuff
- Status file for kernel
 -> Testing with (before fasta)
    ```
    python tools/test.py -mrelease -cdartk --no-tree-shake --no-dfe service
    ```
    now shows everything as passing.
    Reload stuff, and evaluation stuff (e.g.) has been disabled though.
- Lots of new service tests that tests what positions we stop at when
  saying next.

As fasta has now landed debugging does not currently work, but this is still needed in order to both test better and allow for proper kernel debugging support.

R=hausner@google.com, kmillikin@google.com

Review-Url: https://codereview.chromium.org/2680303002 .
 2017-03-07 09:43:59 +01:00
Stephen Adams bf9a4502c8 Tweak Florian's dart2js inlining heuristic change 
This CL updates https://chromiumcodereview.appspot.com/2558633007/

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2724473004 .
 2017-03-06 20:32:54 -08:00
Konstantin Shcheglov bf4dd380ea Fix for parsing 'rethrow' statement with Fasta. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2730293003 .
 2017-03-06 16:50:28 -08:00
Vijay Menon d5372c79ae Bump timeout 
This test seems to timeout often on travis lately.

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2731243003 .
 2017-03-06 16:45:59 -08:00
danrubel c354e26fb6 A/B fasta performance measurement harness 
Tweak and reapply https://codereview.chromium.org/2731703003/

Review-Url: https://codereview.chromium.org/2734863003 .
 2017-03-06 14:30:47 -05:00
Konstantin Shcheglov 262cee7864 Add support for parsing #void with Fasta. 
For the reason why we need this, see the following documents.
https://codereview.chromium.org//427603002
https://github.com/dart-lang/sdk/issues/20191
https://github.com/dart-lang/sdk/issues/19972

R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2737593002 .
 2017-03-06 11:24:54 -08:00
Konstantin Shcheglov 7c0a0f0f99 Fix tests for parsing literals. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2738453002 .
 2017-03-06 11:14:22 -08:00
Konstantin Shcheglov 3e4c4057cd Fix test for parsing 'await'. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2732023002 .
 2017-03-06 11:07:11 -08:00
Konstantin Shcheglov 2a60cbf9de Fix for parsing 'const X()' with Fasta. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2733913002 .
 2017-03-06 11:00:32 -08:00
Konstantin Shcheglov 05852a6625 Rename parser tests that use 'type arguments', but named 'type parameters'. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2738433002 .
 2017-03-06 10:03:54 -08:00
Konstantin Shcheglov b24ad2e168 Fix for a couple of cascade tests. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2729373004 .
 2017-03-06 09:40:02 -08:00
Vijay Menon 2acb2eb669 Update for latest tests and sdk 
TBR=leafp@google.com

Review-Url: https://codereview.chromium.org/2731333002 .
 2017-03-06 09:36:14 -08:00
Brian Wilkerson f645c34bb0 Add support for copying directory structures 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2733053002 .
 2017-03-06 08:51:40 -08:00
Konstantin Shcheglov 21f8fd8244 Fixes for map literal tests. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2731313002 .
 2017-03-06 08:51:12 -08:00
danrubel 8552edb9b3 Revert "A/B fasta performance measurement harness" 
This reverts commit 82685eacbf.

Review-Url: https://codereview.chromium.org/2733033002 .
 2017-03-06 10:59:51 -05:00
Konstantin Shcheglov be521515fe Parse #operator symbol literals with Fasta. 
R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2735623002 .
 2017-03-06 07:47:46 -08:00
danrubel 82685eacbf A/B fasta performance measurement harness 
Given two separate Dart SDK repo clones, A and B,
this pkg/front_end/tool/fasta/abcompile.dart harness
alternately runs

<A>/pkg/front_end/tool/fasta/compile.dart
then
<B>/pkg/front_end/tool/fasta/compile.dart

so that a performance comparison can be made of the difference
between fasta in A vs B.
For example, from the <A> root directory:

xcodebuild/ReleaseX64/dart
  -DbRoot=/path/to/2nd/dart/sdk/repo
  -Diterations=15
  pkg/front_end/tool/fasta/abcompile.dart
  --compile-sdk=xcodebuild/ReleaseX64/patched_sdk/
  pkg/compiler/lib/src/dart2js.dart
  --verbose

The output contains the raw data along with a summary
of the average difference, and is formatted in a way
that can be easily pasted into Google Sheets
for further analysis.

Future improvements to this include:

* Add JSON output to pkg/front_end/tool/fasta/compile.dart
  so that abcompile.dart is not text scraping the numbers

* Adjust pkg/front_end/tool/fasta/compile.dart so that --verbose
  is not needed to capture the needed numbers and progress

* tweak the A/B summary section to paste more easily
  into Google Sheets

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2731703003 .
 2017-03-06 10:09:45 -05:00
Dmitry Olshansky 8dda473a55 Improve fasta scanner performance 
Reorder cases in bigSwitch according
to frequency, reduce the number of
comparisons.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2711403002 .
 2017-03-06 11:35:28 +01:00
Konstantin Shcheglov 24d5466a72 Send error notifications only for files in analysis roots (and not excluded). 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2734673002 .
 2017-03-05 15:01:27 -08:00
Paul Berry a2c4fe177f Update .iml files. 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2734723002 .
 2017-03-05 11:58:36 -08:00
Konstantin Shcheglov 686a60aacf Verify resynthesized elements by comparing text presentations. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2728883004 .
 2017-03-03 18:26:16 -08:00
Brian Wilkerson 25989faf83 Support accessing the parameter element when there is no name 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2725013003 .
 2017-03-03 08:11:01 -08:00
Peter von der Ahé 3873b0fc83 Recover from bad supertypes. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2729943003 .
 2017-03-03 15:06:09 +01:00
Vyacheslav Egorov c0c87b0afd GN: change the way we specify dependencies for the patched_sdk target. 
Instead of listing all files as inputs in GN script using Python helper we make
patch_sdk.dart generate a depfile that Ninja can use:

            https://ninja-build.org/manual.html#_depfile

This prevents breakages when some dependencies are deleted and GN is not rerun.

R=ahe@google.com, kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2729503006 .
 2017-03-03 14:52:51 +01:00
Peter von der Ahé ff89087641 Recover correctly from this-parameter on non-constructors. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2727313004 .
 2017-03-03 12:40:30 +01:00
Peter von der Ahé 2af498fc84 Recover from missing arguments in new expression. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2730763002 .
 2017-03-03 10:31:19 +01:00
Jens Johansen f979537725 [Fasta] Include line starts 
BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2731633003 .
 2017-03-03 10:29:56 +01:00
Peter von der Ahé 790df00dc6 Recover correctly from empty optional parameters. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2725093003 .
 2017-03-03 10:26:13 +01:00
Peter von der Ahé 6f550ef4ea Correctly recover from incorrect imports, etc. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2725973004 .
 2017-03-03 10:10:00 +01:00
pq cc0036d5ad Calculate text ranges for default args. 
Continued work on generating sensible default contents for args in completions.

Calculated text ranges allow us to produce linked edits in the IDE.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2727343002 .
 2017-03-02 13:14:49 -08:00
Peter von der Ahé 7c0af354ed Skip bootstrap_test on bots that don't build the sdk. 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2725183002 .
 2017-03-02 16:54:22 +01:00
Peter von der Ahé bffd9e28ac Implement deps files in compile_platform.dart. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2730743002 .
 2017-03-02 16:15:42 +01:00
Peter von der Ahé 88a92f805a Move all main methods to tool/. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722223006 .
 2017-03-02 14:41:06 +01:00
Peter von der Ahé 628be2b36a Apply transformers and other work arounds to get boostrapping to work. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723173002 .
 2017-03-02 14:31:58 +01:00
Zhivka Gucevska 1b82e0c3a0 Initial implementation of interpreter for Kernel 
Basic framework, evaluation of BasicLiterals and dummy evaluation
of print.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2722283003 .
 2017-03-02 13:19:27 +01:00
Peter von der Ahé 6176847e36 Consolidate analyzer dependencies. 
This allows us to create a smaller .dill file for Fasta.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2723113002 .
 2017-03-02 12:59:47 +01:00
Peter von der Ahé 369c94815d Rename FeContext to FastaContext. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2726843003 .
 2017-03-02 12:38:32 +01:00
Peter von der Ahé c59ecd801c Remove package imports from itself. 
Without this, we risk creating two different libraries at runtime. One
named file:///something/ and one named package:front_end/something.
These libraries are different and if enums from one gets mixed with
the other, you get very confusing errors (to apparently identical enums
aren't equal).

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2726793003 .
 2017-03-02 12:34:46 +01:00
Jens Johansen 89b68e905b Set dartAsyncMarker the same as asyncMarker unless explicitly set 
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2728683005 .
 2017-03-02 11:13:38 +01:00
Martin Kustermann bd59a9724e Regenerate baseline files for kernel/test/baseline_strong_mode_test 
Review-Url: https://codereview.chromium.org/2731483002 .
 2017-03-02 11:06:43 +01:00