dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
45,113 Commits 2 Branches 0 Tags
91cf66ed5de50e7cdf5c429dc3306b00a67cc834
Commit Graph

45113 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantin Shcheglov 91cf66ed5d Fix for parsing empty compilation units with Fasta. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2738693003 .
 2017-03-07 09:48:29 -08:00
Vyacheslav Egorov f566a1e61c VM: Fix build on GCC which requires explicit initialization of the base class 
in the copy constructor.

TBR=fschneider@google.com

Review-Url: https://codereview.chromium.org/2738733002 .
 2017-03-07 18:24:18 +01:00
Lasse R.H. Nielsen 74a8351fb6 Add test for cancel-future being awaited after an await for. 
See http://dartbug.com/28974 (#28974)

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2734143002 .
 2017-03-07 18:05:36 +01:00
Konstantin Shcheglov 7aa9b301e5 Fix for 'const C.named()' type inference when 'C' is resolved and has type parameters, but 'named' is unresolved. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2735033002 .
 2017-03-07 08:49:05 -08:00
Vyacheslav Egorov da5cd4197a VM: Remove ZoneCompileType class. 
This auxiliary wrapper was introduced originally to work-around an assertion
in ZoneAllocated destructor which was preventing us from using descendants of
ZoneAllocated as value objects. That assertion was removed some time ago
which means ZoneCompileType is not needed anymore and CompileType can
become ZoneAllocated instead.

R=fschneider@google.com
BUG=

Review-Url: https://codereview.chromium.org/2739643002 .
 2017-03-07 17:29:02 +01:00
Brian Wilkerson 0fa6715bd8 More support for generic function types 
Review-Url: https://codereview.chromium.org/2736643006 .
 2017-03-07 08:04:01 -08:00
Peter von der Ahé 2934dfaf16 Avoid crashing on function syntax. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2730093002 .
 2017-03-07 16:54:09 +01:00
Dmitry Olshansky a1f784e643 Revert "Replacing TrySync with Metadata" 
This reverts commit cf08eebc71.

TBR=vegorov@google.com

Review-Url: https://codereview.chromium.org/2739663002 .
 2017-03-07 16:17:59 +01:00
Jens Johansen a58fe4898d [Fasta] include source code in dill 
At least for now, only when passing --include-source

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2729913005 .
 2017-03-07 15:48:25 +01:00
Claire Sarsam 1f8111e081 Fix typo in the MUST_CALL_SUPER hint message (#28971) 2017-03-07 06:32:44 -08:00
Peter von der Ahé b05dacd6f6 Add missing test from previous CL. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2728123002 .
 2017-03-07 14:57:47 +01:00
Vyacheslav Egorov 9bd34ef785 VM: [Kernel] Set DoubleInitializedBit on fields with double initializers. 
If this field is not set correctly then background compiler constantly bails
out when encoutering stores to these fields.

R=erikcorry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2732273002 .
 2017-03-07 14:52:52 +01:00
Peter von der Ahé ac9d87b707 Keep track of references to guide. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2739593004 .
 2017-03-07 14:50:57 +01:00
Jens Johansen 8e2bf308c1 Fix new service tests on windows; make status file more precise. 
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2734133003 .
 2017-03-07 13:48:58 +01:00
Peter von der Ahé 3835ccf907 One shared guide for diagnostics. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2718023003 .
 2017-03-07 13:44:39 +01:00
Vyacheslav Egorov 64940df644 VM: [Kernel, Precompiler] Improve Function and Field hashes for objects originating from Kernel. 
Currently Fasta does not assign any position information to these objects so we had a very bad hash for them.

BUG=
R=erikcorry@google.com

Review-Url: https://codereview.chromium.org/2739623002 .
 2017-03-07 13:25:47 +01:00
Dmitry Olshansky b980b5a6e2 Fix SIMDBC64 build 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2733103004 .
 2017-03-07 12:42:16 +01:00
Dmitry Olshansky cf08eebc71 Replacing TrySync with Metadata 
Use that to sync variables to predefined stack
slots inside of exception handler, not before
each MayThrow() instruction.

In JIT mode we can avoid storing extra metadata
by using deopt info instead.

Introduce caching of metadata and
exception handler based on PC.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2640853002 .
 2017-03-07 11:33:07 +01:00
Jens Johansen 067b377a3c Mark new debugging stuff as flaky as it fails on mac/win/whatnot 
BUG=

Review-Url: https://codereview.chromium.org/2732973006 .
 2017-03-07 10:34:52 +01:00
Jens Johansen 9837563cd1 Kernel debugging; service tests 
- Offsets on more stuff
- Status file for kernel
 -> Testing with (before fasta)
    ```
    python tools/test.py -mrelease -cdartk --no-tree-shake --no-dfe service
    ```
    now shows everything as passing.
    Reload stuff, and evaluation stuff (e.g.) has been disabled though.
- Lots of new service tests that tests what positions we stop at when
  saying next.

As fasta has now landed debugging does not currently work, but this is still needed in order to both test better and allow for proper kernel debugging support.

R=hausner@google.com, kmillikin@google.com

Review-Url: https://codereview.chromium.org/2680303002 .
 2017-03-07 09:43:59 +01:00
Jens Johansen 137b85c114 Hide kernel isolate from isolate list; do not register it either 
This is basically a copy of https://codereview.chromium.org/2689563010/
and https://codereview.chromium.org/2695013002/ - just hiding the kernel
isolate too.
That way, we won't see it and be confused when debugging via observatory.
Also, service tests could probably start working with the kernel isolate
too.

Still show isolate if passing "--show_kernel_isolate" though.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2690323003 .
 2017-03-07 08:27:14 +01:00
Jens Johansen 1ba39faa3f Make observatory 'pub serve' work again in Dartium 
pub serve in runtime/observatory with Dartium seems to have been broken
since c8e275537d.

When I try to make observatory connect I just get a blank page.
If I open Dartiums console I get a *long* stacktrace saying
"Caught exception: String Expected".

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2729773004 .
 2017-03-07 08:21:31 +01:00
Stephen Adams bf9a4502c8 Tweak Florian's dart2js inlining heuristic change 
This CL updates https://chromiumcodereview.appspot.com/2558633007/

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2724473004 .
 2017-03-06 20:32:54 -08:00
Konstantin Shcheglov bf4dd380ea Fix for parsing 'rethrow' statement with Fasta. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2730293003 .
 2017-03-06 16:50:28 -08:00
Vijay Menon d5372c79ae Bump timeout 
This test seems to timeout often on travis lately.

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2731243003 .
 2017-03-06 16:45:59 -08:00
danrubel c354e26fb6 A/B fasta performance measurement harness 
Tweak and reapply https://codereview.chromium.org/2731703003/

Review-Url: https://codereview.chromium.org/2734863003 .
 2017-03-06 14:30:47 -05:00
Konstantin Shcheglov 262cee7864 Add support for parsing #void with Fasta. 
For the reason why we need this, see the following documents.
https://codereview.chromium.org//427603002
https://github.com/dart-lang/sdk/issues/20191
https://github.com/dart-lang/sdk/issues/19972

R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2737593002 .
 2017-03-06 11:24:54 -08:00
Konstantin Shcheglov 7c0a0f0f99 Fix tests for parsing literals. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2738453002 .
 2017-03-06 11:14:22 -08:00
Konstantin Shcheglov 3e4c4057cd Fix test for parsing 'await'. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2732023002 .
 2017-03-06 11:07:11 -08:00
Konstantin Shcheglov 2a60cbf9de Fix for parsing 'const X()' with Fasta. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2733913002 .
 2017-03-06 11:00:32 -08:00
Matthias Hausner 2d0522b643 Better error message for unresolved super calls 
Improve error message if super invocation resolves to a method
with an incompatible error message.

BUG=#27569
R=regis@google.com

Review-Url: https://codereview.chromium.org/2730193002 .
 2017-03-06 10:27:59 -08:00
Konstantin Shcheglov 05852a6625 Rename parser tests that use 'type arguments', but named 'type parameters'. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2738433002 .
 2017-03-06 10:03:54 -08:00
Konstantin Shcheglov b24ad2e168 Fix for a couple of cascade tests. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2729373004 .
 2017-03-06 09:40:02 -08:00
Vijay Menon 2acb2eb669 Update for latest tests and sdk 
TBR=leafp@google.com

Review-Url: https://codereview.chromium.org/2731333002 .
 2017-03-06 09:36:14 -08:00
Vijay Menon 9d31aed38b Update node for travis 
TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2734893002 .
 2017-03-06 09:18:35 -08:00
Brian Wilkerson f645c34bb0 Add support for copying directory structures 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2733053002 .
 2017-03-06 08:51:40 -08:00
Konstantin Shcheglov 21f8fd8244 Fixes for map literal tests. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2731313002 .
 2017-03-06 08:51:12 -08:00
Zachary Anderson cbc9564f59 Use set_min_proto_version instead of set_min_version. 
To align better with OpenSSL 1.1.0, BoringSSL is transitioning the APIs
from SSL_CTX_set_min_version to (the longer but more
upstream-compatible) SSL_CTX_set_min_proto_version.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2727663007 .
 2017-03-06 08:49:44 -08:00
Erik Corry 634a9a673a ICData::NumberOfChecks is O(n) so don't call it in loops 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2734883002 .
 2017-03-06 17:03:22 +01:00
danrubel 8552edb9b3 Revert "A/B fasta performance measurement harness" 
This reverts commit 82685eacbf.

Review-Url: https://codereview.chromium.org/2733033002 .
 2017-03-06 10:59:51 -05:00
Konstantin Shcheglov be521515fe Parse #operator symbol literals with Fasta. 
R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2735623002 .
 2017-03-06 07:47:46 -08:00
danrubel 82685eacbf A/B fasta performance measurement harness 
Given two separate Dart SDK repo clones, A and B,
this pkg/front_end/tool/fasta/abcompile.dart harness
alternately runs

<A>/pkg/front_end/tool/fasta/compile.dart
then
<B>/pkg/front_end/tool/fasta/compile.dart

so that a performance comparison can be made of the difference
between fasta in A vs B.
For example, from the <A> root directory:

xcodebuild/ReleaseX64/dart
  -DbRoot=/path/to/2nd/dart/sdk/repo
  -Diterations=15
  pkg/front_end/tool/fasta/abcompile.dart
  --compile-sdk=xcodebuild/ReleaseX64/patched_sdk/
  pkg/compiler/lib/src/dart2js.dart
  --verbose

The output contains the raw data along with a summary
of the average difference, and is formatted in a way
that can be easily pasted into Google Sheets
for further analysis.

Future improvements to this include:

* Add JSON output to pkg/front_end/tool/fasta/compile.dart
  so that abcompile.dart is not text scraping the numbers

* Adjust pkg/front_end/tool/fasta/compile.dart so that --verbose
  is not needed to capture the needed numbers and progress

* tweak the A/B summary section to paste more easily
  into Google Sheets

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2731703003 .
 2017-03-06 10:09:45 -05:00
Erik Corry 2d4fbaed32 Fix assert in app-jit where heap verifier finds ICData 
R=vegorov@google.com
BUG=

Review-Url: https://codereview.chromium.org/2734853002 .
 2017-03-06 16:08:58 +01:00
William Hesse 367130e18b Copy fix of language/bad_raw_string test to language_strong suite. 
BUG=https://github.com/dart-lang/sdk/issues/28664
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2731983002 .
 2017-03-06 15:27:08 +01:00
Vyacheslav Egorov 7fe4c0991f Skip language/vm/closure_memory_retention_test on dartkp configuration. 
The test is running out of memory.

TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2731963002 .
 2017-03-06 13:51:25 +01:00
William Hesse 3696281998 Update status for strong-mode lib and language tests for dartanalyzer 
BUG=https://github.com/dart-lang/sdk/issues/28823
BUG=https://github.com/dart-lang/sdk/issues/28969
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2734833002 .
 2017-03-06 12:35:32 +01:00
Dmitry Olshansky 8dda473a55 Improve fasta scanner performance 
Reorder cases in bigSwitch according
to frequency, reduce the number of
comparisons.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2711403002 .
 2017-03-06 11:35:28 +01:00
Vyacheslav Egorov 005453346e Update Kernel dartkp mode statuses. 
TBR=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2732933003 .
 2017-03-06 09:41:35 +01:00
William Hesse b226f6c3c2 Remove mojo download from dartium DEPS 
This step is causing failures on the buildbots, so if it isn't needed,
we can remove it.  The scripts try and use gsutil in an incorrect location,
and we can no longer manually copy it because the buildbots have started
automatically removing it.

BUG=https://github.com/dart-lang/sdk/issues/28248
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2724303004 .
 2017-03-06 09:32:43 +01:00
Konstantin Shcheglov 24d5466a72 Send error notifications only for files in analysis roots (and not excluded). 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2734673002 .
 2017-03-05 15:01:27 -08:00