dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
84,392 Commits 2 Branches 0 Tags
8f563a4f357362171de6a2cdcc3ed2006299834d
Commit Graph

84392 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nate Bosch 8f563a4f35 Update to the latest package:test 
R=jakemac@google.com

Change-Id: Iac051b5cfaf80717125a4011ff39c437e62aba53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237723
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2022-03-17 17:51:07 +00:00
Konstantin Shcheglov 592bfc0174 Remove newDotPackagesFile(), related from file_paths, context location / manager. 
Change-Id: I0f3c067b47e4d0f6171b8a26d34fc173df983c29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237637
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-17 17:40:16 +00:00
Konstantin Shcheglov 073db61a4e Add implicit arguments for super-formal parameters during constant evaluation. 
Change-Id: I1150ebfc9bcdad53ffb38504cff97c2ea9aea5cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-17 17:39:16 +00:00
Keerti Parthasarathy a73357a995 Add a helper class to use kythe from cider. 
Change-Id: I498cc5acc436b319f3b05641b24b37c106a80027
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237181
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-03-17 17:23:46 +00:00
Ben Konyi 400bad7544 [ package:vm_service ] Mark endTime, lastReadTime, and lastWriteTime as nullable 
These properties of `SocketStatistic` were mistakenly marked as
non-nullable but are not always returned as part of the response from
the service extension.

Change-Id: I996d8bdd9ff3b2acd00ce388582042b86fb95301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237632
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-17 16:47:57 +00:00
Ahmed Ashour 3ebb07c016 [analyzer] AddTrailingComma to handle FormalParameterList 
Fixes #48578

Change-Id: If3f7d4e407512117729396ca7582f1923f55aab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-17 16:47:47 +00:00
Johnni Winther 280a87df1e [cfe] Change expression_suite to use embedded sources 
This changes that expression_suite tests to embed the needed source
code in the yaml file. Single source and multi sources are supported.
When using a single source, the file name is implicitly "main.dart"
and the "position" and "entry_point" yaml properties are updated to
supports this, meaning that the yaml files should only use file names
when using multiple sources.

Change-Id: Ia6756eb86a7b72dea2187f72b9f2c75c28783a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237680
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-03-17 14:17:26 +00:00
Alexander Thomas 69f433b701 [co19] Roll co19 to 74ba459aecc908d5db91531f020a3f74e9aa1b4d 
2022-03-16 eernst@google.com Fixes needed based on roll f5124538 (dart-lang/co19#1323)
2022-03-14 sgrekhov@unipro.ru Fixes dart-lang/co19#1310. Add language version 2.16 (dart-lang/co19#1314)
2022-03-10 519320+chloestefantsova@users.noreply.github.com Correct an enhanced-enum test to alow setters named values (dart-lang/co19#1312)
2022-02-25 sgrekhov@unipro.ru dart-lang/co19#993. Added tests for Abi class
2022-02-25 sgrekhov@unipro.ru dart-lang/co19#1258. Added test for a generic enum which does have a regular-bounded instantiate-to-bounds result
2022-02-24 sgrekhov@unipro.ru Fixes dart-lang/co19#1308. Make `UriData` tests case-insensitive
2022-02-24 sgrekhov@unipro.ru dart-lang/co19#1258. Not regular-bounded enum test added
2022-02-21 irina.arkhipets@gmail.com Merge remote-tracking branch 'remotes/origin/weak-reference-fix'
2022-02-21 sgrekhov@unipro.ru Revert accidental commits
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception
2022-02-21 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator
2022-02-20 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum
2022-02-19 sgrekhov@unipro.ru dart-lang/co19#1260. Fixed tests that check attachment of the same object to finalizer several times
2022-02-18 irina.arkhipets@gmail.com dart-lang/co19#1260: Weak reference tests updated.
2022-02-18 sgrekhov@unipro.ru dart-lang/co19#1258. More implementing enums tests added
2022-02-17 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48412. Different issues fixed in Finalizer tests
2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer test improved
2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Minor code enhancement
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Typo fixed
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Fix attach to finalizer tests
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer tests fixed and refactored
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Another WeakReference tests added
2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated.
2022-02-15 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48391. Use function with 'no-inline' to create a WeakReference and to lost link to its target
2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated.
2022-02-14 sgrekhov@unipro.ru dart-lang/co19#130. Roll failure fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Icc2bea05df29e00b671b2843af7c3c55fa45da35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237581
Reviewed-by: William Hesse <whesse@google.com>
 2022-03-17 14:16:09 +00:00
Jens Johansen fd4e41a7af [parser-ish] Better errors on invalid unicode escapes 
https://github.com/dart-lang/sdk/issues/48542

Change-Id: Icbdcc939a93c737914091c00aaefa3c4efb2dde0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-03-17 13:57:45 +00:00
Jonas Finnemann Jensen 29d0fe90e4 Bump yaml_edit to 4fadb43801b07f90b3f0c6065dbce4efc6d8d55e 
Changes:
```
> git log --format="%C(auto) %h %s" df1452b..4fadb43
 https://dart.googlesource.com/yaml_edit.git/+/4fadb43 Prepare 2.0.2 release (#7)
 https://dart.googlesource.com/yaml_edit.git/+/46eb45d Do not add trailing whitespace to new map keys (#16)
 https://dart.googlesource.com/yaml_edit.git/+/bd96cbf Fix example usage in README and dartdoc (#17)
 https://dart.googlesource.com/yaml_edit.git/+/0ae6897 CI: fix the branch (#10)
 https://dart.googlesource.com/yaml_edit.git/+/6385372 Only run the golden tests on the vm (#9)
 https://dart.googlesource.com/yaml_edit.git/+/71db634 Drop unneeded dependency on pkg:pedantic (#8)
 https://dart.googlesource.com/yaml_edit.git/+/6f66114 Fix repo location (#6)
 https://dart.googlesource.com/yaml_edit.git/+/151acb4 Bump to version 2.0.1 (#5)

```

Diff: https://dart.googlesource.com/yaml_edit.git/+/df1452bfe1653286277a1a8f34dddf3e4fbedd9e~..4fadb43801b07f90b3f0c6065dbce4efc6d8d55e/
Change-Id: I409673535a9e7c9dd78e6a8cf5c522d9e1ef1ab4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237682
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Sarah Zakarias <zarah@google.com>
Commit-Queue: Sarah Zakarias <zarah@google.com>
 2022-03-17 12:44:55 +00:00
Johnni Winther acc535dfab [cfe] Show annotations on library dependencies 
This updates ast-to-text to show the annotations on import/exports. A
test is added that uses augmentation libraries to show that the
annotations are not currently ascribed to the correct library dependency.

Change-Id: I340c1ab920b16ff08dd9ac36ee9be4d2d651b4a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237301
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-03-17 09:38:25 +00:00
Konstantin Shcheglov b2044efef7 Look for and build package_config.json files in PluginManager. 
Change-Id: Iea851a2c773163a274b5ffc7259b2647aaa5099d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-17 03:48:23 +00:00
Konstantin Shcheglov 963bd7c165 Add AnalysisContext.changeFile() 
Change-Id: I42d215e872322cace019bc64f04a74d883e9849e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237628
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-17 00:33:34 +00:00
Srujan Gaddam a16bd37ed2 [dart:html] Change AudioNode.connect to be nullable 
AudioNode.connect can return undefined in the case where
destination is an AudioParam. Note this is not a breaking
change since it's a private method. This unbreaks users
who use native null assertions.

Change-Id: I517863798b0ebe4859d195dcadc2696716ebc8a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237500
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
 2022-03-17 00:28:05 +00:00
Ryan Macnak c9d2394c02 [infra] Remove references to unsupported ARMv6 and ARMv5TE. 
Change-Id: I2fb2f438940866333c7d34d26f7eb4c447b25a95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237624
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-03-17 00:07:54 +00:00
Konstantin Shcheglov e2f615fa9d Remove the temporary SummaryDataStore constructor. 
Change-Id: Id14fc6502bb0885b6843748a1ed833656e1a2df9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237625
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-16 23:53:45 +00:00
Konstantin Shcheglov bff94a4c3a Always provide 'isNonNullableByDefault' arguments for ErrorReporter. 
Change-Id: If556a25d5ce6d0d33e55d2cf8fb2df950d3959a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-16 23:53:35 +00:00
Ryan Macnak 981d569821 [vm, compiler] Make use of load/store-pair with SIMD registers on ARM64. 
TEST=ci
Change-Id: I140ffdce400c7dfa8a51b79e56f585d9edee5389
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237520
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-03-16 22:51:04 +00:00
Brian Wilkerson 844ca214c4 Correctly handle a trailing comma in convert_to_super_parameter 
Change-Id: I8acfe80106666d9105f0c7a4c5e8c6352635e2bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237601
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-16 21:41:44 +00:00
Chloe Stefantsova f83b5c251d [ddc] Update the test that declared a custom 'index' in an enum 
Landing of https://dart-review.googlesource.com/c/sdk/+/237365 made
the test fail due to a custom declaration of a member named
'index'. This CL adjusts the test, removing the declaration.

Change-Id: I8f967a6ec473cb1aac8690d740d90647e01bc55f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237584
Auto-Submit: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2022-03-16 21:28:44 +00:00
Konstantin Shcheglov 5bd060484b Fix order of inference for super-formal parameters. 
Change-Id: Ie98663d1788b14d4622e692b446756d8c1c9b763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237629
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-16 20:31:04 +00:00
Konstantin Shcheglov 408083ccad Use PluginFiles instead of List<String> in PluginManager. 
Change-Id: I517830dfd388af6ac293ff7eea2ea8840c60fc01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-16 18:36:24 +00:00
Brian Wilkerson 519b391291 Do not convert field initializing parameters to super parameters 
Change-Id: I2238b49fe9a872d5235108839fa60a98e6de3c09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-16 18:29:04 +00:00
Konstantin Shcheglov eea52d35f8 Issue 48583. Inherit evaluationResult in DefaultSuperFormalParameterElementImpl. 
Bug: https://github.com/dart-lang/sdk/issues/48583
Change-Id: I6217adb5d1e96d2fbb40e4033b9ed62025cd60ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-16 18:14:14 +00:00
Brian Wilkerson 8d6fb0f31c Add ignore comments for upcoming dead code warnings 
Change-Id: I80406737abdbaded667cbb8b830e38be2a1f3280
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237621
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-16 16:55:44 +00:00
Konstantin Shcheglov 1a1701c2b5 Build macro kernels. 
They are not used yet.

Change-Id: I7849bf845f161f5c48e8ec9ded5900a3486148c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-16 16:55:14 +00:00
Martin Kustermann fc513d9448 [vm] Avoid usage of STL container with const template argument 
Issue b/223663984

TEST=ci

Change-Id: I7b915014df78641e4924cde2f07f9b55ee4bac7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237583
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2022-03-16 15:13:14 +00:00
Chloe Stefantsova 5bd7d75b1e [cfe] Report errors on restricted instance members in enums 
Part of https://github.com/dart-lang/sdk/issues/47453

Change-Id: I2fddd2ad5da82807fef7e9ed1d7a6781fde38600
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237365
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2022-03-16 13:47:44 +00:00
Johnni Winther 5f7d226ae8 [cfe] Enable nnbd in expression suite 
Change-Id: Iad66d179b4b2795ba68a65cf078fa69a4f65fae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237040
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-03-16 11:44:31 +00:00
Aske Simon Christensen 3b64cede6d [ffi] Use explicitly cached getters for Array nested dimensions 
The FFI use sites transformation generates code accessing some late
final fields of the Array class. By changing these to be getters, the
transformation works both with and without late field lowering.

Tested: ci
Change-Id: Ib30d18e0830f7bb597214701272b1d0a922ac06a
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237363
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2022-03-16 11:29:03 +00:00
Alexander Thomas 5317e4c605 [infra] Fix architecture detection on M1/arm64 macs 
Change-Id: I678054cbe27965cd552020ebc73fecebc6c6224d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237422
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
 2022-03-16 10:12:43 +00:00
Aske Simon Christensen a8f8d96a27 [dart2wasm] Implement map constants without lowering. 
Change-Id: I9c467ff0e5176c1400794f2008f41eaaaf91bea3
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237142
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2022-03-16 10:05:43 +00:00
Aske Simon Christensen 83e4aad58b [vm] Avoid wasted space in the data array for map and set constants. 
The element data array in the VM's hash map/set implementation always
has a power-of-two length, growing exponentially as entries/elements are
added.

For constant maps/sets, this is not necessary, and the unused parts of
these data arrays is just wasted space.

This changes the data arrays for constant maps and sets to only contain
the actual entries/elements of the map/set.

Tested: ci
Change-Id: I061eb44b6c74c87157ef920143bf1885582f1b9a
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237140
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2022-03-16 10:05:43 +00:00
Aske Simon Christensen d24354ea09 [vm/dart2wasm] Brush up mixin structure of hash implementation classes 
This changes all mixins in the VM's hash map/set implementation to be
declared as mixins and introduces appropriate interfaces needed to
concisely express the prerequisites of the various mixins in the stack.

It also separates most of the implementation of immutable maps and sets
into mixins to enable sharing the implementation with dart2wasm.

Tested: ci + manual testing of dart2wasm
Change-Id: Ife1e7195aba35741629aa4dffedb929b1028a85a
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236180
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2022-03-16 10:05:43 +00:00
Devon Carew f2c623a987 Turn the tools/generate_package_config.py script into a no-op. 
Change-Id: Idd1bdd9f0d9613b9898d81afd00f76273634ac26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237441
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-03-16 08:22:33 +00:00
Ian Hickson df59e987be Add more details to contributing docs 
Hopefully this will make it easier for people to get started, without actually changing the processes in any way.

Closes https://github.com/dart-lang/sdk/pull/48570
https://github.com/dart-lang/sdk/pull/48570

GitOrigin-RevId: f73520481a2a7db310fade3ca08d71e4e5f106a8
Change-Id: Ie4f89530a4e5100ff6032b8157e980d45b72dbf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237481
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-03-16 07:56:58 +00:00
Brian Wilkerson cd5933c833 Fix a false positive in convert_to_super_parameters 
Unlike normal parameters, super parameters are visible in the body of
the constructor. So if the normal parameter is referenced it can't be
converted.

Change-Id: I6a48e0d6de896b25d7a9d25f6d20ae7ad01f82c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237502
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-16 04:19:03 +00:00
Alexander Aprelev 8a43a891f3 [io/win] Ensure no-console flag is not used if stdio is inherited. 
Follow-up to b6c5e52af6 that fixes broken test.

TEST=process_inherit_stdio_test

Change-Id: Ice2188af03f3230d0b8d1161fedce333e43b862b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237482
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-03-16 00:20:03 +00:00
Paul Berry f58adc5dc3 Rework heuristic for "fixing" type parameters after downwards inference. 
Sometimes the upwards inference phase of generic type inference is
capable of assigning a more specific type than the downwards inference
phase, but we don't want to use the more specific type due to Dart's
"runtime checked covariant generics" design.  For example, in this
code:

    List<num> x = [1, 2, 3];
    x.add(4.0);

Downwards inference provisionally considers the list to be a
`List<num>`.  Without this heuristic, upwards inference would refine
the type to `List<int>`, leading to a runtime failure.  So what we do
is "fix" the type parameter to `num` after downwards inference,
preventing upwards inference from doing any further refinement.

(Note that the heuristic isn't needed for type parameters whose
variance is explicitly specified using the as-yet-unreleased
"variance" feature, since type parameters whose variance is explicitly
specified don't undergo implicit runtime checks).

Previously, this heuristic was implemented in a kludgy way: we would
go ahead and gather type constraints during both the upwards and
downwards inference phases, and then just prior to choosing the final
type, if the downward constaints were sufficient to lock down the
type, we would discard the constraints from the upwardsr inference
phase.

This change simplifies the logic so that we figure out which
parameters to fix after the downwards inference phase, and simply stop
accumulating constraints for them.

This is a preparatory step towards implementing
https://github.com/dart-lang/language/issues/731, which will require
splitting type inference into more phases.

Change-Id: I0cc5774e61a5ace589ea0f45a20fbc1a67c8b940
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237381
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-15 22:00:22 +00:00
Alexander Aprelev b6c5e52af6 [io/win] Ensure console window is not created when running in windows mode. 
Fixes https://github.com/dart-lang/sdk/issues/39945

TEST=ci, manually check flutter windows app doesn't pop-up console.

Change-Id: I05983947de10058e4b0d2f9cbe795bd52f97ad05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237400
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-03-15 21:34:23 +00:00
Brian Wilkerson 37e67cccfa Add a quick fix for convert_to_super_parameters 
Change-Id: Ied50bcd6af6e0cf4871c8810c5b8466fa268bd86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237460
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-15 20:12:26 +00:00
Danny Tuppeny 094c598703 [analysis_server] Change empty linked edit groups to have placeholder text 
Change-Id: Id687c4db11a1b43507f61e6d8ff5775ccccc819f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-15 20:03:33 +00:00
Srujan Gaddam 7e1cc8612c Make tools/dom owned by OWNERS_WEB 
Change-Id: I8aea10ad3b35cb7f615788291a92c6724a9a562d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237182
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2022-03-15 19:54:13 +00:00
Danny Tuppeny 7d6c965fc9 [analysis_server] Handle InconsistentAnalysisException centrally in request handlers 
Change-Id: I42de91467ad89e70560e63e27518df2a38ba45f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-15 19:38:53 +00:00
Stephen Adams e2c9472485 IE11 cleanup - setting function names is unnecessary 
Change-Id: Iaf327270bbee48736905b42e7b4290c2eb78e51a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237185
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-03-15 19:22:03 +00:00
Paul Berry 41a330b8f4 Remove _functionNestingLevel from flow analysis logic. 
Previously, this field existed as a sanity check to help ensure that
the client didn't accidentally call `functionExpression_end` more
often than `functionExpression_begin`.  However now that flow analysis
maintains an explicit stack of what constructs have been begun and not
ended, the check is redundant, because trying to pop from an empty
stack would cause a runtime failure anyway.

Change-Id: I4a56c66169a6de6b4c19d67800d8d0083e7bd59f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-15 19:16:42 +00:00
Ben Konyi 8c484d12fe Reland "[ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS" 
This reverts commit d4f71515c7.

TEST=CQ

Change-Id: I180f9d045870a1ff5f7f3f82b6f4782e18c18cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237440
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-15 18:14:42 +00:00
Paul Berry 8fbb5bbf5b Remove GenericInferrer.considerExtendsClause. 
This logic allowed the analyzer to omit consideration of type
parameter bounds during execution of the `matchSupertypeConstraints`
method (which is used for mixin type parameter inference).  I added it
back in 2018 (https://dart-review.googlesource.com/c/sdk/+/44220) in
an attempt to fix #32353, however after I made the fix, additional
work by the front end team made it seem like I had probably
misunderstood the issue.  In any case, I've verified with both SDK
trybots and an internal presubmit that removing this logic doesn't
break anything, so I believe it's likely that the bug was later fixed
in a different (and presumably more correct) fashion.

I'm currently doing work on the analyzer's type inference logic, and
GenericInferrer.considerExtendsClause is complicating my efforts, so
it seems reasonable to remove it at this point.

Change-Id: Ia0a988c7297e1579c2e96f9fa886e280f47ab62e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237003
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-15 17:49:15 +00:00
William Hesse 3f0988bc17 [infra] Allow upload of SDK to CIPD to fail in SDK builders 
Change-Id: Ib8272650c7c468127c00a54e6bab679131deff5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237366
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-03-15 17:27:18 +00:00
pq c305b6b6f0 bump linter to 1.20.0 
Change-Id: I44ca585b3cf3649983955a2202c8fb093677329a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237184
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-03-15 17:09:22 +00:00