8e2d140fa5
[cfe][InternalNodes] Implement InternalVariable directly
...
This updates the InternalVariable hierarchy to be based on a sealed base class InternalVariable with no connection to IVariable. IVariable is removed and unused properties of InternalVariable are removed.
TEST=existing
Change-Id: Iacfbe9ab21d1c9aab043712099cd1ee6e4cee174
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510825
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2026-06-11 02:43:16 -07:00
c390eb0931
[cfe][InternalNodes] Separate Variable from InternalVariable
...
This adds an InternalLegacyVariable the doesn't derive from LegacyVariable. This fully separates InternalVariable from Variable and assigned variable tracking and flow analysis is now changed to used InternalVariable instead.
TEST=existing
Change-Id: Ida9dc78d4f0e3fab3baf7a965273e1ddf68a80b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510341
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2026-06-11 02:43:16 -07:00
680f6e24d7
[co19] Roll co19 to ba5777c42fcc391253f5d51089a3b503654b53d7
...
2026-06-10 sgrekhov22@gmail.com Fixes dart-lang/co19#3851 . Add test for representation variable, fix augmenting_constructors_A09_t02.dart (dart-lang/co19#3852 )
2026-06-10 sgrekhov22@gmail.com dart-lang/co19#3847 . Add method override inference tests (dart-lang/co19#3850 )
2026-06-08 sgrekhov22@gmail.com dart-lang/co19#3315 . Add tests for abbreviations. Part 3. (dart-lang/co19#3841 )
2026-06-08 sgrekhov22@gmail.com Fixes dart-lang/co19#3844 . Add tests for implicit const of enum constructors (dart-lang/co19#3845 )
2026-06-08 sgrekhov22@gmail.com Fixes dart-lang/co19#3842 . Fix typos in augmenting_variables_getters_setters_A03_t12/3.dart (dart-lang/co19#3843 )
R=athom@google.com , eernst@google.com
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I0193d307b55335268d8e5555176a6bfe360d9d01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510940
Auto-Submit: Nate Biggs <natebiggs@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2026-06-11 01:40:13 -07:00
9bf5bfb83d
[infra] Increase Linux ARM64 sanitizer test coverage.
...
Change-Id: Id9086913d0c3b7a0d88eaeb2ce8f2be17f80e285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510541
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-10 16:12:39 -07:00
892e6a8b53
[dart2wasm] Pass on @pragma('wasm:prefer-inline') to wasm-opt
...
Now that we have a way to tell binaryen to inline functions (see [0],
which added support for `(@binaryen.inline <0...127>)` annotations) we
can tell it to inline functions that were annotated with
`@pragma('wasm:prefer-inline')`
Since binaryen sometimes can devirtualize call sites that TFA cannot, it
can then inline those devirtualized calls.
[0] https://github.com/WebAssembly/binaryen/issues/7972
Change-Id: I139bd43976a1ddb83afe756d4fbac09419f7199e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510822
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2026-06-10 15:59:53 -07:00
8e751fbc02
[dart2wasm] Remove deprecated mjs API functions
...
This is a re-land of [0] from 1.5 years ago.
[0] https://dart-review.googlesource.com/c/sdk/+/385020
Change-Id: I92747494f7c0d9dc43c09040ce06a523453994f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510823
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2026-06-10 15:52:03 -07:00
5cd42e6b21
[dart2wasm] Start emitting binaryen.inline custom section
...
Binaryen introduced `binaryen.inline` which allows us to tell it
inlining hints now, including "never inline" hint (see [0])
This allows us to remove the ugly mangling of wasm function names with
`<noInline>` postfix.
We also now pass `--strip-toolchain-annotations`: The annotations
occupy size in the wasm binary and wasm runtimes ignore them (they are
for `wams-opt` only).
Except for IR tests: Here we want to see the annotations, so we keep
them there.
We also rename the package:wasm_builder classes to clearly indicate
those are binaryen specific sections.
We also make the ir_test.dart put it's options first, allowing the IR
tests to override options if needed.
[0] https://github.com/WebAssembly/binaryen/commit/3c25487214600a9
Change-Id: I96688bfaeba403a39cd5e7376f8d2889bcbae030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510000
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2026-06-10 15:51:47 -07:00
b5294b9753
[test_runner] Invoke tests with relative paths.
...
This makes tests more reproducible, and makes it easier to copy commands between workspaces, or between a failing bot and a local workspace.
Change-Id: Ic8dd10a3540f314a406e5c5b0a23d97032e5d01d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508364
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-10 15:30:26 -07:00
9a4a02f9c5
Roll Fuchsia GN SDK from oOAcFhkoE2_-Sy67z... to a87CbQSWEjkPUK1ZY...
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-gn-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia GN SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I93daef929f755d3b2cfb56c196769d51745fc42d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509780
Reviewed-by: Zijie He <zijiehe@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2026-06-10 14:00:05 -07:00
bdd383b966
Add a fix for unnecessaryPrimaryConstructorBody
...
Closes https://github.com/dart-lang/sdk/issues/63556
Change-Id: I04ff967649b1b834600578a2d38ca480b9d19ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511020
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2026-06-10 13:04:13 -07:00
78f9ab6cb8
Start analyzer 13.3.0-dev, analyzer_plugin 0.14.12-dev, analyzer_testing 0.3.2-dev, analysis_server_plugin 0.3.18-dev
...
Change-Id: I2a9e762e2f5b3fd4762ee0d0eb22296db0f3dff4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-10 13:03:15 -07:00
49546393c6
Remove the JIT entitlement from gen_snapshot, take 2.
...
Push this down to VirtualMemory since some parts of the VM go there directly instead of through Page.
TEST=ci
Change-Id: Icc65242e9099e8785a38ba9e38311146d8b5845b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510260
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2026-06-10 12:56:03 -07:00
9057e23671
Use a separate environment variable for RBE_expensive_exec_strategy.
...
The bots set RBE_exec_strategy=remote_local_fallback, which we don't want to override racing for the Dart actions.
Change-Id: I8739dc04af183fe2011e2589bd5480fd5a2daca1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511001
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-10 12:52:31 -07:00
594efdd63c
Add documentation for another warning
...
Change-Id: If31cfea7c3dc3379cc0e8eda454ac9fdec4a348d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/503942
Reviewed-by: Connie Ooi <connieooi@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2026-06-10 12:21:26 -07:00
e82b6a24cd
[infra] Include fastboot into the Android test shards.
...
Change-Id: Ib676bb9c177125889b7bc06cf976a23d3be3add8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510640
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-10 11:58:10 -07:00
ff0cd5e0d6
[analysis_server] Don't warn on renames of private named parameters
...
Fixes https://github.com/dart-lang/sdk/issues/63433
Change-Id: I6e39d3b8c9379df07a677cabfcd9028a7bca79db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510840
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2026-06-10 11:57:21 -07:00
bf71251dcd
CQ. Remove ResolutionTest.error/message, all goes through inline expected diagnostics now.
...
Change-Id: I46fd2efe14e1bb46fa7ec12423c19fcf551bdca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510660
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2026-06-10 11:25:41 -07:00
cb41c7b055
CQ. Remove assertErrorsInList().
...
Change-Id: I51afa9bce21992d6093935d303034551e135c94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510500
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-10 11:25:01 -07:00
95b017937c
[infra] Combine the GCC and MSVC builder configurations.
...
This also switches the MSVC builders to create_sdk.
Change-Id: I7ec46f91530003dc7e80f5740d1c4c23b755b65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510860
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-10 11:23:21 -07:00
6c3cf9ea51
Roll Clang from a3f244e2d555 to deb6854eec93
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-dart-sdk
Please CC dart-engprod@google.com ,dart-vm-gardener@rotations.google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TEST=ci
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try;luci.dart.try:vm-asan-mac-release-arm64-try
Change-Id: Iddd7439c096af8c37076756330a067ccb7d10a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510520
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-10 11:05:58 -07:00
db905b9711
[vm/service]: Add OS::SafeReadMemory for Windows using ReadProcessMemory
...
TEST=runtime/vm/service_test.cc
Cq-Include-Trybots: dart/try:vm-asan-linux-release-x64-try,vm-asan-win-release-x64-try,vm-dyn-linux-debug-x64-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-linux-debug-arm64-try,vm-linux-debug-ia32-try,vm-linux-debug-simriscv32-try,vm-linux-debug-simriscv64-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-linux-release-simarm-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-tsan-linux-release-x64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-win-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try
Change-Id: I7afabe66211657139981e18d8b1a14c2081d3f5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506640
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2026-06-10 10:58:15 -07:00
8267ce6fff
CQ. Use more inline expected diagnostics.
...
Change-Id: I83743fee43718133df71dd33093056543dc83094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510482
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-10 10:57:43 -07:00
e4ef831dfc
Prepare to publish analyzer 13.2.0, _fe_analyzer_shared 102.0.0, analysis_server_plugin 0.3.17, analyzer_plugin 0.14.11, analyzer_testing 0.3.1
...
Change-Id: I534e30c37570cf5fdc194eb9668d37747823aa82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510480
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-10 10:52:25 -07:00
6d86b39595
Fine. Store formal parameter default values separately from FunctionType(s).
...
A type is just a type, it should not attempt to carry element semantics.
Bug: https://github.com/dart-lang/sdk/issues/63555
Change-Id: I9dacc4f5cc4060d862f7e1bb1ececdd9dc1a303c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510420
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-10 10:29:28 -07:00
8f1a38f07b
[vm/isolate_api] Ensure isolate acquisition fails gracefully when target isolate is exiting.
...
Introduce `is_acquirable` isolate property that tracks whether isolate can be entered, avoid a `pool_` check that does not work correctly as isolate being shutdown.
BUG=https://github.com/dart-lang/sdk/issues/63515
BUG=https://github.com/dart-lang/sdk/issues/63514
TEST=ci
Change-Id: I84577ad082d87ead8cdb9f591fabdf918e2f4bd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509221
Reviewed-by: Slava Egorov <vegorov@google.com >
2026-06-10 09:59:06 -07:00
24cf34371a
CQ. Stop using assertErrorsInList() in AnalysisDriverCachingTest.
...
Change-Id: Icac933eb6cfd61798a163daa906348f68b7c2616
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510441
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-10 09:57:10 -07:00
93ca44b048
[ffi] Add DynamicLibrary.openFromAssetId
...
Adds a new API `DynamicLibrary.openFromAssetId` to `dart:ffi` that
allows opening dynamically loaded libraries using their native asset IDs
instead of physical file paths.
Closes https://github.com/dart-lang/sdk/issues/63295
TEST=./tools/test.py -n vm-aot-linux-debug-x64 'ffi/native_assets/asset_*'
Cq-Include-Trybots: dart/try:vm-aot-linux-debug-arm64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-debug-arm64-try,vm-aot-mac-debug-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-asan-linux-release-arm64-try,vm-asan-linux-release-x64-try,vm-asan-mac-release-arm64-try,vm-asan-win-release-x64-try,vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try,vm-ffi-dyn-mac-debug-simarm64_arm64-try,vm-msan-linux-release-arm64-try,vm-msan-linux-release-x64-try,vm-tsan-linux-release-arm64-try,vm-tsan-linux-release-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-linux-release-arm64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-mac-release-arm64-try,vm-ubsan-win-release-x64-try
R=vegorov@google.com
Change-Id: Ic617cb0906d1688d2d080dae7d1e08ee58b4c8d6
CoreLibraryReviewExempt: VM-only
Change-Id: Ic617cb0906d1688d2d080dae7d1e08ee58b4c8d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507180
Auto-Submit: Shikhar Soni <shikharsoni@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2026-06-10 09:49:30 -07:00
088614d11b
DAS plugins: Export types from analyzer_plugin for convenience
...
Fixes https://github.com/dart-lang/sdk/issues/61821
Change-Id: Ibb2737553de713aeef725a19417e09202bee8ac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509543
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2026-06-10 09:38:40 -07:00
4f2ee94e20
[vm/isolate_api] Fix thread-starting race in threading_test.
...
Fixes https://github.com/dart-lang/sdk/issues/63526
TEST=ci
Change-Id: I7e0a52d3c5a7c04c1d853f769544547758c49545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509541
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2026-06-10 09:37:00 -07:00
eb979c2f0c
[analysis_server] Don't show field modifiers in signature help for primary constructors
...
Fixes https://github.com/dart-lang/sdk/issues/63560
Change-Id: I2c93e4a1011075e103d9165d0664f588f3109c40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510821
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2026-06-10 09:03:48 -07:00
44bb92f49a
[dartdev] Provide no installation feedback in dart installed
...
Updates `dart installed` to provide feedback if nothing is installed. If they didn't specify `--all` but there are inactive tools, provide a suggestion to specify the `--all` flag as well.
Resolves https://github.com/dart-lang/sdk/issues/61626
Change-Id: I7d68fe91a29650c113047065e673e7a1139df847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510020
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2026-06-10 08:26:03 -07:00
7c3c71ae4d
Don't lint on raw types in constant patterns if the matched type is of type Type.
...
The issue does not have total consensus but I do feel strongly and the
fix was trivial and so I am just sending this out.
Feel free to push back if you feel strongly, or I should go through some
formal process.
Bug: https://github.com/dart-lang/sdk/issues/59334
Change-Id: I7c5e25e9754c4cebd427b8dc9ccfbe8daa57e71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510460
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2026-06-10 08:23:43 -07:00
7d126dc14f
Bump the github-actions group with 2 updates
...
Closes https://github.com/dart-lang/sdk/pull/63499
GitOrigin-RevId: deb858dd6b7bf379639970a18312fa476c51bdc1
Change-Id: I21296af424f6648c183084454c7e24b4706ceb36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508480
Reviewed-by: Alexander Thomas <athom@google.com >
2026-06-10 05:07:48 -07:00
dd4f983cee
fix location tracking transformer for use in flutter
...
Closes https://github.com/dart-lang/sdk/pull/63551
GitOrigin-RevId: a14cbbd88c605d193e2a1b744727765c45d38278
Change-Id: Ied6c2fc4ee3b5343c6ab8e38080542d667175f4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510160
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2026-06-10 04:15:37 -07:00
034b90af5d
[dart2wasm] Allow using experimental dart:ffi in deferred modules
...
The experimental `dart:ffi` support predates deferred loading
implementation. Any use of FFI features would lazily import `ffi.memory`
into the (fixed coded) main module.
This CL now lazily imports the `ffi.memory` module into all modules that
operate on the memory.
=> This will now allow a flutter app that is compiled with dart2wasm
in deferred loading mode to possibly defer parts of flutter
engine code that uses FFI into deferred modules.
Issue https://github.com/dart-lang/sdk/issues/56952
Change-Id: Idf821ce2dd92c36ac1be9dae24307516a1ae86d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510760
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2026-06-10 02:34:44 -07:00
c5f9583eb3
[dart2wasm] Roll binaryen to new version
...
This brings the `(@binaryen.inline <>)` annotation support.
Change-Id: I2fbafd23aeee5d6843a470b8f887e7dc2514447c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510700
Reviewed-by: Slava Egorov <vegorov@google.com >
2026-06-10 02:23:19 -07:00
abd32d5449
[analyzer] Fix _OverlayFile.writeAsBytesSync
...
Change-Id: I3b4d7ad2b7a781c49abebef307a44dd9b3381b37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510361
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2026-06-10 01:08:18 -07:00
fa2e23b83c
[cfe][InternalNodes] Remove unused precise messages
...
These messages where never used. This was revealed through the separation of Variable and InternalVariable.
Change-Id: I96d337f941d300cc5437c9fa5c9341abe4889176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510380
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2026-06-10 00:27:50 -07:00
26e4018188
[parser] Rename _reportInvalidConstantPatternOperator -> _checkForInvalidConstantPatternOperator
...
Follow-up to https://dart-review.googlesource.com/c/sdk/+/510320 .
Change-Id: I90fcf18fbaf63600c40409ca420030e749180242
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510360
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2026-06-09 23:51:55 -07:00
92ae8b61ec
[dart2wasm] Fix switch statements that include a Type expression case.
...
'canInvokeTypeEquality' was assuming that if a single case was a Type expression, then type equality should be used for the whole switch statement. This is incorrect because if a single case is a type expression but the rest are, for example, ints (as in the fixed test) then the int cases should be compared with identical while only the type expression should be compared with ==.
More importantly, the expected type of the case expression constants should be top type rather than the Type type. Top type is the union of Type and the other case type.
Switches that only include Type expressions will now use "top" type as well but in general switching on a Type expression is an antipattern we shouldn't optimize for. And the impact of not specializing the switch type to Type should be very minimal.
Fixes: https://github.com/dart-lang/sdk/issues/63476
Change-Id: Ib96172f157d8cf3093199e5127d4835e7b25011c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509920
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Nate Biggs <natebiggs@google.com >
2026-06-09 20:39:04 -07:00
6282b35c4c
[dart2js] Fix labeled jump target resolution in SSA builder
...
When generating SSA jump instructions (HContinue and HBreak) for AST break statements, ensure that we only select labels from the target's label list that are explicitly marked as valid continue (isContinueTarget) or break (isBreakTarget) targets.
Previously, handler.labels.first was selected indiscriminately if non-empty, which caused unlabeled continue statements inside loops that had an outer break label to incorrectly generate labeled continue jumps targeting the break label.
Fixes: https://github.com/dart-lang/sdk/issues/63456
Change-Id: Ic497776141a192edb0930f4585cdaae2feecb3d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510280
Commit-Queue: Nate Biggs <natebiggs@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2026-06-09 19:23:06 -07:00
31b6c9f0d2
Roll Fuchsia SDK from 32.20260601.5.1 to 32.20260604.3.1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I1297129ceeb6f6b5b5d68f10983b8bc4d2d7274a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509420
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2026-06-09 18:02:42 -07:00
aa6489ca91
Roll BoringSSL from 047c29fe2c3e to 60553ee001ee (29 revisions)
...
https://boringssl.googlesource.com/boringssl.git/+log/047c29fe2c3e..60553ee001ee
2026-06-04 davidben@google.com draft-ietf-dnsop-svcb-https was also published
2026-06-04 davidben@google.com draft-ietf-lamps-dilithium-certificates is now RFC 9881
2026-06-03 davidben@google.com Restore the libcrypto C++ runtime dependency, but with a build flag
2026-06-03 davidben@google.com Fix error_depth in the name constraints common name check
2026-06-03 chlily@google.com Add default SSL options to SSL_OP_ALL
2026-06-03 rpolzer@google.com Unroll the ML-DSA NTT outer loops.
2026-06-03 rpolzer@google.com In SSL_reset_early_data_reject, clear out unreported bytes written.
2026-06-02 davidben@google.com Update Wycheproof test vectors
2026-06-02 andreser@google.com Replace most of P-256 assembly code with C
2026-06-02 rpolzer@google.com For AES-GCM-SIV, also require PCLMUL instruction set.
2026-06-02 rpolzer@google.com Add CMS_LIB to kLibraryNames.
2026-06-02 chlily@google.com Documentation: Change |...| to `...` for code references in comments 9/N
2026-06-02 rpolzer@google.com Remove the size limits for AES-EAX.
2026-06-02 chlily@google.com Documentation: Change |...| to `...` for code references in comments 15/15
2026-06-02 chlily@google.com Documentation: Change |...| to `...` for code references in comments 14/N
2026-06-02 chlily@google.com Documentation: Change |...| to `...` for code references in comments 12/N
2026-06-01 davidben@google.com Remove unreachable checks in builtin BIO callbacks
2026-06-01 davidben@google.com Convert built-in BIOs to write_ex
2026-06-01 davidben@google.com Switch some BIO_write calls to BIO_write_ex
2026-06-01 chlily@google.com Documentation: Change |...| to `...` for code references in comments 13/N
2026-06-01 davidben@google.com Take another pass at EVP_MD_CTX and EVP_CIPHER_CTX documentation
2026-06-01 mattm@google.com Implement plants-04 landmark relative MTC verification.
2026-06-01 davidben@google.com Implement BIO_write_ex
2026-06-01 davidben@google.com Narrow BIO_read and BIO_write error values
2026-06-01 davidben@google.com Fix BIOTest.SocketConnect on platforms where loopback is synchronous
2026-06-01 davidben@google.com Fix non-blocking connect completion check in BIO.
2026-06-01 davidben@google.com Fix EVP_MD_CTX reuse across EVP_PKEY algorithms
2026-06-01 davidben@google.com Use C++ destructors in by_dir.cc
2026-06-01 davidben@google.com Clean up by_dir's get_cert_by_subject function
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com ,dart-vm-gardener@rotations.google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: dart-vm-gardener@rotations.google.com
Change-Id: Iae122815779b6085963c2b4c78bde9f7c5f37ff0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509421
Reviewed-by: Alexander Aprelev <aam@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-09 17:52:05 -07:00
f8d286d4d2
CQ. Migrate from assertInvalidTestCode() to resolveTestCodeWithDiagnostics() and remove it.
...
Change-Id: Id1306cef4434ee4f61fa3df8a33aa4009698203f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510189
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2026-06-09 12:34:43 -07:00
b5eb9af663
[build] Fix RBE fallback on pkg, ddc and dyn bots.
...
Also fix --check-clean. `ninja target -t commands` reports the commands for the default target, fix to use `ninja -t commands target` instead.
Change-Id: Ice179290e75b083a96abadb7540ca960eafcc982
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510440
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2026-06-09 12:27:23 -07:00
a7c437e4d8
CQ. Remove SdkConstraintVerifierTest, assertErrorsInCode()
...
Change-Id: I563d661c70faa6c3cedf64df442f06aa688864c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510186
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2026-06-09 12:26:39 -07:00
9f47e3186d
Add an unnecessary_primary_constructor_body lint
...
The lint will fire even when there is a comment in the body, such as
```dart
class C() {
this { /* comment */ }
}
```
I think this is the right behavior because I can't think of any useful
comment that wouldn't be better somewhere else, but let me know if you
disagree.
This doesn't yet have a fix, but it should.
Change-Id: Ia5ffa6b06c75a6a7400ec32a9d22209c08a9c73d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510401
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2026-06-09 11:39:04 -07:00
2a3c26806f
[migrate] Allow additional force enabled codes in BulkFixProcessor.
...
This CL allows the BulkFixProcessor to handle additional force-enabled
codes that may not be enabled in the existing analysis options of the
current project.
Change-Id: I346a1fba8a25d7ebc6a2d95828796e7f7c0ff52c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509681
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2026-06-09 11:29:45 -07:00
fa78f9f947
Augment. Deprecate MethodDeclaration.isAbstract, add isComplete to ConstructorDeclaration, FunctionDeclaration, MethodDeclaration.
...
Change-Id: I3d5c884870ef183f54e59cd0a5c735373cbe71a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509900
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2026-06-09 11:28:23 -07:00
6a678d1f49
Quick fixes that create constructors use new-style syntax when primary_constructors is enabled
...
Closes https://github.com/dart-lang/sdk/pull/63534
GitOrigin-RevId: 345471bc33c002bbca9cea9c6626a05f481f70e3
Change-Id: If8d533ab0bbb4e6dff51a4256101fb8cb0490fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509680
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2026-06-09 10:57:01 -07:00
Johnni Winther