dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ryan Macnak 3dcdaf9e57 [vm] Check for OOM when allocating a new handle block. 
Bug: https://github.com/dart-lang/sdk/issues/32706
Change-Id: I0159d794e11c18f24204d11d9ba3bbfe8a5a4140
Reviewed-on: https://dart-review.googlesource.com/48706
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-03-28 23:08:39 +00:00
Zach Anderson 865f52737a [dart:io] Adds IOOverrides.socketConnect 
fixes #32535

Change-Id: I335e3698ec3505114d480ae6179254fa0ade3f7a
Reviewed-on: https://dart-review.googlesource.com/48702
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Todd Volkert <tvolkert@google.com>
 2018-03-28 23:07:49 +00:00
Dan Rubel f858e5d539 Replace Token.previous usage in BodyBuilder 
Change-Id: If96a87086724e05756ab237a2afdec6782bfca3c
Reviewed-on: https://dart-review.googlesource.com/48660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-28 22:58:19 +00:00
danrubel f66532b31b Replace more occurrences of token.previous with findPrevious 
Change-Id: If86539e4a50caec456891e58cb9f928762860282
Reviewed-on: https://dart-review.googlesource.com/48560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-28 22:41:58 +00:00
Natalie Weizenbaum d46915d239 Bring in the latest pub 
Change-Id: If138dd10ebae40bf031c05d9702f166abfb511e5
Reviewed-on: https://dart-review.googlesource.com/48525
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
 2018-03-28 21:50:28 +00:00
Brian Wilkerson 7470f410dd Clean up documentation of command-line analyzer options 
Change-Id: If37cfbd7f1187229ab90205e59a7eb60d3b884cf
Reviewed-on: https://dart-review.googlesource.com/48701
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-28 21:15:58 +00:00
Ben Konyi 4b682341d9 [ VM / Dart 2 ] Marked tests that exercise functionality not supported in Dart 2 as SkipByDesign. 
Change-Id: I9e02b2663a00861c4e11dd21cc74bd32bbef33cb
Reviewed-on: https://dart-review.googlesource.com/47420
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-28 20:45:48 +00:00
Konstantin Shcheglov 859632b439 Fixes for uninitialized fields of Flutter widgets create constructors in Flutter style. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2021
Change-Id: Ia5c8989d463ce7071b31069313e4638dea7b13a6
Reviewed-on: https://dart-review.googlesource.com/48700
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-28 20:28:28 +00:00
Jenny Messerly c9e9c1d8e9 Remove dart:isolate runtime support in DDC 
This disables most runtime features of dart:isolate, similar to dart:io.

For now, this supports `new ReceivePort()` and `ReceivePort.close` as
those are used by async tests to keep the Dart VM alive. Those are
no-ops in DDC. Also removes most of dart:_isolate_helper, except for
the JS API that's used to bootstrap DDC `main()`.

Change-Id: I84eab6cd39d05a70a6afe982e952076ddaaa8c0f
Reviewed-on: https://dart-review.googlesource.com/45754
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-28 19:42:08 +00:00
Zach Anderson 0482cf4da1 [fuchsia] Add rules to build gen_snapshot targeting Fuchsia 
This change enables building a gen_snapshot that targets Fuchsia during
an SDK build that targets the host (Mac, Linux).

Change-Id: I4cfbcbe4e26e4be7108fc40c96122fe9a2fb4c19
Reviewed-on: https://dart-review.googlesource.com/48683
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-03-28 19:39:49 +00:00
Sigmund Cherem 2de82410e0 Make isolate patch play nice with web workers. 
Closes https://github.com/dart-lang/sdk/issues/32438

Change-Id: I14163ef868365bf5faecfdfaccb54047391e0f80
Reviewed-on: https://dart-review.googlesource.com/48520
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-03-28 19:14:18 +00:00
Paul Berry be3baa0b8f Additional ExprBuilder implementation. 
This CL makes the following improvements:

- Makes ParameterElementImpl._unlinkedParam public so that it can be
  used by the ExprBuilder.

- Adds logic to ExprBuilder to create elements for closure parameters
  and to resolve references to those elements.

- Adds support for async closures.

- Adds support for nested closures.

Change-Id: I4b2c2271dac44bb54eb12049de7143b14adef84a
Reviewed-on: https://dart-review.googlesource.com/48680
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-28 18:55:29 +00:00
Ben Konyi 42581e4fa6 [VM] Added '--enable-asserts' to the top-level help message. 
Change-Id: I91b22cc1563b7c5217f21032109d948a5bb78b57
Reviewed-on: https://dart-review.googlesource.com/48456
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-03-28 18:54:00 +00:00
Konstantin Shcheglov 44dbba2b80 Use offset/length of the import prefix, or empty. Same for constructor names. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32685
Change-Id: I40b7f9c679b04725db19dad661e3a88a4a982f1c
Reviewed-on: https://dart-review.googlesource.com/48682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-28 18:19:09 +00:00
Régis Crelier 85b4c604c5 [VM runtime] Improve type error messages in Dart 2 (fixes #32564). 
Hide private class _Future and map it to core lib class Future.
In Dart 2, show dynamic as type argument(s) of raw generic types.

Change-Id: I70b0e1707bc767d04838ac12d16b3ad15623f51f
Reviewed-on: https://dart-review.googlesource.com/48502
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-28 17:12:04 +00:00
Paul Berry ebdee7ee0f More prep work to allow the linker to re-use resolution logic. 
See #32525.

This CL makes the following changes:

- Extracts the logic from AbstractClassElementImpl.getSetter to a
  static method so it can be re-used by the summary linker.

- Modifies ParameterElementImpl._resynthesizeTypeAndParameters so that
  it avoids unnecessary calls to resolveLinkedType.  This is crucial
  because resolveLinkedType is not available when linking.

- Makes it possible to suppress reporting of const evaluation errors
  when doing resolution.  This is necessary because in order to report
  these errors we must do constant evaluation, which is not possible
  during summary linking.

- Modifies ResolverVisitor._hasSerializedConstantInitializer to avoid
  unnecessary calls to LibraryElementImpl.hasResolutionCapability.
  This is crucial because the linker contains an implementation of
  LibraryElementImpl that's incompatible with
  LibraryElementImpl.hasResolutionCapability.

Change-Id: Iec91bd8d6a68193e091c2438bafcd7cb15488d89
Reviewed-on: https://dart-review.googlesource.com/48681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-03-28 16:54:44 +00:00
Paul Berry 91e6c8b019 Fix missing_return warning in expr_builder.dart 
Change-Id: Ia1157d668f46114ded9f017dce3b11e202c6a76b
Reviewed-on: https://dart-review.googlesource.com/48561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-03-28 07:53:04 +00:00
Konstantin Shcheglov 59de9710ea Complete Flutter's setState() as a whole statement, with a closure, and the caret inside the closure. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1916
Change-Id: I90b8c11c5435e1981fb334a4762bbe2131f3064f
Reviewed-on: https://dart-review.googlesource.com/48526
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-28 04:26:36 +00:00
danrubel b82e5b4704 Replace code completion usage of token.previous with findPrevious 
This CL is the first in a multi-part effort to remove the `previous`
field from the Token class. This first step introduces a new findPrevious
utility method that finds the the token before a given token in a token stream,
and then replaces usages of token.previous with calls to this
new findPrevious utility.

Change-Id: I57de4e542adb5950f1bddd951ff555dd98b19b3b
Reviewed-on: https://dart-review.googlesource.com/48461
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-28 02:27:54 +00:00
Konstantin Shcheglov 0e8457c8c8 Fix for building sequence of identifiers and several tests. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/32525
Change-Id: Iddc0a4825e98bf186e6c3da0fd24c81a95b96522
Reviewed-on: https://dart-review.googlesource.com/48501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-28 01:36:25 +00:00
Terry Lucas 6a84638d7a Updated for proper failure. 
TBR=kevmoo@google.com

Change-Id: Ie3ec0d72f03b441bd305eafbd78aa9eb370a9a21
Reviewed-on: https://dart-review.googlesource.com/48540
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-28 00:08:05 +00:00
Sigmund Cherem 577b168c39 Fix jsinterop bug: we incorrectly added null values for js-interop constructor 
calls.

Closes https://github.com/dart-lang/sdk/issues/32697

Change-Id: I7f372e9f32ec415f5d0e1472c04085029f41d5b9
Reviewed-on: https://dart-review.googlesource.com/48522
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-28 00:06:04 +00:00
Terry Lucas 8e02ff92db Added @category annotation for Web libraries and removed createCustomUpgrader. 
TBR=jcollins@google.com

Change-Id: I151e8d8af4bc647bdf47399c11f83b1625dabcf6
Reviewed-on: https://dart-review.googlesource.com/48523
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-27 23:53:14 +00:00
Alexander Markov c60199cf86 [vm/kernel/aot] Tree shaking based on results of TFA, take 2. 
This is a re-landing of

https://github.com/dart-lang/sdk/commit/06ebf884db61b97a60b1578560678329cd51bf61

after the fix was submitted separately at

https://github.com/dart-lang/sdk/commit/e3b9c2860e46f9d673ffc3129ede2a11c6125d06

Original review: https://dart-review.googlesource.com/c/sdk/+/46942

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I2d3a10acb9b5af0184b3d1504acb2f4ebebfff8a
Reviewed-on: https://dart-review.googlesource.com/48440
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-03-27 23:39:24 +00:00
Terry Lucas b217e21907 Mark a few more co19 failures to fix. 
TBR=kevmoo@google.com

Change-Id: I319903466ef7efce6d61e25e33f5163eb8e7515f
Reviewed-on: https://dart-review.googlesource.com/48521
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-27 22:59:40 +00:00
Samir Jindel 70f455351d [kernel] Add field for instantiate-to-bounds algorithm in TypeParameter. 
Change-Id: Idd1859b378080f01dc5d5078ee0960021c1689b6
Reviewed-on: https://dart-review.googlesource.com/48424
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-27 22:26:07 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-27 20:45:33 +00:00
Sigmund Cherem f9e12f1116 step 3 of ??: ignore old options from old FE 
* preserve-comments: unused, only used for source-mirrors & dartdoc long long ago
* preserve-uris: ignored, mirrors-only flag
* allow-native-extensions: error, was only used for analyze-only with the old FE

Change-Id: Ic93c31edf188cdab3aa658c13018a432baf14742
Reviewed-on: https://dart-review.googlesource.com/48457
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-27 20:18:37 +00:00
Sigmund Cherem c0fa4e2fe3 step 2 of ??: remove unnecessary pattern in -m option 
Change-Id: I58757a0988c2275a617e2fa13903de66585b8dd4
Reviewed-on: https://dart-review.googlesource.com/48454
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-27 20:18:32 +00:00
Sigmund Cherem 51867f28a2 step 1 of ??: cleaning up options... 
* remove serialization options
* remove checks that are only for the old FE (e.g. checks about imply compilation and --analyze-*)

Change-Id: I148025a7158340339bba4205f3b961b3c9902e47
Reviewed-on: https://dart-review.googlesource.com/48453
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-27 20:18:26 +00:00
Ben Konyi e305117519 [ VM / Flutter ] Replaced NO_RETRY_EXPECTED with VOID_TEMP_FAILURE_RETRY in console_posix.cc:69. 
Change-Id: Iaa5772476bfc81b01a646b16a9d8280ef0edf788
Reviewed-on: https://dart-review.googlesource.com/48465
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-03-27 19:15:22 +00:00
Konstantin Shcheglov 28c4de8207 Resynthesize more expressions in ExprBuilder. 
One thing that occurred to me is that maybe we don't need precise
resynthesis of some expressions, e.g. `a is T`, because it does not
have dependencies, and has known type. Thoughts?

We already kind of went this way by not serializing arguments of
invocations with type arguments, and cascades.

OTOH, it might be simplier to resynthesize where it is easy.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/32525
Change-Id: I742b1adc6ae22d8743ef127af7d6a33446e53449
Reviewed-on: https://dart-review.googlesource.com/48466
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-27 18:54:23 +00:00
Brian Wilkerson d3295ded48 Remove the SORT_MEMBERS refactoring from the spec 
Change-Id: Ic8b8135f22d8c3c07d4ded661ac43d2d5105dc3f
Reviewed-on: https://dart-review.googlesource.com/48464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-27 16:37:44 +00:00
Janice Collins f386b367a5 Update dartdoc to v0.18.0 and tag library categories. 
Bug: https://github.com/dart-lang/sdk/issues/32297
Change-Id: Id99c98c1b908c5a4b42594cd7e73cd92e089bbca
Reviewed-on: https://dart-review.googlesource.com/48450
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-27 16:19:34 +00:00
Paul Berry 7df4235587 Make _ConstExprBuilder re-usable. 
This CL moves _ConstExprBuilder to its own file, renames it to
ExprBuilder (so that it can be re-used for non-const expressions), and
begins adding support for expression types that can appear in
non-const expressions.

It also introduces an expr_builder_test.dart file to make testing of
ExprBuilder easier.

See #32674.

Change-Id: I5a3d91408c51770ee8f70621032a2f0767eaea55
Reviewed-on: https://dart-review.googlesource.com/48462
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-27 15:49:35 +00:00
Samir Jindel eeba621943 [kernel/vm] Build NSM forwarders for getters and setters. 
They are necessary for performing type-checks.

Change-Id: Ie30f0617488730d920c00229fb2ec358cc8d6c4b
Reviewed-on: https://dart-review.googlesource.com/48421
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-03-27 14:40:04 +00:00
Dmitry Stefantsov c3872eedf8 [fasta] Generate noSuchMethod forwarders for abstract setters 
Change-Id: Ic5bcb318c156a5e8716ced8ba9d2826f73c84a4d
Reviewed-on: https://dart-review.googlesource.com/48425
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-27 13:25:35 +00:00
Johnni Winther 36c2a71fcf Handle FutureOr in RuntimeTypeNeed/Checks computations. 
Change-Id: I3b5b3f3feb665ff2f34b0975fb0062515a7b6ffd
Reviewed-on: https://dart-review.googlesource.com/48400
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-27 08:03:32 +00:00
Jenny Messerly 192b4621ba Fix DDC shadowing bug with named arguments and async functions. 
Change-Id: I4c01ab03bc02d0e533b6d27d43e824aad5d32fea
Reviewed-on: https://dart-review.googlesource.com/48458
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-27 00:34:46 +00:00
Jenny Messerly a914cac65e fix #32481, DDK signatures for mock members induced by nSM 
This bug prevented various DDK features from working correctly at
runtime, such as tearoffs, dynamic call checking, generic methods, and
parameter type checks.

This was fixed for DDC in https://dart.googlesource.com/sdk/+/40738b8884e584f8b6fce26b71e9692c0067db18

Change-Id: I91fd12b3c167341c692d8d3e7ad2217dd78d2950
Reviewed-on: https://dart-review.googlesource.com/45964
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-27 00:25:32 +00:00
Ben Konyi 6e0f2f4e47 [ VM / Dart 2 ] Fixed StackOverflow tests. 
Made modifications to the original VM flow graph builder so the token
position for the top frame of the overflow stack is the same as the
token position of the method (before we pointed to the opening '{' or
'=>').

Change-Id: I5c878fc238898e2fea197ea80ed4e320adca9439
Reviewed-on: https://dart-review.googlesource.com/48448
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-03-26 23:47:11 +00:00
Ben Konyi a7e3c2e365 [ VM / Dart 2 ] Fixed strong-mode issue in Native SendPort tests. 
Change-Id: I37a437d338d67095038130981b5fa947e0425b9d
Reviewed-on: https://dart-review.googlesource.com/48452
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-03-26 22:42:02 +00:00
Samir Jindel 83c5778345 [kernel/vm] Cleanup NSM forwarding. 
Change-Id: Ia2077d2752fbeb45da7d1051cdab0c16d67377d0
Reviewed-on: https://dart-review.googlesource.com/48420
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-03-26 22:34:02 +00:00
Konstantin Shcheglov 0f7622d945 Remove 'stateful' option from the 'Extract Widget' refactoring. 
There is already a Quick Assist to convert StatelessWidget to StatefulWidget,
and duplicating implementation is not very nice.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Iacbe58c9d05359ec96a86affc774c83532f7456f
Reviewed-on: https://dart-review.googlesource.com/48451
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-26 22:18:42 +00:00
Sigmund Cherem 5d7820e68a Simplify option processing 
Using immutable options objects was nice, but it came with a tax every time we added or modified
options (often having to edit 5 locations). I'm now using a mutable object and
default values are inline with the field declaration.

Change-Id: I92768f0ff50a4140271dc0ebfa3b615c94a57e4d
Reviewed-on: https://dart-review.googlesource.com/48446
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-26 21:55:32 +00:00
Sam Rawlins 301b5a1f16 Remove Maps; move _fillMapWith* methods to MapBase 
Fixes #31843

Bug: https://github.com/dart-lang/sdk/issues/31843
Change-Id: I02c544c921951f4a50421205dc1f25997cbecd6e
Reviewed-on: https://dart-review.googlesource.com/39880
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-03-26 21:23:21 +00:00
pq 742ddd104a Pull in Linter 0.1.46 
* performance fixes for library prefix testing (`library_prefixes`)
* new `avoid_bool_literals_in_conditional_expressions` lint
* new `prefer_equal_for_default_values` lint
* new `avoid_private_typedef_functions` lint
* new `avoid_single_cascade_in_expression_statements` lint

Change-Id: I4abd83e6b8e269eab992dcea2f227f0f1f805fa0
Reviewed-on: https://dart-review.googlesource.com/48449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-26 20:47:56 +00:00
Paul Berry b4e176b570 Adjust timeout for reanalyze_concurrent_test.dart. 
Change-Id: Ic1cb4aa69cfeec14109b9503db140f85fcfab06b
Reviewed-on: https://dart-review.googlesource.com/48445
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-26 20:20:52 +00:00
Konstantin Shcheglov 8d1a0749b9 Create parameters only for unique referenced elements. 
R=brianwilkerson@google.com

Change-Id: I1aad38c68454016846601b861432695eb6632242
Reviewed-on: https://dart-review.googlesource.com/48444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-26 19:17:18 +00:00
Konstantin Shcheglov cde2d81676 Check for name conflict in 'Extract Widget' refactoring. 
R=brianwilkerson@google.com

Change-Id: Ifa620eafa32e4c2ce8b062328b562d6991ddfa0b
Reviewed-on: https://dart-review.googlesource.com/48442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-26 18:54:38 +00:00