dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Rubel 1daa81339f Improve fasta parser enum declaration recovery 
In addition to improving recovery when an enum declaration is missing
a body, this CL also fixes ensureBlock to report an error on the
correct token and cleans up some more analyzer tests.

Change-Id: I96e9f8380b8d92082d94fcc9fa4b8cfe113fa238
Reviewed-on: https://dart-review.googlesource.com/48980
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-02 17:55:14 +00:00
Konstantin Shcheglov fabc51bbf7 Silence parser recovery tests. 
I realize that it is convenient to get debug output while working on
a test, but it is probably better to enable this debug output only
while one is working in this area, not for everyone ;-)

R=brianwilkerson@google.com, danrubel@google.com

Change-Id: I4027b3351eba07ba2b5e13471bbdb076ee72d388
Reviewed-on: https://dart-review.googlesource.com/48764
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-02 17:50:54 +00:00
Konstantin Shcheglov feceb2c59e Restore ErrorCode default constructor, rename the one with named parameters to 'temporary'. 
R=brianwilkerson@google.com

Change-Id: If0577d0e3da0abdef83f0f46f979014b69f76202
Reviewed-on: https://dart-review.googlesource.com/49020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-02 17:38:45 +00:00
Brian Wilkerson 616acb06ec Deprecate the option to enable using a URI in a part-of directive 
Change-Id: Ie9df0d727c0f81c9671ccedf5ba4d21cdbbe65b8
Reviewed-on: https://dart-review.googlesource.com/48892
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-02 16:25:04 +00:00
Dan Rubel 374058aa79 Improve fasta parser try/catch error messages and recovery 
Change-Id: I6e591fa5d03c73aa6f3e8060f2ca310f68be9a78
Reviewed-on: https://dart-review.googlesource.com/48709
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-01 02:14:52 +00:00
Konstantin Shcheglov 79a349fa07 Don't put libraries of all analyzed units into the current session. 
This is expensive, and we rarely need this.
Requesting LibraryElement by URI costs 6-7 ms, and we need to do it
only once after a change for each library.

R=brianwilkerson@google.com

Change-Id: I7c959abdaf27e99695ffa6d451d3c516a55b7740
Reviewed-on: https://dart-review.googlesource.com/48920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-31 02:00:51 +00:00
asiva a0470fefb6 Remove implicit_creation/implicit_new_or_const_composite_test from the status file under darkp as the test now passes. 
Change-Id: I672127172ffcfcdc603d90671bb7e51c2d0b4dda
Reviewed-on: https://dart-review.googlesource.com/48960
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-31 01:53:31 +00:00
Stephen Adams 0c892a8bc8 Improve signatures of tear-offs 
Signatures for static tear-offs cannot have free variables, so we can
always generate them in the types table.

Signatures for instance tear-offs can always use the existing
mechanism, since the type must be parameterized only by the class
instance type parameters.

Change-Id: I3ccfe8fc9220c57cfee07e1f7d9afbd5674b2b92
Reviewed-on: https://dart-review.googlesource.com/48841
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-03-31 01:30:21 +00:00
Stephen Adams 9858ea1f8d Explicitly store isIntercepted in full emitter tearoffs 
The trick of detecting isIntercepted from the number of arguments does
not work with function type arguments. We fixed this in other places,
now fix it in the full emitter.

Change-Id: I35fcda11db1df0e7442b66317c9ea20674514722
Reviewed-on: https://dart-review.googlesource.com/48922
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-03-31 00:02:11 +00:00
Alexander Markov a60b4d6f56 [kernel/vm/aot] De-duplicate identical mixin applications 
Closes https://github.com/dart-lang/sdk/issues/32458

Change-Id: I8439541375d806b0c3ebc5bda2d43a0a0f6643e4
Reviewed-on: https://dart-review.googlesource.com/48884
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-03-30 23:38:03 +00:00
Ryan Macnak 3db2338283 [vm] Remove old --break_at_isolate_spawn. 
This has long been replaced with --pause_isolates_on_start.

Change-Id: Ibf5850473b0d2090ec8ff244897a214149fb250c
Reviewed-on: https://dart-review.googlesource.com/48882
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-03-30 22:52:02 +00:00
Ryan Macnak 5941ebc33b [observatory] Filter platform dil files. 
These were ending up in the archive only in Fuchsia tree.

Change-Id: I8979663c596831e99eec764046e9b57bbf15f01b
Reviewed-on: https://dart-review.googlesource.com/48889
Reviewed-by: Zach Anderson <zra@google.com>
 2018-03-30 22:48:07 +00:00
asiva 996a66d247 Fix build bot failure in dartkp mode (language_2/implicit_creation/implicit_new_or_const_test now passes) 
Change-Id: Ic079d4012cee62fe4c42321dbe2c5a795e90b890
Reviewed-on: https://dart-review.googlesource.com/48921
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-30 22:38:43 +00:00
Natalie Weizenbaum 76db5505ec Bring in the latest pub and pub_semver 
This fixes a couple edge cases in the new version solver.

Change-Id: I70cf03790f5adbb5ec4f3ddddf42f9c798d7d3c5
Reviewed-on: https://dart-review.googlesource.com/48888
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
 2018-03-30 21:39:41 +00:00
asiva c1432bf7a3 [observatory] Remove references to pkg:browser from web/index.html 
Updated version of dart-lang/observatory_pub_packages in DEPS

Updated generated pubspec.yaml file after removing web_components from
third_party/observatory_pub_packages

This should fix part of issue https://github.com/dart-lang/sdk/issues/32539

Bug: 32539
Change-Id: I3d48fd59f1fedc9d64a652cde7d0229c0a7ace28
Reviewed-on: https://dart-review.googlesource.com/48804
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-30 21:13:52 +00:00
Ben Konyi 52afcba357 [ VM ] Fixed issue where process was suspended at exit when backgrounded. 
Restoring console state when backgrounded causes SIGTTOU to be raised by
tcsetattr, which has the affect of suspending the process instead of
allowing it to complete. Blocking SIGTTOU results in tcsetattr failing
gracefully and the process running to completion.

Change-Id: I605dccbdbf311697881e5729e4fd64f1d60ed6b1
Reviewed-on: https://dart-review.googlesource.com/48823
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-03-30 20:33:12 +00:00
Jenny Messerly cdc696f9a7 fix status of VM precomp tests to match its callable function support 
(The status entries match the standard Dart 2 VM behavior.)

Change-Id: I6c939ca04c892959479b00621ad8dc27767a5f0a
Reviewed-on: https://dart-review.googlesource.com/48890
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-03-30 20:11:10 +00:00
Janice Collins ee73718e50 Change to dartdoc v0.18.1. 
Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v0.18.1

Change-Id: I48fe72b520651acd4652a8454b668d0e10ae0d4d
Reviewed-on: https://dart-review.googlesource.com/48886
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2018-03-30 19:29:56 +00:00
Konstantin Shcheglov e5ed23fdb5 Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled." 
This reverts commit a1e4d8e0bf.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Don't do implicit new/const code generation with --preview-dart-2 enabled.
> 
> R=​brianwilkerson@google.com, devoncarew@google.com
> 
> Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
> Reviewed-on: https://dart-review.googlesource.com/48883
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: Ie3acf0794ed7b8264682e29aaa4bc1516fce6981
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/48900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 19:24:46 +00:00
Jenny Messerly 6fecb1e263 fix analysis_server for callable function change in Analyzer 
Change-Id: Ibb87b80399deb1b780a412f2a640b8b8cec6425a
Reviewed-on: https://dart-review.googlesource.com/48887
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-03-30 19:19:27 +00:00
Jenny Messerly 60630ed80f fix #30540, define dart.library.mirrors and isolate false in DDC 
Change-Id: I0d26d32724096bfbebd53f4a0adcbbd9194cb8ec
Reviewed-on: https://dart-review.googlesource.com/48885
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2018-03-30 19:16:05 +00:00
Dmitry Stefantsov 59d859645e [fasta] Do new/const insertion in simple cases 
Bug: http://dartbug.com/32553
Change-Id: I58e201ffd5019a5a65c0ac188aaab363225b5296
Reviewed-on: https://dart-review.googlesource.com/48481
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-30 18:35:05 +00:00
Ryan Macnak 4c0a09b79f [vm-service] Add setFlag. 
Bug: https://github.com/dart-lang/sdk/issues/32709
Change-Id: I7777b005c477574c93430d56ede6cde2cd421203
Reviewed-on: https://dart-review.googlesource.com/48803
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Todd Volkert <tvolkert@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-30 18:17:55 +00:00
Jenny Messerly bed5debbeb Callable object support in Analyzer and DDC. 
Fixes #32156
Fixes #32157
Fixes #32426

This also fixes `implements Function` so it has no effect in Dart 2
(it is ignored for the purposes of subtyping.)

Change-Id: Ibec9c77cd516b8b97fef68a579998598d0acf8c6
Reviewed-on: https://dart-review.googlesource.com/45141
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-30 18:14:55 +00:00
Konstantin Shcheglov a1e4d8e0bf Don't do implicit new/const code generation with --preview-dart-2 enabled. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
Reviewed-on: https://dart-review.googlesource.com/48883
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 18:07:25 +00:00
Terry Lucas 49558b9c4c Fixed MessageChannel receiveing messages on ports. 
Removed pkg browser from tests.

Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631

R=kevmoo@google.com

Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-30 17:16:15 +00:00
Konstantin Shcheglov e150bf638c Fix tests for missing required SDK libraries on Windows. 
I have not tried them on Windows, hopefully it will help.

R=brianwilkerson@google.com

Change-Id: I1446a834f95398979337db4b887e3d76c3ec164f
Reviewed-on: https://dart-review.googlesource.com/48880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 16:14:55 +00:00
Johnni Winther b970d834e1 Update type_representation_test to test strong mode types 
Change-Id: Id2d88952f802796f3d7e4ff21593e0aec83eeee2
Reviewed-on: https://dart-review.googlesource.com/48620
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-30 12:12:00 +00:00
Johnni Winther 85d5812a93 Port type_representation_test to work with kernel 
Change-Id: Icfc60f741fd00386d781c1d6dd1a4b874478a1fb
Reviewed-on: https://dart-review.googlesource.com/48601
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-30 11:36:57 +00:00
Johnni Winther 8504808ce3 Remove Dart 2 errors in package:js_ast 
Change-Id: I1684a662bb777e2175cb0f1a6590136ab3ba5cc2
Reviewed-on: https://dart-review.googlesource.com/48580
Reviewed-by: Stephen Adams <sra@google.com>
 2018-03-30 11:21:21 +00:00
Johnni Winther a6a2152482 Add runtime type representation for void 
Change-Id: Id4eff63656fc5eacfa7aada6120d85acec735cad
Reviewed-on: https://dart-review.googlesource.com/48426
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-30 11:05:43 +00:00
Ian McKellar 477a773cdb [fidl] Port Dart runtime to FIDL2. 
Change-Id: I0423c17514027b282856f5796a550ceaa3b66baf
Reviewed-on: https://dart-review.googlesource.com/48840
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Adam Barth <abarth@google.com>
 2018-03-30 05:23:36 +00:00
Jenny Messerly d46dd1bd68 fix error message for dcalls on null 
Change-Id: I0f3ab303ce8844c9b147a21f3233ef04ec0acb66
Reviewed-on: https://dart-review.googlesource.com/45920
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-30 00:34:29 +00:00
Kevin Moore af22f6a591 Track calls to 'pub get' from analysis_server 
Fixes https://github.com/dart-lang/sdk/issues/32712

Change-Id: I04825e03e57dd2c45de7a332942c0a8e6415286d
Reviewed-on: https://dart-review.googlesource.com/48800
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 22:29:49 +00:00
Sigmund Cherem 8d689fcca7 step 4 of ??: add omit-implicit-checks and preview-dart-2 flags, strong-mode 
defaults to include implicit checks.

Closes https://github.com/dart-lang/sdk/issues/32332

Change-Id: Iad5311234dec50a3f8dbd6557264b3feeb92afc8
Reviewed-on: https://dart-review.googlesource.com/48459
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-29 22:13:09 +00:00
Konstantin Shcheglov f201ace7f3 Check for missing required libraries dart:core and dart:async. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32686
Change-Id: I337cb61911061f25b501a5615fe40c02b9749b19
Reviewed-on: https://dart-review.googlesource.com/48703
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 22:09:50 +00:00
Konstantin Shcheglov d53291d156 Fix MockErrorCode after adding isUnresolvedIdentifier. 
R=brianwilkerson@google.com

Change-Id: Ic8bb1bbc9ade3e895f59ece50f29c012a4d7284f
Reviewed-on: https://dart-review.googlesource.com/48801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-29 21:58:09 +00:00
Régis Crelier b05ba71b0c [VM runtime] Minor clean up of type test with non-function type object. 
Change-Id: I2d15c43d12f143d6566615c7b95fff678408beb5
Reviewed-on: https://dart-review.googlesource.com/48500
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-03-29 21:52:32 +00:00
Konstantin Shcheglov ce1d52481c Don't remove unused imports when there are unresolved symbols. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32124
Change-Id: If1b7b57bd98922768f28584325f668ba612c69d7
Reviewed-on: https://dart-review.googlesource.com/48705
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 21:44:19 +00:00
Konstantin Shcheglov ad9afa1656 Add the isUnresolvedIdentifier flag for ErrorCode. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32124
Change-Id: I8d69113d29cb20f0426924a1ea049f9daa53d803
Reviewed-on: https://dart-review.googlesource.com/48780
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 20:48:28 +00:00
Konstantin Shcheglov 14806df576 Make correction parameter optional named in ErrorCode and subclasses. 
This is a preparatory step before adding a flag that signals
that the error code represents an unresolved identifier situation.

R=brianwilkerson@google.com

Change-Id: Ic3b30e2efae7ee0c12a40d1cc2bd48c14185d926
Reviewed-on: https://dart-review.googlesource.com/48763
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 19:59:13 +00:00
Konstantin Shcheglov 98f627f989 Issue 32708. Make GenericFunctionTypeElementForLink implement GenericFunctionTypeElementImpl. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/32708
Change-Id: I50e3bf46ca276dbffed9cccb39d800bebb9aec68
Reviewed-on: https://dart-review.googlesource.com/48761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 19:47:29 +00:00
Konstantin Shcheglov 3306aabd82 Fix for type inference from instance creation arguments. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0e8386f2a7b3e6d034350a21e474fc1a297c0120
Reviewed-on: https://dart-review.googlesource.com/48762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-29 19:44:20 +00:00
Brian Wilkerson 055dfad887 Fix the test to determine whether a library is in the SDK 
Change-Id: I711daae49f27ca21fb4adce3c10ccb1bfc9d72a8
Reviewed-on: https://dart-review.googlesource.com/48760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 17:29:19 +00:00
Paul Berry 506ac7f953 Rework linker type inference using ExprBuilder. 
This CL changes the way linker type inference works.  Instead of
walking the operations in an UnlinkedExpr in order and inferring types
directly, it first builds an AST for the expression using ExprBuilder,
then uses ResolverVisitor to resolve the AST and perform type
inference.

This helps ensure that summary type inference and ordinary AST-based
type inference produce the same result, since they now use the same
core algorithm.  In particular, this means that summary type inference
now does downwards inference properly.

Since the ResolverVisitor makes greater use of the element model than
the rest of the linker, this required implementing additional methods
in the linker's element model.

This CL includes some minor fixes to ExprBuilder that were uncovered
during testing.  It also contains some minor changes to
ResolverVisitor to make it work during linking.

Fixes #32525.
Fixes #32394.

Change-Id: I5ec9b2bf5565ad30b8cc856475334323dc118da8
Reviewed-on: https://dart-review.googlesource.com/48741
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-29 17:16:39 +00:00
Paul Berry 494b861d00 Further prep work for #32525. 
This CL refactors the bodies of the following methods so that they can
be re-used by the summary linker:

- CompilationUnitElementImpl.getType
- LibraryElementImpl.createLoadLibraryFunction
- LibraryElementImpl.getImportsWithPrefix
- LibraryElementImpl.getType

Change-Id: I9b398d87323eb9ec6deb9a9a76bd6e9a1aa6bb76
Reviewed-on: https://dart-review.googlesource.com/48740
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-03-29 16:58:30 +00:00
Régis Crelier 7d90df42f1 [Kernel, VM runtime] Hook up bool checks in strong mode (fixes #32336). 
Update kernel status file.

Change-Id: I08b153d431c15870e0251e7dd760213c795579c9
Reviewed-on: https://dart-review.googlesource.com/48707
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-29 16:10:52 +00:00
Alexander Aprelev 4da52281aa [frontend-server] Return non-zero exit code if there are errors. 
Change-Id: I2a1c28b391fae1cb2f7dd20b9302c70fa2fbd44e
Reviewed-on: https://dart-review.googlesource.com/48684
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-29 02:45:39 +00:00
Sigmund Cherem d7a540bfe7 Document --enable-asserts in dart2js's help, and remove --checked. 
Closes #32648

Change-Id: I0d4cc8dd7117909b484be4119c0f5e7627cf3f85
Reviewed-on: https://dart-review.googlesource.com/48708
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-29 00:20:18 +00:00
Ryan Macnak d9c3190e44 [vm] Remove some bin -> vm includes. 
Change-Id: Id304de9618a299a201b946a901a54352772f56fb
Reviewed-on: https://dart-review.googlesource.com/48704
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-03-28 23:16:09 +00:00