dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

1689 Commits

Author SHA1 Message Date
antonm@google.com 80ce8347ac Use Directory, not a string. 
TBR=whesse@google.com

Review URL: https://codereview.chromium.org//11414300

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15669 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 23:20:26 +00:00
antonm@google.com 7526c02dab Fix string concatenation. 
TBR=whesse@google.com

Review URL: https://codereview.chromium.org//11299313

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15659 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 21:46:52 +00:00
antonm@google.com a229522c74 Hacky fix for paths with drive names on Windows. 
TBR=whesse@google.com

Review URL: https://codereview.chromium.org//11412306

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15654 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 20:52:41 +00:00
antonm@google.com 0522fc0442 Add some diagnostics to understand what goes on. 
TBR=whesse@google.com

Review URL: https://codereview.chromium.org//11308328

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15651 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 20:23:27 +00:00
antonm@google.com ac192a1c52 Add some diagnostics to understand what goes on. 
TBR=whesse@google.com

Review URL: https://codereview.chromium.org//11299306

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15650 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 19:19:45 +00:00
whesse@google.com 2b929563ed Fix test.dart's --build-directory option to accept absolute paths. 
BUG=

Review URL: https://codereview.chromium.org//11308293

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15632 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 12:35:00 +00:00
ricow@google.com 3f9aaca941 Don't run pub and pkg as default, explicitly add these to the test command for running 
Review URL: https://codereview.chromium.org//11428084

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15520 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-29 15:22:04 +00:00
ahe@google.com c17990a886 Call dart2js directly from sdk/bin. 
Review URL: https://codereview.chromium.org//11299206

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15512 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-29 12:15:29 +00:00
ricow@google.com a799a7e402 Add --checked or --minified to test directory name when generating output. 
Currently the compiled output will simply be overwritten if you run
non-checked mode followed by checked mode.
Review URL: https://codereview.chromium.org//11280085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15503 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-29 09:12:10 +00:00
ahe@google.com dd76d416c2 Make the PackageRoot test file option relative to the test file. 
BUG=http://dartbug.com/6817

Review URL: https://codereview.chromium.org//11411150

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15387 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-27 12:30:30 +00:00
ahe@google.com 438a21c698 Allow passing in command-line options to co19_test.dart. 
Review URL: https://codereview.chromium.org//11299161

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15372 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-27 09:14:08 +00:00
whesse@google.com 6220720429 Add --build-directory option to test.py. 
Fix problem when no --step-name option is present.

BUG=dart:6885

Review URL: https://codereview.chromium.org//11308179

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15280 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-23 12:54:04 +00:00
kustermann@google.com 8f86ec778d Remove the legacy --additional-compiler-flags option from test.py 
The --additional-compiler-flags option is no longer used. The buildbots
use the --minified option now.

Review URL: https://codereview.chromium.org//11299102

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15148 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-20 13:24:37 +00:00
kustermann@google.com 072625732c Pass --minify to dart2dart if --minified was specified on test.py 
Currently --minified on test.py has only an effect on dart2js commands.
The dart2dart commands use the legacy --additional-compiler-flags="--minify"
option.

This change is the first one of two CLs, where we pass --minify to dart2dart
if --minified was specified on test.py.

The second change will then remove the --additional-compiler-flags option
as soon as the build bots have been updated to use the new scheme for dart2dart.

Review URL: https://codereview.chromium.org//11419089

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15144 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-20 12:21:04 +00:00
kustermann@google.com cc3ef5ed38 Make SummaryReport.addCompileErrorSkipTest() depend on --report 
Review URL: https://codereview.chromium.org//11316100

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15138 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-20 09:29:13 +00:00
kustermann@google.com 52077af7fa Revert "Added support for skipping redundant dart2js compilations." 
We must disable this feature until we've made sure that the boolean
dart2js flags (e.g. --checked) are included in the directory names.

TBR=ahe

Review URL: https://codereview.chromium.org//11280061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15087 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 15:47:59 +00:00
kustermann@google.com f4bc6a5f3f Added support for skipping redundant dart2js compilations. 
Currently, the buildbots run tests on every commit. But often neither
the tests nor the dart2js compiler did change (e.g. on status file updates).

The added code will check if the dependencies (i.e. files listed in
test.js.deps) or the dart2js snapshot did change. If not, the output
of the previous dart2js compilation is up to date and the compilation
step is skipped.
The skipping of redundant dart2js compilations works only if the '--use-sdk'
option was specified (because in this case the dart2js snapshot is used).

Review URL: https://codereview.chromium.org//11369216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15080 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 13:56:11 +00:00
ahe@google.com bbddb15ea2 Pass package-root option to dart2js in browser tests. 
Review URL: https://codereview.chromium.org//11414056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15076 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 13:08:17 +00:00
ahe@google.com f4ca9548c9 Allow tests to specify a package root. 
Use a shared package root if none is specified.

Committed: https://code.google.com/p/dart/source/detail?r=15064

Review URL: https://codereview.chromium.org//11359187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15070 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 11:35:57 +00:00
ahe@google.com 88a921030d Revert "Allow tests to specify a package root." 
Revert "Add dependencies for bots that doesn't build everything."

This reverts r15066 and r15064.

Review URL: https://codereview.chromium.org//11414055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15068 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 10:42:55 +00:00
ahe@google.com 89cc5a2d23 Allow tests to specify a package root. 
Use a shared package root if none is specified.

Review URL: https://codereview.chromium.org//11359187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15064 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 09:51:17 +00:00
kustermann@google.com 42b89c9f77 Changed: TestCase.output -> TestCase.commandOutputs[] 
Currently the TestCase has exactly one TestOutput. This worked
until now, since we were only interested in the output of the
last command.

This change introduces one CommandOutput for each command which
has been run. Doing so enables us to fetch output (stdin,stderr)
information as well as exitCode ... for all commands.

See also 11293278.

Review URL: https://codereview.chromium.org//11348088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15006 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-16 11:17:47 +00:00
kustermann@google.com 3dc5c7056a Revert of commit 14947 
Review URL: https://codereview.chromium.org//11348060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14949 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-15 09:15:43 +00:00
kustermann@google.com 5ec78286df Changed: TestCase.output -> TestCase.commandOutputs[] 
Currently the TestCase has exactly one TestOutput. This worked
until now, since we were only interested in the output of the
last command.

This change introduces one CommandOutput for each command which
has been run. Doing so enables us to fetch output (stdin,stderr)
information as well as exitCode ... for all commands.

Review URL: https://codereview.chromium.org//11293278

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14947 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-15 09:05:41 +00:00
ajohnsen@google.com 970cc5ba68 Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. 
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.

BUG=

Review URL: https://codereview.chromium.org//11365196

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 10:41:37 +00:00
ajohnsen@google.com ab69873a42 Make RegExp constructor non-const. 
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.

BUG=

Review URL: https://codereview.chromium.org//11369210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 10:18:06 +00:00
ajohnsen@google.com ec9fee9858 "Reverting 14829-14832" 
BUG=

Review URL: https://codereview.chromium.org//11312203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 07:28:13 +00:00
ajohnsen@google.com 8dc3edd7ce Make RegExp's constructor non-const. 
BUG=

Review URL: https://codereview.chromium.org//11410033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 06:48:43 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b) 
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-12 17:19:58 +00:00
antonm@google.com 1ba6e54811 Do not generate multiple tests for vm options. 
R=ahe@google.com,ager@google.com
BUG=6436

Review URL: https://codereview.chromium.org//11358175

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14786 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-12 13:26:30 +00:00
rnystrom@google.com f30fb024ce The goal here is to rearrange StandardTestSuite so that it's possible override some of its behavior for running package tests while still keeping the rest of the behavior. 
This patch is just the refactoring. I'll do the actual pub stuff in a separate patch.

Review URL: https://codereview.chromium.org//11275217

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14757 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-09 20:56:59 +00:00
kustermann@google.com e78ad924f6 Added support for logging the output of failed flaky tests. 
Failed flaky tests will be logged to 'failed_flaky_tests.log'.
The default behavior is that the old log file gets deleted before
any tests are run. To prevent this, the '--append_flaky_log' option
can be set.

Review URL: https://codereview.chromium.org//11364129

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14735 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-09 12:08:00 +00:00
efortuna@google.com 4a23980c8a Take 2 of splitting html tests into subtests. Had to make two changes to drt to 
fully work.
Review URL: https://codereview.chromium.org//11368128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14703 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-08 18:54:14 +00:00
efortuna@google.com 868b439bc4 Revert run large html tests individually. 
Review URL: https://codereview.chromium.org//11406002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14667 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-08 00:11:09 +00:00
efortuna@google.com bf9cd05e79 Move html_individual_config to correct location after tree rearranging. 
Review URL: https://codereview.chromium.org//11362147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14664 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-07 23:53:11 +00:00
efortuna@google.com 3476d1c528 Run large html tests individually. 
Review URL: https://codereview.chromium.org//11293019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14663 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-07 23:42:50 +00:00
kustermann@google.com 3462f1ecaa Don't run compile-time error tests on browsers. 
Also added a new category to the report stating the number of tests
we skipped because of this.

Review URL: https://codereview.chromium.org//11368101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14571 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-06 14:46:10 +00:00
ahe@google.com 9b49d61cfb Fix syntax errors. 
Review URL: https://codereview.chromium.org//11362079

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14512 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-05 06:22:15 +00:00
ahe@google.com a57b4fbf71 Prevent hanging if selenium cannot close browser. 
Review URL: https://codereview.chromium.org//11275125

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14511 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-05 06:17:33 +00:00
ahe@google.com dd897e755e Disable wrapping of Firefox/Windows dart2js tests. 
Review URL: https://codereview.chromium.org//11312059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14451 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-02 07:13:26 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions. 
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 23:09:47 +00:00
gram@google.com 353f4c4c8a Update test utils to generate wrappers with new library syntax and handle 
tests with new library syntax.
Review URL: https://codereview.chromium.org//11358045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14437 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 21:31:27 +00:00
ahe@google.com fbe2e51663 Disable Firefox console logging as it appears to hang the browser. 
See this selenium bug: http://code.google.com/p/selenium/issues/detail?id=4375

Review URL: https://codereview.chromium.org//11362036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14419 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 17:46:30 +00:00
ager@google.com 0fed52bd2d Only start http server for browser tests. 
This reduces the annoyance of the fixed port number used and allows
non-browser test configurations to be run in parallel (or one browser
configuration in parallel with a bunch of non-browser configurations).

R=ahe@google.com,ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//11360028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14403 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 12:58:44 +00:00
ager@google.com 83f2cfa4c1 Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your streams. 
When using an interactive process started with Process.start you have
to drain the stdout and stderr streams to make sure that all resources
are freed. If you do that the dart:io library will make sure to free
all system resources for you.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11343009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14187 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-29 11:59:09 +00:00
ager@google.com 7f04c40b2d Land update to tools directory with new binaries. 
BUG=

Review URL: https://codereview.chromium.org//11343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14176 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-29 09:21:14 +00:00
floitsch@google.com 7041a6bbf1 Make methods in Stopwatch getters and rename to be more consistent. 
Includes:
- Stopwatch.frequency.
- Stopwatch.elapsedInMs() -> Stopwatch.elapsedMilliseconds
- Stopwatch.elapsedInUs() -> Stopwatch.elapsedMicroseconds
- Stopwatch.elapsed() -> Stopwatch.elapsedTicks

Review URL: https://codereview.chromium.org//11265024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14140 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-26 14:25:23 +00:00
efortuna@google.com 7df114a8f1 Revert 14110 "Fix usesWebDriver check" 
Review URL: https://codereview.chromium.org//11275052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14111 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-25 23:26:23 +00:00
efortuna@google.com d1aff197ae Fix usesWebDriver check, and the usage of config['browser'] vs config['runtime'] 
Review URL: https://codereview.chromium.org//11275025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14110 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-25 23:14:55 +00:00
ricow@google.com 252f09bc40 Testing support for running tests minified in dart2js. 
Review URL: https://codereview.chromium.org//11262028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14071 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-25 12:18:30 +00:00