dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

1689 Commits

Author SHA1 Message Date
sgjesse@google.com 3e2ffb4394 Revert "Update the test runner to use the new dart:io API" again 
This reverts r20004 and r20008.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12559013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20009 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 12:13:37 +00:00
sgjesse@google.com db7821cdf3 Reapply "Update the test runner to use the new dart:io API" 
The Linux binary will work on the bots. Fixed a number of issues.

The new binaries are from r19850.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12608007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20004 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 11:39:20 +00:00
sgjesse@google.com 78403ce605 Revert "Update the test runner to use the new dart:io API" 
This reverts commit r19987.

The included binaries did not work on the bots due to a glibc version issue.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12864003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19988 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 08:08:56 +00:00
sgjesse@google.com 7ff44f77ac Update the test runner to use the new dart:io API 
The new binaries are from r19850.

R=whesse@google.com, ager@google.com, ricow@google.com, kustermann@google.com

BUG=

Review URL: https://codereview.chromium.org//12417004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19987 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 07:54:07 +00:00
devoncarew@google.com a4a72c29ca Updates to the new analyzer to help make the try bot happy. 
Review URL: https://codereview.chromium.org//12438007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19946 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-13 17:06:20 +00:00
ricow@google.com ad5da2d318 Add support for the new analyzer to the testing scripts 
Review URL: https://codereview.chromium.org//12776004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19885 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 18:18:26 +00:00
kustermann@google.com 4924f73340 Bugfix in test_progress.dart after refactoring 
TBR=ricow

Review URL: https://codereview.chromium.org//12728005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19881 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 17:37:28 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere. 
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 17:34:49 +00:00
kustermann@google.com 53497f0c2c Refactoring of ProgressIndicator 
Currently ProcessQueue creates and depends on exactly ONE ProgressIndicator.
This is not optimal for the following reasons:

 a) The used ProgressIndicator has several responsibilities (printing timing information,
    setting 'io.exitCode', printing test failures, ...)
    Splitting these responsibilities into different classes makes the code cleaner and more testable.

 b) If we make ProcessQueue depended on an abstract EventListener object (or a list of them) and make
    it send events to those listeners would make it easier to test ProcessQueue itself.

Issue: 8095

Review URL: https://codereview.chromium.org//12302016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19867 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 14:09:05 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library." 
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library. 
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-09 02:40:37 +00:00
kustermann@google.com b14b9f7008 Pass half the timeout to run_selenium.py 
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//12674004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19686 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-08 11:51:37 +00:00
iposva@google.com ee927443e0 - Add simarm and simmips to --arch=all for builds and tests. 
Review URL: https://codereview.chromium.org//12690002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19684 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-08 11:46:56 +00:00
floitsch@google.com d876e7ce7a Add 'diff' option to progress. 
Review URL: https://codereview.chromium.org//12611005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19639 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-07 16:48:19 +00:00
ager@google.com ee442f190e Add dart analyzer test suite 'analyze_library' that fails if we 
introduce static type warnings in certain dart libraries.

I wanted this for dart:io and might as well add it for the other
libraries that have no warnings when analyzed.

This required a bit of test script reworking. dartc used a leading
hash in a file to determine if it was a test. That is now broken
and has been removed. This also allowed me to override the
readOptionsFromFile method in test suites so that certain analyzer
test suites can require all tests to be static clean.

R=ricow@google.com,kustermann@google.com,sgjesse@google.com,danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//12475004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19597 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-07 07:25:32 +00:00
kustermann@google.com d1d19278f5 Fixed missing 'io.' prefixes on exit() calls 
Review URL: https://codereview.chromium.org//12378073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19451 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-05 09:29:08 +00:00
kustermann@google.com c7857e7c0b Quote all arguments when printing a Command 
Review URL: https://codereview.chromium.org//12379041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19291 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-01 10:33:59 +00:00
kasperl@google.com f54583de00 Add --csp flag to test.dart. 
When running test with that flag we make sure the HTTP server emits
Content-Security-Policy restriction headers and we pass --disallow-unsafe-eval
to dart2js.

R=ricow@google.com,kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//12387010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19208 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-28 08:59:33 +00:00
devoncarew@google.com f6d7f5251c Remove r09 of guava; make sure all the dartc files are updated to use r13. 
Review URL: https://codereview.chromium.org//12326093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18989 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-25 18:26:34 +00:00
kustermann@google.com 90e2760642 Start two http servers for every configuration 
This should fix: http://dartbug.com/8366

Review URL: https://codereview.chromium.org//12340021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18964 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-25 11:54:20 +00:00
kustermann@google.com d2c575c0b0 Create generated tests inside the build directory 
Patch Set 1 is a revert of r18295.

Review URL: https://codereview.chromium.org//12223074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18802 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-21 08:10:37 +00:00
floitsch@google.com ecce8a6293 Remove deprecated Strings class. 
Review URL: https://codereview.chromium.org//12295014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-19 13:57:03 +00:00
kustermann@google.com 31444b97f9 Print testCase.commands only once if --verbose was specified 
Review URL: https://codereview.chromium.org//12302018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18663 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-19 09:43:22 +00:00
blois@google.com 5871625004 Adding the ability for the test server to listen on non-loopback addrs. 
BUG=

Review URL: https://codereview.chromium.org//12220068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18489 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-13 22:27:30 +00:00
efortuna@google.com c6179a50c0 Revert "Change the location of the output directory" plus one other fix. 
BUG=

Review URL: https://codereview.chromium.org//12225109

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18295 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-09 02:07:19 +00:00
kustermann@google.com 5e292868f0 Fixed path issue on windows 
TBR=ricow

Review URL: https://codereview.chromium.org//12218039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18187 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-06 21:05:40 +00:00
sigmund@google.com 376c46005e Move test_controller.js inside unitest/lib so it can be used in external tests 
too.

Review URL: https://codereview.chromium.org//12217045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18184 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-06 19:33:55 +00:00
kustermann@google.com 3396dc77a9 Change the location of the output directory of generated tests to be inside build directory, but not relative to the dart root. 
This is causing issues on dartium builders where we actually only run because there is a build/Release (and out/Release or xcodebuild/Release for mac/linux) on the bot that has been created inside src/dart.

Also, fix the http server in the testing script to serve files from the output directory - otherwise the tests will not be accessible if an alternative build directory is used.

Review URL: https://codereview.chromium.org//12183022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18176 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-06 16:38:09 +00:00
kustermann@google.com 0a5a3306f7 Added '--package-root' to http_server.dart. 
Review URL: https://codereview.chromium.org//12087130

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17968 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-01 10:22:55 +00:00
kustermann@google.com 7b19966623 If we made progress, add testCases to the front of the queue in test_runner.dart 
Review URL: https://codereview.chromium.org//12114027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17913 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 14:44:38 +00:00
efortuna@google.com 532b0a7e0e Fix Safari "multitest" failure. 
BUG=

Review URL: https://codereview.chromium.org//12089081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17882 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-30 23:53:42 +00:00
ricow@google.com 746d3664db Revert revision 17848 - this is breaking dartium testing 
Review URL: https://codereview.chromium.org//12087086

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17850 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-30 15:27:52 +00:00
ricow@google.com 5947bba6cc Change the location of the output directory of generated tests to be inside output directory, but not relative to the dart root. 
This is causing issues on dartium builders where we actually only run because there is a build/Release (and out/Release or xcodebuild/Release for mac/linux) on the bot that has been created inside src/dart.

Also, fix the http server in the testing script to serve files from the output directory - otherwise the tests will not be accessible if an alternative build directory is used.
Review URL: https://codereview.chromium.org//11896031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17848 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-30 14:38:47 +00:00
ricow@google.com f4bc3b8d09 Speculative fix for flakines on browser bots 
Review URL: https://codereview.chromium.org//12090067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17827 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-30 10:00:38 +00:00
kustermann@google.com 7ccd6f2c68 Bugfix in test_runner: in certain cases tests did not get rerun 
Review URL: https://codereview.chromium.org//12086048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17824 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-30 09:05:02 +00:00
kustermann@google.com a418c4f27f Only print stdout/stderr if we've got an unexpected output 
TBR=ricow

Review URL: https://codereview.chromium.org//12092041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17767 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-29 15:44:27 +00:00
kustermann@google.com 22da1e1fc8 Support for running a limited amount of browser tests in parallel 
Patch Set 1:
  Refactored test_runner.dart to execute "Command after Command" instead of
  "TestCase after TestCase". By doing so, we don't couple the execution of
  compilation commands to the execution of the browser (or test) command.

Patch Set 2:
  Introduce a limitation on the number of parallel browser executions. By doing
  so we can run 'NumCores' compilation commands in parallel but only a single
  browser test command at any given time (necessary for IE).
  This way we can significantly reduce the cycle time on IE bots.

Review URL: https://codereview.chromium.org//12035053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17764 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-29 15:16:44 +00:00
ricow@google.com 03bdded77e Fix selenium to detect and handle browser crashes. 
Some context:
On windows, selenium will be hanging a chrome browser
crashes and additional to this we would actually not get information
that the browser crashed, we would get this as a failing test.

This change basically sets up a python timer that will trigger us to
close the browser using browser.service.stop() (I suspect that when
the browser crashes and does not respond in time selenium will call
browser.quit which will be blocking on trying to kill the remote
service).

In addition, this changes the test_runner to handle a crash exitcode
correctly (we will set it to -10 in the bacth runner, I don't know
why, but I dont want to change that in this cl). The current
hasCrashed getter will mask out errors that it does not recognize as
valid windows crashes (of which -10 is not one since it will have a
bunch of set bits in the middle of the bit pattern). I changed this to
explictily recognize the -10 value.
Input on why we have that value is welcome
Review URL: https://codereview.chromium.org//12051037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17752 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-29 10:20:11 +00:00
kustermann@google.com 740b947e24 Small bugfix in test_suite.dart 
Review URL: https://codereview.chromium.org//11929022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17702 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-28 11:29:41 +00:00
ahe@google.com 2f974584dc Add dart2js option to select library categories. 
By default, the compiler will only accept the Client category, meaning that it will be an error to import dart:io.

During testing on d8, the compiler will support all library categories to continue supporting so called "mock compilation".

Review URL: https://codereview.chromium.org//11740025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17637 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-25 12:08:26 +00:00
scheglov@google.com d9605fe9ef Issue 8051. Make extended exit codes optional. 
http://code.google.com/p/dart/issues/detail?id=8051

Unfortunately testing framework expects exactly 0 and 1.
So, I've made 0/1/2 exit codes optional.

Phil, FYI

R=devoncarew@google.com,pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12045088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17629 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-25 04:11:12 +00:00
scheglov@google.com be31b47690 Issue 8051. dart_analyzer return codes on errors 
http://code.google.com/p/dart/issues/detail?id=8051

R=devoncarew@google.com,whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//12041051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17622 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-25 00:47:48 +00:00
kustermann@google.com 6ca4e48671 Added a comment to clarify the interpretation of exit codes on windows 
Review URL: https://codereview.chromium.org//12035052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17455 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-23 13:24:03 +00:00
floitsch@google.com 1febeb689a Move some core classes to collection library. 
Review URL: https://codereview.chromium.org//11867024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17352 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-21 13:34:02 +00:00
regis@google.com 350fa57800 Add mips and simmips build targets. 
Review URL: https://codereview.chromium.org//11859034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17319 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 21:34:53 +00:00
kustermann@google.com d71f8ff86f Added DebugLogger to testing scripts. 
Review URL: https://codereview.chromium.org//11962042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17291 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 16:45:20 +00:00
kustermann@google.com f9a76d5672 Simplify the enqueuing of tests from all test suites 
TBR=foo

Review URL: https://codereview.chromium.org//11884054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17273 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 13:50:24 +00:00
kustermann@google.com 5d083443f8 Don't exit() in test_progress but rather set io.exitCode 
Review URL: https://codereview.chromium.org//12026013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17264 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 12:28:08 +00:00
ahe@google.com f42b735a0e Correctly implement co19 test suite. 
Review URL: https://codereview.chromium.org//11881053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17204 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 13:40:21 +00:00
kustermann@google.com 9ee5fc4b53 Revert "Removed the 'we don't run multitests on browsers'-hack" 
There is an issue with path names on dartium builders.

Review URL: https://codereview.chromium.org//11975039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17185 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 10:20:12 +00:00