Commit Graph

1980 Commits

Author SHA1 Message Date
alanknight@google.com 7c8351df36 Remove SVG constructor suppressions around foreignobject and altGlyph
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1078853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45112 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:53:35 +00:00
floitsch@google.com 80155170ce dart2js: Fix csp minified.
For the most part this only required status file or test updates.
There was, however, a bug in the code that extracted the class-name from its constructor.

R=sra@google.com

Review URL: https://codereview.chromium.org//1073273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45084 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 07:49:54 +00:00
alanknight@google.com ea26b521a3 Add another issue to the wheelevent_test suppression
BUG=

Review URL: https://codereview.chromium.org//1079523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45077 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 19:51:42 +00:00
sra@google.com e360f87504 Fix order of parameters in intercepted generative constructor body.
When the receiver parameter is inserted at the front of the parameter list, some parameters may have already been inserted and others will be inserted later.
If none have already been inserted, then the subsequent parameters were being inserted in front of the receiver parameter. This is fixed by marking the receiver as the lastAddedParameter if it is the only one. This did not seem to affect 'this', presumably because the position of 'this' is immaterial since it is always removed from the JS function parameters.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1066303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45048 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 03:18:05 +00:00
alanknight@google.com b886757603 Remove spaces from group names in node_validator_test
BUG=

Review URL: https://codereview.chromium.org//1077873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45040 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 22:18:00 +00:00
alanknight@google.com b13d4f5742 Check for DOM clobbering attacks in sanitizing/node validation
BUG=

Review URL: https://codereview.chromium.org//1077813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45028 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 19:47:34 +00:00
alanknight@google.com e1e22c00f2 Fix node validation for SVG foreignobject tag
BUG=

Review URL: https://codereview.chromium.org//1072893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45019 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 17:24:03 +00:00
whesse@google.com 462fd69d5a Update IE status for co19 and html tests.
BUG=dartbug.com/23146
R=ricow@google.com

Review URL: https://codereview.chromium.org//1073753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44994 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 09:05:23 +00:00
alanknight@google.com d795a89017 "Reverting 44988"
BUG=

Review URL: https://codereview.chromium.org//1078583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44990 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 00:56:10 +00:00
alanknight@google.com ad6bff9089 Fix issues with foreignobject sanitizing
BUG=

Review URL: https://codereview.chromium.org//1075693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44988 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 00:06:27 +00:00
alanknight@google.com d5125b52f6 Temporarily suppress tests that do svg/innerHTML, consistency over treatment of foreignobject tag
BUG=

Review URL: https://codereview.chromium.org//1062383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44954 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 23:14:53 +00:00
alanknight@google.com 6d9f24b919 Make SVGValidator reject foreignobject tags, not just their contents. Fixes Firefox inconsistency
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1063213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44949 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 20:59:02 +00:00
alanknight@google.com 4b119a94d8 Better way of fixing attribute_changed_callback_test, doesn't require a timer
BUG=

Review URL: https://codereview.chromium.org//1061403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44946 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 20:52:54 +00:00
alanknight@google.com 4adf68734b Fix attribute_changed_callback_test to expect event delivery either synchronously or asynchronously
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1060103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44942 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 18:23:59 +00:00
alanknight@google.com a2d5aef265 Update node_validator_test for IE11
BUG=

Review URL: https://codereview.chromium.org//1068573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44941 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 17:56:33 +00:00
asiva@google.com d6ae2c8bf3 Update test log to reflect failing test
html/custom/attribute_changed_callback_test/fully_supported

Review URL: https://codereview.chromium.org//1067503003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44915 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 16:27:10 +00:00
sra@google.com 560b094a1f Re-do accidentally removed suppresion on fontface_test
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1059913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44900 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-04 00:09:00 +00:00
sra@google.com 2956fd8739 - Fork implementation for Dartium and dart2js. Dartium is working fine.
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44888

Committed: https://code.google.com/p/dart/source/detail?r=44897

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44898 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 23:00:28 +00:00
sra@google.com 3080315805 - Fork implementation for Dartium and dart2js. Dartium is working fine.
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44888

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44897 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 22:38:56 +00:00
alanknight@google.com 721e1f1133 "Reverting 44881"
BUG=

Review URL: https://codereview.chromium.org//1061703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44896 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 22:32:55 +00:00
sra@google.com ade70628de - Fork implementation for Dartium and dart2js. Dartium is working fine.
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44888 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 20:48:10 +00:00
alanknight@google.com 3b44dc7e00 Unsuppress node_validator_test to check the errors
BUG=

Review URL: https://codereview.chromium.org//1052993009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44881 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 16:46:53 +00:00
sra@google.com 12ad718f3e element_classes_test - move helper functions to top level
The slightly better type inference helps with developing better
CssClassSet implementations.

BUG=

Review URL: https://codereview.chromium.org//1055363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44877 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 02:09:46 +00:00
sra@google.com 6e65076450 Add new methods to html/element_classes_test
- Add tests for retainAll, removeWhere, retainWhere.
 - Simply expect checking

R=vsm@google.com

Review URL: https://codereview.chromium.org//1054093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44866 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-02 19:46:50 +00:00
alanknight@google.com fc92478567 Fix status file for FontFace tests that now pass
BUG=

Review URL: https://codereview.chromium.org//1012193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44693 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 20:04:01 +00:00
alanknight@google.com 5397482fcc Make dartj2s do type conversions on constructor arguments
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1023363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44688 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:39:49 +00:00
alanknight@google.com 085d4205de Temporarily suppress some timing tests on Chrome
BUG=

Review URL: https://codereview.chromium.org//1033553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44650 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 23:54:13 +00:00
alanknight@google.com 06b1030578 Test for the correct class in AnimationPlayer.supported and fix Dartium suppressions
BUG=

Review URL: https://codereview.chromium.org//1031723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44649 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 22:07:59 +00:00
alanknight@google.com d197df6032 Split up element_animate_test into groups to get more information about what might be timing out
BUG=

Review URL: https://codereview.chromium.org//1026103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44647 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 20:29:10 +00:00
alanknight@google.com b44058a0d2 Make Element.animate work in dart2js Chrome
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1014843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44642 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 18:26:06 +00:00
alanknight@google.com 48dedfd9c5 BUG=
Review URL: https://codereview.chromium.org//1022913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44587 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:34:20 +00:00
alanknight@google.com ee70473f73 Update status file for touch event test
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//999503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44579 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 17:27:09 +00:00
whesse@google.com 745b6809e9 Update test status for flaky tests.
BUG=dartbug.com/22695, dartbug.com/22896
R=ricow@google.com

Review URL: https://codereview.chromium.org//1019463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44557 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 12:45:50 +00:00
karlklose@google.com a097f15eb2 Mark notification_test as failing on safarimobilesim.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//1013123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44531 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 09:07:27 +00:00
alanknight@google.com 08e57b406b Notification test passes on Safari, on the basis that it's not supported.
BUG=

Review URL: https://codereview.chromium.org//1013883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44527 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 23:25:29 +00:00
alanknight@google.com 09bfac01d1 Unsuppress notification test on dartium drt
BUG=

Review URL: https://codereview.chromium.org//1010043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44516 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 19:23:16 +00:00
alanknight@google.com 55fc0773b2 Temporarily suppress notification_test for DRT as well
BUG=

Review URL: https://codereview.chromium.org//1010813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44510 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 16:45:43 +00:00
alanknight@google.com f1a52b7069 Temporarily suppress notification test on checked Chrome
BUG=

Review URL: https://codereview.chromium.org//1006083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44489 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 23:26:17 +00:00
alanknight@google.com 1592300cc4 Use group name for suppression on IE
BUG=

Review URL: https://codereview.chromium.org//1009463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44488 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:30:21 +00:00
alanknight@google.com c4ac7f194f Fix status file for Dartium Android Notification test
BUG=

Review URL: https://codereview.chromium.org//1007443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44477 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:06:28 +00:00
alanknight@google.com 05407d3fdb Fix test status for Notification and MediaSource tests
BUG=

Review URL: https://codereview.chromium.org//1000553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44475 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 20:37:35 +00:00
alanknight@google.com 46a24513a3 Add MediaSource.supported, annotations for supported browsers, and a minimal test
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//990383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44472 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:31:42 +00:00
alanknight@google.com 5d2f7f8ae8 Fix notification
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1002953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44471 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:21:31 +00:00
rmacnak@google.com 63f3cd6082 Reapply r44240 "fix deferred_multi_app test and change test status to reflect dartium fix"
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org//989343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44350 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 22:09:39 +00:00
alanknight@google.com 00f641fc77 Fix element_types_constructors split out tests
BUG=

Review URL: https://codereview.chromium.org//988243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44332 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 17:54:14 +00:00
alanknight@google.com f2b2c64fbc Split the constructors group in element_types_test into multiple files to narrow down timeouts
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//984133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44327 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 16:42:00 +00:00
whesse@google.com 07750d9a42 Update test status for Chrome 41 on Windows and Mac OS X.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//983173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44291 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 14:19:58 +00:00
alanknight@google.com a2f4d7195f Re-enable suppressed tests from 22646 to see what's going on
BUG=

Review URL: https://codereview.chromium.org//980703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44266 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-05 18:03:59 +00:00
alanknight@google.com 708be606fe Update offset tests for different text layout in Chrome 40
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//982013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44264 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-05 17:58:57 +00:00
whesse@google.com 8daeb77e10 Revert r44240, "fix deferred_multi_app test and change test status to reflect dartium fix"
The multi-script html tests are still not working on Dartium - they report "Only one Dart script tag allowed per document".  This error message is not in the Dart repo - it must be in the Dart branch of Blink or Chromium.

BUG=dartbug.com/16603
R=ricow@google.com

Review URL: https://codereview.chromium.org//968913005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44255 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-05 10:13:57 +00:00