dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

1980 Commits

Author SHA1 Message Date
Alan Knight 07b2ddd401 Preserve identity of Dart wrappers on DOM objects 
BUG=

Review URL: https://codereview.chromium.org/1380963003 .
 2015-10-01 14:04:01 -07:00
Alan Knight 53e01fdb1b Suppress dartium jsinterop failures on drt as well as dartium 
BUG=

Review URL: https://codereview.chromium.org//1373863003 .
 2015-09-28 09:38:49 -07:00
Terry L. Lucas 3ce007e910 Fixed a bunch of failure cases for custom elements 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1373563004 .
 2015-09-25 15:12:08 -07:00
Alan Knight 1b80b9013e Make sure we short-circuit the second corruption test, it might be crashing firefox 
BUG=

Review URL: https://codereview.chromium.org//1371543002 .
 2015-09-24 16:45:08 -07:00
Alan Knight a004579ccc Try suppressing node_validator test for ff/windows, see if it stops the crashing 
BUG=

Review URL: https://codereview.chromium.org//1368043002 .
 2015-09-24 15:43:54 -07:00
Alan Knight a4004b6e97 Fix one level of error in postmessage tests, suppress nested list tests 
BUG=

Review URL: https://codereview.chromium.org//1371503002 .
 2015-09-24 14:27:27 -07:00
Terry L. Lucas f4df270900 No longer crashes but has runtime errors 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1366023003 .
 2015-09-24 14:09:48 -07:00
Terry L. Lucas 54282ccd72 Update to handle expections in custom element's created constructor 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1370513003 .
 2015-09-24 13:17:35 -07:00
Alan Knight 8f35656f9b Fix node_validator xss tests for IE and Firefox 
BUG=

Review URL: https://codereview.chromium.org//1365093003 .
 2015-09-24 10:43:08 -07:00
Alan Knight 0568fa8679 Omit extra argument to createElement/NS if null 
BUG=

Review URL: https://codereview.chromium.org//1345413004 .
 2015-09-22 09:28:38 -07:00
Terry L. Lucas 87541f5ef5 Few more tests now pass some still have problems 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1362493003 .
 2015-09-21 14:26:40 -07:00
William Hesse ecc9b87690 Suppress failing HTML tests on firefox and IE 11. 
BUG=dartbug.com/24384 dartbug.com/24386 dartbug.com/24387
R=ricow@google.com

Review URL: https://codereview.chromium.org//1350973005 .
 2015-09-21 15:30:08 +02:00
Terry L. Lucas 0e1c08f304 More tests busted by Dartium JSInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1356463003 .
 2015-09-18 13:59:09 -07:00
Terry L. Lucas c5a690fa26 Revert "Mark tests problems because of Dartium JSInterop" 
This reverts commit d1a7ee9ad7.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1355683005 .
 2015-09-18 11:00:54 -07:00
Terry L. Lucas d1a7ee9ad7 Mark tests problems because of Dartium JSInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1358503002 .
 2015-09-18 09:37:37 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
 2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled." 
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
 2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled. 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
 2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled" 
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
 2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
 2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop" 
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
 2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
 2015-09-08 12:46:41 -07:00
Karl Klose d9caf4a725 Move cps-ir section to the end of the file and update test expectations. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1312583008 .
 2015-09-07 15:37:39 +02:00
William Hesse 3699a5c98b Update macos dart2js status for Chrome 45. 
BUG=

Review URL: https://codereview.chromium.org//1309903008 .
 2015-09-03 19:24:21 +02:00
William Hesse d0a3d8c21c Update dart2js status for Chrome 45 on windows. 
BUG=

Review URL: https://codereview.chromium.org//1314903009 .
 2015-09-03 19:15:36 +02:00
Stephen Adams 6f197ac7ff cps_ir can't handle resource_http_test 
TBR=het@google.com

Review URL: https://codereview.chromium.org//1313883005 .
 2015-08-25 18:03:39 -07:00
Harry Terkelsen 1bdd43c233 Disable resource_http_test in Dartium and DRT 
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1315643003 .
 2015-08-25 14:39:49 -07:00
Harry Terkelsen bc0deb66d7 dart2js: fetch http Resources 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1308143002 .
 2015-08-25 10:46:27 -07:00
William Hesse 0bb497875a Update status for Chrome 44 on dart2js tests. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1240363003 .
 2015-07-22 18:02:03 +02:00
Alan Knight cd8c569632 Make sure NodeValidator uriAttributes aren't passed as attributes 
WIP

BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1236413002 .
 2015-07-17 14:12:44 -07:00
Alan Knight de3ce04f0a Fix type problem with FilteredElementList._iterable 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1236793006 .
 2015-07-17 10:53:19 -07:00
Alan Knight 4e790fef3d appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Committed: https://github.com/dart-lang/sdk/commit/930a40daa50a93adfce8786f4d7ef25e06324dda

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-16 10:30:51 -07:00
William Hesse d21bdcc27e Update status for failing dartium tests 
BUG=https://github.com/dart-lang/sdk/issues/23849
TBR=terry@google.com

Review URL: https://codereview.chromium.org//1235283003 .
 2015-07-15 17:34:14 +02:00
Cristian Almstrand 3b125d3bc9 Please refer to https://code.google.com/p/dart/issues/detail?id=23418 for the bug reportincluding a WebStorm project which demonstrates the problem. 
This proposal includes a fix to ensure that indices passed to the public functions defined in class FilteredElementList of the dart:html package consistently refer to element indices (not element indices sometimes, and node indices other times). Without this change, it is not possible to reliably insert elements relative to other elements. This can be problematic as the order of HTML elements must be guaranteed to ensure elements appear where expected in a normal page flow.

This proposal also address the TODO in file sdk/lib/html/html_common/filtered_element_list.dart to avoid excessively creating/allocating a filtered list of elements from nodes whenever calling [], every, any, length, etc. The implementation is less concise but should result in much reduced memory allocation and speed improvements.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1129333002 .

Patch from Cristian Almstrand <cristian.almstrand@gmail.com>.
 2015-07-14 14:50:42 -07:00
Alan Knight 610edadff2 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 930a40daa5.

BUG=

Review URL: https://codereview.chromium.org//1230203005 .
 2015-07-13 15:32:17 -07:00
Alan Knight 930a40daa5 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-13 12:50:49 -07:00
Alan Knight 1e8a275a20 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 560f12bb21.

	modified:   sdk/lib/html/dart2js/html_dart2js.dart
	modified:   sdk/lib/html/dartium/html_dartium.dart
	modified:   tests/html/element_add_test.dart
	modified:   tools/dom/templates/html/impl/impl_Element.darttemplate

BUG=

Review URL: https://codereview.chromium.org//1230553003 .
 2015-07-08 12:19:30 -07:00
Alan Knight 560f12bb21 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-08 10:16:37 -07:00
Karl Klose 71e2bec0a5 dart2js cps: Support JS_CURRENT_ISOLATE. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1222913003 .
 2015-07-07 15:55:13 +02:00
Jacob Richman ae72b6a701 Enhance dart:js interop in a backwards compatible manner. 
BUG=

Review URL: https://codereview.chromium.org//1213873004.
 2015-06-29 11:20:11 -07:00
Asger Feldthaus 34302b1320 dart2js cps: Translate synthesized mixin constructors. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1216593002.
 2015-06-29 15:28:40 +02:00
Stephan Herhut 3b34c17909 Avoid multiline string literal in svgelement test. 
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1219673002.
 2015-06-29 12:39:05 +02:00
Jacob Richman 7e9e4d89d3 Revert "Enhance dart:js interop in a backwards compatible manner." 
This reverts commit ac32e37ab1300cb1ce1cd081f050ff1d04e54cbe.

BUG=

Review URL: https://codereview.chromium.org//1209093005.
 2015-06-26 10:29:25 -07:00
Jacob Richman 3fdeb669ee Enhance dart:js interop in a backwards compatible manner. List objects can now be passed back and forth to Dartium without requiring jsify 
BUG=
R=terry@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//1194643002.
 2015-06-26 10:06:45 -07:00
Stephan Herhut 225be75498 Fix some tests and exclude others from CRLF rewriting. 
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1212823002.
 2015-06-26 14:40:01 +02:00
Kevin Millikin b9192ab9e2 dart2js CPS: Support try/catch/finally. 
Support try/catch/finally by pretending it is macro-expanded into
try/catch and try/finally:

    try S0 catch (ex, st) S1 finally S2
    ==>
    try { try S0 catch (ex, st) S1 } finally S2

The duplicated code for try/catch and try/finally is abstracted into a
function parameterized over translations for all the parts that
differed.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1207703002.
 2015-06-24 17:13:15 +02:00
Kevin Millikin 089ed2965b Implement try/finally by inlining the finally code. 
Try/finally is implemented by inlining.  There is a try/catch to catch
exceptions in the try block.  The catch body contains the finally code
followed by a rethrow.  The code for finally is translated again after the
normal exit of the try block.  Break, continue, and return exits in the try
block have the finally code inlined just before the exit is taken.

Try/catch/finally is not yet supported, it requires some changes to the
assigned variables analysis.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1201983002.
 2015-06-24 10:12:42 +02:00
Asger Feldthaus 04c5c61a10 dart2js cps: Refactor and optimize string concatenations. 
The ConcatenateStrings IR node has been removed. It was a leftover from
dart2dart.

Expressions inside string interpolations are now stringified explicitly
and we concatenate strings with a pure StringConcat operator.

ConstantExpressions have also been removed from the IR. They were also
an artifact from dart2dart and were complicating the optimizer.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac75893964144d5712d1da8417c27c232750ec37

Reverted: https://github.com/dart-lang/sdk/commit/988b65336b3194cd539781195a9b8be24b3bbdc3

Review URL: https://codereview.chromium.org//1195573003.
 2015-06-23 13:17:59 +02:00
Alan Knight 1d5b657427 Make it easier and more efficient to use trusted HTML text 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1154423009.
 2015-06-22 09:41:01 -07:00
Kevin Millikin bf595224d5 Implement simple switch statements as nested if/else. 
Simple switch statements that do not have continue to labeled cases
are compiled into a chain if/else comparisons.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1191193005.
 2015-06-22 11:29:31 +02:00