Commit Graph

4276 Commits

Author SHA1 Message Date
Konstantin Shcheglov 39b3e79dfe Apply resolution to CatchClause.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I0203f510802b9b258da608231957c9383f677360
Reviewed-on: https://dart-review.googlesource.com/27503
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2017-12-08 16:56:18 +00:00
Konstantin Shcheglov 31dfab26e2 Fix for applying resolution to MapLiteral.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Icc213c310ae49ac315ed6772f88a16337d441475
Reviewed-on: https://dart-review.googlesource.com/27410
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-08 05:53:49 +00:00
Konstantin Shcheglov af4b9b8436 Translate FunctionType and InterfaceType references.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ib0814e8c25234fea4d8a3685c96b481f27d3af03
Reviewed-on: https://dart-review.googlesource.com/27413
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-08 00:09:49 +00:00
Konstantin Shcheglov 14c730d9de Apply resolution to constructor parameter default values.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I9241e86963e9821fa914f4daef8717a67328cadb
Reviewed-on: https://dart-review.googlesource.com/27409
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-07 23:19:39 +00:00
Brian Wilkerson 8b37075fd4 Gracefully handle some cases of missing data
Change-Id: I56d8d2395b416663d1580239e4d35683b5dfd583
Reviewed-on: https://dart-review.googlesource.com/27440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 23:09:49 +00:00
Konstantin Shcheglov 2f39ad2f74 Apply types to FunctionTypeAlias.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Id7be33790dcb07952738c83ac6ebdeaa8659e1fd
Reviewed-on: https://dart-review.googlesource.com/27405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-07 21:56:40 +00:00
Konstantin Shcheglov 76e3d55b10 Apply type to TypeParameter bounds.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ica3501ae8a38d7956948d4c7aa7afaaa7421f9af
Reviewed-on: https://dart-review.googlesource.com/27403
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 21:04:34 +00:00
Konstantin Shcheglov be50952130 Apply types to FieldDeclaration type annotation.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Iec0dd5dc72bd221a27fae9f8083c32f1798843f6
Reviewed-on: https://dart-review.googlesource.com/27401
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 20:33:23 +00:00
Konstantin Shcheglov 950891fd2f Apply resolution to enums.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I1cf5aed4fdecae1d660ec2717b6c98ca69603959
Reviewed-on: https://dart-review.googlesource.com/27380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 20:04:49 +00:00
Konstantin Shcheglov 87f4f462bf Apply types to ClassTypeAlias.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: If6d0b4d9886b9e217e57cd6076ddadbfc39ad8cf
Reviewed-on: https://dart-review.googlesource.com/27320
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 19:33:11 +00:00
Sam Rawlins 0a6253312f Check for @alwaysThrows when evaluating for dead code.
The meta package version 1.1.0 includes a new `alwaysThrows`, which developers
can use to annotate methods that always throw. This helps to avoid erroneous
DEAD_CODE warnings from analyzer.

Bug: https://github.com/dart-lang/sdk/issues/31384
Change-Id: I70e2469b4f3a0d2c87064851160b268ea2259807
Reviewed-on: https://dart-review.googlesource.com/26563
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 19:29:18 +00:00
Konstantin Shcheglov 031ef9821c Apply types to ClassDeclaration in DeclarationResolver..
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I27dc21e877aee21c3012db58b02c52feeecb40fe
Reviewed-on: https://dart-review.googlesource.com/27300
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-07 18:57:50 +00:00
Konstantin Shcheglov 03fa398eae Apply resolution to SuperConstructorInvocation.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I0f795679e666c9067468a68669d447913a6164b7
Reviewed-on: https://dart-review.googlesource.com/27082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-07 04:34:01 +00:00
Konstantin Shcheglov c11e0e032a Apply resolution to ConstructorFieldInitializer.
Bug:
Change-Id: I18f48408e20f8ee37ca3cb1fe6f205d9ae9e7a73
Reviewed-on: https://dart-review.googlesource.com/26960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2017-12-07 01:27:30 +00:00
Konstantin Shcheglov e8c6c628de Provider context ElementImpl for all cases.
Bug:
Change-Id: I5ebcf0b5d92f4a9d1ebe83f90701651ffa2e14cc
Reviewed-on: https://dart-review.googlesource.com/26940
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-06 23:15:20 +00:00
Brian Wilkerson 7937e6e84a Enable computing hints when using front-end
Change-Id: I8a8344c98dc8fdb65c8711b2adbdfbaaafb023ed
Reviewed-on: https://dart-review.googlesource.com/26780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-12-06 22:04:31 +00:00
Konstantin Shcheglov 94907f1aea Apply resolution to FunctionExpression.
Bug:
Change-Id: Iaa8c4b31800fdb9d5a4613417a6076c3af683c6a
Reviewed-on: https://dart-review.googlesource.com/26721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-06 20:41:40 +00:00
Paul Berry 115d54f0b4 Implement strong mode "invalid cast" rules.
When an implicit cast can be proven by the front end to always fail,
due to the form of the expression being cast, the front end now
reports this as a compile-time error.  (This feature is not new--it is
part of the analyzer's implementation of strong mode).

Newly failing tests are marked with issue #31537.

Change-Id: Ib3fc068352bb91dd283fa4b81d8104fa213eafe9
Reviewed-on: https://dart-review.googlesource.com/26420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-12-06 20:01:02 +00:00
Dan Rubel f369d3caa1 Allow native clause in analyzer use of fasta parser
Change-Id: Idb0224d448d8d5cee2043ee51058125f51b7fe33
Reviewed-on: https://dart-review.googlesource.com/26681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2017-12-06 18:40:45 +00:00
Brian Wilkerson 597c9705ab Copy resolution data for cascades
Change-Id: I01b95f5e0b118c56c8af596d5eae919abb40a086
Reviewed-on: https://dart-review.googlesource.com/26680
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-12-06 18:35:35 +00:00
Dan Rubel 1cd64fd472 Implement fasta parser parseDirectives
Change-Id: Ic8d9ba44184f66c90086b0b46df0ce9f43bd9282
Reviewed-on: https://dart-review.googlesource.com/26660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2017-12-06 18:21:40 +00:00
Dan Rubel 108de2f354 Add fasta parser argument list recovery
Change-Id: If6cbda065c798147871d6c8a016f0fd3c07d2a69
Reviewed-on: https://dart-review.googlesource.com/26403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2017-12-06 13:04:59 +00:00
Konstantin Shcheglov 15f317412d Support @factory prefix in resynthesizer.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ifaa8fc7f37b09c224d30928fb11478e025342d70
Reviewed-on: https://dart-review.googlesource.com/26422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-06 06:08:08 +00:00
Konstantin Shcheglov ef7a229264 Apply resolution to 'is!'.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I8d805c4bd46446005880ea271c2baac5f6c99bda
Reviewed-on: https://dart-review.googlesource.com/26560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-06 06:00:13 +00:00
Konstantin Shcheglov f358176e57 Check that the target of IndexExpression has InterfaceType.
It should be, but in ast_builder tests it is not.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I98390b020100a4e17e9930c3796981b83965aeb3
Reviewed-on: https://dart-review.googlesource.com/26562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-06 06:00:03 +00:00
Konstantin Shcheglov e680cef99a Mix 'useFastaParser' (set when --preview-dart-2) into the options signature.
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/31554
Change-Id: Ia5d394339488baf2ad67a1476d07448c92fd2592
Reviewed-on: https://dart-review.googlesource.com/26461
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-06 00:07:57 +00:00
Konstantin Shcheglov 5c56e6d1cc Apply resolution to default values of optional formal parameters.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Icbb5c20be4a2dafc3fdc49a36590cace706c82ee
Reviewed-on: https://dart-review.googlesource.com/26463
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-05 23:50:16 +00:00
Dan Rubel badeafe806 Record annotations on parameters
Change-Id: I1b93006a1ccd85de34ceb2ec9a8c0b560b41baaf
Reviewed-on: https://dart-review.googlesource.com/26401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2017-12-05 20:17:21 +00:00
Konstantin Shcheglov 58a9f14822 Apply resolution to for-identifier-in.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ifeacd8a091af93043c0cb8d967b36ff48905216a
Reviewed-on: https://dart-review.googlesource.com/26362
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-05 19:05:31 +00:00
Konstantin Shcheglov 1c003c8967 Apply resolution to binary logical expressions.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I96f01f5e19696b43bdd58c2eca5866d6af7c08ee
Reviewed-on: https://dart-review.googlesource.com/26322
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-05 18:26:10 +00:00
Brian Wilkerson 4d0619832f Correctly copy resolution data in functions with optional parameters
Change-Id: Iaa4dbe72394a032216a184b93a894030286959e8
Reviewed-on: https://dart-review.googlesource.com/26100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-12-05 17:06:14 +00:00
Dan Rubel ddd6e1611a Recover when named parameter is outside { }
Change-Id: I945545278895e370ba51bf7a9e5bce209e1389b6
Reviewed-on: https://dart-review.googlesource.com/26320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2017-12-05 16:44:22 +00:00
Konstantin Shcheglov 6bb1d1a93e Set AdjacentStrings type to String.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I5a2fa448a2e38946bb9310e4240fbe996efb3adc
Reviewed-on: https://dart-review.googlesource.com/26140
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-05 16:20:52 +00:00
Konstantin Shcheglov 401bdbeb06 Apply resolution to ForEachStatement.
Only the case with declared loop variable.

Using externally decalred identifier requires avoiding storing
resolution for ShadowLoopAssignmentStatement while performing inference.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Iec7ab7621d9c7deb3971921731e9115b55aa5b86
Reviewed-on: https://dart-review.googlesource.com/26160
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-05 05:45:41 +00:00
Konstantin Shcheglov ca4b1fcdc3 Use offsets to distinguish StaticGet and PropertyGet for Analyzer's PrefixedIdentifier.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I458facf24099d25a1a0d3632acf1ee562930cec5
Reviewed-on: https://dart-review.googlesource.com/26080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2017-12-05 01:49:34 +00:00
Konstantin Shcheglov 93a6d43f31 Apply resolution to 'a ?? b'.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: If0a6c91c99af10992a1cc3465bf1f954c8baca39
Reviewed-on: https://dart-review.googlesource.com/26082
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-05 00:23:56 +00:00
Paul Berry e8091b27b1 Implement "unknown getter/setter/method" compile time errors in the front end.
Fixes #21938 (Front end does not warn on function calls on Object).

A small number of tests begin failing with this change--these tests
have been marked with issue #31533 for later triage.

Change-Id: I3a956410a6780772fe90098d8604fb10718504df
Reviewed-on: https://dart-review.googlesource.com/26045
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-12-05 00:14:54 +00:00
danrubel 9dbaa323e0 fix AstBuilder missing method body recovery
Change-Id: I875cfb2dbe96f12fd1369a7176cf575afa0d2bd5
Reviewed-on: https://dart-review.googlesource.com/26060
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-04 23:18:24 +00:00
Mike Fairhurst edd366b1c9 Fix #30147 partially applied function crash.
Occurs when there are both bounds and also partially provided type
args. Attempt to still perform substitution analysis even during
partial application, so long as the partial application warning is
still provided.

Bug: 30147
Change-Id: I25a6dabe458494ee9fd6c53aeba75883c3143816
Reviewed-on: https://dart-review.googlesource.com/26040
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-04 21:42:04 +00:00
Konstantin Shcheglov c0ec510666 Skip type parameters that are not used in the invocation type.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ia91aa010f3005c2a3d24f50b86e1d09b0e009c24
Reviewed-on: https://dart-review.googlesource.com/26002
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-04 19:40:04 +00:00
Konstantin Shcheglov b89f810077 Apply resolution to annotations.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I7ae87b0ea0bb273fb2f29add5a9b7ced83ec358f
Reviewed-on: https://dart-review.googlesource.com/25781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-04 16:50:35 +00:00
Peter von der Ahé e14726a3f4 Use absolute URIs instead of relative paths
We change the type of FileUriNode.fileUri from String to Uri, which in principle
doesn't change the binary format. However, we did notice that LibraryParts
weren't serialized as specified in binary.md, so we also fixed that.

Since fileUris are stored as strings in a separate table, Uri.parse is only called
once per unique URI.

Fasta only uses relativizeUri when printing diagnostics, and URIs stored in
expectation files (golden files) are relativized using String.replaceAll.

Change-Id: Ib2dc1b80c03a0cdaf84e48b8b3ba73b16bdf8a40
Reviewed-on: https://dart-review.googlesource.com/25421
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-12-04 11:34:24 +00:00
Samir Jindel bf797e6507 [kernel] Re-land assert initializers.
This change updates Dart2js and DDC.
Thanks to johnniwinther@ for the Dart2js updates.

The original revision is in patchset 2.

Change-Id: I26db33312f003f88ccccb67b27998ef21a1f667f
Reviewed-on: https://dart-review.googlesource.com/25820
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
2017-12-04 11:22:34 +00:00
Peter von der Ahé d4cfecb106 Revert "Apply resolution to AdjacentStrings."
This reverts commit 1699831282.

Reason for revert: I didn't say LGTM to this, and I'm not convinced this change is necessary.

Original change's description:
> Apply resolution to AdjacentStrings.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug:
> Change-Id: Iae09b39be41f1ddcd05a5a5ded554a1b7f9c09f3
> Reviewed-on: https://dart-review.googlesource.com/25800
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I11a947708e8e2de6a4591396fb2a32cb8833dc6d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/25541
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2017-12-04 09:09:36 +00:00
Konstantin Shcheglov 1699831282 Apply resolution to AdjacentStrings.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Iae09b39be41f1ddcd05a5a5ded554a1b7f9c09f3
Reviewed-on: https://dart-review.googlesource.com/25800
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-04 05:30:03 +00:00
Konstantin Shcheglov 21277a4df8 Apply resolution to 'this' and 'super'.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I905ea53aa1c39d789824e8c7061135a41b8f8cac
Reviewed-on: https://dart-review.googlesource.com/25663
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-03 00:13:42 +00:00
Konstantin Shcheglov 7abdca3adc Record resolution information only for the requested library.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I4609182ab04343178e7ed95164e3abd6287df7b4
Reviewed-on: https://dart-review.googlesource.com/25512
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2017-12-02 04:26:13 +00:00
Konstantin Shcheglov 2804d6db9b Apply resolution to null-aware local variable assignment.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ib7e4621169063b433ec9f52b7f293d909e3cae20
Reviewed-on: https://dart-review.googlesource.com/25509
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2017-12-02 03:55:53 +00:00
Paul Berry 7d65fec76e Reland "Route all messages through Loader."
This is the same as https://dart-review.googlesource.com/24481, but
with additional status file fixes.

Change-Id: Ic076c4dbf9c07e0fdf316298ca1ee1b6ce25002b
Reviewed-on: https://dart-review.googlesource.com/25508
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-12-01 22:47:06 +00:00
Konstantin Shcheglov 4740885c5a Apply resolution to ConditionalExpression.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I26bfba9d1e03fac01fbc84911de740b3c1435e6c
Reviewed-on: https://dart-review.googlesource.com/25683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-12-01 22:39:12 +00:00