Commit Graph

3160 Commits

Author SHA1 Message Date
danrubel@google.com f198c3485c cleanup visitInheritedTypes signature
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1120893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45465 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 02:25:56 +00:00
danrubel@google.com e6e1182a6d add import file uri suggestions
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1117963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45464 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 01:37:07 +00:00
danrubel@google.com 85e1841e35 suggest keywords for switch statement and expressions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45463 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 01:35:35 +00:00
brianwilkerson@google.com d741aaf58d Add utilities for creating SourceChanges
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1110583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45461 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-30 14:56:55 +00:00
danrubel@google.com af475ead16 restructure internal request to implement CompletionRequest API,
move performance tracking out of internal completion request,
and add resourceProvider to request

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1115843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45455 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-30 05:09:03 +00:00
danrubel@google.com 763fd171c9 cleanup imports
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1112183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45452 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-29 16:58:47 +00:00
scheglov@google.com ed2f434829 Issue 23337. Quick Fix for removing dead code.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23337

Review URL: https://codereview.chromium.org//1116593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45447 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-29 04:52:24 +00:00
brianwilkerson@google.com 641ea327ec Add standard files needed before we publish
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1094823004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45426 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 14:18:06 +00:00
brianwilkerson@google.com 0c90300719 Rename two more classes to prepare for the public API
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1087483006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45424 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 14:14:22 +00:00
danrubel@google.com 7f280a6779 guard against non-existant package directory
BUG=dartbug.com/23073
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1055983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45417 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 21:46:53 +00:00
danrubel@google.com a7fa3c85c2 suggest async/await
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1103643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45415 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 21:39:57 +00:00
danrubel@google.com 140fd9c601 fix for r45387 - canonicalize path to prevent "type X cannot be assigned to type X" warnings
BUG=dartbug.com/23073
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1102913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45412 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:28:43 +00:00
nweiz@google.com 70a846ad6c Update pubspecs and dependencies to get pkgbuild tests working.
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1058283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:08:53 +00:00
brianwilkerson@google.com ac3613e2bb Re-apply change to move to plugin package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1094083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 18:54:24 +00:00
pquitslund@google.com a565470b1f Bump analysis_server dep on args to >=0.13.0.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1108553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45402 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 17:09:07 +00:00
danrubel@google.com 6237c8909f add dart: and package: import uri suggestions
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 12:51:52 +00:00
scheglov@google.com 0cb3816eea Fix for linked position offsets when insert directly before.
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1086273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45394 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 04:51:12 +00:00
scheglov@google.com 1fb5410c07 Issue 23271. Check target.staticElement for null.
Unable to reproduce and provide a test.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23271

Review URL: https://codereview.chromium.org//1098423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45393 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 04:47:06 +00:00
nweiz@google.com 127f7e2a0b Update args to 0.13.0.
See also https://codereview.chromium.org/1094793005.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1103803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45389 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 23:42:54 +00:00
danrubel@google.com b5e86ba441 switch -package-root to use PackageMapUriResolver
This change allows future code completion mods to consistently use the
SourceFactory.packageMap method to build a list of package uri import
suggestions.

BUG=dartbug.com/23073
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1107583004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45387 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 23:06:13 +00:00
brianwilkerson@google.com 3d536efcfe Revert breaking change
Review URL: https://codereview.chromium.org//1101213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:12:20 +00:00
brianwilkerson@google.com 24c853446a Convert analyzer and analysis_server to use the plugin package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1063153004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45382 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:32:35 +00:00
danrubel@google.com 1330c1f1ee provide importUri for packages and include those suggestions
BUG=dartbug.com/23175
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45377 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 16:24:57 +00:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
pquitslund@google.com 434ba369f9 Driver fix to decouple from analyzer front-end deps.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1100943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45361 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:31:52 +00:00
danrubel@google.com 8f7079de3d fix NSM in suggestions with importUri
BUG=dartbug.com/23302
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1088973008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45359 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:15:16 +00:00
brianwilkerson@google.com b63a2e1d78 Add API for contributing to the index
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1060063008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45358 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:11:20 +00:00
brianwilkerson@google.com 8e6ccb391a Rename IndexStore to avoid confusion with the new public API
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100673005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45356 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 19:40:45 +00:00
brianwilkerson@google.com cb7e001db8 Add file missed in previous CL and comment clean-up
R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1084793006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45355 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 19:23:07 +00:00
danrubel@google.com b0886e8c98 include importUri in out of scope suggestions
BUG=dartbug.com/23175
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1095113004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45349 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 14:31:46 +00:00
brianwilkerson@google.com 4e0bb57118 Update specification version number
R=jwren@google.com

Review URL: https://codereview.chromium.org//1096693006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45297 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:07:29 +00:00
brianwilkerson@google.com 4422b7c01e Fix error handling for formatting and update the spec
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:57:33 +00:00
brianwilkerson@google.com 1fa696f64d Initial version of completion plugin API
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1095143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45293 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 17:44:41 +00:00
danrubel@google.com f117f67660 add optional importUri to completion suggestion
BUG=dartbug.com/23175
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1097083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45288 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:32:54 +00:00
danrubel@google.com 25c6bbaa14 suggest types in var declaration when partial type name supplied
BUG=dartbug.com/23225
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1097973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45287 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:29:28 +00:00
danrubel@google.com 58dd0377b3 fix NSM when computing field formal parameter in non-constructor arg list
BUG=dartbug.com/23268
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45286 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:15:01 +00:00
danrubel@google.com 1a605b53d5 suggest this keyword in constructor param list
BUG=dartbug.com/22685
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1084233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45285 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:13:40 +00:00
lukechurch@google.com 27ab530d1d Update analysis_server SDK requirements
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1068693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45269 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-19 18:16:06 +00:00
scheglov@google.com ec67f0c0c5 Issue 23184. Fix for exception when 'async' is used outside of a function body.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23184

Review URL: https://codereview.chromium.org//1098493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45219 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 19:39:39 +00:00
brianwilkerson@google.com e57ae7de7b Rename method for consistency
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1091003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45214 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 16:22:13 +00:00
danrubel@google.com 118f05d804 suggest "this." local fields in constructor param
BUG=dartbug.com/22685
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1082233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45213 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 16:06:26 +00:00
paulberry@google.com cd1dd1864b Fix additional cases where analysis server might send null, violating protocol.
In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1083223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45211 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 15:41:39 +00:00
paulberry@google.com cb319b21cd Fix "edit.format" to follow protocol when there is no selection.
BUG=dartbug.com/23230
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1092653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45210 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 14:44:55 +00:00
paulberry@google.com bb10493211 Use mock ProcessResult in optimizing_pub_package_map_provider_test.
This will make it feasible to cherry-pick this test into older
versions of Dart in which the ProcessResult constructor is private.

Also, fix some "unused variable" hints.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1062853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45183 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 20:55:18 +00:00
paulberry@google.com 7e53bd2b1f Avoid redundant calls to "pub list" when multiple dependencies change.
BUG=dartbug.com/22574
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1089453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45170 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 16:02:18 +00:00
paulberry@google.com 5b1c199b22 Prevent analysis exceptions from crashing the completion engine.
Prevent CompletionDomainHandler.priorityChanged() from crashing if the
future returned by DartCompletionManager.computeCache() completes with
an error (which can happen in the event that an exception occurred
while analyzing the file in question).

BUG=dartbug.com/23176
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1080323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45142 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-14 16:30:23 +00:00
danrubel@google.com 29d83d3cb5 improve keyword suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1084613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45113 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 17:44:19 +00:00
scheglov@google.com 9448ea0f06 Use working cache size when request resolved units in requests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1081903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45111 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:35:16 +00:00
brianwilkerson@google.com dbfb8bf97d Create a public API for contributing assists and make assists pluggable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1073383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45109 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:03:50 +00:00
brianwilkerson@google.com 46064e8f2f Create a public API for contributing fixes and make fixes pluggable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1080653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45079 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 21:01:10 +00:00