dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

3160 Commits

Author SHA1 Message Date
Konstantin Shcheglov 0bb5179b84 Quick Assist for converting field formal parameters into normal parameters and initializers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1217593006.
 2015-07-06 11:19:30 -07:00
Paul Berry 9857471f8c Modify analysis server codegen check to tolerate Windows line endings. 
Now that the git repository config has been modified to use CR/LF on
Windows machines, our generated files contain different contents on
Windows machines than they do on Mac/Linux machines, so they were
failing the codegen check.  This CL updates the codegen check to
tolerate those differences.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1219493007.
 2015-07-01 11:12:26 -07:00
danrubel 1647483615 move performance measurement to benchmark/integration 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1219023006.
 2015-07-01 12:09:43 -04:00
danrubel d2bd01852f performance measurement improvements 
* report mean, 90th, 99th, and std-dev
* increase analysis wait time to 60 seconds
* add option for analysis server localhost diagnostics
* report running old vs new task model
* do not check if src dir exists so that scripts are more portable
* set clientRequestTime for each request
* ensure dir paths have trailing separators

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1221893003.
 2015-06-30 18:08:10 -04:00
Brian Wilkerson dd9fa13157 More GetHandler clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1221703003.
 2015-06-30 07:49:32 -07:00
Brian Wilkerson 0513859704 Re-implement the status page for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1211243003.
 2015-06-29 12:20:19 -07:00
danrubel 13b601ffc5 watch for file system changes after context created 
Closes #23671

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1188663006.
 2015-06-29 12:24:29 -04:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class. 
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
 2015-06-26 13:00:44 -07:00
Dan Rubel a87e9386eb performance measurement: generate report 
* track/correlate responses
* separate req/resp from notifications
* track/report completion notifications
* add min/max/unexpected to report

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202843010.
 2015-06-25 10:03:24 -04:00
Paul Berry 921a5229fa Make use of test_flushAstStructures in analysis server. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1203783004.
 2015-06-24 14:04:26 -07:00
pq bee94603a0 Warning fix. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1209633002.
 2015-06-24 09:35:30 -07:00
Dan Rubel aa91c7c436 performance measurement: mapFrom/To --> map 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202803002.
 2015-06-23 19:35:15 -04:00
Dan Rubel 1ce49788ea performance measurement: add explicit temp source directory argument 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1201263002.
 2015-06-23 15:53:01 -04:00
danrubel e43c98a13c rework packageMapInfo dependency watching to avoid race condition 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1199083002.
 2015-06-22 19:19:09 -04:00
danrubel 679de372f4 gracefully degrade if package map input file cannot be watched 
BUG=

Review URL: https://codereview.chromium.org//1198423002.
 2015-06-22 17:07:12 -04:00
Konstantin Shcheglov 19a87506bc Fix for the server test. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1196213005.
 2015-06-22 10:03:06 -07:00
Konstantin Shcheglov e9c3b2d7b1 Move cache consistency validation into Analysis Server. 
This speeds up the add/analyze/remove/analyze cycle from 1600 ms to
1300 ms, i.e. on about 20%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1195183002.
 2015-06-22 08:19:44 -07:00
danrubel d907a4265e (TBR) improve integration test failure message 
BUG=

Review URL: https://codereview.chromium.org//1194393002.
 2015-06-22 07:04:28 -04:00
danrubel f3a1297576 fix tests 
BUG=

Review URL: https://codereview.chromium.org//1191363003.
 2015-06-20 18:20:46 -04:00
Dan Rubel eb95064511 recompute package map when input file changes 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1180843011.
 2015-06-20 17:18:54 -04:00
Dan Rubel 8b9578ef26 add for() keyword suggestion 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1179283007.
 2015-06-20 15:01:20 -04:00
Dan Rubel 61460a0a10 pull in new watcher package 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1194653002.
 2015-06-20 14:12:12 -04:00
danrubel 108f6c114b analysis server performance measurement - work in progress 
still need to debug some failing requests,
verify responses match expected responses,
track notifications to determine what was analyzed,
add docs, and ...

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1182933005.
 2015-06-17 11:35:47 -04:00
Dan Rubel e7321ee4a0 (TBR) fix server tests 
BUG=

Review URL: https://codereview.chromium.org//1192603002
 2015-06-17 11:04:56 -04:00
danrubel db11964b83 refactor Reqest.fromJson for use by performance measurement tests 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1181363004.
 2015-06-15 12:27:41 -04:00
danrubel ce311218e9 suggest keywords in if expression 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1147213008.
 2015-06-12 09:50:10 +02:00
danrubel 9c9108d51a no keyword suggestions in library identifier or property accessor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1151493004.
 2015-06-12 09:39:40 +02:00
Konstantin Shcheglov f3c28ef449 Don't create navigation regions for not existing sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1180883003.
 2015-06-11 13:21:12 -07:00
Konstantin Shcheglov b8067b5fb9 Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying. 
This fixes many co19 tests, so I guess it might solve the problems with constants you mentioned.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1183533002.
 2015-06-11 10:47:26 -07:00
Brian Wilkerson add5a6910d Remove many explicit references to AnalysisContextImpl and enable testing of the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1150863007
 2015-06-06 08:30:38 -07:00
Konstantin Shcheglov 811877df42 Invalidate resolution of analysisOptions/sourceFactory changes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1167483004
 2015-06-05 14:09:12 -07:00
Konstantin Shcheglov 1c1497ff98 Another tweak for displaying performance. 
1. It is still interesting to see performance tags, even with the next task model.

2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1161183004
 2015-06-05 09:19:28 -07:00
Dan Rubel 4224b9c049 fix ENUM_CONSTANT suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1157283004
 2015-06-04 18:01:06 -04:00
danrubel d6580fd9fb generated analysis server java client code package rename 
This changes the generated package name to better reflect our new home
from com.google.dart.server.generated.types
to   org.dartlang.analysis.server.protocol

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1164683003
 2015-06-04 17:29:35 -04:00
Konstantin Shcheglov 3cbd3e2e96 Tweak ADD_PART_OF quick fix to support both new/old task models. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1165943003
 2015-06-04 14:28:35 -07:00
Konstantin Shcheglov c1e2448928 Tweak for the new task statistics formatting. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1147043006
 2015-06-04 11:49:37 -07:00
Dan Rubel 4b082cb871 cleanup local reference contributor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1163973004
 2015-06-04 14:18:03 -04:00
Brian Wilkerson aec339a767 Expose timing data for the new task model in the status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1169573003
 2015-06-04 10:47:04 -07:00
Dan Rubel ab5371e9b7 analysis server performance measurement driver first cut 
* reads instrumentation file (log file support later)
* tracks initial analysis elapse time
* skeleton structure for adding more operations and tracking

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1163713005
 2015-06-04 10:11:59 -04:00
Konstantin Shcheglov b35d54a8b7 Decide if unit without directives is a part or a library. 
1. When there is a library containing it while we are parsing a part.

2. When a part was parsed, but then we found a library containing it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1167733004
 2015-06-02 16:01:01 -07:00
Konstantin Shcheglov a567814119 Replace 'Element.node' with 'Element.computeNode()'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1164823003
 2015-06-02 13:25:04 -07:00
Konstantin Shcheglov 8e439849b3 Issue 23573. Catch exception during indexing. 
R=paulberry@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23573

Review URL: https://codereview.chromium.org//1168473003
 2015-06-02 09:40:20 -07:00
Brian Wilkerson 06a3fd1984 Fix more tests for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1159623013
 2015-06-02 09:06:53 -07:00
Brian Wilkerson 40e925078f Bug fixes for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1144393006
 2015-06-01 16:42:36 -07:00
Konstantin Shcheglov aad76fdcbf Issue 23568. Fix for NPE in index when unresolved field formal parameter. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23568

Review URL: https://codereview.chromium.org//1162853004
 2015-06-01 15:08:33 -07:00
Konstantin Shcheglov b9cdbace93 Issue 23545. Replace unaccessible type parameters with 'dynamic'. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23545

Review URL: https://codereview.chromium.org//1147213005
 2015-06-01 14:50:39 -07:00
Konstantin Shcheglov a3a40c9ef6 Issue 11200. Quick Fix for adding required/positional parameters. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200

Review URL: https://codereview.chromium.org//1159273004
 2015-06-01 14:48:50 -07:00
Konstantin Shcheglov be9cd1c165 Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551

Review URL: https://codereview.chromium.org//1151183003
 2015-06-01 14:19:33 -07:00
Paul Berry 717da6731b Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef. 
Modifier.TYPEDEF was redundant with Modifier.MIXIN_APPLICATION and
ClassElement.isTypedef was redundant with
ClassElement.isMixinApplication.

Since Modifier.TYPEDEF was private to analyzer, it has been
eliminated.  Since ClassElement.isTypedef is part of the public API to
analyzer, it is retained, but with a "@deprecated" annotation.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1158193008
 2015-06-01 14:17:40 -07:00
Konstantin Shcheglov f1d4ef9164 Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'. 
This fixes the corresponding 'Extract Method' issue.

R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23409

Review URL: https://codereview.chromium.org//1161343002
 2015-06-01 12:40:30 -07:00