dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

3160 Commits

Author SHA1 Message Date
Konstantin Shcheglov 0d84e5e586 New test for multiple imports with the same prefix name. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2200473002 .
 2016-07-29 16:04:38 -07:00
pq 722d4a13b0 Default trailing comma support to true (#26647). 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2185873002 .

See: https://github.com/dart-lang/sdk/issues/26647.
 2016-07-27 09:42:12 -07:00
Kevin Moore 17a2ddfd42 Update dependency on pkg/package_compiler 
For analysis_server, analyzer, analyzer_cli, compiler packages

Progress on https://github.com/dart-lang/sdk/issues/26711

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2172683002 .
 2016-07-27 08:42:05 -07:00
Konstantin Shcheglov a3b1936567 Fix for SearchEngine.searchMemberDeclarations() - search exact names. 
R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2183263002 .
 2016-07-26 14:47:32 -07:00
pq 9f424fa9d5 Remove duplicated import. 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2181423002 .
 2016-07-26 10:56:22 -07:00
pq 065238943a Associate excludes with context data. 
A step towards centralizing file exclusion handling (which is currently duplicated by all analyzer clients).

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2183003003 .
 2016-07-26 10:24:39 -07:00
Konstantin Shcheglov dd18f93154 Issue 26926. Don't search hierarchy for static class members. 
R=pquitslund@google.com
BUG= https://github.com/dart-lang/sdk/issues/26926

Review URL: https://codereview.chromium.org/2176173004 .
 2016-07-25 11:36:52 -07:00
Devon Carew c52843e42d Validate the regex used in search.findTopLevelDeclarations. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2160723002 .
 2016-07-18 12:13:12 -07:00
Konstantin Shcheglov 55fcc03572 Use the new StaticWarningCode.UNDEFINED_IDENTIFIER_AWAIT error. 
...instead of StaticWarningCode.UNDEFINED_IDENTIFIER

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2162523003 .
 2016-07-18 10:48:55 -07:00
Brian Wilkerson 12dfb8b6ed Keep track of where objects are being referenced in memory status page 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2157613002 .
 2016-07-15 14:21:31 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
 2016-07-15 09:05:09 -07:00
Konstantin Shcheglov ce55b927fc Print min/max element in memory benchmarks. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2150033002 .
 2016-07-14 12:20:41 -07:00
Brian Wilkerson 2b34885e4c Fix a small bug in the stress test 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2147223003 .
 2016-07-14 10:05:20 -07:00
Konstantin Shcheglov e279c1de27 Rework local benchmarks into benchmarks on the Flutter codebase. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2150793003 .
 2016-07-14 08:45:54 -07:00
Konstantin Shcheglov 7d9d451730 Don't insert additional ':' when changing a named argument name. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2136223004 .
 2016-07-12 17:25:55 -07:00
Konstantin Shcheglov 79f7150d97 Issue 26249. Quick Assist to convert final fields into getters. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249

Review URL: https://codereview.chromium.org/2140193003 .
 2016-07-12 14:15:44 -07:00
Konstantin Shcheglov f1fa32e356 Issue 26249. Quick Assist to convert getters into final fields. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249

Review URL: https://codereview.chromium.org/2144763002 .
 2016-07-12 13:31:53 -07:00
Konstantin Shcheglov 94a41e0d2e Fixes for context_manager_test on Windows. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2142143002 .
 2016-07-12 12:26:29 -07:00
Konstantin Shcheglov bf731dfcd5 Issue 26764. Insert required imports in the correct sorting order. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26764

Review URL: https://codereview.chromium.org/2143023002 .
 2016-07-12 11:17:02 -07:00
Konstantin Shcheglov c706a355b1 Tweak for the type of the 'instances' variable. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2142593002 .
 2016-07-11 13:26:38 -07:00
Brian Wilkerson cfb3f57a97 Initial memory use status page 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2140583003 .
 2016-07-11 10:27:28 -07:00
Konstantin Shcheglov d2d8dbff41 'Import library' fixes should use the same 'addLibraryImports' implementation as the fixes where importing is a side effect. 
Preparation for https://github.com/dart-lang/sdk/issues/26764

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2138843002 .
 2016-07-11 09:33:58 -07:00
Konstantin Shcheglov ed887c09d1 Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2132073003 .
 2016-07-08 15:01:05 -07:00
Konstantin Shcheglov 1ce4c29f51 Validate only private sources, display statistics. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2131303002 .
 2016-07-08 10:07:04 -07:00
danrubel 37a6f62566 fix code completion when enableTrailingCommas is true 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2128693002 .
 2016-07-07 12:42:30 -04:00
danrubel b8f6bb0958 remove arglist suggestion 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2124103002 .
 2016-07-07 12:40:23 -04:00
Konstantin Shcheglov dc42500408 Issue 26821. Don't add 'void' return type for setters when lint 'avoid_return_types_on_setters' is enabled. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26821

Review URL: https://codereview.chromium.org/2123333002 .
 2016-07-06 13:00:38 -07:00
Brian Wilkerson d8dfab5217 Fix comments in benchmark 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2124053002 .
 2016-07-06 11:06:03 -07:00
Brian Wilkerson 552d209a2a Add links to context information for SDK contexts 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2119713004 .
 2016-07-01 13:10:16 -07:00
pq 71b1359ac8 Option to enable analyzer trailing comma support (#26647). 
(Parser changes to follow.)

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2112073002 .
 2016-07-01 08:40:39 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
 2016-06-30 07:44:41 -07:00
Brian Wilkerson e7008947ca Make SDK contexts visible on status page 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2107313002 .
 2016-06-29 10:36:35 -07:00
John Messerly 1b9bf0769d fix #26122, classify strong mode errors correctly 
StaticTypeWarningCode was being handled, but many warnings with StaticWarningCode also need to be treated as errors.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2108823002 .
 2016-06-28 14:35:44 -07:00
Brian Wilkerson 9c5213a077 Generalize DartSdkManager to support embedder SDKs 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2107793002 .
 2016-06-28 13:48:57 -07:00
Brian Wilkerson 221e92f172 Add a flutter benchmark; refactor 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2110443002 .
 2016-06-28 10:27:22 -07:00
Konstantin Shcheglov 2cdaa62c98 Make LIBRARY_CYCLE, LIBRARY_CYCLE_UNITS and LIBRARY_CYCLE_DEPENDENCIES for library source. 
It seems to me that it uses only LibrarySpecificUnit.library anyway.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2094133002 .
 2016-06-27 08:43:59 -07:00
Konstantin Shcheglov 3f1955a819 Add '--finer-grained-invalidation' option to Analysis Server. 
I think we could start fishfooding it.
There might still be bugs, and I saw it still invalidating more than
I would like. But we can fix these problems.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2091883002 .
 2016-06-23 13:10:04 -07:00
pq 270695fc31 Adds PID to server.connected notification (#26744). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2088663004 .

Fixes: https://github.com/dart-lang/sdk/issues/26744.
 2016-06-21 16:00:27 -07:00
Konstantin Shcheglov 929cdf8e02 New scenario and local benchmark - refactoring after change. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2087763002 .
 2016-06-21 08:38:33 -07:00
Brian Wilkerson 1974dc5f20 Guard against missing element (issue 26685) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2085563002 .
 2016-06-20 09:51:53 -07:00
Konstantin Shcheglov 716f3fe041 Analysis and completion benchmarks with a set of local uses. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2081483002 .
 2016-06-20 09:02:30 -07:00
Jaime Wren b7aff9c72f Initial Bazel file resolver support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2079873002 .
 2016-06-17 14:20:55 -07:00
Brian Wilkerson 5c97a88ddd Remove embedder locator from analysis context 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2078993002 .
 2016-06-17 09:42:27 -07:00
Brian Wilkerson 2b522d50d0 Deprecate EmbedderUriResolver 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2076743002 .
 2016-06-17 07:44:02 -07:00
Jaime Wren 7f244c8d39 Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace the usages with ResourceUriResolver(PhysicalResourceProvider.INSTANCE). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2060263006 .
 2016-06-16 11:14:03 -07:00
Brian Wilkerson 34a71429d9 Remove hook for setting a provider for an EmbedderUriResolver 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2075663002 .
 2016-06-16 10:28:40 -07:00
pq ed4dc77436 Switch statement cleanups. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2067973002 .
 2016-06-14 12:34:08 -07:00
Florian Schneider 705e9e781d Fix more flakiness in pkg tests. 
I already fixed similar failures.

I recommend eliminating all uses of pumpEventQueue.

BUG=#26556
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2059503002 .
 2016-06-09 15:08:06 -07:00
Brian Wilkerson 800a54354a Conditionally enable SDK summaries in server 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2020293004 .
 2016-06-09 09:58:59 -07:00
Brian Wilkerson f183ec3a45 Fix equality between subclasses of Source 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2050083002 .
 2016-06-09 07:42:32 -07:00