dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

3160 Commits

Author SHA1 Message Date
Konstantin Shcheglov 2a000e1587 Issue 27539. Check that the source is not modified between constructor and correction computing. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27539

Review URL: https://codereview.chromium.org/2411063002 .
 2016-10-11 13:41:44 -07:00
Konstantin Shcheglov 1a70ff791a Parse the 'patches' argument in SDK libraries declarations. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2408863002 .
 2016-10-11 09:19:27 -07:00
Brian Wilkerson 0f364bfac2 Fix more tests on windows bots 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2404733002 .
 2016-10-09 11:57:40 -07:00
Konstantin Shcheglov 831d3119f2 Issue 27536. Quick Fix for 'Avoid using braces in interpolation when not needed'. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27536

Review URL: https://codereview.chromium.org/2397153004 .
 2016-10-07 12:51:04 -07:00
Konstantin Shcheglov d4ebdabf43 MemoryResourceProvider.getFolder() should not create the folder. 
But newFolder() should be used to create.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2396423002 .
 2016-10-07 10:12:00 -07:00
Konstantin Shcheglov 2e2b92932a Move analysis_server dependency on analyzer back to 0.28.0 
The dart_style change to widen version was landed, but now pub says
that there is the same problem with 'linter'. I don't know why
analysis_server is tested as a package at all.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2391263007 .
 2016-10-06 20:38:35 -07:00
Brian Wilkerson ff513066c0 Improve server documentation 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2397293002 .
 2016-10-06 14:57:10 -07:00
James Robinson fe9ed42b62 Added build files for the analyzer and analysis_server packages. 
This way they can be used in the Fuchsia tree.

BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2398143002 .
 2016-10-06 14:00:19 -07:00
Brian Wilkerson 6de0803deb Clean up hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2394733004 .
 2016-10-06 12:59:38 -07:00
Brian Wilkerson 9c76fe554a Fix the spec generator to use test rather than unittest 
Review URL: https://codereview.chromium.org/2401463005 .
 2016-10-06 11:52:08 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'. 
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
 2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Konstantin Shcheglov 5a4d7ebf61 Issue 27475. Discourage users from naming constructors the same as the enclosing classes. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27475

Review URL: https://codereview.chromium.org/2399533003 .
 2016-10-05 12:07:40 -07:00
Konstantin Shcheglov f693119146 Catch and suppress expected exceptions in corrections. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2391173003 .
 2016-10-05 08:31:07 -07:00
Paul Berry f5ed63f2be Deprecate analysis option "cacheSize". 
This option has had no effect for quite some time.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2392983002 .
 2016-10-04 09:53:56 -07:00
Brian Wilkerson 852a479b73 Handle session logs and add event subset selection 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2390693002 .
 2016-10-03 08:32:09 -07:00
Brian Wilkerson 25374847ab Handle null element in completion (issue 27461) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2383533005 .
 2016-09-30 15:16:21 -07:00
Brian Wilkerson 3a610fc9f4 Fix test failures under windows 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2383133002 .
 2016-09-30 10:53:53 -07:00
Brian Wilkerson 685e4ff9e1 Revert "Remove unused option in server API" 
Review URL: https://codereview.chromium.org/2382033003 .
 2016-09-30 10:14:12 -07:00
Brian Wilkerson 2972bd0d6b Remove unused option in server API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2382053002 .
 2016-09-30 09:04:38 -07:00
Brian Wilkerson 539452bd3e ContextBuilder can configure contexts to use summaries 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2380573006 .
 2016-09-29 10:55:35 -07:00
Konstantin Shcheglov 3647e7bac0 Order suggested Quick Fix imports: direct, export, non-API. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2377803002 .
 2016-09-27 15:03:26 -07:00
Konstantin Shcheglov ef015221b1 Catch exceptions while preparing analysis.implemented notification. 
This notification is sent often, and uses index and search engine. We
have several exceptions in internal logs, and all there exceptions are
fatal by default. It seems too harsh to shutdown the server because of
a missing notification.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2376493002 .
 2016-09-26 12:54:33 -07:00
Konstantin Shcheglov 0223b08a34 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Land again) 
The pkg/analysis_server/test/integration/analysis/error_test was fixed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2366963002 .
 2016-09-23 10:21:21 -07:00
Konstantin Shcheglov 09b0bba932 Issue 27358. Reset AnalysisContext 'sourceFactory' and 'typeSystem' on analysis options change. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27358

Review URL: https://codereview.chromium.org/2361203004 .
 2016-09-23 09:44:47 -07:00
Brian Wilkerson 74686371b3 Add support for getting the sessionId from instrumentation and sending it to the client 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2359233002 .
 2016-09-22 10:26:13 -07:00
Konstantin Shcheglov 163931ffdd Fix couple hints. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2362753002 .
 2016-09-22 09:59:40 -07:00
William Hesse 92cd3e10f5 Fix test.py and tests to use an explicit --packages flag. 
BUG=https://github.com/dart-lang/sdk/issues/27412
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2361813003 .
 2016-09-22 17:51:09 +02:00
Konstantin Shcheglov e82cbea8fe Issue 27386. Fix for 'use similar' Quick Fix for import-prefixed identifiers. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27386

Review URL: https://codereview.chromium.org/2361483002 .
 2016-09-21 10:02:20 -07:00
Konstantin Shcheglov bdc024a303 Move PackageIndexAssembler into analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2357283002 .
 2016-09-21 08:54:46 -07:00
Brian Wilkerson d947a7ba89 Async is no longer optional 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2361433002 .
 2016-09-21 08:29:34 -07:00
Brian Wilkerson 2d9e690e6c Fix newly introduced errors and warnings 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2357553003 .
 2016-09-21 08:01:04 -07:00
Brian Wilkerson c369a8449e More clean-up in server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2350143004 .
 2016-09-20 08:39:43 -07:00
Brian Wilkerson 22040876bf Use declared variables to select the correct configuration for resolution 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2345773003 .
 2016-09-16 07:32:40 -07:00
Brian Wilkerson ab9ba20c04 Fix recently introduced strong-mode errors 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2344933002 .
 2016-09-15 14:37:37 -07:00
Brian Wilkerson ecc84b26a4 Break up another large file 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342733002 .
 2016-09-15 07:49:27 -07:00
Brian Wilkerson 37d213e608 Add a tool for viewing instrumentation logs 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2338883003 .
 2016-09-14 09:50:46 -07:00
Dan Rubel 023295912a improve import URI completions at EOF 
fixes https://github.com/dart-lang/sdk/issues/27020

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342473002 .
 2016-09-14 11:22:25 -04:00
Dan Rubel 4fce5e9022 reduce the relevance of completions starting with "$" 
fixes https://github.com/dart-lang/sdk/issues/27303

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2330413004 .
 2016-09-13 14:21:31 -04:00
Brian Wilkerson 6c448b6938 Move exception support to its own library 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2328043002 .
 2016-09-10 11:04:19 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
 2016-09-09 09:09:59 -07:00
Konstantin Shcheglov f5144faed8 Remove JavaArrays from java_core. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2329483002 .
 2016-09-09 09:03:25 -07:00
Konstantin Shcheglov 9cf47ce04c Remove parseUriWithException() and URISyntaxException. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2321263003 .
 2016-09-09 08:30:01 -07:00
Brian Wilkerson fe02411930 Remove several references to JavaFile 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2323173002 .
 2016-09-09 07:45:40 -07:00
Konstantin Shcheglov e976e692be Replace and remove JavaException(s). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2326813002 .
 2016-09-08 15:56:33 -07:00
Konstantin Shcheglov e187e33923 Remove StringUtils from java_core. 
It is used almost only in analyzer and analysis_server.
There are two places where it is used internally - I'm fixing them.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2317113005 .
 2016-09-08 13:26:56 -07:00
Konstantin Shcheglov 7343da76ba Issue 27078. Describe RefactoringProblemSeverity values. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27078

Review URL: https://codereview.chromium.org/2312073003 .
 2016-09-06 17:46:24 -07:00
Konstantin Shcheglov 7442a85cbb Issue 27130. Fix applying changes to .analysis_options on save. 
This fix partially reverts changes made in https://github.com/dart-lang/sdk/commit/de6925a23ebf29cd587dd5f4e214cb277a7397e4
It is correct that we should ignore applyChanges() for sources with
content overridden in the content cache. But we cannot know what else
happened with results in the analysis cache at this point. So, we
should just let Analysis Server to always run analysis, so that
Driver and WorkManager(s) will decide if there is anything to do.

I believe that the original motivation for the change was to avoid
sending extr 'analysis.implemented' notifications. It does not happen
anymore, probably because we set other shortcuts using source content.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27130

Review URL: https://codereview.chromium.org/2314933003 .
 2016-09-06 13:41:48 -07:00
Konstantin Shcheglov 9aa060e67f Issue 27143. Fill documentation for local, AST based completion. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27143

Review URL: https://codereview.chromium.org/2313003002 .
 2016-09-06 12:05:20 -07:00
Konstantin Shcheglov f4186fb463 Issue 27244. Add 'isDeprecated' to HoverInformation. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244

Review URL: https://codereview.chromium.org/2310153002 .
 2016-09-06 11:31:11 -07:00