238894eb76
Stop using ExecutableElement.localVariables in RenameClassMemberRefactoringImpl.
...
This is the only / last usage in Analysis Server.
And this change fixes 3 failing tests.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2961363003 .
2017-06-30 11:58:15 -07:00
6248df44a6
Add the tests of the spec generator to the unit tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2966623003 .
2017-06-30 10:08:51 -07:00
10fa170d66
Add null check before returning postfix expansion
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2966813002 .
2017-06-30 09:43:51 -07:00
99cc563718
Update the spec to deprecate fileStamp
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2964653002 .
2017-06-30 08:21:47 -07:00
d1bb233f52
Remove timeStamp from the ChangeBuilder API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962223002 .
2017-06-29 13:48:46 -07:00
f6b7fd307a
Pass target elements being renamed into validator.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2963173002 .
2017-06-29 13:42:01 -07:00
077b6b687d
Remove incremental: logger, validator, options.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2968473002 .
2017-06-29 11:51:12 -07:00
8f5c21ea68
Use SearchEngine.membersOfSubtypes() instead of actual elements in ImplementedComputer.
...
This makes 'implemented' notification 10x faster for files with
many types and implemented methods, like visitor.dart - from 400 ms
down to 36 ms. Still not as fast as I would like, but much better.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2955313003 .
2017-06-29 10:11:26 -07:00
b3fe985371
Use AnalysisDriver.getCachedResult() for 'implemented' notification.
...
In general case we cannot use getResult() in this notification.
We generate these notifications after analysis is complete in scheduler.
But if there is no cached result, getResult() will schedule analysis.
So, we might get into a loop.
In practice this worked, because IDEA always makes files priority,
so their results cached, and then subscribes for notifications.
But in general case we need this protection.
This also means that the 'implemented' notification works (and will
work) only for priority files.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2965533002 .
2017-06-29 09:57:20 -07:00
256d6fa704
Remove the stale test for discarding notifications.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2961173002 .
2017-06-28 14:27:38 -07:00
e0f4c7b467
Report only private members in the same library as overrides.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2959273002 .
2017-06-28 13:47:33 -07:00
911263f240
Remove the old index.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2963773003 .
2017-06-28 13:44:05 -07:00
2b64bbed6a
Add SearchEngine.membersOfSubtypes().
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2962023002 .
2017-06-28 11:44:48 -07:00
7bd9e6c443
Add a mixin for assists similar to that for fixes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2956353002 .
2017-06-28 11:44:22 -07:00
6248e7cab2
Add support code to make fixes easier in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962903002 .
2017-06-28 10:52:06 -07:00
9ddb832e10
Generate constants in server as we do in plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
a2f18fdb73
Fixes and tests for adding library imports.
...
R=brianwilkerson@google.com , pquitslund@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/1119
Review-Url: https://codereview.chromium.org/2955913002 .
2017-06-26 13:16:19 -07:00
8c50e08e64
Add integration tests for postfix serer api
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2961683002 .
2017-06-26 13:13:21 -07:00
4c8e1b9132
Update coverage.md
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2960683002 .
2017-06-26 11:21:50 -07:00
c26c2774ca
This defines some postfix completion templates for use in the IntelliJ editor.
...
R=brianwilkerson@google.com
To use it, you'll need a version of the Dart plugin with this PR patched in:
https://github.com/JetBrains/intellij-plugins/pull/534
Review-Url: https://codereview.chromium.org/2917943002 .
2017-06-26 09:53:02 -07:00
66986042af
Add support for running pub for plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2949893002 .
2017-06-26 09:21:11 -07:00
5946ce552f
Add AnalysisSession to analyzer
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2954153002 .
2017-06-26 09:16:11 -07:00
c9dce504cc
Remove more dead code
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2959713002 .
2017-06-26 07:31:25 -07:00
de5cf42579
Fix an issue calculating analysis server cpu usage.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2959643002 .
2017-06-25 18:59:41 -07:00
029b1cb948
Spelling fixes e to i.
...
R=kevmoo@google.com
BUG=
Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
55d735911b
Remove the unused operations queue
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2957643002 .
2017-06-23 09:04:13 -07:00
ec8505fc79
Fix hints and clean-up obsolete comment syntax (TBR)
...
Review-Url: https://codereview.chromium.org/2952233002 .
2017-06-22 10:59:26 -07:00
a420a1fbb5
Remove more dead code from analysis server
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2949103003 .
2017-06-22 08:21:03 -07:00
e28064f405
Restore partial analysis of analysis options files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2946313003 .
2017-06-22 08:00:50 -07:00
fcb23e967c
Remove the unused class SingleContextManager
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2945313002 .
2017-06-21 11:21:25 -07:00
53e01faa43
Remove unused implementation of SearchEngine and rename the driver-based implementation
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2949823002 .
2017-06-21 09:33:51 -07:00
6e89075952
Disable finding plugin locations in the pubspec
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2947153002 .
2017-06-21 09:30:32 -07:00
6e8453ed94
Fix invalid initializing formal by adding a field
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2946093002 .
2017-06-21 07:56:26 -07:00
47c9dcad97
Update plugin whitelist to accomodate angular plugin rename
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2947953002 .
2017-06-20 12:01:51 -07:00
5582824e3c
Rename the plugin location key and directory name
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2952583003 .
2017-06-20 11:06:39 -07:00
24996fbfe7
Add support to pass the location of the analysis options file to plugins
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2947743002 .
2017-06-20 07:41:03 -07:00
d30c5070a2
Disable a test to fix the bots (TBR)
...
Review-Url: https://codereview.chromium.org/2946763002 .
2017-06-19 12:02:52 -07:00
f9dc588a27
Don't compute 'dart:core' LibraryElement during completion.
...
AnalysisResult already has TypeProvider, which can give us Object type.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review-Url: https://codereview.chromium.org/2946643002 .
2017-06-19 08:18:08 -07:00
e0216fef7f
Remove ability to disable new analysis driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2937323003 .
2017-06-19 08:13:14 -07:00
9600dab0e0
Enable 'analysis.implemented' with the new analysis driver.
...
It is not very efficient on large files, but works well enough for small
files. I will work on making it more efficient in following CLs.
R=brianwilkerson@google.com , devoncarew@google.com
BUG= https://github.com/dart-lang/sdk/issues/29113
Review-Url: https://codereview.chromium.org/2942753002 .
2017-06-16 09:13:45 -07:00
305f358fa4
update statement completion for fasta scanner
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2936143002 .
2017-06-14 11:15:50 -04:00
a0d7d64f0b
Convert more tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2936123002 .
2017-06-13 19:38:59 -07:00
e523061acc
Minor tweaks to the diagnostics page.
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2937623005 .
2017-06-13 19:22:28 -07:00
4337a3aeee
Cleanup some unused code in some of the tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2942433002 .
2017-06-13 14:01:17 -07:00
4da8380881
Convert more tests to use the new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939803002 .
2017-06-13 12:04:25 -07:00
1e9ae646ff
Clean up some hints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939723002 .
2017-06-13 09:24:50 -07:00
67ff4d4c47
Convert more tests to the new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2933943002 .
2017-06-12 14:10:14 -07:00
65d05524ce
Remove some unnecessary tests for non-driver mode
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2935733003 .
2017-06-12 11:31:09 -07:00
d9749ef0ac
Get the highlights test to work with the new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2934863002 .
2017-06-12 11:30:24 -07:00
10a5bfaa08
Reduce the test scope of get_fixes_test.dart.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2932343002 .
2017-06-12 08:24:53 -07:00
Konstantin Shcheglov