Commit Graph

3160 Commits

Author SHA1 Message Date
Paul Berry 89c910b9c1 Move byte_store.dart and file_byte_store.dart to their own subdirectory.
This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.

R=scheglov@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2990323002 .
2017-08-07 11:04:48 -07:00
Brian Wilkerson 4c635b7b85 Initial support for an explicit plugin list
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988343002 .
2017-08-02 11:30:57 -07:00
Devon Carew e164b2a820 ignore errors deleting the analysis driver cache.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2992203002 .
2017-08-02 10:33:00 -07:00
Devon Carew f383c17bc2 Redo our benchmarks; add a benchmark/benchmarks.dart tool.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2986293002 .
2017-08-02 08:07:38 -07:00
Brian Wilkerson ae69313731 Initial implementation of the import-aware copy support
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988183002 .
2017-08-01 08:32:12 -07:00
Brian Wilkerson 45d0b24283 Add a test for import-aware paste
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2992133002 .
2017-08-01 08:20:30 -07:00
Jaime Wren 17d640d6ff Some initial work for the Dart Kythe indexer support in the analysis server
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2987193002 .
2017-07-31 14:38:32 -07:00
Brian Wilkerson 5b88eef0af Suggest covariant in parameter lists
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986133002 .
2017-07-28 10:33:07 -07:00
Brian Wilkerson de0b7a2f40 Add sourceFactory getter to AnalysisSession
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2989883002 .
2017-07-28 06:18:53 -07:00
Brian Wilkerson 9591a9449f Partial support for intelligent paste operation
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986073002 .
2017-07-27 13:55:59 -07:00
Brian Wilkerson c618032a69 Remove the uri from the ImportedElements object in the experimental spec API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2991893002 .
2017-07-27 12:52:38 -07:00
Brian Wilkerson 9a6b134d33 Improve name generation for indexed expressions
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2990793002 .
2017-07-27 07:58:34 -07:00
Brian Wilkerson 950b4108f7 Add assist to convert part-of directives
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986903002 .
2017-07-26 09:08:37 -07:00
Konstantin Shcheglov b1589bf879 Replace typed_mock with mockito in analysis_server.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2991773002 .
2017-07-26 08:14:25 -07:00
Brian Wilkerson a040de8c08 Update the version of the server API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2985003002 .
2017-07-25 12:45:16 -07:00
Brian Wilkerson 8bbf373a5e Remove the analysus.reanalyze request from the plugin API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
Konstantin Shcheglov 939d8aaf6d Issue 30238. Fix for subscribing for a notifications with already cached analysis result.
With the new 'sendCachedToStream' option we can control that whether
cached analysis result is also reported into the 'results' stream when
it is desirable (when we do this to send analysis notifications from
the stream listener). Or not, when it is not desirable, e.g. when we
ask becaue we need the results unit for Quick Assists.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/30238

Review-Url: https://codereview.chromium.org/2989633002 .
2017-07-25 10:28:25 -07:00
Brian Wilkerson f434d87581 Fix the bots (TBR)
Review-Url: https://codereview.chromium.org/2986813002 .
2017-07-24 10:39:16 -07:00
Brian Wilkerson 0f9707073d Add support for creating a .packages file when the plugin is in a Bazel workspace
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988673002 .
2017-07-24 10:00:05 -07:00
Konstantin Shcheglov bdd69ccd6c Remove UriReferencedElement with its uri/uriOffset/uriEnd properties.
The 'Move File' refactoring does not work, so I comment out most
of its code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2982993003 .
2017-07-19 09:31:03 -07:00
Konstantin Shcheglov 90121b528a Remove the 'Move File' refactoring.
It has been broken since we switched to Analysis Driver.
Given that IDEA does not use it, there is little incentive to fix it.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2983783003 .
2017-07-18 17:59:20 -07:00
Devon Carew 8b7e3ef7e4 add env var info to the diagnostics page
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2981123002 .
2017-07-17 09:22:23 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
Mike Fairhurst 2eb0017013 Add angular to analyzer plugin whitelist
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2982773002 .
2017-07-13 14:36:14 -07:00
Konstantin Shcheglov 78f78feaf8 Don't include *.yaml files in 'analysis.analyzedFiles' notification.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review-Url: https://codereview.chromium.org/2980653002 .
2017-07-11 14:19:15 -07:00
Konstantin Shcheglov 5cd77dda37 AnalysisOptionsProvider.getOptionsFile() should return only existing files.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review-Url: https://codereview.chromium.org/2981553002 .
2017-07-11 13:38:08 -07:00
danrubel b47bfa88be remove unused analysis server flag
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2974013002 .
2017-07-11 08:10:42 -04:00
danrubel def1ee6604 add analysis server --flutter-repo startup flag
This adds a new flag used by `flutter analyze --watch` when analyzing
the flutter repository. When specified, this flag causes analysis server
to enable the public_member_api_docs lint even though it is not enabled
in the analysis_options file. `flutter analyze --watch` needs the results
of this lint to summarize the number of public members missing dartdoc,
but enabling it in the analysis_options causes too much noise in the IDE.

See https://github.com/flutter/flutter/issues/10721 for more background

R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2976473003 .
2017-07-10 16:50:04 -04:00
Konstantin Shcheglov a673395664 Don't depend on visiting local functions.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2970403002 .
2017-07-07 13:01:23 -07:00
Devon Carew a2e9519279 Make exception reporting best effort.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2965263002 .
2017-07-06 13:36:28 -07:00
Konstantin Shcheglov ee4a09faea Fix for element_search.dart import in analysis_server.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975473002 .
2017-07-06 12:38:56 -07:00
Brian Wilkerson e454986288 Add code to run more tests from test_all
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2968233002 .
2017-07-06 12:24:01 -07:00
Konstantin Shcheglov 19265a82b4 Move findElementsByName() into shared analyzer/element_search.dart file.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2965133003 .
2017-07-06 11:51:17 -07:00
Devon Carew ba625804b7 Tweaks to the profiling diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2966383002 .
2017-07-06 11:47:26 -07:00
Konstantin Shcheglov 6323bedc58 Stop depending on LabelElement(s) to be reported in visitChildren().
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2973093002 .
2017-07-06 11:28:06 -07:00
Brian Wilkerson fe445e079e Add a generated file that was missed
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2966223004 .
2017-07-06 09:55:29 -07:00
Brian Wilkerson cc5ccf5dcf Add unit tests for copy/paste support
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2965243002 .
2017-07-06 09:54:42 -07:00
Devon Carew d4abd49df7 Add analytics to analyzer-cli and analysis server.
BUG=
R=brianwilkerson@google.com, scheglov@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
Brian Wilkerson d9754a58e9 Initial implementation of copy/paste support
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2972833002 .
2017-07-05 14:02:07 -07:00
Konstantin Shcheglov ce43a15e51 Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().
We still visit them, but analyzer and analysis_server don't need it.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2969343002 .
2017-07-05 12:28:20 -07:00
Brian Wilkerson d2569cc3ee Add lint timing information to the status pages
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2970153002 .
2017-07-05 12:00:42 -07:00
Brian Wilkerson 3c1c22a3a1 Add a quick fix for missing new (issue 30077)
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2965063002 .
2017-07-05 10:59:34 -07:00
Brian Wilkerson 62f43f663b Fix a bug in inline method refactoring
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2973673002 .
2017-07-05 09:35:48 -07:00
Brian Wilkerson a3406c38e2 Update server version after adding experimental API
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2972673002 .
2017-07-04 16:14:57 -07:00
Brian Wilkerson 6a7b9f441b Convert DartChangeBuilder to use AnalysisSession
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2969833002 .
2017-07-03 08:41:40 -07:00
Brian Wilkerson 2f28f5713c Fix a test so that it passes
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2968883002 .
2017-07-03 08:39:31 -07:00
Brian Wilkerson 0ee29eadf1 Run the generator after updates to spec
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972473002 .
2017-07-02 07:49:05 -07:00
Brian Wilkerson 8c8a177f3c Fix failing test (TBR)
Review-Url: https://codereview.chromium.org/2964343002 .
2017-07-01 12:55:17 -07:00
Brian Wilkerson aadafd1bd5 Use DartEditBuilder to write types and remove dead code
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
Brian Wilkerson d31ed8690e Capture imports on copy; update imports on paste
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939593002 .
2017-07-01 12:02:30 -07:00