dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

2342 Commits

Author SHA1 Message Date
Konstantin Shcheglov bb6a4b2fd8 Better message for Rename refactoring changes. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1319663008 .
 2015-09-02 15:14:05 -07:00
Konstantin Shcheglov b15a031276 Navigation extension point. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303033010 .
 2015-09-01 13:06:25 -07:00
danrubel 07184f6cdd rename ImportUriContributor to UriContributor 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1329463002 .
 2015-09-01 11:11:36 -04:00
danrubel 773c3cf9d1 improve import uri completions - fixes #24000 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1325583002 .
 2015-08-31 15:21:34 -04:00
Alexandre Ardhuin 0784fc3134 use const constructors of Utf8* 2015-08-29 22:44:28 +02:00
Dan Rubel c0fe214c47 show all available import completion suggestions - fixes #23955 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1317023002 .
 2015-08-26 17:37:01 -04:00
Dan Rubel bd95b13b90 improve keyword suggestions - fixes #24016 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1303233008 .
 2015-08-26 17:34:57 -04:00
Brian Wilkerson c3b12a65ba Add a task to partially resolve a compilation unit 
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1321523002 .
 2015-08-26 11:22:03 -07:00
Dan Rubel f61faa2fbd exclude instance suggestions in static context - fixes #22932 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1319753002 .
 2015-08-26 14:00:03 -04:00
Brian Wilkerson 271bc1f776 Convert completion API to be future based 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1318543002 .
 2015-08-25 11:01:13 -07:00
Brian Wilkerson 4bd6b4b048 Fix display of parameter lists in servers Element structure (issue 24194) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1313113002 .
 2015-08-25 09:23:26 -07:00
Konstantin Shcheglov aea1e572a1 Sort top-level constants before other top-level variables. 
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1306083003 .
 2015-08-21 12:19:48 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34). 
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
 2015-08-20 09:47:26 -07:00
Konstantin Shcheglov 7e99b8696e Support for analysis.setPriorityFiles for files in SDK. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/215

Review URL: https://codereview.chromium.org//1289643003 .
 2015-08-17 10:48:38 -07:00
danrubel 9af696a4f7 suggest prefixed constructors - fixes #23210 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1291283002 .
 2015-08-14 20:33:12 -04:00
John McCutchan 67a7aeaf12 Add _sdkext support back to analysis server 
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1295463003 .
 2015-08-13 12:24:37 -07:00
Konstantin Shcheglov 7ab954efb5 Remove debug output in getNavigation(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1288163003 .
 2015-08-12 14:02:07 -07:00
Konstantin Shcheglov e9d2f739ad More tweaks in attempt to debug the reason of failing getNavigation() tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1284933002 .
 2015-08-11 11:13:48 -07:00
Konstantin Shcheglov e6702099e6 Add debug output for getNavigation(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1276883004 .
 2015-08-11 09:15:28 -07:00
Konstantin Shcheglov 089f84f6cd Keep only unique overridden elements. 
If the implemented interfaces don't declare an element, keep only a single copy of the element - from the superclass.

In Dart Editor we use any element, but in in IDEA we show all of them, and we don't want to have duplicates.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1273003005 .
 2015-08-10 16:13:43 -07:00
Brian Wilkerson 97225c3a21 Possible fix for Windows bot failures 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1275503003 .
 2015-08-10 13:10:08 -07:00
Paul Berry f3f52d4b59 Fix regression in import fixups introduced by .packages support. 
With the introduction of support for ".packages" files, analysis
server now uses a slightly different code path for translating the
Source objects from imported package files into "package:" URI's.
Previously it used PackageUriResolver.resolveAbsolute(); now it uses
ResourceUriResolver.resolveAbsolute(), and then translates the
resulting file: URI to a package: URI uring the .packages file.

The old code path used Source.fullName (the file path) to locate the
file in the filesystem; the new code path uses Source.uri.  This
causes problems because when figuring out the correct import statement
to insert, the analysis server creates a bogus Source object whose uri
field is null.  As a result, import fixups were getting relative paths
like "../../../../.pub-cache/..." rather than package imports, which
is clearly wrong.

As a short term non-invasive fix, we set Source.uri in the bogus
Source object, so that the new codepath is able to find the path of
the imported file.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1281313002 .
 2015-08-10 12:14:26 -07:00
Konstantin Shcheglov c48cc7b913 Check for reset during 'await' in refactoring manager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1281983002 .
 2015-08-10 11:19:03 -07:00
danrubel 07d94ad596 fix completion after dot-keyword - fixes #23882 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1273773005 .
 2015-08-10 11:11:51 -04:00
danrubel 3bbf03ba7b suggest "in" in for statement 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1285573003 .
 2015-08-10 10:43:27 -04:00
danrubel f79d02ddd0 remove complex keyword suggestions - fixes #23978 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1280313002 .
 2015-08-10 10:09:18 -04:00
danrubel 8ac02a9a24 suggest constructor named param 
fixes #24004

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1283443004 .
 2015-08-07 13:09:47 -05:00
danrubel a05ee55f03 suggest import uris when import is only text in file 
prevent keyword suggestion in import uri without semicolon

fixes #24002

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1276273003 .
 2015-08-07 12:25:25 -05:00
Paul Berry 206083c8b1 In analysis server, favor package root setting over ".packages" file. 
R=brianwilkerson@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1277063002 .
 2015-08-07 09:23:53 -07:00
danrubel 3b8b7ee7a2 suggest "deferred as" rather than "deferred" 
suggest show and hide in import declaration

fixes #23967

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1276843007 .
 2015-08-06 16:02:58 -07:00
Brian Wilkerson 2fd3bad64e Cause "implement methods" to be sorted before "make abstract" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1276963003 .
 2015-08-06 14:40:50 -07:00
Konstantin Shcheglov 65941839b7 Remove also duplicate imports. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1277983002 .
 2015-08-06 12:42:30 -07:00
Paul Berry d977370e3f Fix PathFilter constructor to be backward compatible with analyzer 0.26.0. 
Commit 24189ea4f9 modified the
PathFilter constructor signature in a backwards-incompatible way, and
made corresponding changes to analysis_server, causing warnings to
show up in analysis_server when analyzed using the version of analyzer
in its pubspec.

This CL switches to a backwards-compatible signature and updates the
analyzer pubspec in preparation for publishing.  Once the new version
of analyzer is published I will update analysis_server's pubspec to
point to it, which should fix the warnings.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278823002 .
 2015-08-06 11:03:55 -07:00
Brian Wilkerson 9aa45d4cf0 Capture more data when instrumenting exceptions 
R=lukechurch@google.com

Review URL: https://codereview.chromium.org//1257023003 .
 2015-08-06 08:50:39 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
danrubel a6ea45883d add location to suggestions from local file 
fixes #23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1267203002 .
 2015-08-04 22:12:01 -07:00
danrubel bf05b75f43 update suggestion element return type to have type param 
cleanup loadLibrary suggestion to have correct element

dartbug.com/23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1260593005 .
 2015-08-04 22:08:55 -07:00
Konstantin Shcheglov d11b644cc5 Issue 23963. Improve to/from block/expression body with void expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23963

Review URL: https://codereview.chromium.org//1267333003 .
 2015-08-04 16:16:17 -07:00
Konstantin Shcheglov fbb7aedee5 WEB-17598. Name new libraries according to the Dart Style Guide. 
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-17598
     https://github.com/dart-lang/sdk/issues/23972

Review URL: https://codereview.chromium.org//1253103007 .
 2015-08-04 14:47:30 -07:00
pq d4d7e300f4 Flip .packages server support bit. 
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1253183015 .
 2015-08-04 14:01:49 -07:00
Konstantin Shcheglov 60ab26dc30 Simplify directive's optimizer edit. 
There was also a bug in computing common range.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1272013002 .
 2015-08-04 13:14:27 -07:00
Konstantin Shcheglov 92f49b892d Implementation of 'edit.organizeDirectives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1255413003 .
 2015-08-03 22:44:35 -07:00
danrubel fde3b1b335 better completions in switch statements 
Closes #23527

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1255953004 .
 2015-08-03 14:06:30 -07:00
danrubel e8e6cf823a fix completion replacement offset/length for invalid token in switch statement 
Closes #23947

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1271723002 .
 2015-08-03 14:02:40 -07:00
John McCutchan dfc35faaf9 Make exclude list also exclude contexts 
- Only create a context if the directory/.packages/pubspec.yaml is not excluded.
- Add tests.

Fixes: https://github.com/dart-lang/sdk/issues/23941

R=brianwilkerson@google.com, devoncarew@google.com, paulberry@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1263443005 .
 2015-08-03 13:54:17 -07:00
danrubel 9d5154a1fd include exported library namespace in prefixed import suggestions 
Closes #23946

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1263093003 .
 2015-08-03 13:52:44 -07:00
Konstantin Shcheglov 64ff591f56 Organize directives implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1266393002 .
 2015-08-03 13:49:57 -07:00
Konstantin Shcheglov e5b4713f03 'Import library' and 'Create class' Quick Fixes for unresolved class-like name in list literals. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1269043003 .
 2015-08-03 13:03:28 -07:00
Konstantin Shcheglov aa30cad380 Proposal for the 'edit.organizeDirectives' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23921

Review URL: https://codereview.chromium.org//1258563008 .
 2015-08-03 07:59:26 -07:00
Brian Wilkerson 24189ea4f9 Make PathFilter use the resource providers path context 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1260443006 .
 2015-07-31 10:06:38 -07:00