dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

2342 Commits

Author SHA1 Message Date
Konstantin Shcheglov 7beaf28f32 Always include Object and its members into 'inherited'. 
Analyzing them honestly is too expensive.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//1375313004 .
 2015-09-30 18:23:53 -07:00
Konstantin Shcheglov db4e79b74d Issue 24459. Fix for 'Create Method' QF in different unit. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24459

Review URL: https://codereview.chromium.org//1375043004 .
 2015-09-29 21:29:07 -07:00
Paul Berry f9aebddc67 Ignore added files in hidden directories. 
In commit 6ddc37a5cc, the ContextManager
was modified to disable analysis of files in hidden directories,
provided those files existed prior to the creation of the context.
This CL extends the fix to apply also to files that are added after
context creation.

Fixes #24212.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1372173004 .
 2015-09-28 14:10:32 -07:00
Konstantin Shcheglov 5bc38481a7 Report a fatal error on attempt to rename an element declared in SDK. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1377623002 .
 2015-09-28 14:00:13 -07:00
danrubel 6cd9e0da71 Do not suggest static fields in constructor initializer - fixes #24256 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1365403002 .
 2015-09-26 11:59:15 +02:00
Konstantin Shcheglov 6bab7d9cbc Use Element.nameLength where possible. 
...or don't use it when there is a better alternative.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372673003 .
 2015-09-25 15:03:46 -07:00
Konstantin Shcheglov 3924b15d85 Remove ElementLocator.locateWithOffset altogether. 
It was needed only for the old Angular implementation support, which
overlayed its own Element subclasses into normal Dart AST, for example
for string literals - names of components.

As we don't support this anymore, there is no need for the method.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1370833002 .
 2015-09-25 14:57:15 -07:00
Konstantin Shcheglov 4f8649f1b3 Issue 24442. Fix for renaming library names with spaces. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24442

Review URL: https://codereview.chromium.org//1370793003 .
 2015-09-25 13:55:13 -07:00
Konstantin Shcheglov 83f94a2114 Add navigation region for 'library' directives. 
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1373593002 .
 2015-09-25 12:35:51 -07:00
Konstantin Shcheglov df827a06ae The 'analysis.implemented' notification implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1368793003 .
 2015-09-25 12:33:02 -07:00
Konstantin Shcheglov da29a447c4 New analysis.implemented notification specification. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372623004 .
 2015-09-25 09:57:29 -07:00
Konstantin Shcheglov 805f6ec3ba Record HAS_ANCESTOR relations into index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1371463002 .
 2015-09-24 16:21:09 -07:00
pq d869088ea3 Error handling for bad .analysis_options files. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1364813003 .
 2015-09-23 13:27:19 -07:00
Konstantin Shcheglov 6899986bfe Use TypeSystem in the 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1364803003 .
 2015-09-23 10:28:50 -07:00
Konstantin Shcheglov 5fd8b38737 Tweak navigation for 'part of' directives. 
This makes it consistent with import/export/part directives, where only URIs are navigation sources.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1365663002 .
 2015-09-23 10:14:49 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
 2015-09-23 08:17:33 -07:00
Brian Wilkerson 7aa459affd Add more performance data 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1363653005 .
 2015-09-23 07:44:44 -07:00
pq d2f4a19fa6 Import cleanup. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1364583002 .
 2015-09-22 17:06:55 -07:00
Konstantin Shcheglov 531f1d1e5b Extract Dart specific node management into DartUnitIndexObjectManager. 
We want to be able to index not just CompilationUnitElement(s), but also
for example results of Angular resolution, which while are based on resolved
CompilationUnit(s), are not ready together with it, so should live in separate
split index nodes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359023002 .
 2015-09-22 12:26:41 -07:00
Brian Wilkerson 163ad75127 Fix status pages when running new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1351243003 .
 2015-09-22 11:03:56 -07:00
Konstantin Shcheglov f67bc2f546 Replace NameElement with IndexableName. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1347943006 .
 2015-09-21 12:02:34 -07:00
Konstantin Shcheglov bd51946e6f Remove old translated code from DAS. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1355173002 .
 2015-09-21 10:43:35 -07:00
danrubel d6051a53a0 refactor ContributionSorter to use new API 
move CompletionTarget to public API
modify DartCompletionRequest to return completion target

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1347283005 .
 2015-09-18 16:03:22 -04:00
danrubel 9ad1bf1f0e rename inherited_computer to inherited_contributor (TBR) 
Review URL: https://codereview.chromium.org//1357003002 .
 2015-09-18 15:56:59 -04:00
danrubel 3d05453793 add inherited_computer.dart (TBR) 
Review URL: https://codereview.chromium.org//1346813005 .
 2015-09-18 15:46:56 -04:00
Brian Wilkerson f4b1879180 Add a completion for inherited methods 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1338173002 .
 2015-09-18 08:59:56 -07:00
Konstantin Shcheglov 594fe93422 Support for NAVIGATION/OCCURRENCES notifications for any source (such as HTML). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1343283004 .
 2015-09-17 12:37:36 -07:00
danrubel b96b1cfc5d Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339 
I will convert CompletionSorter to use the new completion API in a subsequent CL.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1353913002 .
 2015-09-17 14:59:48 -04:00
Konstantin Shcheglov 75600fc162 Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1345943006 .
 2015-09-17 10:37:04 -07:00
Brian Wilkerson 1a6daab9d1 Wrap the http server start-up in an exception handler 
R=devoncarew@google.com

Review URL: https://codereview.chromium.org//1349263002 .
 2015-09-17 10:15:38 -07:00
Konstantin Shcheglov a01281370b Fix for dynamic instance field reference highlighting. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1349223002 .
 2015-09-17 09:25:22 -07:00
Konstantin Shcheglov d71bda7c05 Highlight library identifiers as LIBRARY_NAME. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1352843002 .
 2015-09-17 09:24:14 -07:00
Brian Wilkerson b233ab26ad Remove unused setter from ServerStarter and un-deprecate a used setter 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1341343002 .
 2015-09-15 09:38:56 -07:00
Konstantin Shcheglov cf88943a10 Issue 24338. Don't propose creating a local class for prefixed identifiers. 
Importing with prefix would take more time than I'd like to spend now.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1336323003 .
 2015-09-14 08:17:18 -07:00
Konstantin Shcheglov e4b7c93961 Merge occurrences. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1338153002 .
 2015-09-14 08:10:02 -07:00
Konstantin Shcheglov ef2fc0d778 Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1337143002 .
 2015-09-11 13:59:28 -07:00
pq 5441e21750 Fixed server plugin status reporting. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1336733003 .
 2015-09-11 08:55:15 -07:00
Lasse R.H. Nielsen 931e41777e Merge pull request #24236 from a14n/use-const 
use const constructors of Utf8* at several places
 2015-09-11 12:26:27 +02:00
Konstantin Shcheglov d13a9ec666 Rename NavigationHolder to NavigationCollector. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1307663007 .
 2015-09-09 13:27:24 -07:00
Konstantin Shcheglov cfc52cfbbf Make NavigationOperation a MergeableOperation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1327173002 .
 2015-09-09 11:01:01 -07:00
Konstantin Shcheglov 0e6eec7968 Make navigation notification operation Source based, without Dart knowledge. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1307143004 .
 2015-09-09 10:02:12 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
 2015-09-09 08:19:18 -07:00
Konstantin Shcheglov c67b274852 Explicitly document that NavigationRegion.targets cannot be empty. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1328273002 .
 2015-09-08 13:16:43 -07:00
Paul Berry b39928e01d Ignore non-existent analysis roots. 
Fixes #24242.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1316753003 .
 2015-09-08 05:36:30 -07:00
Konstantin Shcheglov f0cbf430e0 Issue 24298. Fix for 'async' function body conversion. 
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24298

Review URL: https://codereview.chromium.org//1324323004 .
 2015-09-04 21:39:28 -07:00
Konstantin Shcheglov 9263610196 Sort navigation regions after gathering results from all of the contributors. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1323243008 .
 2015-09-04 17:06:44 -07:00
Konstantin Shcheglov dfd09f3f66 Extension point for AnalysisResultListener(s). 
The plan is that plugins will listen for computed results. For example the Angular
plugin will listen for DART_TEMPLATES and once it sees one, it will schedule
sending the navigation notification, because now the other extension - NavigationContributor
can produce its navigation regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303343008 .
 2015-09-04 09:56:27 -07:00
Konstantin Shcheglov 13d5a4744d Support for 'superOnly' in 'search.getTypeHierarchy'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1322323005 .
 2015-09-03 14:29:48 -07:00
Konstantin Shcheglov 58f5005cb1 Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325543006 .
 2015-09-03 13:03:01 -07:00
Konstantin Shcheglov e090ff872e Issue 24277. Use node's offset as the source range start for the first unit node in Outline. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24277

Review URL: https://codereview.chromium.org//1325143003 .
 2015-09-02 17:55:15 -07:00