df62a0d75d
Warn when implicit default value overrides explicit one that differs.
...
BUG=dartbug.com/18914
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//700923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41503 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 20:32:18 +00:00
e18464b912
Always check if instance method name collides with superclass static.
...
Previously we only did this check if nothing was overridden.
Persumably that was intended as a speed optimization, since at first
glance it would seem that if the instance method overrides something,
then it can't possibly conflict with a static method in the
superclass. However, that optimization doesn't work if the method
being overridden is in an interface (in that case the superclass can
still have a static method with the same name). So just go ahead and
check in all cases.
BUG=dartbug.com/18947
R=scheglov@google.com
Review URL: https://codereview.chromium.org//698973005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41501 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 19:31:31 +00:00
010f33956f
cleanup warnings/hints
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//685363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41419 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:12:30 +00:00
9a806f616d
Replace EngineTestCase.assertSize() with hasLength().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//686793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41361 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 15:57:33 +00:00
63523cf050
Inline JUnitTestCase 'assert' methods.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//685573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41347 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:00:13 +00:00
78c7e8fc06
Convert most of the EngineTestCase.createSource invocations into multi-line String literals.
...
There are sill invocations in Angular tests, but these call it with List<String>,
I will clean them up in the following CL.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//682553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41308 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:03:21 +00:00
febb8f2e22
Split up large resolver_test.dart file.
...
This splits the four largest classes out of resolver_test.dart
and into their own files. Hopefully this should help prevent
resolver_test.dart from timing out on the buildbots.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//656543003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41085 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-13 21:43:33 +00:00
paulberry@google.com