8637cfd322
Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
...
This reverts commit r41512.
BUG=
Review URL: https://codereview.chromium.org//693183006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
2b336e17f0
Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
...
BUG=
Review URL: https://codereview.chromium.org//690103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00
0219bdb81a
Regularize naming to make BUILD.gn files easier to write.
...
Review URL: https://codereview.chromium.org//703693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41510 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 22:03:57 +00:00
84baa3028d
Update comments about CSP in polymer
...
R=jakemac@google.com
Review URL: https://codereview.chromium.org//704513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41504 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 20:33:12 +00:00
df62a0d75d
Warn when implicit default value overrides explicit one that differs.
...
BUG=dartbug.com/18914
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//700923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41503 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 20:32:18 +00:00
e18464b912
Always check if instance method name collides with superclass static.
...
Previously we only did this check if nothing was overridden.
Persumably that was intended as a speed optimization, since at first
glance it would seem that if the instance method overrides something,
then it can't possibly conflict with a static method in the
superclass. However, that optimization doesn't work if the method
being overridden is in an interface (in that case the superclass can
still have a static method with the same name). So just go ahead and
check in all cases.
BUG=dartbug.com/18947
R=scheglov@google.com
Review URL: https://codereview.chromium.org//698973005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41501 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 19:31:31 +00:00
7f4d5bb1fb
Issue 21506. Fix for adding back previously excluded resources in sub-folders.
...
The server's part of the issue.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21506
Review URL: https://codereview.chromium.org//692073004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41500 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 18:47:14 +00:00
7688ecbd3f
Track initializers already seen ( fixes #21439 )
...
R=jakemac@google.com
Review URL: https://codereview.chromium.org//700733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41499 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 18:33:37 +00:00
b38805416c
Update status for Android content_shell on co19 DOM tests.
...
TBR=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//699883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41497 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 16:51:58 +00:00
64afcee75b
Update status of checked Dartium co19 DOM tests.
...
TBR=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//702723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41496 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 16:28:29 +00:00
24fac6c7e5
Flush analysis server output stream when closed.
...
This ensures that if the analysis server terminated with an exception,
the stacktrace will actually be written to stdout before the server
exits.
BUG=dartbug.com/21494
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//694413004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41495 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 16:11:55 +00:00
b721523807
Update dartium status for flaky test.
...
BUG=
Review URL: https://codereview.chromium.org//699163003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41494 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 15:39:12 +00:00
32ab9a4ea4
Fix analyzer warning in analyzer2dart.
...
BUG=
Review URL: https://codereview.chromium.org//695563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41493 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 15:03:33 +00:00
49acd886b9
Improve handling of intentionally broken links in test scripts.
...
BUG=
Review URL: https://codereview.chromium.org//702673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41492 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 15:00:00 +00:00
dadff8c117
Support for-in in analyzer2dart.
...
BUG=
R=paulberry@google.com , sigurdm@google.com
Review URL: https://codereview.chromium.org//702453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41491 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 14:53:18 +00:00
0928369fc9
Improve browser testing scripts to better handle tests that reload themselves.
...
BUG=dartbug.com/18558
R=ricow@google.com
Review URL: https://codereview.chromium.org//702543006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41490 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 14:46:45 +00:00
ae271bf236
Split the largest classes from resolver.dart to their own files.
...
This should make resolver.dart small enough to support side-by-side
diffs in the code review tool.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//700753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41489 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 14:04:36 +00:00
d82d6f7782
Dart2js is slow when compiled in checked mode.
...
Review URL: https://codereview.chromium.org//698283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41488 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 13:58:20 +00:00
ddda60fc15
Firefox not only slow on Windows.
...
Review URL: https://codereview.chromium.org//700863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41487 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 13:53:43 +00:00
fd67614e9a
Add test for docgen of source with async/await.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//687723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41486 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 13:45:39 +00:00
36c8c68868
Support async/await in the dart2js frontend.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//675113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41485 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 12:21:40 +00:00
446c4a79fc
Update status for Firefox on Windows.
...
Review URL: https://codereview.chromium.org//703613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41484 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 12:01:17 +00:00
4beb7fda42
Fix typo in json.dart
...
Review URL: https://codereview.chromium.org//702653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41483 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 11:41:09 +00:00
fb3cf87b6d
Handle instance methods.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//657883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41482 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 11:39:33 +00:00
54dea3276c
Make incremental tests time out faster.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//667763005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41481 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 10:55:12 +00:00
d80fd3f758
Fix a bug in the handling of Phi nodes.
...
BUG= http://dartbug.com/21351
R=karlklose@google.com
Review URL: https://codereview.chromium.org//701793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41480 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 10:26:22 +00:00
e3d4226c63
Make JSON.fuse(UTF8) be more efficient by not creating intermediate string.
...
Adds JsonUtf8Encoder class that can be used directly, or through jsonEncoder.fuse(utf8Encoder) or jsonEncoder.startChunkedConversion(_Utf8EncoderSink).
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//689043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41479 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 10:25:41 +00:00
e5fcd1fd91
Properly restore context when leaving visitor functions in ErrorVerifier.
...
BUG=dartbug.com/15565
R=scheglov@google.com
Review URL: https://codereview.chromium.org//702623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41478 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 04:17:06 +00:00
18b71fa42a
Fix type analysis of the keyword "dynamic".
...
The type of "dynamic" isn't "dynamic", it's "Type".
BUG=dartbug.com/18731
R=scheglov@google.com
Review URL: https://codereview.chromium.org//680423003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41477 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 04:13:06 +00:00
d578d3767e
Support globs in $include and $exclude.
...
R=rnystrom@google.com
BUG=17093
Review URL: https://codereview.chromium.org//686363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41476 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 01:55:28 +00:00
31c3f90301
Properly implement identical() test in analyzer constant evaluation.
...
Previously we were treating identical(x, y) as equivalent to (x == y).
However the semantics aren't the same.
BUG=dartbug.com/21177
R=scheglov@google.com
Review URL: https://codereview.chromium.org//689173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41475 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 01:32:33 +00:00
5c55e61647
Resubmit fix for Function::Clone() and Field::Clone() to adjust the class owner
...
of type parameters (issue 18630).
Make sure to clone the parameter type array as well.
Add regression tests.
R=iposva@google.com
Review URL: https://codereview.chromium.org//693693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41474 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 23:16:33 +00:00
cd068eb106
Convert analysis starting point to an absolute path before analyzing.
...
This ensures that if the analysis starting point is part of an import
loop, then once the analysis engine reaches the starting point again,
it will recognize that it's the same file.
BUG=dartbug.com/21440
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//688593005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41473 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 22:42:52 +00:00
1c6ddd0751
Issue 21498. Fix for navigation from instance creation with type arguments.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498
Review URL: https://codereview.chromium.org//694383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41468 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:45:34 +00:00
75a0128a52
Add a QueueList class to the collection package.
...
This class is based on the ListQueue implementation and implements both the
Queue and List interfaces.
R=lrn@google.com
Review URL: https://codereview.chromium.org//660373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41467 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:39:26 +00:00
1d69da9c39
Issue 21496. Fix for inlining negate/decrement into negate.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496
Review URL: https://codereview.chromium.org//695383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:29:57 +00:00
15743f701e
Support for inlining methods when some arguments are missing.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//694373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 18:35:58 +00:00
d55ac5e968
Disable integration test reanalyze_concurrent_test on debug buildbots.
...
It is timing out.
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//701563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41463 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 18:16:42 +00:00
b094516396
Fix early erasure of resolution data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//696343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41462 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 17:29:46 +00:00
9b35b056a7
Fix deprecation warnings in analyzer and analysis server.
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//685133003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41461 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 17:10:08 +00:00
35c6e351da
Fix access semantics for foreach loops.
...
In a statement like:
for (x in ...) { ... }
"x" needs to be considered to be in setter context, not getter
context.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//702473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41460 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 16:47:28 +00:00
08713a5230
Add debugging for issues 21013 and 21014
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//696293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41459 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 16:37:01 +00:00
687c90faa5
Depend on sdk/lib and runtime dart files through the dart vm implicitly
...
This long list of inputs is causing issues for xcode
R=ahe@google.com
Review URL: https://codereview.chromium.org//694323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41458 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 15:26:26 +00:00
8240d9a4cf
Only lower-case ContentType's values if the name is 'charset'.
...
BUG=https://code.google.com/p/dart/issues/detail?id=21385
R=lrn@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//694293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41456 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 12:34:08 +00:00
94a510176b
Copy irregexp related code from V8.
...
This "syntactic" change copies the irregexp code from V8 r24065 to Dart.
Compared to the V8 files the only changes are that the files have been
suitably renamed, headers and footers have been updated, and most of the
unneeded code has been replaced by a 'SNIP' marker. None of the files
are added to the build and they cannot compile. Integration with the
Dart VM is done in a follow-up CL [1].
[1]: https://codereview.chromium.org/683433003/
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//678193004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41455 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 10:00:31 +00:00
47532a7ba5
Tweak test for the new resolved/parsed AST management and restore it.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//695923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41454 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-01 05:28:46 +00:00
30dce6a5d1
Fix issue 21474 in mirrors.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//690413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41453 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 23:16:11 +00:00
4d70e2f8a4
Optimize LineInfo.getLocation().
...
Three simple optimizations:
1. Do a binary search through _lineStarts to find the line instead of linear.
2. Store the last result and see if the offset starts there or later. If so, skip leading lines when searching.
3. See if the current offset is on the same line as the last result and exit early if so.
On my benchmark test for the formatter, this reduced it from 13.23ms to 7.57ms.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//692093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41452 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 21:49:10 +00:00
da1b1e947a
Remove unnecessary cast in Quick Assist.
...
Sorry, missed it in the previous CL.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//696003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41451 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:44:44 +00:00
90b785c88c
Fix for an error in the error handler.
...
We pass exception as String message.
We would have caught it if we had run the server in the checked mode.
Instead it failed at the JSON serialization stage.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//698563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41450 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:43:28 +00:00
johnniwinther@google.com