8637cfd322
Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
...
This reverts commit r41512.
BUG=
Review URL: https://codereview.chromium.org//693183006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
2b336e17f0
Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
...
BUG=
Review URL: https://codereview.chromium.org//690103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00
84baa3028d
Update comments about CSP in polymer
...
R=jakemac@google.com
Review URL: https://codereview.chromium.org//704513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41504 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 20:33:12 +00:00
df62a0d75d
Warn when implicit default value overrides explicit one that differs.
...
BUG=dartbug.com/18914
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//700923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41503 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 20:32:18 +00:00
e18464b912
Always check if instance method name collides with superclass static.
...
Previously we only did this check if nothing was overridden.
Persumably that was intended as a speed optimization, since at first
glance it would seem that if the instance method overrides something,
then it can't possibly conflict with a static method in the
superclass. However, that optimization doesn't work if the method
being overridden is in an interface (in that case the superclass can
still have a static method with the same name). So just go ahead and
check in all cases.
BUG=dartbug.com/18947
R=scheglov@google.com
Review URL: https://codereview.chromium.org//698973005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41501 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 19:31:31 +00:00
7f4d5bb1fb
Issue 21506. Fix for adding back previously excluded resources in sub-folders.
...
The server's part of the issue.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21506
Review URL: https://codereview.chromium.org//692073004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41500 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 18:47:14 +00:00
7688ecbd3f
Track initializers already seen ( fixes #21439 )
...
R=jakemac@google.com
Review URL: https://codereview.chromium.org//700733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41499 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 18:33:37 +00:00
24fac6c7e5
Flush analysis server output stream when closed.
...
This ensures that if the analysis server terminated with an exception,
the stacktrace will actually be written to stdout before the server
exits.
BUG=dartbug.com/21494
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//694413004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41495 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 16:11:55 +00:00
32ab9a4ea4
Fix analyzer warning in analyzer2dart.
...
BUG=
Review URL: https://codereview.chromium.org//695563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41493 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 15:03:33 +00:00
dadff8c117
Support for-in in analyzer2dart.
...
BUG=
R=paulberry@google.com , sigurdm@google.com
Review URL: https://codereview.chromium.org//702453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41491 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 14:53:18 +00:00
ae271bf236
Split the largest classes from resolver.dart to their own files.
...
This should make resolver.dart small enough to support side-by-side
diffs in the code review tool.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//700753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41489 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 14:04:36 +00:00
fd67614e9a
Add test for docgen of source with async/await.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//687723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41486 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 13:45:39 +00:00
fb3cf87b6d
Handle instance methods.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//657883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41482 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 11:39:33 +00:00
e5fcd1fd91
Properly restore context when leaving visitor functions in ErrorVerifier.
...
BUG=dartbug.com/15565
R=scheglov@google.com
Review URL: https://codereview.chromium.org//702623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41478 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 04:17:06 +00:00
18b71fa42a
Fix type analysis of the keyword "dynamic".
...
The type of "dynamic" isn't "dynamic", it's "Type".
BUG=dartbug.com/18731
R=scheglov@google.com
Review URL: https://codereview.chromium.org//680423003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41477 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 04:13:06 +00:00
31c3f90301
Properly implement identical() test in analyzer constant evaluation.
...
Previously we were treating identical(x, y) as equivalent to (x == y).
However the semantics aren't the same.
BUG=dartbug.com/21177
R=scheglov@google.com
Review URL: https://codereview.chromium.org//689173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41475 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 01:32:33 +00:00
cd068eb106
Convert analysis starting point to an absolute path before analyzing.
...
This ensures that if the analysis starting point is part of an import
loop, then once the analysis engine reaches the starting point again,
it will recognize that it's the same file.
BUG=dartbug.com/21440
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//688593005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41473 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 22:42:52 +00:00
1c6ddd0751
Issue 21498. Fix for navigation from instance creation with type arguments.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498
Review URL: https://codereview.chromium.org//694383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41468 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:45:34 +00:00
75a0128a52
Add a QueueList class to the collection package.
...
This class is based on the ListQueue implementation and implements both the
Queue and List interfaces.
R=lrn@google.com
Review URL: https://codereview.chromium.org//660373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41467 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:39:26 +00:00
1d69da9c39
Issue 21496. Fix for inlining negate/decrement into negate.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496
Review URL: https://codereview.chromium.org//695383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:29:57 +00:00
15743f701e
Support for inlining methods when some arguments are missing.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//694373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 18:35:58 +00:00
d55ac5e968
Disable integration test reanalyze_concurrent_test on debug buildbots.
...
It is timing out.
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//701563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41463 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 18:16:42 +00:00
b094516396
Fix early erasure of resolution data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//696343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41462 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 17:29:46 +00:00
9b35b056a7
Fix deprecation warnings in analyzer and analysis server.
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//685133003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41461 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 17:10:08 +00:00
35c6e351da
Fix access semantics for foreach loops.
...
In a statement like:
for (x in ...) { ... }
"x" needs to be considered to be in setter context, not getter
context.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//702473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41460 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 16:47:28 +00:00
08713a5230
Add debugging for issues 21013 and 21014
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//696293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41459 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 16:37:01 +00:00
47532a7ba5
Tweak test for the new resolved/parsed AST management and restore it.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//695923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41454 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-01 05:28:46 +00:00
4d70e2f8a4
Optimize LineInfo.getLocation().
...
Three simple optimizations:
1. Do a binary search through _lineStarts to find the line instead of linear.
2. Store the last result and see if the offset starts there or later. If so, skip leading lines when searching.
3. See if the current offset is on the same line as the last result and exit early if so.
On my benchmark test for the formatter, this reduced it from 13.23ms to 7.57ms.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//692093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41452 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 21:49:10 +00:00
da1b1e947a
Remove unnecessary cast in Quick Assist.
...
Sorry, missed it in the previous CL.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//696003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41451 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:44:44 +00:00
90b785c88c
Fix for an error in the error handler.
...
We pass exception as String message.
We would have caught it if we had run the server in the checked mode.
Instead it failed at the JSON serialization stage.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//698563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41450 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:43:28 +00:00
2805871f91
Remove "-dev" to publish args package.
...
R=nweiz@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//698463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41448 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 20:29:04 +00:00
8bd5c75f0c
Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//690353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41446 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 19:22:22 +00:00
b7c685bbe2
Support for 'Add Type Annotation' when selection if right after ';'.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//693193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41445 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 19:09:03 +00:00
e9696e5f67
Clean up logging uses
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//685993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41443 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 19:05:19 +00:00
58b915ffea
move import combinator suggestions into a separate computer
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//695773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41442 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 18:31:18 +00:00
20c13d4715
Fix logging API. This should fix the exception I'm seeing. I'll clean up uses of the deprecated API in a separate CL.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//694833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41439 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 16:22:50 +00:00
e19de8c272
Support is/as expressions in analyzer2dart.
...
BUG=
R=paulberry@google.com , sigurdm@google.com
Review URL: https://codereview.chromium.org//693153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41438 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 14:16:22 +00:00
517ed0cd54
Use a constant instead of int.parse("0x10ffff")
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//651513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41431 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-31 01:29:06 +00:00
fb7f7a8823
Update template_binding test that was still using the deprecated mutation_observer polyfill
...
Review URL: https://codereview.chromium.org//690163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41430 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 23:22:47 +00:00
83cb5a410a
Remove deprecated packages from the repo
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//695603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41429 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 22:57:29 +00:00
9dad99f92c
Disable a test until I can fix it
...
Review URL: https://codereview.chromium.org//655353005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41428 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:47:58 +00:00
3d13808d7d
Status page improvements: sort context names, right align numbers, add missing data descriptors.
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//685123006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41427 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:11:40 +00:00
678f9e2a3e
Fix issue 21379
...
R=danrubel@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//683673004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41426 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:07:50 +00:00
d22c027e0a
add suggestions in format parameter list
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//693573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41420 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:13:57 +00:00
010f33956f
cleanup warnings/hints
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//685363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41419 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:12:30 +00:00
2db6b324e1
Update Safari status files.
...
BUG=dartbug.com/21434
Review URL: https://codereview.chromium.org//687353006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41415 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 10:17:19 +00:00
b7aeaab3f7
make deprecated elements have low suggestion relevance
...
BUG=dartbug.com/19615
R=scheglov@google.com
Review URL: https://codereview.chromium.org//690793004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41414 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 01:08:32 +00:00
97bc20ffc5
Suggest names for PropertyAccess.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//646103006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41409 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 22:07:27 +00:00
40ad9b8eeb
Improve cache entry tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//686293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41408 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 21:56:56 +00:00
e96b29143c
Rename ForEachStatement.iterator -> iterable.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//689793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41405 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 21:33:04 +00:00
johnniwinther@google.com