1c1497ff98
Another tweak for displaying performance.
...
1. It is still interesting to see performance tags, even with the next task model.
2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1161183004
2015-06-05 09:19:28 -07:00
c1e2448928
Tweak for the new task statistics formatting.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1147043006
2015-06-04 11:49:37 -07:00
aec339a767
Expose timing data for the new task model in the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1169573003
2015-06-04 10:47:04 -07:00
ac3613e2bb
Re-apply change to move to plugin package
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1094083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 18:54:24 +00:00
3d536efcfe
Revert breaking change
...
Review URL: https://codereview.chromium.org//1101213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:12:20 +00:00
24c853446a
Convert analyzer and analysis_server to use the plugin package
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1063153004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45382 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:32:35 +00:00
4af80fc1e7
Add an analysis server option to enable null-aware-operator support.
...
The option may be enabled in editor by setting the tracing option
"experimental/nullAwareOperators" (in com.google.dart.tools.core) to
true.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1063613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44909 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 14:53:00 +00:00
6150881e01
Add plugin info to the status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1020813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44620 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 23:23:13 +00:00
29c0fb7cd6
Add an analyzer option to properly check ".call" methods.
...
Enabling this option fixes issue 21938. For now the option is
disabled by default, since there is a lot of code in the dart SDK (and
in third_party) that isn't warning clean with this option enabled.
Once the SDK and third_party code have been cleaned up, we should be
able to turn this option on permanently.
BUG=dartbug.com/21938
R=scheglov@google.com
Review URL: https://codereview.chromium.org//994253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44390 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 00:35:31 +00:00
fafa5d79c7
Convert content cache to use file paths
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//983183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44300 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 19:22:44 +00:00
9004e91fec
No errors in third-party packages (issue 22170)
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//983733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44270 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-05 20:17:24 +00:00
cd58e290c4
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//969113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
a2fa6b10ec
Improve displaying overlays.
...
1. Use path as argument instead of id.
2. Show every file in the global ContentCache just once.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43994 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 19:55:01 +00:00
e267b86440
Improve performance tags display - percent and sorting.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//953933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43992 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 17:53:08 +00:00
55a3255070
Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.
...
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//923103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:01:45 +00:00
056909e4a7
Rework analysis server performance measurement code.
...
This change has the following advantages:
- We now keep track of the amount of time spent doing unknown
activities using its own timer.
- Several pieces of analysis server functionality are now tracked
(previously we only tracked time spent inside the "analyzer"
package).
- The set of all performance timers is tracked in PerformanceTag.all
so that new timers can be added without having to update the code
that prints out timing measurements.
- Performance measurement code has been integrated with Observatory
"user tags", so that the same categories measured by the analysis
server also show up in the VM profiler view.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//918383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43745 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 23:54:49 +00:00
0efb52aa0f
More complete state transition data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//916973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43700 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 22:04:51 +00:00
52af26ea3d
Minimal initial performance reporting
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//913853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43672 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 23:09:40 +00:00
937c4be45d
Add index search support to AST and element model pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//910293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43665 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 20:11:27 +00:00
d04ad125fc
Add link to performance data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43410 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:28:11 +00:00
98e926db9a
Support for inspecting index.
...
Page http://127.0.0.1:2040/index/element-by-name?name=sendAnalysisNotificationHighlights
shows all relations with elements named 'sendAnalysisNotificationHighlights'.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//894853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43377 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 03:11:09 +00:00
cd996f37bf
Improve error reporting on status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//899513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43374 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:34:29 +00:00
03874e1c60
record and display request latency
...
and update unknown page handler
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//894823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43359 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 19:44:51 +00:00
675b99110c
fix race condition when recording computeCache performance
...
and improve completion performance status page
BUG=dartbug.com/22205
R=paulberry@google.com
Review URL: https://codereview.chromium.org//889583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43299 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 17:00:57 +00:00
4f5494c2ac
Clean up and add analyzing contexts
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//875663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43170 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 03:40:39 +00:00
ef257710e1
add periodic delay in analysis to reduce request processing latency
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//874083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43127 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 02:10:38 +00:00
f99f4f3212
improve measurement of completion performance
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//861153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43051 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 19:33:43 +00:00
14d008359d
Use UTF-8 when serving web pages for analysis server debug.
...
This avoids the need to encode unicode characters using hexadecimal
escape sequences.
(Note that setting the charset using response.headers.contentType
affects the encoding used by both client and server.)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//855643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43045 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 17:57:57 +00:00
0b975704b5
Alternate status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//840953008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43020 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:46:44 +00:00
3eb4d4f9a2
Include overlays contents.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//854703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42943 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 04:50:36 +00:00
a737481621
improve completion performance status page
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//813563007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42941 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 00:33:20 +00:00
dc96eabde3
Display overlays at /overlays URI.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//823123004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42891 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 00:22:44 +00:00
81b8596681
Add indication of instrumentation active/inactive to analysis server status.
...
The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//847963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42879 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:23:22 +00:00
b09752d035
enhance code completion tracking and measurement
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//796913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42340 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:27:07 +00:00
c5a938fde2
Allow the contents of the analysis cache to be inspected via http debugging.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//759083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41975 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 00:51:55 +00:00
b8da9bc651
Format and sort analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//725143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
f60be24eb8
add code completion cache
...
- generic mechanism for use in a subsequent CL
- minor get_handler import cleanup
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//729193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41778 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 15:13:38 +00:00
7e7f3ce68c
display completion performance in new server status page
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//691853006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41612 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-07 18:10:51 +00:00
3d13808d7d
Status page improvements: sort context names, right align numbers, add missing data descriptors.
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//685123006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41427 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:11:40 +00:00
03b3d16691
Make table entries on analysis server's '/status' page clickable.
...
Clicking on a table entry now takes you to a list of files in the
given state.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//685863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41400 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 20:05:16 +00:00
3e361ba46b
Allow print() to be used for debugging analysis server.
...
We now run analysis server inside a zone so that all print() calls it
executes can be captured to a buffer (rather than being sent to
standard output, where they will confuse the client). When the server
is run in HTTP server mode, the print buffer is displayed on the
status page.
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//686763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41380 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 23:29:27 +00:00
4745b7f24a
Add a debug option to analysis server to specify HTTP port.
...
When a port is specified, user may navigate to localhost:$port/status
to see the status of analysis.
Intended for internal debugging of analysis server only.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//679113006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41349 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:34:24 +00:00
ae59c7e055
Clean ups for warnings and unused code.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//314173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37039 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 17:52:20 +00:00
e7e559942c
add server.status notification
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//298823007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36727 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 02:25:20 +00:00
764c6b112c
Partial implementation of the 'setAnalysisRoots' API.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//300023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36702 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 19:01:14 +00:00
fbae744eaa
Fix warnings in get_handler.dart
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//297123003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36596 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 22:59:33 +00:00
a1a3ae4eeb
Fix a typo in the analysis server's status page
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//243383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35186 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 22:26:49 +00:00
33c7e78bb0
Split analysis server's HttpAnalysisServer into two classes.
...
Behaviours of the HttpAnalysisServer which are independent of the
WebSocket transport mechanism have been moved to a new class,
SocketServer, which will also be used when the transport mechanism is
stdio.
GetHander now holds a reference to the SocketServer rather than the
AnalysisServer, so that we don't need to go to extra effort to update
it when the AnalysisServer is created.
R=brianwilkerson@google.com , jwren@google.com
Review URL: https://codereview.chromium.org//237643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35061 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 15:41:09 +00:00
7e7426ae99
Clean-up and progress on analysis server
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//214933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34529 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 21:26:03 +00:00
238ca64ce9
Server code clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//139983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32466 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-08 15:25:37 +00:00
Konstantin Shcheglov