787e9fcf7f
Reanalyze after creating a referenced part.
...
We need to finish linking CompilationUnitElement(s) to LibraryElement(s)
even for not existing sources. Otherwise we get NPE later and leave
model in the ERROR state.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1168743002
2015-06-05 11:29:04 -07:00
e8fe98ecb6
Update status file to work around bug #23595
...
BUG=dartbug.com/23595
TBR=pquitslund@google.com
Review URL: https://codereview.chromium.org//1170593003
2015-06-05 09:33:14 -07:00
ba4523df1a
Add correct test for issue 23523
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1166503004
2015-06-05 09:20:54 -07:00
1c1497ff98
Another tweak for displaying performance.
...
1. It is still interesting to see performance tags, even with the next task model.
2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1161183004
2015-06-05 09:19:28 -07:00
3fd32d4d05
Pull in latest analyzer_cli.
...
The latest update to analyzer_cli makes it analyze all files using a
single context, so it can re-use analysis results; this makes it much
faster when analyzing large projects (~13x faster at analyzing pub,
for example).
On a temporary basis, this CL pulls in analyzer_cli using a git SHA
rather than a tag, since the new analyzer_cli features don't have a
release tag yet. Once they have been validated on the buildbots, I'll
assign a release tag and update DEPS to point to it.
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//1170543003
2015-06-05 09:07:15 -07:00
9326f9d79a
update one-line docs for svg, gl, audio
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//1163163004
2015-06-04 16:39:02 -07:00
ac4bc7c0e7
Merge pull request #23590 from dart-lang/sethladd-patch-3
...
one-line description for web audio
2015-06-04 16:23:38 -07:00
7a0e422980
Merge pull request #23592 from dart-lang/sethladd-patch-5
...
one-line description for SVG
2015-06-04 16:22:01 -07:00
79c7ff9fc2
Merge pull request #23591 from dart-lang/sethladd-patch-4
...
one-line description for web gl
2015-06-04 16:21:01 -07:00
2b6904a1c8
one-line description for SVG
2015-06-04 16:15:51 -07:00
fab343f7f6
one-line description for web gl
2015-06-04 16:15:10 -07:00
5def75c172
one-line description for web audio
2015-06-04 16:13:48 -07:00
fcd407b0cf
Revert "Support Package Resolution Configuration files."
...
This reverts commit 36c29d05bchttps://codereview.chromium.org//1165943005
2015-06-04 15:55:13 -07:00
36c29d05bc
Support Package Resolution Configuration files.
...
BUG=http://dartbug.com/23371
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1162363004
2015-06-04 15:15:09 -07:00
4224b9c049
fix ENUM_CONSTANT suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1157283004
2015-06-04 18:01:06 -04:00
d6580fd9fb
generated analysis server java client code package rename
...
This changes the generated package name to better reflect our new home
from com.google.dart.server.generated.types
to org.dartlang.analysis.server.protocol
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1164683003
2015-06-04 17:29:35 -04:00
3cbd3e2e96
Tweak ADD_PART_OF quick fix to support both new/old task models.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1165943003
2015-06-04 14:28:35 -07:00
2ccb9224e4
Merge pull request #23584 from dart-lang/turnidge-protocol-patch
...
@Int no longer exists
2015-06-04 14:10:24 -07:00
676fcddbff
@Int no longer exists
2015-06-04 14:07:03 -07:00
32f4b9aca5
Only units with 'part of' and no other directives are parts.
...
Invalidate CONTAINING_LIBRARIES as needed.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1160873004
2015-06-04 14:03:07 -07:00
bacea55d88
Merge pull request #23582 from dart-lang/sethladd-patch-1
...
Tweak to markdown for link in service protocol spec
2015-06-04 14:00:24 -07:00
5d2cbd5d55
Added test for issue 23523
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1166653006
2015-06-04 13:34:13 -07:00
8e3bc82c85
Tweak to markdown for link in service protocol spec
2015-06-04 12:47:09 -07:00
56be513cf9
Add isExternal accessor to element model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1158793004
2015-06-04 12:38:31 -07:00
6545e8539e
Fix isAssignableTo in VM mirrors to use subtype (<:) rather than moreSpecificThan (<<).
...
BUG=http://dartbug.com/22852
R=gbracha@google.com
Review URL: https://codereview.chromium.org//1156583005
2015-06-04 12:25:59 -07:00
c1e2448928
Tweak for the new task statistics formatting.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1147043006
2015-06-04 11:49:37 -07:00
a24d84ecd9
Ensure types are resolved for combined import/export closures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1166983005
2015-06-04 11:48:56 -07:00
4b082cb871
cleanup local reference contributor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1163973004
2015-06-04 14:18:03 -04:00
aec339a767
Expose timing data for the new task model in the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1169573003
2015-06-04 10:47:04 -07:00
a9632f3bab
Fix for DeclarationResolver.
...
It's not the main problem we observe during pkg/analysis_server/test/operation/operation_test, but I still saw it.
The actual fix is removing "unary-".
The other change is just for performance.
It is much cheaper to compare int(s) than to compute (for methods) 'displayName'.
Maybe we should go as far as removing the name check altogether and use just element kind.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1149083007
2015-06-04 10:41:19 -07:00
d5dc5ccc56
Add feedback link.
...
BUG=
R=sethladd@google.com
Review URL: https://codereview.chromium.org//1159983007
2015-06-04 10:19:40 -07:00
996f012707
2nd attempt at adding streamListen/streamCancel to the service protocol.
...
This time I am committing the protocol changes first and saving the
Observatory changes for a second cl.
------
We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph.
Only generate events when at least one client is listening to the
corresponding event stream.
Only send events to the clients that actually request them.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1166433008
2015-06-04 09:57:22 -07:00
1b59b9ea06
Service cleanups...
...
- Allow for multiple breakpoints in the service protocol.
The info isn't actually provided or used yet.
- Drop index for list elements returned by the protocol. Flatten structure.
- Drop index for context elements. Keep sub-structure so we
can choose to add extra slot info later.
- Errors now have ids and kinds.
- exception and stacktrace move from @Error to Error.
- All heap Objects now include class/size.
- Changed BoundedType.type and TypeRef.type to different names.
Turns out we already have a "type" property that conflicts.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1152753005
2015-06-04 09:09:22 -07:00
ab5371e9b7
analysis server performance measurement driver first cut
...
* reads instrumentation file (log file support later)
* tracks initial analysis elapse time
* skeleton structure for adding more operations and tracking
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1163713005
2015-06-04 10:11:59 -04:00
de68aaa595
Clean up JSON parsing code.
...
Fixes some hard-to-find bugs and warnings.
Improves the layout of all the constants.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//1150033013
2015-06-04 14:55:32 +02:00
6d4aea874d
Don't fail taskkill on chrome processes alive
...
It happens quite often that the browser controller fails to kill chrome on the package waterfall.
R=eernst@google.com
BUG=
Review URL: https://codereview.chromium.org//1150543004
2015-06-04 12:43:33 +02:00
0e1673ead0
cps_ir: Clean up BuilderTask.
...
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1149423009
2015-06-04 09:07:03 +02:00
22976789b5
Mark new test as failing on dart2js-cps_ir.
...
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1163943006
2015-06-04 09:06:05 +02:00
b666398745
Fix fix (again)
...
BUG=
Review URL: https://codereview.chromium.org//1153413006
2015-06-03 17:13:27 -07:00
1c18123cea
Fix analyzer run on bot
...
BUG=
Review URL: https://codereview.chromium.org//1162023007
2015-06-03 16:52:20 -07:00
5649434e4f
Disable a test
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//1160063004
2015-06-03 16:31:08 -07:00
a5669190ab
Fixed breakpoint handling at return statement with inlined finally clauses.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1170483002
2015-06-03 15:25:42 -07:00
2c5e890fc7
Build fixes.
...
Long tail of fixes related to moving out of `pkg_tested`.
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1162423002
2015-06-03 14:03:15 -07:00
e13679d393
Fix the profiler.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1152553010
2015-06-03 14:02:07 -07:00
fcc694c629
Move analyzer_cli out of pkg_tested.
...
Net-net: we used `mockito` for testing and that's not in `third_party`. Until it is (or we remove the need for it), we need to get out of `pkg_tested`.
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1159073004
2015-06-03 13:46:35 -07:00
7b04897743
Fix fix
...
BUG=
Review URL: https://codereview.chromium.org//1166523005
2015-06-03 12:39:59 -07:00
12da412110
Fix build
...
BUG=
Review URL: https://codereview.chromium.org//1160623004
2015-06-03 11:22:46 -07:00
c0824e7725
Fix 23563: double unary- operator unstable for NANs
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//1160453003
2015-06-03 11:00:28 -07:00
0805625757
analyzer_cli and linter DEP bumps.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//1160503005
2015-06-03 10:47:32 -07:00
4bf6db0c25
Adjust context level when required before executing inlined finally clauses.
...
Add regression test.
BUG=23537
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1154823003
2015-06-03 10:31:48 -07:00
Konstantin Shcheglov