e4c8b49dcc
Format benchmarks/.
...
Change-Id: I1362ada67a02b0ed352612fc29c727e94d8cd254
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394901
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2024-11-18 10:06:01 +00:00
933537b66b
Trivial cleanup to make VSCode workspace for the SDK
...
free of diagnostics as long as you filter with "!TODO"
R=athom@google.com , jensj@google.com , natebiggs@google.com
Change-Id: I73cf3c5ef6dab81808330c4eb5f44cb62e753c81
Tested: manually verified that VSCode is warning free. No changes in functionality.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333903
Auto-Submit: Jacob Richman <jacobr@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Jacob Richman <jacobr@google.com >
2023-11-07 17:49:53 +00:00
4c20cedd30
Fix analysis issues in benchmarks/ directory
...
Now that I'm able to open the entire SDK in VSC, I'm fixing some
of the analysis issues in various files (carefully) without changing
their meaning.
In this case, I removed unnecessary imports from benchmarks.
In regexp_benchmark I ignored one warning which likely would
have changed the behavior of the code.
BUG=https://github.com/dart-lang/sdk/issues/52419
Change-Id: I9a195a4e45121313bd9f065f2579a165c3fec05b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303901
Auto-Submit: Eric Seidel <eric@shorebird.dev >
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2023-05-17 09:14:50 +00:00
6ca7571e2b
[benchmark] Benchmark for switch on various constant types
...
AOT:
SwitchFSM.enum(RunTime): 29.549523327947906 us.
SwitchFSM.int(RunTime): 37.73789702628717 us.
SwitchFSM.class(RunTime): 138.6418530572675 us.
SwitchFSM.string(RunTime): 797.54075 us.
dart2js+V8:
SwitchFSM.enum(RunTime): 31.484299349840917 us.
SwitchFSM.int(RunTime): 26.022895908416366 us.
SwitchFSM.class(RunTime): 91.67433302667894 us.
SwitchFSM.string(RunTime): 92.31338451577098 us.
Both AOT and dart2js are 'good at' switches on enum values.
When compiled with --enable-experiment=records,patterns:
AOT:
SwitchFSM.enum(RunTime): 141.75470079359405 us.
SwitchFSM.int(RunTime): 145.25322604030737 us.
SwitchFSM.class(RunTime): 138.45460840662005 us.
SwitchFSM.string(RunTime): 797.226 us.
dart2js+V8:
SwitchFSM.enum(RunTime): 98.93787283573403 us.
SwitchFSM.int(RunTime): 29.459852700736498 us.
SwitchFSM.class(RunTime): 98.62184338405162 us.
SwitchFSM.string(RunTime): 92.035889371936 us.
There is work to be done to recover the performance.
Change-Id: I1197129cb32615a06a63a05d7ba300b46c68b4d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287246
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2023-03-10 04:21:13 +00:00
Robert Nystrom