6f076f90e1
[benchmark] Cleanup lint violations
...
Fix violations of lints that I expect have no influence on the
performance characteristics of this benchmark:
* annotate_overrides
* directives_ordering
Change-Id: I49f33347aea5cfdcbac5c9195a18427bdb7c667e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433266
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2025-06-09 14:01:29 -07:00
6310de0424
[deps] rev ai, web, webdev
...
Revisions updated by `dart tools/rev_sdk_deps.dart`.
ai (https://github.com/dart-lang/ai/compare/1d9d60c..f2b48c6 ):
f2b48c6 2025-06-09 Nate Bosch Retain compatibility with 3.7 SDKs (dart-lang/ai#163 )
52adf08 2025-06-06 Jacob MacDonald add homepage, repository, and documentation links to the pub result (dart-lang/ai#155 )
fa1c2be 2025-06-06 Nate Bosch Always use the failures-only reporter for testing (dart-lang/ai#160 )
66a152f 2025-06-06 Nate Bosch Instruct clients to prefer MCP (dart-lang/ai#161 )
55ad850 2025-06-05 Jacob MacDonald Add a retroactive changelog (dart-lang/ai#157 )
b08a610 2025-06-05 Jacob MacDonald Update instructions, add cursor install link (dart-lang/ai#159 )
web (https://github.com/dart-lang/web/compare/f1becf0..de6b3e4 ):
de6b3e4 2025-06-06 Srujan Gaddam Add missing copyrights and delete empty files (dart-lang/web#371 )
74a33ba 2025-06-06 Kevin Moore Add in a missing library directive, missing new line (dart-lang/web#370 )
4d24eb5 2025-06-06 nikeokoronkwo [web_generator] Setting up `web_generator` for Dart JS Interop Gen (dart-lang/web#368 )
webdev (https://github.com/dart-lang/webdev/compare/55941b0..661dafd ):
661dafd4 2025-06-08 Srujan Gaddam Defer execution of main until resume for hot restart with DDC library bundle format (dart-lang/webdev#2623 )
01a3b9d7 2025-06-06 Nicholas Shahan Remove skip from chrome proxy service test
Change-Id: If3d4326d0bacf47a4d95520dbd0aac5fb58de439
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433363
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-06-09 11:20:00 -07:00
b0fd6d4a15
[vm] Fix some Google3 ClangTidy warnings.
...
TEST=google3
Change-Id: I23236f32d78920388c0b7d2beb738e7cec965226
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433580
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2025-06-09 11:05:59 -07:00
5a95bd8b2c
Add mcp server instantiation to the list of commands parsed by the VM.
...
TEST=ci
Change-Id: I080dd6f8b1d864d35689701207d282447aaf879f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433560
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2025-06-09 10:51:49 -07:00
4715ebd181
[vm/shared] Update mutator count as entering/exiting mutator thread.
...
Running dart code on mutator thread outside of isolate still should follow limits on number of concurrent mutators in the vm.
Also this fixes inconsistency when entering isolate group as mutator, where original worker was marked as blocked while thread was actually running dart code. That inconsitency showed up as sporadic crash on isolate_group_shared_init_test with increased number of spawned isolates.
TEST=isolate_group_shared_init_test
BUG=https://github.com/dart-lang/sdk/issues/60877
Change-Id: I8917be903bb5517940dad3e5dab143d5ed5fdf79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432900
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2025-06-09 10:34:40 -07:00
c219974ecf
analyzer: Deprecate Diagnostic.errorCode in favor of diagnosticCode
...
Work towards https://github.com/dart-lang/sdk/issues/60635
Change-Id: I2c7d64a81bc214e64fbc3ac95cf1fe2363a6ebd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433242
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2025-06-09 09:22:22 -07:00
0242cc0b98
Roll BoringSSL from a934ee9e1fe4 to 035e720641f3 (18 revisions)
...
https://boringssl.googlesource.com/boringssl.git/+log/a934ee9e1fe4..035e720641f3
2025-06-02 davidben@google.com Don't pass `parent` or `ad` to CRYPTO_EX_free
2025-05-28 agl@chromium.org Address some minor things from the MLDSA mu support.
2025-05-28 guillaumee@google.com Add an external mu variant of the ML-DSA API (65 and 87 variants).
2025-05-27 davidben@google.com Make CRYPTO_EX_DATA opaque
2025-05-27 davidben@google.com Move CRYPTO_refcount_t into internal headers
2025-05-27 davidben@google.com Remove unused bputs hook
2025-05-27 davidben@google.com Make BIO and BIO_METHOD opaque
2025-05-23 davidben@google.com Update defaults for PKCS12_create
2025-05-22 agl@chromium.org Note a couple of typoed struct names that we'll leave alone.
2025-05-22 agl@chromium.org xwing: tweaks and cleanups.
2025-05-22 davidben@google.com Update references to RFC 2898
2025-05-21 andreser@google.com add a test for -fno-strict-aliasing
2025-05-21 davidben@google.com Fix some more IWYU issues
2025-05-20 davidben@google.com Replace OPENSSL_ia32cap env test with a unit test
2025-05-20 davidben@google.com Update googletest
2025-05-19 davidben@google.com Remove empty messages in static_assert
2025-05-19 davidben@google.com Remove P-224 from TLS
2025-05-19 agl@imperialviolet.org Fix OPENSSL_ia32cap parsing.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com ,dart-vm-gardener@grotations.appspotmail.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I681f37bc7332a5f7c76a6b14fc364306e054d1cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432365
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2025-06-09 08:59:54 -07:00
1c3c2d220f
Roll gn from afd24ed11bc5 to e5c4d1881b85
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com ,dart-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in gn: https://bugs.chromium.org/p/gn/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: I4857c405336a40163e740aedb7237bd507537c61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433120
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2025-06-09 08:52:58 -07:00
b0adb4185e
Convert upper snake case fields to lower camel case
...
There are no semantic changes in this CL, just renames.
The one unfortunate rename was from `DEFAULT` to `default_`. It can't be
`default` because that's a built-in identifier. If you have a better
convention to follow here I'm happy to change it.
Change-Id: Idf70621ad577dbea6c1c161aac17e9e200aac2d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433440
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-09 07:35:37 -07:00
bddcddfe6b
analysis_server: use new Diagnostic name over AnalysisError
...
Work towards https://github.com/dart-lang/sdk/issues/60635
Change-Id: I5cc0cc66afd3531271eb8dc337556505cb21c074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-06-06 16:00:25 -07:00
3502a35cf7
Add a context message to not_a_type diagnostics
...
Fixes https://github.com/dart-lang/sdk/issues/55947
Change-Id: I38b838c59d3c2983ac26efda7a5ab20f3d29485e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433362
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-06-06 14:23:32 -07:00
5a17591682
[analysis_server] Dot shorthands: Hover work and tests.
...
Added some extra logic for handling dot shorthands in hovers. They should show the same information in the hover as if we had added the type in front of `.`.
Added a new line "Declared in:" to show the containing class information.
Bug: https://github.com/dart-lang/sdk/issues/59836 , https://github.com/dart-lang/sdk/issues/60864
Change-Id: If159d53b7c4443d8a8311125ceef66c441d39d4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2025-06-06 13:35:19 -07:00
bd2a0e6a5e
[DAS] Fixes keyword/type in auto-completion for pattern matching
...
Fixes: https://github.com/dart-lang/sdk/issues/59854
Change-Id: Ic7a0dee51eb45792520ae49d935510e8669f94ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417222
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-06 13:31:50 -07:00
426227b3ac
[Completion] Fix for adding duplicate suggestions for Keywords 'covariant' and 'this'.
...
Change-Id: I736ad405791638bf8be0eb898e72ccb7983abfb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2025-06-06 12:58:23 -07:00
23ba783c4c
[dart2js] Use null-aware elements
...
Change-Id: I2dc74c57efd355ab4871eb2ad48a97fc817a2940
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433300
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2025-06-06 12:45:17 -07:00
5ccfa844da
[analysis_server] Update bullets on language feature checklist.
...
The bullets on this doc were bugging me because they were confusing which tasks were subtasks of one another. I made them all into checklist bullets (since that's what's most useful for me anyways) and it looks much better.
Change-Id: I593ceb7db5ae39ffda52a2a2e481b1c53a5a7784
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2025-06-06 11:57:10 -07:00
3f2befef35
Revert "[dart2js] Do some load elimination in simplifier"
...
This reverts commit ff583f2e2ehttps://dart-review.googlesource.com/c/sdk/+/432502
> Commit-Queue: Stephen Adams <sra@google.com >
> Reviewed-by: Mayank Patke <fishythefish@google.com >
> Reviewed-by: Nate Biggs <natebiggs@google.com >
Change-Id: I97f06e46b193394df6393296d504965f959bcfa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433340
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2025-06-06 11:32:11 -07:00
0f41778adf
linter: merge most of the impl of discarded and unawaited futures rules
...
Change-Id: I784b383dc14f2f74036a4c70cafee6b9454c22eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-06-06 11:26:41 -07:00
0da11d5464
[flow analysis] Share more code in tests of try/finally ordering.
...
This change introduces some helper functions to avoid duplication
between the enabled/disabled variants of each of the try/finally
ordering tests.
Thanks to Lasse for the suggestion.
Change-Id: I4538d44643fde7954a75bc1b6843fcc805d8afc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432782
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2025-06-06 11:01:42 -07:00
9cdc4a1963
[ddc] Reformat pkg/dev_compiler
...
Something seems wrong with the previous formatting. This change formats
with language version 3.8 again.
Change-Id: I077d635d815fa82ddf1153122ee3082787e1dd73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433301
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2025-06-06 09:14:23 -07:00
201484c398
[co19] Roll co19 to ae9af9df72a7d5998cbbfd910da0f42e329d964f
...
2025-06-06 sgrekhov22@gmail.com Fixes dart-lang/co19#3217 . Ignore warning in string_length_t07.dart (dart-lang/co19#3218 )
2025-06-06 sgrekhov22@gmail.com dart-lang/co19#3180 . Add tests for JSAnyOperatorExtension. Part 1. (dart-lang/co19#3215 )
2025-06-04 sgrekhov22@gmail.com Fixes dart-lang/co19#3210 . Don't expect promotion from `FutureOr<void>` to `Future<void>` or `void` (dart-lang/co19#3211 )
2025-06-03 sgrekhov22@gmail.com Fixes dart-lang/co19#3192 . Add tests for constant expression `String?.length` (dart-lang/co19#3209 )
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: If4f523a44a7efb9ac97dde388c293b1bc8dd1e4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433321
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2025-06-06 08:54:51 -07:00
e208c2c636
[flow analysis] Rework tests of try/finally ordering.
...
This change adds test-only methods `propertyPromotionChainForTesting`
and `variablePromotionChainForTesting` to flow analysis; these are
used by the flow analysis unit tests to query the full promotion chain
of a porperty (or variable, respectively). This allows tests to
observe the effect of try/finally ordering on promotion chains without
having to resort to clever control flow joins.
Thanks to Lasse for the suggestion.
Change-Id: Ida5349ecc93dbd4b3392becd20882be3eb101024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432800
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2025-06-06 08:47:41 -07:00
bbc99947c9
[ddc] Rolling internal dart_library.js into the external module loader.
...
Change-Id: If25fd9ac78d795d16b7edca507df0b806a0ebf39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433262
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2025-06-06 07:20:10 -07:00
15c58a889f
Add static variants of Dart engine library and update samples
...
Fixes https://github.com/dart-lang/sdk/issues/60799
Change-Id: I16a8dd2c854ed6915f14e1b71547879f50f2de0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432920
Reviewed-by: Tess Strickland <sstrickl@google.com >
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com >
2025-06-06 04:00:45 -07:00
fae7752e9e
[DAS] Adds tests for fix priorities and new priority for Create class
...
The related issue asked for a new priority for the `Create class` fix
that would be lower if the undefined name was lowercase, giving the
`Create method` and `Create function` fixes a higher relative priority.
This change also adds a new abstract class to test the relative priority
between fix kinds. It is also used to test agains the merge combinators
fixes.
Fixes: https://github.com/dart-lang/sdk/issues/60523
Change-Id: I938f52a577ecf1b6bb8dd66c94fd45395a011ffa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422321
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-06-05 16:58:40 -07:00
f0ad03cabf
[DAS] Adds fixes for implicit_this_reference_in_initializer
...
Fixes: https://github.com/dart-lang/sdk/issues/60729
Change-Id: Ie2ee6ff84062b749a9a8385a3140f9bc35760df2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429081
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-05 16:17:39 -07:00
4fbb4dc6ee
Fix the field formal parameter to normal parameter assist
...
This disables the assist if the field formal parameter happens to also
be an older style function typed parameter. As written the assist
produces invalid code, and the older style is strongly discouraged so
not supporting it shouldn't impact very many users.
Change-Id: I44a3942b4656265bb1cbbba29e68fff61962b689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433260
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-05 14:30:09 -07:00
ef4e39a6ef
[vm/shared] Ensure exclusive execution of shared field initialization.
...
Add a mutex to guard execution of vm:shared field initialization.
TEST=isolate_group_shared_init_test
BUG=dartbug.com/60699
Change-Id: If544351fc26bfcc7fb9703954efe785989d488bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431742
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2025-06-05 14:12:33 -07:00
903d77cc82
analyzer: Rename ErrorListener classes to DiagnosticListener
...
Work towards https://github.com/dart-lang/sdk/issues/60635
I tried to keep this minimal but still sensible:
* Rename AnalysisErrorListener and all subtypes to use 'Diagnostic'.
* Rename all instantiations of such classes if they previously
contained the word 'error'.
* Rename `RecordingDiagnosticListener.errors` to `.diagnostics`.
* Rename some _testing_ instance members that had the word 'error'
to instead use 'diagnostic'.
Change-Id: I3948e27ba28ac2494092e04f4e1d201a20cc1135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433004
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-06-05 14:05:40 -07:00
73d9a8d08b
[dart2js] Cleanup
...
Rename DummyInterceptorConstantValue to DummyConstantValue. It was
actually used as a dummy *receiver* argument and could be used against
any unused parameter.
Remove unused CompilerOptions argument in SSA as-checks and is-tests.
Pass the checked input explicitly to facilitate testing on other inputs (e.g. to do partial redundancy elimination by pushing the operation into the arms of a phi.)
Change-Id: I4b450bfcf5fc877de731bf83201e3c9248ffcb0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433104
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2025-06-05 13:53:16 -07:00
0ac78fb92f
[io] Fix a bug where the proxy configuration parser did not correctly validate proxy passwords.
...
Closes https://github.com/dart-lang/sdk/pull/60476
GitOrigin-RevId: c2f3b31db38755c7d439daa862e86c528744739c
Change-Id: I498dcfae0b0c9614fc388f102f8d88630e0761ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420381
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Brian Quinlan <bquinlan@google.com >
2025-06-05 13:52:34 -07:00
ff583f2e2e
[dart2js] Do some load elimination in simplifier
...
Doing load elimination of final fields earlier generates more
opportunities for GVN. This helps when the same value is 'boxed' in a
wrapper object and the 'unboxed' multiple times.
Change-Id: Id3a2b392a7563bae7a4cd1f8b2763c5ac1b377b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432502
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
2025-06-05 13:21:13 -07:00
e2d6df2a74
[deps] rev ai, ecosystem, i18n, protobuf, test, tools, webdev
...
Revisions updated by `dart tools/rev_sdk_deps.dart`.
ai (https://github.com/dart-lang/ai/compare/6a71aeb..1d9d60c ):
1d9d60c 2025-06-05 Jacob MacDonald handle relative paths under roots without trailing slashes (dart-lang/ai#152 )
ecosystem (https://github.com/dart-lang/ecosystem/compare/8cebaf0..64aac3a ):
64aac3a 2025-06-03 Daco Harkes [health] Bump dart_apitool (dart-lang/ecosystem#360 )
i18n (https://github.com/dart-lang/i18n/compare/e44af54..43214dd ):
43214dde 2025-06-04 Moritz Upgrade to new native_assets (dart-lang/i18n#964 )
protobuf (https://github.com/dart-lang/protobuf/compare/c69077d..32d53da ):
32d53da 2025-06-05 Devon Carew Refactor the test goldens so they have standard file name extensions (dart-lang/protobuf#1014 )
test (https://github.com/dart-lang/test/compare/e2ddae9..0793a2b ):
0793a2b3 2025-06-05 Agam Agarwal Add isSorted and related matchers (dart-lang/test#2490 )
tools (https://github.com/dart-lang/tools/compare/04c6849..e84cbd9 ):
e84cbd9e 2025-06-04 Christophe Coevoet [source_span] Add a test covering the highlighting of non-contiguous spans (dart-lang/tools#1666 )
700a3c4d 2025-06-04 Liam Appelbe [coverage] Fix remaining ~0.1% flakiness (dart-lang/tools#2102 )
webdev (https://github.com/dart-lang/webdev/compare/64492b2..55941b0 ):
55941b0c 2025-06-05 Kevin Moore [dwds] DRY up MD5/etag logic (dart-lang/webdev#2625 )
ab7c4d68 2025-06-05 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/webdev#2593 )
f149e43f 2025-06-05 Nate Biggs Update e2e_test expectation to look for more consistent message. (dart-lang/webdev#2630 )
80b1686b 2025-06-03 Nicholas Shahan Fix e2e_test to work with current DDC output (dart-lang/webdev#2626 )
Change-Id: I4802d7c4a7e39ba238f2f4ce0748dfa6dba9d8c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2025-06-05 12:58:53 -07:00
edce10b761
Add an assist to convert from a field formal parameter to a normal parameter
...
Fixes https://github.com/dart-lang/sdk/issues/60852
Change-Id: Iffc674e61b4df16e80ca71cfd18e12c548770b54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433220
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-05 12:33:34 -07:00
9d6c5d40d0
[DAS] Fixes "Go to declaration" for undefined new constructor
...
Fixes: https://github.com/dart-lang/sdk/issues/60773
Change-Id: I7ee7cec371fbf0d0f9de1a4fe2b946929ba80d61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2025-06-05 12:08:44 -07:00
45722db629
Add documentation for dot shorthand diagnostics
...
Please let me know if there are other diagnostics that I missed.
Change-Id: I87d29f62bcd1dad519c34212a2aa41d4422f1002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431949
Reviewed-by: Kallen Tu <kallentu@google.com >
Reviewed-by: Amanda Fitch <afitch@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-05 10:58:09 -07:00
9df000075a
[analysis_server] Exclude blocks/switch cases from Inline Values unless execution is within them
...
This prevents inline values showing up alongside code that didn't execute in conditional blocks. It does also mean they don't know up in conditional blocks that _did_ execute one execution has fallen out of them, but I believe this is the best we can do with the current LSP APIs (unless we try to track execution across requests, but that would probably be complete and not entirely reliable).
Fixes https://github.com/Dart-Code/Dart-Code/issues/5454
Change-Id: Ia1cf2437b76844ff0a6aeeb958d769c9523dc5dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433200
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-06-05 10:53:12 -07:00
60d418034a
[ddc] Bump language version to 3.8
...
* Reformat pkg/dev_compiler.
* Re-flow some comments to keep them within 80 characters.
Change-Id: I0849ce113ecf3dce4a2b4405c2b09a17dee4df76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433081
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2025-06-05 10:40:57 -07:00
6697075645
[ddc] Fix spelling typos
...
Change-Id: Iafcf14be1fd3032381b4ced2610230538100ce52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433080
Reviewed-by: Mark Zhou <markzipan@google.com >
2025-06-05 10:40:57 -07:00
e76fcdad1a
analyzer: Remove TODO that is DONE
...
Change-Id: I15a85d31b797d99d68c94b3c0fe433c18d9effbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432905
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2025-06-05 09:43:32 -07:00
b8daa53fef
[analysis_server] Don't rebuild contexts on deletion of an analysis root
...
This is a partial revert of ca9523058ehttps://github.com/dart-lang/sdk/issues/60863
Change-Id: I10289160b341d273e8e409184a1c013c7fb9439d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-06-05 09:24:41 -07:00
26e9c8201a
[dart2js] Don't emit deferred loading logs in part files when flag is disabled.
...
Change-Id: I70a3a3a3c7bd56d8fd994e766f0ab2ab8c1f9ec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432820
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Nate Biggs <natebiggs@google.com >
2025-06-05 09:17:11 -07:00
c9c8929099
[package:vm_service] Add kTimerSignificantlyOverdue field to EventKind
...
I overlooked making this additon earlier. This CL also prepares
`package:vm_service 15.0.2` to be published.
TEST=CI
Change-Id: I4d28d87c027d27c4e532e5608f57b62eaa290e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433082
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2025-06-05 07:34:51 -07:00
e891cac045
[dds/dap] Handle some additional kinds of errors when the VM Service connection shuts down
...
This handles an RPC Error -32000 with text "Service connection disposed" as reported in https://github.com/dart-lang/sdk/issues/60851 . It extracts some of this logic into an extension on RPCError to simplify checking in multiple places.
Unfortunately I can't reproduce the specific conditions that produce this error in a test (it probably requires terminated the VM Service at just the right time during startup or an isolate starting?).
Fixes https://github.com/dart-lang/sdk/issues/60851
Change-Id: Iae945f60290766164d04b91d851fbb8b58f178c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432944
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2025-06-05 07:26:16 -07:00
bf9acedc73
Adds a new helper resolveTestRelativePath for resolving paths relative to the test dir, which works using the package config instead of Platform.script. This allows it to work via dart test as well as the test runner, or when manually invoked.
...
Replaced usages of Platform.script.resolve with this utility.
Change-Id: I904d281934c3eb42516e891f27a8f3dbe714e7f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432740
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2025-06-05 07:23:15 -07:00
495a2bb694
Update to latest DevTools hash
...
Change-Id: I3ecb7e661b606907186c0a81b16eecefe4d63a4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432803
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com >
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com >
2025-06-05 04:13:34 -07:00
b2beba242d
analyzer: Convert callers of InheritanceManager3 to use InterfaceElement API
...
This includes all callers in analysis_server and analyzer_plugin. And
callers of `getOverridden4`.
Change-Id: Ia744f6c7260b445c6b1e02d3cf5515aaa9c7feeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432962
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-06-04 16:30:22 -07:00
c4c3a72bd4
analyzer: Move error_supporession_test.dart
...
Work towards https://github.com/dart-lang/sdk/issues/60635
Also rename the test methods to use camelCase and to read more like
sentences.
Change-Id: If4ef85aeeefc5f1364ffbcba2e73df36981fc951
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432961
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-06-04 16:06:14 -07:00
1a7617e015
Improve the message for non_exhaustive_switch diagnostics
...
Fixes https://github.com/dart-lang/sdk/issues/60690
Change-Id: I1431d646a53c39b738369493b6a234df440dc2f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-06-04 15:17:19 -07:00
bc17496b00
[vm] Fix Google3 ClangTidy warnings.
...
TEST=presubmit
Change-Id: Ifa4e77cc4548729526a90683ee163c68517e87ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433001
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2025-06-04 15:14:15 -07:00
Nicholas Shahan