dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
107,086 Commits 2 Branches 0 Tags
67a24ea983adcced5b358a435313f8b40ff76e1b
Commit Graph

107086 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kevin Moore 67a24ea983 [pkg] drop lints already covered by the included lint file 
Change-Id: I84fdee27e3e28576187896502e5ffed487ee232f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425408
Reviewed-by: Moritz Sümmermann <mosum@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
 2025-04-30 11:58:24 -07:00
Sam Rawlins 1c64983086 analyzer: Add docs to ExpectedDiagnostic, LintRuleTest, and PubPackageResolutionTest 
These will (likely / in some capacity) become public API.

Change-Id: Ia9af4a227956d1335ad1d748e6100d12befc40f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425582
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-30 11:48:22 -07:00
MarkZ 2284e20fcf [ddc] Adding IndexedDB to auto-loaded libraries with global side effects. 
Change-Id: If5e0fdd6c269c1933018b741813d180c8d62c660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425660
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2025-04-30 11:37:22 -07:00
DEPS Autoroller 3ee54d9fe3 Roll Fuchsia SDK from 27.20250423.4.1 to 27.20250428.4.1 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I2c87c580565cbf1d47e2e33eddcce5d162fc3b7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425003
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2025-04-30 10:47:23 -07:00
DEPS Autoroller b01e62ba1d Roll BoringSSL from cccf8525db8a to 34492c89a8e3 (1 revision) 
https://boringssl.googlesource.com/boringssl.git/+log/cccf8525db8a..34492c89a8e3

2025-04-25 bmclarnon@google.com Expose P1363-based ECDSA sign/verify functions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: Ibb8b01d75dd674dbb38158ff3db18681c8a57079
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425001
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2025-04-30 10:08:58 -07:00
Brian Wilkerson 7f74e064b0 Allow analytics gathering for any clients that can display a message 
This test was added before the unified analytics package and was
intended to guard against gathering analytics where we were not allowed
to do so. We can now gather analytics from other clients as long as we
have displayed the appropriate message, and that should be a sufficient
check at this point.

Change-Id: I1ec68439cb1048d99fbbdec2084332e8e830235a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417861
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
 2025-04-30 10:07:28 -07:00
Sam Rawlins cd07d191fc analyzer: Make AnalysisError._problemMessage non-late and public 
Work towards https://github.com/dart-lang/sdk/issues/60635

Change-Id: Id80912299c8bd9caafb9f6a9521168c74911f90d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425581
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-30 09:44:18 -07:00
Sam Rawlins 508ad1359b analysis_server_plugin: Use new DiagnosticCode name 
Work towards https://github.com/dart-lang/sdk/issues/60635

Change-Id: Ia021bc5a80f1e53407393454ab058f6b7c8a633a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-30 09:35:02 -07:00
Sam Rawlins 3a9f4331dd analysis_server: Use new DiagnosticCode name 
Work towards https://github.com/dart-lang/sdk/issues/60635

Change-Id: I76c3f7b3ed890b808f3831f2b7776bd1988a223d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425407
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-30 09:29:50 -07:00
DEPS Autoroller 3fd1ad311a Roll gn from 85cc21e94af5 to 487f8353f154 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com,dart-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in gn: https://bugs.chromium.org/p/gn/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: Id5f7a1df360d20bfdbdd0f27a34c1ec14a1538f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425480
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2025-04-30 09:27:00 -07:00
Alexander Markov c23ed7aabe [lib/web_gl] Workaround to Flutter license script choking on web_gl_dart2js.dart 
Flutter license script (which collects various licenses) processes only
the first N number of bytes.

Unfortunately, https://dart-review.googlesource.com/c/sdk/+/424741
increased size of the header in sdk/lib/web_gl/dart2js/web_gl_dart2js.dart
so copyright notice in the middle of the file was cut in half and
no longer recognized by the Flutter license script.

Issue: https://github.com/flutter/flutter/issues/168065
CoreLibraryReviewExempt: comment change
Change-Id: I694066223b7fd4724c4856ce7875d64e870ab723
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425560
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
 2025-04-30 09:05:11 -07:00
Sam Rawlins a06be8f7bf linter: Migrate reportLint to reportAtNode for rules q-z 
Change-Id: Idc5711338e0cae4232d680634d8b85a7c57fbad0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-30 07:55:18 -07:00
Sam Rawlins 6c30676f93 linter: Migrate reportLint to reportAtNode in prefer_mixin 
Change-Id: Ie63886a744a1b4e6c6c9db8b6527da6c7afd2860
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425322
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-30 07:55:10 -07:00
Alexander Markov 77e6cdc259 [dyn_modules] Handle interpreter frames during deoptimization 
TEST=tools/test.py -n vm-dyn-linux-debug-x64 corelib/bigint_test
Fixes b/406924438

Change-Id: I621c31af7754c629e577e39b2ee4102533fa1363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425341
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2025-04-30 06:42:56 -07:00
Johnni Winther 7850078ce7 [cfe] Implement getter/setter aspect of fields through Getter/SetterDeclaration 
This removes the parts of the FieldDeclaration interface dealing with the getter/setter aspects and instead uses the Getter/SetterDeclaration interfaces.

Change-Id: Ia807c085536c3132527d82491b17b796dfd745bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425521
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2025-04-30 06:05:17 -07:00
Johnni Winther f867dc7600 [cfe] Don't create ClassMember for internal implementation 
Internal implementation members, like those used for the late lowering, are not real instance members on should not be part of the hierarchy member computation. These members are only called directly from within the members for which these are generated, so we don't need to add forwarders and stubs to handle calls from the outside.

Closes #49339

Change-Id: I4d87477243d4e015265c7bb200e1fb5431ae21f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424943
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2025-04-30 03:42:10 -07:00
Chloe Stefantsova f749040450 [model] Keep Let expressions intact in the verifier 
Prior to this CL the CFE verifier would update the type of the
variable in Let expressions from `dynamic` to the computed static type
of the initializer. This CL removes the type update, making the
.expect files reflect the CFE output more accurately. Additionally, a
verification check is added to make sure the static type of the
initializer is assignable to the type of the Let variable.

Change-Id: I0b7b8f175bcb319678c323eb6440d93f1f384a85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425500
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2025-04-30 03:25:50 -07:00
FMorschel 8e45add222 [DAS] Fixes types for convert to function declaration 
Fixes: https://github.com/dart-lang/sdk/issues/60633
Change-Id: I97d7aa1018343d3435d019cb5c3a2605b840d8f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425020
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2025-04-30 00:58:02 -07:00
Chloe Stefantsova aea68e45ac [model] Add ConstructorDeclarationBuilder.markAsErroneous 
This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/424980

Change-Id: Ia64aa18592a80ac71c04a5e103f13ecf04e50c92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425281
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2025-04-29 22:55:06 -07:00
Robert Nystrom 2f2bdc3c22 Reformat tests/lib/js and /js_interop_unsafe using 3.8 style. 
Change-Id: I182e28a3c4b44dd899e5ea30ac5c5c3ba60fd6cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425333
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2025-04-29 21:21:29 -07:00
Danny Tuppeny 9831fc4e98 [analysis_server] Rename "CodeAction" to CodeActionLiteral" 
The term "CodeAction" is a bit overloaded. It could mean both an
individual result from the `textDocument/codeAction` request (which is a
`Command` or a `CodeAction`), or the `CodeAction` type defined in
the spec (which the spec refers to as a "Code Action literal").

To reduce confusion where we have similar APIs that operate on
"Code Actions" (CodeAction|Command), this renames the `CodeAction` class to
`CodeActionLiteral` and we will use the term `CodeAction` to mean either of
those types.

To make things simpler to review, this change _only_ renames the class, and also swaps the order of the types in some places that used `Either2<Command, CodeAction>` (which is opposite to the spec and some other code). Some further clean up will be done in a separate change.

Change-Id: Idcd8265f9229c3450004e68334e98a7b530330a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425300
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-29 20:54:58 -07:00
Robert Nystrom 4cc31f8f4f Reformat tests/lib/html using 3.8 formatting style. 
There are no behavioral changes here, I just ran `dart format` on the
`tests/lib/html/` directory.

Change-Id: I221b2a370adc393e49621db1d37aa6eeb09b3015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425329
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2025-04-29 19:23:05 -07:00
Kallen Tu c12926e3a9 [analyzer] Dot shorthands: Const constructor invocations. 
Added `isConst` and `constKeyword` to `DotShorthandConstructorInvocation`.

`DotShorthandInvocation`s are rewritten to `DotShorthandConstructorInvocation` immediately once we parse the `const` keyword. If we don't resolve to a constructor, we'll produce the `CONST_WITH_UNDEFINED_CONSTRUCTOR` error.

Summary changes in a different CL that follows this one: https://dart-review.googlesource.com/c/sdk/+/424340

co19 tests passing and unit tests added.

Bug: https://github.com/dart-lang/sdk/issues/59835
Change-Id: Ic12cd98cf08009187b8bf32afb62aa026cb7c8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424240
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2025-04-29 18:50:58 -07:00
Kevin Moore 5d4d797ee4 [analyzer] fix argument to INVALID_USE_OF_PROTECTED_MEMBER 
The template is

    "The member '{0}' can only be used within instance members of subclasses "
        "of '{1}'.",

In this case, {1} is expected to be the class name.
Fixes calling code to pass the element instead of the library URI

Change-Id: I25e9d28e1ad4f10e7b0463add20e6963a7d98af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425331
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-04-29 17:52:53 -07:00
Sam Rawlins 7d1c867f42 linter: Fix await_only_futures: Fix for type variables and intersection types 
Fixes https://github.com/dart-lang/sdk/issues/58492

Change-Id: Iae036742b05815332553a540c95b4fdf5ad83413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425402
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-29 17:44:59 -07:00
Srujan Gaddam c497d099db [ddc] Add hot restart initializers to a pending map instead 
It is possible with the way the library manager is written
today that during a hot restart, a previously defined library
may be initialized. Because the manager uses the same map
to store the initializers for the non-hot restart case and
the hot restart case, we may end up using a newer version of
code in an older generation. Instead, this CL adds a pending
map that stores the hot restart initializers so that we can
later add them to the general map of initializers right before
we call main during a hot restart and during synchronous code.
This should avoid that race condition.

Change-Id: Ib40cbe5bec400035276ebd6fca12efed7077a2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425190
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2025-04-29 17:11:45 -07:00
Srujan Gaddam 96c8aff4ce Support stacktrace testing for DDC library bundle 
These tests are currently run with the ES6 module format.
This expands and refactors the test suite to also test the
DDC library bundle module format. Refactoring is mostly
limited to better naming and structuring of parameters.

Change-Id: If2a813af1a503e18d74dd4eec57eac4ecc8a3f35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424880
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2025-04-29 17:11:45 -07:00
Srujan Gaddam 8ac1fbdd07 [ddc] Emit call to register source maps in DDC library bundle format 
- Sets the name field in the emitted LibraryBundle node to
to the provided module name. We tried to avoid providing a
module name as the notion doesn't map cleanly to library
bundles, but we need to respect the provided module name.
- Emits a call to set the source map for a given library
bundle url. We don't need the full trackLibraries call so we
don't use it.
- Adds a check to avoid redefining libraries outside of a hot
reload or a hot restart. This was handled in the same code
where we emitted trackLibraries calls in the old compiler
for dynamic modules, but we want this for all code, regardless
of whether dynamic modules is enabled. So, add this check in
the library manager instead.

Change-Id: Ic4e86dbfca2b3eefa99cce44fae0973164ab77a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423620
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2025-04-29 17:11:45 -07:00
asiva edd241dc36 Invoke dart2js directly using dartaotruntime while building 
observatory instead of using 'compile js'

TEST=ci

Change-Id: Id190a764d1d7e9ee4b29b02549cf94b750c6dbe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425420
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2025-04-29 17:03:43 -07:00
Ryan Macnak 077d7c9e89 [vm] Don't acquire safepoint locks while participating in reload safepoints. 
Also disable lint intended to guard against use of std::thread::detach as it has too many false positives against dart::FinalizerEntry::detach.

TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/60638
Change-Id: I19a0fde743fc5c5658a8dd96cecb5b074481a035
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425324
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2025-04-29 16:23:20 -07:00
Sam Rawlins d1696f890d CFE: Introduce type aliases for ErrorCode, ErrorSeverity, ErrorType 
Work towards https://github.com/dart-lang/sdk/issues/60635

In this CL I only introduce the typedefs, update comments, and export
the typedefs. I don't change any references. Next we should update
internal references and maybe separately, any generated references.

Change-Id: I1c6d16580533b9283934261f56a6e5237e59109e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425343
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-29 16:19:30 -07:00
Stephen Adams 8e8fc6a565 Partial revert "[rti/js_interop] Accelerate is JSObject" 
This reverts one file from commit 2cc7d381a5.

Change-Id: Iec4dc5e9a3e564b34ae326c5517e8d6764dfc9e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425327
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2025-04-29 15:29:58 -07:00
Konstantin Shcheglov 466cda235d Fix typos in analyzer_testing/README.md 
Change-Id: If7cf1381220b7dbc64ae576e9921ee6a8ae9530b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425323
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-29 14:59:04 -07:00
Konstantin Shcheglov 15f02dcc58 Cider. Load not only LibraryFileKind, but also its docLibraryImports. 
Bug: https://buganizer.corp.google.com/issues/414309937
Change-Id: I2ad62a6de93caa2cf707eabe7d13003897e1d653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425401
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-29 14:47:49 -07:00
Kallen Tu 2c4fd4e9a8 [analyzer] Dot shorthands: Allow index expressions. 
`IndexExpressionImpl`s now have the `DotShorthandMixin` applied. We save the context at the point of resolving an index expression to be used for resolving a dot shorthand head later.

Unit tests added. There's multiple co19 tests that will start passing, but rely on https://dart-review.googlesource.com/c/sdk/+/425181.

Bug: https://github.com/dart-lang/sdk/issues/59835
Change-Id: I08076bb437bad1955d353a24fc119466b7dfad61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425360
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2025-04-29 14:21:41 -07:00
Nicholas Shahan c31a282435 Revert "[ddc] Refactor visitInstanceGetterInvocation()" 
This reverts commit 776c0586aa.

Reason for revert: Broke test in google3

Original change's description:
> [ddc] Refactor `visitInstanceGetterInvocation()`
>
> Moves the remaining special case logic out of `_emitMethodCall()`
> simplifying the reasoning about where so hot reload soundness checks
> can be added.
>
> Change-Id: I13e2f451e61f6e067ea689bcc35039cf92946492
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423603
> Reviewed-by: Mark Zhou <markzipan@google.com>
> Reviewed-by: Nate Biggs <natebiggs@google.com>
> Commit-Queue: Nicholas Shahan <nshahan@google.com>

Change-Id: I67d35d085e9b9510547aff8fb16ac0a8ed44d6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425404
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-04-29 14:16:38 -07:00
Devon Carew 201fcca4dc Bump web to 553c14d5365dc51433d4c3f4a04028f88a462ab8 
Changes:
```
> git log --format="%C(auto) %h %s" 5a39fdc..553c14d
 https://dart.googlesource.com/web.git/+/553c14d generator: drop pkg:collection dep (361)
 https://dart.googlesource.com/web.git/+/034067f Migrate web_generator to new element model (359)
 https://dart.googlesource.com/web.git/+/fa43ddd Bump actions/cache from 4.2.2 to 4.2.3 in the github-actions group (356)
 https://dart.googlesource.com/web.git/+/4854093 Add pull request and id-token write permissions to publish.yaml (351)
 https://dart.googlesource.com/web.git/+/33ed133 Bump the github-actions group with 2 updates (349)
 https://dart.googlesource.com/web.git/+/6031c1f Delete all deprecated members (347)

```

Diff: https://dart.googlesource.com/web.git/+/5a39fdc396ae40344308975140343c23b6863261..553c14d5365dc51433d4c3f4a04028f88a462ab8/
Change-Id: I0f09d713d0815e1f37df35566fc642b031f7cadb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425344
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2025-04-29 13:16:30 -07:00
Ryan Macnak cfd0ae327e [tools] Remember the current view in the URL fragment. 
Change-Id: I516914b3b64269571c0932a8bcada3891b266c15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425361
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2025-04-29 13:01:59 -07:00
Konstantin Shcheglov 5cfae22986 Elements. Prepare for a case when both getter/setter and the variable are synthetic. 
This will happen when we build top-merged fragments / elements and put
into summaries.

Change-Id: If8451b2bee8347243fced829fab51a85fc38fdd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2025-04-29 12:43:29 -07:00
Sam Rawlins 7df1bd2f39 Add empty analyzer_testing package 
Work towards https://github.com/dart-lang/sdk/issues/55660

Change-Id: Ia4f8186c328c9929869d1305ee0fe606d9dfa0e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425320
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2025-04-29 12:33:30 -07:00
FMorschel 14c82024ea [analyzer] Adds context message for three or more ambiguous extensions 
Fixes https://github.com/dart-lang/sdk/issues/59542

Change-Id: Ie7ae97397878db86a38cc369d3c21d18a2a03efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396540
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-04-29 11:39:38 -07:00
Sam Rawlins cbca779edb analyzer: Use a consistent case in warning names 
There is only one written in lower_snake_case. Rename it so that
every warning is written in SCREAMING_SNAKE_CASE.

Change-Id: If1db2c772899ff3cde25736dc2423d141d0f49ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425156
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-29 11:36:45 -07:00
FMorschel dbd0be6b7e [DAS] Fixes Create getter and Create mixin quick-fixes trigger 
Fixes: https://github.com/dart-lang/sdk/issues/60613
Change-Id: Ie8661ae57f4fb3d8e9702fb67fc900530ba10632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424560
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-04-29 11:31:19 -07:00
FMorschel cb21aa5ecc [DAS] Fixes triggers for Create class and Create getter quick-fixes 
Fixes: https://github.com/dart-lang/sdk/issues/60527
Change-Id: I85e75c89d9b6057f516e4356865cee19c6eee27c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-04-29 11:11:58 -07:00
Sam Rawlins 62824ba646 Migrate the last AnalysisOptionsHintCodes to be Warnings 
Change-Id: I8f9826a57e434a185d6c0d68e2ccbd1c2610885d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425157
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-29 10:44:55 -07:00
Robert Nystrom e5194dae87 Reformat tools/ and utils/ using the 3.8 style. 
Change-Id: I7b28583eb928f60a45d1f476194d197b4df88062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425184
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2025-04-29 10:40:59 -07:00
Elliott Brooks fac5fec88a Update DevTools rev to 4b7eda127290518ad9e0dea4dcb9510b6e5e4a41 
Change-Id: I90e581181568ff4cfeeec1e4cee2c3482c4d90c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425321
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
 2025-04-29 10:36:52 -07:00
Konstantin Shcheglov 9448dd7a95 Elements. Remove ConstructorElementImpl typedef, previously retained for DartDoc. 
Change-Id: Id693fac19a22a6d1394902a081a5eaeb043453b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425189
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-29 10:28:48 -07:00
Robert Nystrom 0a385ddf20 Reformat sdk/ using the 3.8 style. 
Change-Id: I6e037ab1091cdaaf72b21f558a45b2c5f99304bb
Tested: Automated reformatting, so no behavior changes.
CoreLibraryReviewExempt: Automated reformatting.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425147
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
 2025-04-29 10:12:32 -07:00
Konstantin Shcheglov b2c8a30998 Elements. Remove AnnotatableElement. 
Now that ManifestItem(s) store only ElementImpl, we don't need it.

Change-Id: I911fb22382aa73556ee65b291d30009288851185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425143
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-29 09:54:31 -07:00